Re: [PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-11-02 Thread Lee Jones
On Mon, 02 Nov 2015, Alexandre Belloni wrote: > On 02/11/2015 at 08:46:21 +0900, Krzysztof Kozlowski wrote : > > On 02.11.2015 02:40, Alexandre Belloni wrote: > > > On 30/10/2015 at 11:55:34 +0530, Alim Akhtar wrote : > > >> RTC found in s2mps15 is almost same as one found on s2mps13 > > >> with

Re: [PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-11-02 Thread Alexandre Belloni
On 02/11/2015 at 09:03:59 +, Lee Jones wrote : > > > I think you cannot apply it directly because it depends on headers from > > > patch 2/4. It won't build. > > > > > > > Yeah, this depends on the mfd tree. I don't thin Lee applied patch 2/4 > > yet so I'm taking that one for 4.5. > > I

Re: [PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-11-02 Thread Lee Jones
On Mon, 02 Nov 2015, Alexandre Belloni wrote: > On 02/11/2015 at 09:03:59 +, Lee Jones wrote : > > > > I think you cannot apply it directly because it depends on headers from > > > > patch 2/4. It won't build. > > > > > > > > > > Yeah, this depends on the mfd tree. I don't thin Lee applied

Re: [PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-11-01 Thread Alexandre Belloni
On 30/10/2015 at 11:55:34 +0530, Alim Akhtar wrote : > RTC found in s2mps15 is almost same as one found on s2mps13 > with few differences in RTC_UPDATE register fields, like: > 1> Bit[4] and Bit[1] are reversed >- On s2mps13 > WUDR -> bit[4], AUDR -> bit[1] >- On s2mps15 >

Re: [PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-11-01 Thread Alexandre Belloni
On 02/11/2015 at 08:46:21 +0900, Krzysztof Kozlowski wrote : > On 02.11.2015 02:40, Alexandre Belloni wrote: > > On 30/10/2015 at 11:55:34 +0530, Alim Akhtar wrote : > >> RTC found in s2mps15 is almost same as one found on s2mps13 > >> with few differences in RTC_UPDATE register fields, like: > >>

Re: [PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-11-01 Thread Krzysztof Kozlowski
On 02.11.2015 02:40, Alexandre Belloni wrote: > On 30/10/2015 at 11:55:34 +0530, Alim Akhtar wrote : >> RTC found in s2mps15 is almost same as one found on s2mps13 >> with few differences in RTC_UPDATE register fields, like: >> 1> Bit[4] and Bit[1] are reversed >>- On s2mps13 >> WUDR

Re: [PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-10-30 Thread Krzysztof Kozlowski
On 30.10.2015 15:25, Alim Akhtar wrote: > RTC found in s2mps15 is almost same as one found on s2mps13 > with few differences in RTC_UPDATE register fields, like: > 1> Bit[4] and Bit[1] are reversed >- On s2mps13 > WUDR -> bit[4], AUDR -> bit[1] >- On s2mps15 > WUDR ->

[PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-10-30 Thread Alim Akhtar
RTC found in s2mps15 is almost same as one found on s2mps13 with few differences in RTC_UPDATE register fields, like: 1> Bit[4] and Bit[1] are reversed - On s2mps13 WUDR -> bit[4], AUDR -> bit[1] - On s2mps15 WUDR -> bit[1], AUDR -> bit[4] 2> In case of s2mps13, for alarm

Re: [PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-10-30 Thread Lee Jones
On Fri, 30 Oct 2015, Alim Akhtar wrote: > RTC found in s2mps15 is almost same as one found on s2mps13 > with few differences in RTC_UPDATE register fields, like: > 1> Bit[4] and Bit[1] are reversed >- On s2mps13 > WUDR -> bit[4], AUDR -> bit[1] >- On s2mps15 > WUDR ->

Re: [PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-10-30 Thread Alim Akhtar
Hi Krzysztof, On 10/30/2015 02:08 PM, Krzysztof Kozlowski wrote: On 30.10.2015 15:25, Alim Akhtar wrote: RTC found in s2mps15 is almost same as one found on s2mps13 with few differences in RTC_UPDATE register fields, like: 1> Bit[4] and Bit[1] are reversed - On s2mps13 WUDR ->