Re: [PATCH v5 4/7] platform/chrome: Add Chrome OS EC userspace device interface

2015-02-26 Thread Olof Johansson
On Thu, Feb 26, 2015 at 1:08 AM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Hello Olof, Thanks a lot for your feedback. On 02/26/2015 02:13 AM, Gwendal Grignou wrote: Olof, I think the way Javier did it is fine, the 'major' of the ioctl is 0xEC, from ':'. Gwendal.

Re: [PATCH v5 4/7] platform/chrome: Add Chrome OS EC userspace device interface

2015-02-26 Thread Javier Martinez Canillas
Hello Olof, Thanks a lot for your feedback. On 02/26/2015 02:13 AM, Gwendal Grignou wrote: Olof, I think the way Javier did it is fine, the 'major' of the ioctl is 0xEC, from ':'. Gwendal. As Gwendal said, I deliberately changed the IOCTL mayor number to make it different in both

Re: [PATCH v5 4/7] platform/chrome: Add Chrome OS EC userspace device interface

2015-02-25 Thread Olof Johansson
On Mon, Feb 02, 2015 at 12:26:25PM +0100, Javier Martinez Canillas wrote: From: Bill Richardson wfric...@chromium.org This patch adds a device interface to access the Chrome OS Embedded Controller from user-space. Signed-off-by: Bill Richardson wfric...@chromium.org Reviewed-by: Simon

Re: [PATCH v5 4/7] platform/chrome: Add Chrome OS EC userspace device interface

2015-02-25 Thread Gwendal Grignou
Olof, I think the way Javier did it is fine, the 'major' of the ioctl is 0xEC, from ':'. Gwendal. On Wed, Feb 25, 2015 at 4:54 PM, Olof Johansson o...@lixom.net wrote: On Mon, Feb 02, 2015 at 12:26:25PM +0100, Javier Martinez Canillas wrote: From: Bill Richardson wfric...@chromium.org This

[PATCH v5 4/7] platform/chrome: Add Chrome OS EC userspace device interface

2015-02-02 Thread Javier Martinez Canillas
From: Bill Richardson wfric...@chromium.org This patch adds a device interface to access the Chrome OS Embedded Controller from user-space. Signed-off-by: Bill Richardson wfric...@chromium.org Reviewed-by: Simon Glass s...@google.com Signed-off-by: Javier Martinez Canillas