Re: [PATCH v9 1/2] regulator: Add driver for max77802 PMIC PMIC regulators

2014-08-26 Thread Mark Brown
On Mon, Aug 25, 2014 at 08:40:40AM -0700, Doug Anderson wrote: On Mon, Aug 25, 2014 at 2:07 AM, Javier Martinez Canillas I see, so probably until we have a way to define the operating mode for each regulator using DT we should set the opmode to normal when enabling a regulator

Re: [PATCH v9 1/2] regulator: Add driver for max77802 PMIC PMIC regulators

2014-08-26 Thread Javier Martinez Canillas
Hello Mark, On 08/26/2014 09:17 AM, Mark Brown wrote: On Mon, Aug 25, 2014 at 08:40:40AM -0700, Doug Anderson wrote: Can you please test the following change [0] so I can post as a proper patch? Doug, Mark do you think that forcing the regulator to opmode normal when enabling is the right

Re: [PATCH v9 1/2] regulator: Add driver for max77802 PMIC PMIC regulators

2014-08-26 Thread Mark Brown
On Tue, Aug 26, 2014 at 11:08:07AM +0200, Javier Martinez Canillas wrote: On 08/26/2014 09:17 AM, Mark Brown wrote: No, this doesn't make any obvious sense to me at all. Picking normal as a default if the hardware reads back off due to overlapping impelementation or something *might* make

Re: [PATCH v9 1/2] regulator: Add driver for max77802 PMIC PMIC regulators

2014-08-25 Thread Yuvaraj Cd
On Sat, Aug 23, 2014 at 3:45 AM, Doug Anderson diand...@chromium.org wrote: Hi, On Fri, Aug 22, 2014 at 3:02 PM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Hello Mark, On 08/22/2014 08:30 PM, Mark Brown wrote: The problem is that one of these regulators is used as the

Re: [PATCH v9 1/2] regulator: Add driver for max77802 PMIC PMIC regulators

2014-08-25 Thread Javier Martinez Canillas
Hello Yuvaraj, On 08/25/2014 10:22 AM, Yuvaraj Cd wrote: Good question. I'm not that familiar with the dw_mmc host controller nor its driver implementation so I'll let Yuvaraj or Doug to answer that. Well,here it goes! 1. Power ON the board LDO4CTRL1[7:6] 11b 2. dw_mmc driver enable the

Re: [PATCH v9 1/2] regulator: Add driver for max77802 PMIC PMIC regulators

2014-08-25 Thread Yuvaraj Cd
On Mon, Aug 25, 2014 at 2:37 PM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Hello Yuvaraj, On 08/25/2014 10:22 AM, Yuvaraj Cd wrote: Good question. I'm not that familiar with the dw_mmc host controller nor its driver implementation so I'll let Yuvaraj or Doug to answer

Re: [PATCH v9 1/2] regulator: Add driver for max77802 PMIC PMIC regulators

2014-08-25 Thread Doug Anderson
Javier, On Mon, Aug 25, 2014 at 2:07 AM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Hello Yuvaraj, On 08/25/2014 10:22 AM, Yuvaraj Cd wrote: Good question. I'm not that familiar with the dw_mmc host controller nor its driver implementation so I'll let Yuvaraj or Doug to

Re: [PATCH v9 1/2] regulator: Add driver for max77802 PMIC PMIC regulators

2014-08-25 Thread Javier Martinez Canillas
Hello Doug, On 08/25/2014 05:40 PM, Doug Anderson wrote: I see, so probably until we have a way to define the operating mode for each regulator using DT we should set the opmode to normal when enabling a regulator independently of the value the hardware register reported on probe. Can you

Re: [PATCH v9 1/2] regulator: Add driver for max77802 PMIC PMIC regulators

2014-08-22 Thread Yuvaraj Cd
On Mon, Aug 18, 2014 at 2:02 PM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout (LDO) regulators. This patch adds support for all these regulators found on the MAX77802 PMIC and is based on a driver added by Simon

Re: [PATCH v9 1/2] regulator: Add driver for max77802 PMIC PMIC regulators

2014-08-22 Thread Javier Martinez Canillas
Hello Yuvaraj, On 08/22/2014 08:01 AM, Yuvaraj Cd wrote: + +static int max77802_pmic_probe(struct platform_device *pdev) +{ + struct max77686_dev *iodev = dev_get_drvdata(pdev-dev.parent); + struct max77686_platform_data *pdata = dev_get_platdata(iodev-dev); + struct

Re: [PATCH v9 1/2] regulator: Add driver for max77802 PMIC PMIC regulators

2014-08-22 Thread Mark Brown
On Fri, Aug 22, 2014 at 02:15:46PM +0200, Javier Martinez Canillas wrote: Mark, any opinions on how this should be solved will be highly appreciated. If someone could tell me what this is that'd help... signature.asc Description: Digital signature

Re: [PATCH v9 1/2] regulator: Add driver for max77802 PMIC PMIC regulators

2014-08-22 Thread Javier Martinez Canillas
Hello Mark, On 08/22/2014 04:45 PM, Mark Brown wrote: On Fri, Aug 22, 2014 at 02:15:46PM +0200, Javier Martinez Canillas wrote: Mark, any opinions on how this should be solved will be highly appreciated. If someone could tell me what this is that'd help... Sorry for not being clear on

Re: [PATCH v9 1/2] regulator: Add driver for max77802 PMIC PMIC regulators

2014-08-22 Thread Mark Brown
On Fri, Aug 22, 2014 at 07:53:19PM +0200, Javier Martinez Canillas wrote: On 08/22/2014 04:45 PM, Mark Brown wrote: On Fri, Aug 22, 2014 at 02:15:46PM +0200, Javier Martinez Canillas wrote: Mark, any opinions on how this should be solved will be highly appreciated. If someone could tell

Re: [PATCH v9 1/2] regulator: Add driver for max77802 PMIC PMIC regulators

2014-08-22 Thread Javier Martinez Canillas
Hello Mark, On 08/22/2014 08:30 PM, Mark Brown wrote: The problem is that one of these regulators is used as the vqmmc-supply (VCCQ/VDD_IO) so the mmc host controller driver disables it on MMC_POWER_OFF. Now AFAIK (Yuvaraj can correct me what I got wrong) this shouldn't be an issue since on

Re: [PATCH v9 1/2] regulator: Add driver for max77802 PMIC PMIC regulators

2014-08-22 Thread Doug Anderson
Hi, On Fri, Aug 22, 2014 at 3:02 PM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Hello Mark, On 08/22/2014 08:30 PM, Mark Brown wrote: The problem is that one of these regulators is used as the vqmmc-supply (VCCQ/VDD_IO) so the mmc host controller driver disables it on

[PATCH v9 1/2] regulator: Add driver for max77802 PMIC PMIC regulators

2014-08-18 Thread Javier Martinez Canillas
The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout (LDO) regulators. This patch adds support for all these regulators found on the MAX77802 PMIC and is based on a driver added by Simon Glass to the Chrome OS kernel 3.8 tree. Signed-off-by: Javier Martinez Canillas

Re: [PATCH v9 1/2] regulator: Add driver for max77802 PMIC PMIC regulators

2014-08-18 Thread Mark Brown
On Mon, Aug 18, 2014 at 10:32:41AM +0200, Javier Martinez Canillas wrote: The MAX77802 PMIC has 10 high-efficiency Buck and 32 Low-dropout (LDO) regulators. This patch adds support for all these regulators found on the MAX77802 PMIC and is based on a driver added by Simon Glass to the Chrome