Re: [PATCHv2 4/5] clk: samsung: exynos5410: Add fixed rate clocks

2014-07-31 Thread Tomasz Figa
Humberto, On 31.07.2014 23:01, Humberto Naves wrote: > Hi, > > On Thu, Jul 31, 2014 at 1:45 PM, Sylwester Nawrocki > wrote: >> Can you explain what is rationale behind this change ? Is it related to >> suspend/resume ordering ? > > I had forgotten, but now remember the reason why I did this. If

Re: [PATCHv2 4/5] clk: samsung: exynos5410: Add fixed rate clocks

2014-07-31 Thread Humberto Naves
Hi, On Thu, Jul 31, 2014 at 1:45 PM, Sylwester Nawrocki wrote: > Can you explain what is rationale behind this change ? Is it related to > suspend/resume ordering ? I had forgotten, but now remember the reason why I did this. If you see the current implementation of clk-exynos5410, you will noti

Re: [PATCHv2 4/5] clk: samsung: exynos5410: Add fixed rate clocks

2014-07-31 Thread Tomasz Figa
On 31.07.2014 15:23, Humberto Naves wrote: > Hi Tomasz, > > I perfectly see your point. > However my question was why you did you decide to postpone > Sylwester's? Was there any specific reason? > I suppose it would break all the dtb compatibility, but besides that, > was there any other reason?

Re: [PATCHv2 4/5] clk: samsung: exynos5410: Add fixed rate clocks

2014-07-31 Thread Humberto Naves
Hi Tomasz, I perfectly see your point. However my question was why you did you decide to postpone Sylwester's? Was there any specific reason? I suppose it would break all the dtb compatibility, but besides that, was there any other reason? Best, Humberto On Thu, Jul 31, 2014 at 2:53 PM, Tomasz F

Re: [PATCHv2 4/5] clk: samsung: exynos5410: Add fixed rate clocks

2014-07-31 Thread Tomasz Figa
Hi Humberto, You can find my comments inline. On 31.07.2014 13:22, Humberto Silva Naves wrote: > This implements the fixed rate clocks generated either inside or > outside the SoC. It also adds a dt-binding constant for the > sclk_hdmiphy clock, which shall be later used by other drivers, > such

Re: [PATCHv2 4/5] clk: samsung: exynos5410: Add fixed rate clocks

2014-07-31 Thread Sylwester Nawrocki
(dropping linux-doc ML and Randy from Cc) On 31/07/14 13:22, Humberto Silva Naves wrote: > This implements the fixed rate clocks generated either inside or > outside the SoC. It also adds a dt-binding constant for the > sclk_hdmiphy clock, which shall be later used by other drivers, > such as the

[PATCHv2 4/5] clk: samsung: exynos5410: Add fixed rate clocks

2014-07-31 Thread Humberto Silva Naves
This implements the fixed rate clocks generated either inside or outside the SoC. It also adds a dt-binding constant for the sclk_hdmiphy clock, which shall be later used by other drivers, such as the DRM. Since the external fixed rate clock fin_pll is now registered by the clk-exynos5410 file, th