Re: [RESEND: RFC PATCH 3/3] pcie: keystone: add pcie driver based on designware core driver

2014-04-07 Thread Jason Gunthorpe
On Mon, Apr 07, 2014 at 12:38:23PM -0400, Murali Karicheri wrote: > On 3/25/2014 12:54 PM, Jason Gunthorpe wrote: > >On Tue, Mar 25, 2014 at 08:44:36AM +0100, Arnd Bergmann wrote: > > > >>I have no idea how this would work with the standard interrupt-map property, > >>since the legacy interrupt hos

Re: [RESEND: RFC PATCH 3/3] pcie: keystone: add pcie driver based on designware core driver

2014-04-07 Thread Murali Karicheri
On 3/25/2014 12:54 PM, Jason Gunthorpe wrote: On Tue, Mar 25, 2014 at 08:44:36AM +0100, Arnd Bergmann wrote: I have no idea how this would work with the standard interrupt-map property, since the legacy interrupt host is now the same device as the pci host. Maybe it's better to move the legacy

Re: [RESEND: RFC PATCH 3/3] pcie: keystone: add pcie driver based on designware core driver

2014-04-04 Thread Murali Karicheri
On 4/3/2014 4:32 AM, Lucas Stach wrote: Am Mittwoch, den 02.04.2014, 13:17 -0400 schrieb Murali Karicheri: Arnd, Thanks for reviewing the RFC patch. Please see below my response. On 3/25/2014 3:44 AM, Arnd Bergmann wrote: On Monday 24 March 2014 20:35:26 Murali Karicheri wrote: [...] +

Re: [RESEND: RFC PATCH 3/3] pcie: keystone: add pcie driver based on designware core driver

2014-04-03 Thread Lucas Stach
Am Mittwoch, den 02.04.2014, 13:17 -0400 schrieb Murali Karicheri: > Arnd, > > Thanks for reviewing the RFC patch. Please see below my response. > > On 3/25/2014 3:44 AM, Arnd Bergmann wrote: > > On Monday 24 March 2014 20:35:26 Murali Karicheri wrote: [...] > > >> + ks_pcie->clk = devm_clk_get

Re: [RESEND: RFC PATCH 3/3] pcie: keystone: add pcie driver based on designware core driver

2014-04-02 Thread Murali Karicheri
On 4/2/2014 12:47 PM, Andrew Murray wrote: On 2 April 2014 16:43, Murali Karicheri wrote: Keystone pcie driver is developed based on other dw based pcie drivers such as pci-exynos that uses subsys_initcall(). I am new to this list, probably Jingoo (copied) has some history on why we can't us

Re: [RESEND: RFC PATCH 3/3] pcie: keystone: add pcie driver based on designware core driver

2014-04-02 Thread Murali Karicheri
Arnd, Thanks for reviewing the RFC patch. Please see below my response. On 3/25/2014 3:44 AM, Arnd Bergmann wrote: On Monday 24 March 2014 20:35:26 Murali Karicheri wrote: + +int k2_pcie_platform_setup(struct platform_device *pdev) +{ + struct resource *phy_base_r, *devstat_r; + vo

Re: [RESEND: RFC PATCH 3/3] pcie: keystone: add pcie driver based on designware core driver

2014-04-02 Thread Andrew Murray
On 2 April 2014 16:43, Murali Karicheri wrote: > Keystone pcie driver is developed based on other dw based pcie drivers > > such as pci-exynos that uses subsys_initcall(). I am new to this list, > > probably Jingoo (copied) has some history on why we can't use module. > For now I will keep it as

RE: [RESEND: RFC PATCH 3/3] pcie: keystone: add pcie driver based on designware core driver

2014-03-27 Thread Karicheri, Muralidharan
ichard Zhu; Kukjin Kim; >Mohit >Kumar; Jingoo Han; Shilimkar, Santosh; Bjorn Helgaas; Shawn Guo >Subject: Re: [RESEND: RFC PATCH 3/3] pcie: keystone: add pcie driver based on >designware core driver > >On Monday 24 March 2014 20:35:26 Murali Karicheri wrote: >> + >> +i

Re: [RESEND: RFC PATCH 3/3] pcie: keystone: add pcie driver based on designware core driver

2014-03-25 Thread Jason Gunthorpe
On Tue, Mar 25, 2014 at 08:44:36AM +0100, Arnd Bergmann wrote: > I have no idea how this would work with the standard interrupt-map property, > since the legacy interrupt host is now the same device as the pci host. > > Maybe it's better to move the legacy irqchip handling entirely out of > the d

Re: [RESEND: RFC PATCH 3/3] pcie: keystone: add pcie driver based on designware core driver

2014-03-25 Thread Andrew Murray
On 25 March 2014 10:35, Thierry Reding wrote: > On Tue, Mar 25, 2014 at 08:44:36AM +0100, Arnd Bergmann wrote: >> On Monday 24 March 2014 20:35:26 Murali Karicheri wrote: > [...] >> > +/* Keystone PCIe driver does not allow module unload */ >> > +static int __init ks_pcie_init(void) >> > +{ >> > +

Re: [RESEND: RFC PATCH 3/3] pcie: keystone: add pcie driver based on designware core driver

2014-03-25 Thread Thierry Reding
On Tue, Mar 25, 2014 at 08:44:36AM +0100, Arnd Bergmann wrote: > On Monday 24 March 2014 20:35:26 Murali Karicheri wrote: [...] > > +/* Keystone PCIe driver does not allow module unload */ > > +static int __init ks_pcie_init(void) > > +{ > > + return platform_driver_probe(&ks_pcie_driver, ks_pcie

Re: [RESEND: RFC PATCH 3/3] pcie: keystone: add pcie driver based on designware core driver

2014-03-25 Thread Arnd Bergmann
On Monday 24 March 2014 20:35:26 Murali Karicheri wrote: > + > +int k2_pcie_platform_setup(struct platform_device *pdev) > +{ > + struct resource *phy_base_r, *devstat_r; > + void __iomem *phy_base, *devstat; > + u32 val; > + int i; > + > + devstat_r = platform_get_resource_byna

[RESEND: RFC PATCH 3/3] pcie: keystone: add pcie driver based on designware core driver

2014-03-24 Thread Murali Karicheri
keystone pcie hardware is based on designware version 3.65. This doesn't support standard MSI controller and ATU port available on newer version of the designware hardware. In keystone dw hardware the application register space implements the legacy and MSI irq controller registers and has register