Re: [PATCH] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-10-21 Thread Domenico Andreoli
On Wed, Oct 17, 2012 at 08:13:01PM +0100, Russell King - ARM Linux wrote: On Wed, Oct 17, 2012 at 08:00:00PM +0900, Kukjin Kim wrote: +static int samsung_usbphy_get_refclk_freq(struct samsung_usbphy *sphy) +{ + struct clk *ref_clk; + int refclk_freq = 0; + + ref_clk =

Re: [PATCH] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-10-20 Thread Pavel Machek
Hi! +#define S3C_PHYPWR (0x00) ... +#define S3C_PHYCLK (0x04) + +#define S3C_PHYCLK_MODE_SERIAL (1 6) +#define S3C_PHYCLK_EXT_OSC (1 5) +#define S3C_PHYCLK_COMMON_ON_N (1 4)

RE: [PATCH] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-10-17 Thread Kukjin Kim
Praveen Paneri wrote: platform_set_drvdata() required for driver's remove function, so adding it back. From v6: Added TODO for phy bindings with controller Dropped platform_set_drvdata() from driver probe This driver uses usb_phy interface to interact with s3c-hsotg. Supports phy_init

Re: [PATCH] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-10-17 Thread Praveen Paneri
Hi, On Wed, Oct 17, 2012 at 4:30 PM, Kukjin Kim kgene@samsung.com wrote: Praveen Paneri wrote: platform_set_drvdata() required for driver's remove function, so adding it back. From v6: Added TODO for phy bindings with controller Dropped platform_set_drvdata() from driver probe This

Re: [PATCH] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-10-17 Thread Russell King - ARM Linux
On Wed, Oct 17, 2012 at 08:00:00PM +0900, Kukjin Kim wrote: +static int samsung_usbphy_get_refclk_freq(struct samsung_usbphy *sphy) +{ + struct clk *ref_clk; + int refclk_freq = 0; + + ref_clk = clk_get(sphy-dev, xusbxti); + if (IS_ERR(ref_clk)) { IS_ERR_OR_NULL(ref_clk)?

Re: [PATCH] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-10-15 Thread Felipe Balbi
On Fri, Oct 12, 2012 at 03:45:34PM +0530, Praveen Paneri wrote: platform_set_drvdata() required for driver's remove function, so adding it back. From v6: Added TODO for phy bindings with controller Dropped platform_set_drvdata() from driver probe This driver uses usb_phy interface to

Re: [PATCH] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-10-15 Thread Kyungmin Park
+ Tomasz Figa, Acked-by: Kyungmin Park kyungmin.p...@samsung.com On Mon, Oct 15, 2012 at 10:28 PM, Felipe Balbi ba...@ti.com wrote: On Fri, Oct 12, 2012 at 03:45:34PM +0530, Praveen Paneri wrote: platform_set_drvdata() required for driver's remove function, so adding it back. From v6:

Re: [PATCH] usb: phy: samsung: Introducing usb phy driver for hsotg

2012-10-15 Thread Praveen Paneri
On Mon, Oct 15, 2012 at 6:58 PM, Felipe Balbi ba...@ti.com wrote: On Fri, Oct 12, 2012 at 03:45:34PM +0530, Praveen Paneri wrote: platform_set_drvdata() required for driver's remove function, so adding it back. From v6: Added TODO for phy bindings with controller Dropped