Re: [PATCH 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-07-22 Thread Javier Martinez Canillas
Hello Yuvaraj, On Sat, Jun 28, 2014 at 12:47 AM, Doug Anderson diand...@chromium.org wrote: On Fri, Jun 27, 2014 at 3:59 AM, Yuvaraj Kumar yuvaraj...@gmail.com wrote: mmc_regulator_set_ocr() is failing as its a fixed-regulator. Can you explain more about what's failing? It sure looks like

Re: [PATCH 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-06-30 Thread Jaehoon Chung
On 06/27/2014 01:18 AM, Doug Anderson wrote: Yuvaraj, On Thu, Jun 26, 2014 at 4:21 AM, Yuvaraj Kumar yuvaraj...@gmail.com wrote: Doug On Tue, Jun 24, 2014 at 11:30 PM, Doug Anderson diand...@chromium.org wrote: Yuvaraj, On Mon, Jun 23, 2014 at 3:45 AM, Yuvaraj Kumar C D

Re: [PATCH 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-06-30 Thread Doug Anderson
Jaehoon, On Mon, Jun 30, 2014 at 5:13 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: On 06/27/2014 01:18 AM, Doug Anderson wrote: Yuvaraj, On Thu, Jun 26, 2014 at 4:21 AM, Yuvaraj Kumar yuvaraj...@gmail.com wrote: Doug On Tue, Jun 24, 2014 at 11:30 PM, Doug Anderson diand...@chromium.org

Re: [PATCH 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-06-30 Thread Jaehoon Chung
Hi Doug. On 07/01/2014 12:06 AM, Doug Anderson wrote: Jaehoon, On Mon, Jun 30, 2014 at 5:13 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: On 06/27/2014 01:18 AM, Doug Anderson wrote: Yuvaraj, On Thu, Jun 26, 2014 at 4:21 AM, Yuvaraj Kumar yuvaraj...@gmail.com wrote: Doug On Tue, Jun

Re: [PATCH 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-06-27 Thread Yuvaraj Kumar
On Thu, Jun 26, 2014 at 9:48 PM, Doug Anderson diand...@chromium.org wrote: Yuvaraj, On Thu, Jun 26, 2014 at 4:21 AM, Yuvaraj Kumar yuvaraj...@gmail.com wrote: Doug On Tue, Jun 24, 2014 at 11:30 PM, Doug Anderson diand...@chromium.org wrote: Yuvaraj, On Mon, Jun 23, 2014 at 3:45 AM,

RE: [PATCH 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-06-27 Thread Seungwon Jeon
On Fri, June 27, 2014, Doug Anderson wrote: Seungwon, On Thu, Jun 26, 2014 at 3:30 AM, Seungwon Jeon tgih@samsung.com wrote: Hi Doug, On Thu, June 26, 2014, Doug Anderson wrote: Seungwon, On Wed, Jun 25, 2014 at 4:18 AM, Seungwon Jeon tgih@samsung.com wrote: +

Re: [PATCH 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-06-27 Thread Doug Anderson
Yuvaraj, On Fri, Jun 27, 2014 at 3:59 AM, Yuvaraj Kumar yuvaraj...@gmail.com wrote: mmc_regulator_set_ocr() is failing as its a fixed-regulator. Can you explain more about what's failing? It sure looks like mmc core is supposed to handle this given comments below /* * If we're using a

RE: [PATCH 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-06-26 Thread Seungwon Jeon
Hi Doug, On Thu, June 26, 2014, Doug Anderson wrote: Seungwon, On Wed, Jun 25, 2014 at 4:18 AM, Seungwon Jeon tgih@samsung.com wrote: + case MMC_POWER_ON: + if (!IS_ERR(mmc-supply.vqmmc) + !test_bit(DW_MMC_IO_POWERED,

Re: [PATCH 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-06-26 Thread Yuvaraj Kumar
Doug On Tue, Jun 24, 2014 at 11:30 PM, Doug Anderson diand...@chromium.org wrote: Yuvaraj, On Mon, Jun 23, 2014 at 3:45 AM, Yuvaraj Kumar C D yuvaraj...@gmail.com wrote: This patch makes use of mmc_regulator_get_supply() to handle the vmmc and vqmmc regulators.Also it moves the code

Re: [PATCH 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-06-26 Thread Doug Anderson
Yuvaraj, On Thu, Jun 26, 2014 at 4:21 AM, Yuvaraj Kumar yuvaraj...@gmail.com wrote: Doug On Tue, Jun 24, 2014 at 11:30 PM, Doug Anderson diand...@chromium.org wrote: Yuvaraj, On Mon, Jun 23, 2014 at 3:45 AM, Yuvaraj Kumar C D yuvaraj...@gmail.com wrote: This patch makes use of

Re: [PATCH 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-06-26 Thread Doug Anderson
Seungwon, On Thu, Jun 26, 2014 at 3:30 AM, Seungwon Jeon tgih@samsung.com wrote: Hi Doug, On Thu, June 26, 2014, Doug Anderson wrote: Seungwon, On Wed, Jun 25, 2014 at 4:18 AM, Seungwon Jeon tgih@samsung.com wrote: + case MMC_POWER_ON: + if

RE: [PATCH 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-06-25 Thread Seungwon Jeon
Hi Yuvaraj. This patch looks like similar Jaehoon's. Is it resending? Anyway, I added some comments below. On Wed, June 25, 2014, Jaehoon Chung wrote: On 06/25/2014 03:00 AM, Doug Anderson wrote: Yuvaraj, On Mon, Jun 23, 2014 at 3:45 AM, Yuvaraj Kumar C D yuvaraj...@gmail.com wrote:

Re: [PATCH 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-06-25 Thread Doug Anderson
Seungwon, On Wed, Jun 25, 2014 at 4:18 AM, Seungwon Jeon tgih@samsung.com wrote: + case MMC_POWER_ON: + if (!IS_ERR(mmc-supply.vqmmc) + !test_bit(DW_MMC_IO_POWERED, slot-flags)) { You can use regulator_is_enabled() instead of flag

Re: [PATCH 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-06-24 Thread Doug Anderson
Yuvaraj, On Mon, Jun 23, 2014 at 3:45 AM, Yuvaraj Kumar C D yuvaraj...@gmail.com wrote: This patch makes use of mmc_regulator_get_supply() to handle the vmmc and vqmmc regulators.Also it moves the code handling the these regulators to dw_mci_set_ios().It turned on the vmmc and vqmmc during

Re: [PATCH 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-06-24 Thread Jaehoon Chung
On 06/25/2014 03:00 AM, Doug Anderson wrote: Yuvaraj, On Mon, Jun 23, 2014 at 3:45 AM, Yuvaraj Kumar C D yuvaraj...@gmail.com wrote: This patch makes use of mmc_regulator_get_supply() to handle the vmmc and vqmmc regulators.Also it moves the code handling the these regulators to

Re: [PATCH 1/3] mmc: dw_mmc: use mmc_regulator_get_supply to handle regulators

2014-06-24 Thread Doug Anderson
Jaehoon, On Tue, Jun 24, 2014 at 8:18 PM, Jaehoon Chung jh80.ch...@samsung.com wrote: On 06/25/2014 03:00 AM, Doug Anderson wrote: Yuvaraj, On Mon, Jun 23, 2014 at 3:45 AM, Yuvaraj Kumar C D yuvaraj...@gmail.com wrote: This patch makes use of mmc_regulator_get_supply() to handle the vmmc