RE: [PATCH 5/7] ARM: EXYNOS4: Add support external GIC

2011-11-02 Thread Kukjin Kim
Marc Zyngier wrote: > > On 12/10/11 06:16, Kukjin Kim wrote: > > Marc Zyngier wrote: > >> > >> Hi Changwan, > >> > >> On 11/10/11 13:22, Changhwan Youn wrote: > Kukjin, could you please comment on the presence of a common memory > region for the distributor? This seem quite odd... > >>>

Re: [PATCH 5/7] ARM: EXYNOS4: Add support external GIC

2011-11-02 Thread Marc Zyngier
On 12/10/11 06:16, Kukjin Kim wrote: > Marc Zyngier wrote: >> >> Hi Changwan, >> >> On 11/10/11 13:22, Changhwan Youn wrote: Kukjin, could you please comment on the presence of a common memory region for the distributor? This seem quite odd... >>> >>> Some registers in Distributor are ban

Re: [PATCH 5/7] ARM: EXYNOS4: Add support external GIC

2011-10-13 Thread Will Deacon
On Thu, Oct 13, 2011 at 12:09:28PM +0100, Russell King - ARM Linux wrote: > On Mon, Oct 10, 2011 at 02:02:09PM +0100, Marc Zyngier wrote: > > On 07/10/11 16:16, Will Deacon wrote: > > > On Fri, Oct 07, 2011 at 10:44:59AM +0100, Marc Zyngier wrote: > > >> +static void __cpuinit exynos4_secondary_ini

Re: [PATCH 5/7] ARM: EXYNOS4: Add support external GIC

2011-10-13 Thread Russell King - ARM Linux
On Mon, Oct 10, 2011 at 02:02:09PM +0100, Marc Zyngier wrote: > On 07/10/11 16:16, Will Deacon wrote: > > On Fri, Oct 07, 2011 at 10:44:59AM +0100, Marc Zyngier wrote: > >> +static void __cpuinit exynos4_secondary_init(unsigned int cpu) > >> { > >>void __iomem *dist_base = S5P_VA_GIC_DIST + >

RE: [PATCH 5/7] ARM: EXYNOS4: Add support external GIC

2011-10-11 Thread Kukjin Kim
Marc Zyngier wrote: > > Hi Changwan, > > On 11/10/11 13:22, Changhwan Youn wrote: > >> Kukjin, could you please comment on the presence of a common memory > >> region for the distributor? This seem quite odd... > > > > Some registers in Distributor are banked for PPI and SGI support (banked > int

Re: [PATCH 5/7] ARM: EXYNOS4: Add support external GIC

2011-10-11 Thread Marc Zyngier
Hi Changwan, On 11/10/11 13:22, Changhwan Youn wrote: >> Kukjin, could you please comment on the presence of a common memory >> region for the distributor? This seem quite odd... > > Some registers in Distributor are banked for PPI and SGI support (banked > interrupts). > The register for pendin

RE: [PATCH 5/7] ARM: EXYNOS4: Add support external GIC

2011-10-11 Thread Changhwan Youn
Dear Marc and Will, On Monday, October 10, 2011 10:02 PM, Marc Zyngier wrote: > > On 07/10/11 16:16, Will Deacon wrote: > > Hi Marc, > > > > On Fri, Oct 07, 2011 at 10:44:59AM +0100, Marc Zyngier wrote: > >> So to make my suggestion completely clear, here's a patch I'm now > >> carrying in my tre

Re: [PATCH 5/7] ARM: EXYNOS4: Add support external GIC

2011-10-10 Thread Marc Zyngier
On 07/10/11 16:16, Will Deacon wrote: > Hi Marc, > > On Fri, Oct 07, 2011 at 10:44:59AM +0100, Marc Zyngier wrote: >> So to make my suggestion completely clear, here's a patch I'm now >> carrying in my tree. It's only been test compiled on EXYNOS4, but works >> nicely on my 11MP. It turns both dis

Re: [PATCH 5/7] ARM: EXYNOS4: Add support external GIC

2011-10-07 Thread Will Deacon
Hi Marc, On Fri, Oct 07, 2011 at 10:44:59AM +0100, Marc Zyngier wrote: > So to make my suggestion completely clear, here's a patch I'm now > carrying in my tree. It's only been test compiled on EXYNOS4, but works > nicely on my 11MP. It turns both dist_base and cpu_base into per-cpu > variables, r

RE: [PATCH 5/7] ARM: EXYNOS4: Add support external GIC

2011-10-07 Thread Kukjin Kim
Marc Zyngier wrote: > > On 06/10/11 09:18, Marc Zyngier wrote: > > On 06/10/11 07:30, Kukjin Kim wrote: > >> Marc Zyngier wrote: > >>> > >>> Hi Changhwan, > >>> > >> Hi Marc, > >> > >> (Cc'ed Will Deacon and Russell King) > >> > >>> On 20/06/11 08:34, Changhwan Youn wrote: > For full support

Re: [PATCH 5/7] ARM: EXYNOS4: Add support external GIC

2011-10-07 Thread Marc Zyngier
On 06/10/11 09:18, Marc Zyngier wrote: > On 06/10/11 07:30, Kukjin Kim wrote: >> Marc Zyngier wrote: >>> >>> Hi Changhwan, >>> >> Hi Marc, >> >> (Cc'ed Will Deacon and Russell King) >> >>> On 20/06/11 08:34, Changhwan Youn wrote: For full support of power modes, this patch adds implementation

Re: [PATCH 5/7] ARM: EXYNOS4: Add support external GIC

2011-10-06 Thread Marc Zyngier
On 06/10/11 07:30, Kukjin Kim wrote: > Marc Zyngier wrote: >> >> Hi Changhwan, >> > Hi Marc, > > (Cc'ed Will Deacon and Russell King) > >> On 20/06/11 08:34, Changhwan Youn wrote: >>> For full support of power modes, this patch adds implementation >>> external GIC on EXYNOS4. >>> >>> External GIC

RE: [PATCH 5/7] ARM: EXYNOS4: Add support external GIC

2011-10-05 Thread Kukjin Kim
Marc Zyngier wrote: > > Hi Changhwan, > Hi Marc, (Cc'ed Will Deacon and Russell King) > On 20/06/11 08:34, Changhwan Youn wrote: > > For full support of power modes, this patch adds implementation > > external GIC on EXYNOS4. > > > > External GIC of Exynos4 cannot support register banking so >

Re: [PATCH 5/7] ARM: EXYNOS4: Add support external GIC

2011-10-05 Thread Marc Zyngier
Hi Changhwan, On 20/06/11 08:34, Changhwan Youn wrote: > For full support of power modes, this patch adds implementation > external GIC on EXYNOS4. > > External GIC of Exynos4 cannot support register banking so > several interrupt related code for CPU1 should be different > from that of CPU0. I