Francois Romieu wrote:
> Byungho An :
> [...]
> > > Nit: you may consider reorganizing the variables in an inverted xmas
> > > tree fashion at some point.
> > Does it look better? No problem.
>
> Marginally if not more. Consider it a guideline to avoid unusual or ugly
layout.
OK. I'll consider
Byungho An :
[...]
> > Nit: you may consider reorganizing the variables in an inverted xmas tree
> > fashion at some point.
> Does it look better? No problem.
Marginally if not more. Consider it a guideline to avoid unusual or ugly
layout.
[...]
> > > +priv->ioaddr + SXGBE_MDIO_C
Francois Romieu :
> Byungho An :
> [...]
> > +static int sxgbe_hw_init(struct sxgbe_priv_data * const priv) {
>
> struct sxgbe_ops *hw = priv->hw;
>
> > + u32 ctrl_ids;
> [...]
> > +struct sxgbe_priv_data *sxgbe_dvr_probe(struct device *device,
>
> nit: s/dvr/drv/ ?
Yes, it is tiriva.
Byungho An :
[...]
> +static int sxgbe_hw_init(struct sxgbe_priv_data * const priv)
> +{
struct sxgbe_ops *hw = priv->hw;
> + u32 ctrl_ids;
[...]
> +struct sxgbe_priv_data *sxgbe_dvr_probe(struct device *device,
nit: s/dvr/drv/ ?
(several occurences in the driver)
> +
