Re: [PATCH v4 9/9] mmc: dw_mmc: add support for exynos specific implementation of dw-mshc

On 28 August 2012 16:13, Seungwon Jeon wrote: > On Tuesday, August 28, 2012 Thomas Abraham wrote: >> Hi Seungwon, >> >> On 28 August 2012 12:36, Seungwon Jeon wrote: [...] >> >> + /* >> >> + * Exynos4412 and Exynos5250 extends the use of CMD register with >> >> the >> >> + * use

RE: [PATCH v4 9/9] mmc: dw_mmc: add support for exynos specific implementation of dw-mshc

On Tuesday, August 28, 2012 Thomas Abraham wrote: > Hi Seungwon, > > On 28 August 2012 12:36, Seungwon Jeon wrote: > > Hi Thomas, > > > > Thank you for your effort. > > Some reviews seems like to be omitted. Please check more. > > > > On Sunday, August 26, 2012 Thomas Abraham wrote: > >> Samsun

Re: [PATCH v4 9/9] mmc: dw_mmc: add support for exynos specific implementation of dw-mshc

Hi Seungwon, On 28 August 2012 12:36, Seungwon Jeon wrote: > Hi Thomas, > > Thank you for your effort. > Some reviews seems like to be omitted. Please check more. > > On Sunday, August 26, 2012 Thomas Abraham wrote: >> Samsung Exynos SoC's extend the dw-mshc controller for additional clock and

RE: [PATCH v4 9/9] mmc: dw_mmc: add support for exynos specific implementation of dw-mshc

Hi Thomas, Thank you for your effort. Some reviews seems like to be omitted. Please check more. On Sunday, August 26, 2012 Thomas Abraham wrote: > Samsung Exynos SoC's extend the dw-mshc controller for additional clock and > bus > control. Add support for these extensions and include provide de

Re: [PATCH v4 9/9] mmc: dw_mmc: add support for exynos specific implementation of dw-mshc

On 28 August 2012 10:46, Jaehoon Chung wrote: > On 08/28/2012 02:10 PM, Thomas Abraham wrote: >> On 28 August 2012 10:40, Thomas Abraham wrote: >>> On 28 August 2012 10:25, Jaehoon Chung wrote: Hi Thomas, On 08/28/2012 01:48 PM, Thomas Abraham wrote: > On 27 August 2012 14:28,

Re: [PATCH v4 9/9] mmc: dw_mmc: add support for exynos specific implementation of dw-mshc

On 08/28/2012 02:10 PM, Thomas Abraham wrote: > On 28 August 2012 10:40, Thomas Abraham wrote: >> On 28 August 2012 10:25, Jaehoon Chung wrote: >>> Hi Thomas, >>> >>> On 08/28/2012 01:48 PM, Thomas Abraham wrote: On 27 August 2012 14:28, Jaehoon Chung wrote: > Hi Thomas, > >> +

Re: [PATCH v4 9/9] mmc: dw_mmc: add support for exynos specific implementation of dw-mshc

On 28 August 2012 10:40, Thomas Abraham wrote: > On 28 August 2012 10:25, Jaehoon Chung wrote: >> Hi Thomas, >> >> On 08/28/2012 01:48 PM, Thomas Abraham wrote: >>> On 27 August 2012 14:28, Jaehoon Chung wrote: Hi Thomas, > + gpio = of_get_named_gpio(slot_np, "wp-gpios", 0); >>

Re: [PATCH v4 9/9] mmc: dw_mmc: add support for exynos specific implementation of dw-mshc

On 28 August 2012 10:25, Jaehoon Chung wrote: > Hi Thomas, > > On 08/28/2012 01:48 PM, Thomas Abraham wrote: >> On 27 August 2012 14:28, Jaehoon Chung wrote: >>> Hi Thomas, >>> + gpio = of_get_named_gpio(slot_np, "wp-gpios", 0); + if (gpio_is_valid(gpio)) { + if

Re: [PATCH v4 9/9] mmc: dw_mmc: add support for exynos specific implementation of dw-mshc

Hi Thomas, On 08/28/2012 01:48 PM, Thomas Abraham wrote: > On 27 August 2012 14:28, Jaehoon Chung wrote: >> Hi Thomas, >> >>> + gpio = of_get_named_gpio(slot_np, "wp-gpios", 0); >>> + if (gpio_is_valid(gpio)) { >>> + if (devm_gpio_request(host->dev, gpio, "dw-mci-wp")) >>> +

Re: [PATCH v4 9/9] mmc: dw_mmc: add support for exynos specific implementation of dw-mshc

On 27 August 2012 14:28, Jaehoon Chung wrote: > Hi Thomas, > >> + gpio = of_get_named_gpio(slot_np, "wp-gpios", 0); >> + if (gpio_is_valid(gpio)) { >> + if (devm_gpio_request(host->dev, gpio, "dw-mci-wp")) >> + dev_info(host->dev, "gpio [%d] request failed\n

Re: [PATCH v4 9/9] mmc: dw_mmc: add support for exynos specific implementation of dw-mshc

Hi Thomas, > + gpio = of_get_named_gpio(slot_np, "wp-gpios", 0); > + if (gpio_is_valid(gpio)) { > + if (devm_gpio_request(host->dev, gpio, "dw-mci-wp")) > + dev_info(host->dev, "gpio [%d] request failed\n", > + gpi