RE: [PATCH v5 2/4] mmc: dw_mmc: Add exynos resume_noirq callback to clear WAKEUP_INT

2013-08-12 Thread Seungwon Jeon
Doug, Looks good to me except for minor comment. On Sat, August 10, 2013, Doug Anderson wrote: > If the WAKEUP_INT is asserted at wakeup and not cleared, we'll end up > looping around forever. This has been seen to happen on exynos5420 > silicon despite the fact that we haven't enabled any wakeup

Re: [PATCH v5 2/4] mmc: dw_mmc: Add exynos resume_noirq callback to clear WAKEUP_INT

2013-08-09 Thread Doug Anderson
Fabio, Thanks for your review. On Fri, Aug 9, 2013 at 9:41 AM, Fabio Estevam wrote: > On Fri, Aug 9, 2013 at 1:33 PM, Doug Anderson wrote: > >> +#else >> +#define dw_mci_exynos_suspend NULL >> +#define dw_mci_exynos_resume NULL >> +#define dw_mci_exynos_resume_noirq NULL

Re: [PATCH v5 2/4] mmc: dw_mmc: Add exynos resume_noirq callback to clear WAKEUP_INT

2013-08-09 Thread Fabio Estevam
On Fri, Aug 9, 2013 at 1:33 PM, Doug Anderson wrote: > +#else > +#define dw_mci_exynos_suspend NULL > +#define dw_mci_exynos_resume NULL > +#define dw_mci_exynos_resume_noirq NULL > +#endif /* CONFIG_PM_SLEEP */ You could avoid this else block if you use 'static SIMPLE_DEV