Re: [PATCH] PM / Domains: Fix initial default state of the need_restore flag

2014-11-10 Thread Ulf Hansson
[...] I guess we do need it for 3.18, but when we are talking about 3.19, before we make any more changes can we outline how power domains are supposed to work? 1. How do we attach a device to power domain? Right now it seems that individual buses are responsible for attaching their devices

Re: [PATCH] PM / Domains: Fix initial default state of the need_restore flag

2014-11-10 Thread Dmitry Torokhov
On Mon, Nov 10, 2014 at 04:18:50PM +0100, Ulf Hansson wrote: [...] I guess we do need it for 3.18, but when we are talking about 3.19, before we make any more changes can we outline how power domains are supposed to work? 1. How do we attach a device to power domain? Right now it

Re: [PATCH] PM / Domains: Fix initial default state of the need_restore flag

2014-11-10 Thread Mark Brown
On Mon, Nov 10, 2014 at 10:32:24AM -0800, Dmitry Torokhov wrote: - I do not see why sirincling platform specific code around i2c, spi, etc bus code (which is not platform-specific) is OK, but a no-no for the driver ocre. sirincling? In the case of I2C and SPI the buses don't define any

Re: [PATCH] PM / Domains: Fix initial default state of the need_restore flag

2014-11-10 Thread Dmitry Torokhov
On November 10, 2014 11:39:31 AM PST, Mark Brown broo...@kernel.org wrote: On Mon, Nov 10, 2014 at 10:32:24AM -0800, Dmitry Torokhov wrote: - I do not see why sirincling platform specific code around i2c, spi, etc bus code (which is not platform-specific) is OK, but a no-no for the driver

Re: [PATCH] PM / Domains: Fix initial default state of the need_restore flag

2014-11-07 Thread Sylwester Nawrocki
On 07/11/14 14:27, Ulf Hansson wrote: [...] To handle things more properly in the generic PM domain, let's change the default initial value of the need_restore flag to reflect that the state is unknown. As soon as some of the runtime PM callbacks gets invoked, update the initial value

Re: [PATCH] PM / Domains: Fix initial default state of the need_restore flag

2014-11-07 Thread Kevin Hilman
Ulf Hansson ulf.hans...@linaro.org writes: The initial state of the device's need_restore flag should'nt depend on the current state of the PM domain. For example it should be perfectly valid to attach an inactive device to a powered PM domain. The pm_genpd_dev_need_restore() API allow us to

Re: [PATCH] PM / Domains: Fix initial default state of the need_restore flag

2014-11-07 Thread Dmitry Torokhov
On Fri, Nov 07, 2014 at 11:47:53AM -0800, Kevin Hilman wrote: Ulf Hansson ulf.hans...@linaro.org writes: The initial state of the device's need_restore flag should'nt depend on the current state of the PM domain. For example it should be perfectly valid to attach an inactive device to a

Re: [PATCH] PM / Domains: Fix initial default state of the need_restore flag

2014-11-07 Thread Kevin Hilman
Dmitry Torokhov dmitry.torok...@gmail.com writes: On Fri, Nov 07, 2014 at 11:47:53AM -0800, Kevin Hilman wrote: Ulf Hansson ulf.hans...@linaro.org writes: The initial state of the device's need_restore flag should'nt depend on the current state of the PM domain. For example it should be

Re: [PATCH] PM / Domains: Fix initial default state of the need_restore flag

2014-11-07 Thread Rafael J. Wysocki
On Friday, November 07, 2014 02:27:27 PM Ulf Hansson wrote: The initial state of the device's need_restore flag should'nt depend on the current state of the PM domain. For example it should be perfectly valid to attach an inactive device to a powered PM domain. The