Re: [PATCH 1/2] spi/s3c64xx: Convert to devm_request_and_ioremap()

2012-07-05 Thread Sylwester Nawrocki
On 07/04/2012 06:11 PM, Mark Brown wrote: Saves some error handling and a small amount of code. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Acked-by: Linus Walleij linus.wall...@linaro.org --- drivers/spi/spi-s3c64xx.c | 25 + 1 file changed, 1

Re: [PATCH 1/2] spi/s3c64xx: Convert to devm_request_and_ioremap()

2012-07-05 Thread Mark Brown
On Thu, Jul 05, 2012 at 10:41:04AM +0200, Sylwester Nawrocki wrote: It doesn't seem right. Why is is the check for valid sdd-regs removed ? This should have rather been: Mostly just because the structure of the code is a bit error prone when making quick updates with the if statement

Re: [PATCH 1/2] spi/s3c64xx: Convert to devm_request_and_ioremap()

2012-06-28 Thread Linus Walleij
On Thu, Jun 28, 2012 at 3:23 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: Saves some error handling and a small amount of code. Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Elegant, monsieur. Acked-by: Linus Walleij linus.wall...@linaro.org I'm starting to

Re: [PATCH 1/2] spi/s3c64xx: Convert to devm_request_and_ioremap()

2012-06-28 Thread Mark Brown
On Thu, Jun 28, 2012 at 08:51:44PM +0200, Linus Walleij wrote: I'm starting to wonder if it would not be possible to mass-convert these using coccinelle. Probably, yes. I'm not actually going through these particularly, really what I'm doing is looking to find drivers I run on my systems that