Re: [PATCH 1/3] sysfs: Fix is_visible() support for binary attributes

2015-09-09 Thread Emilio López
On 09/09/15 01:12, Guenter Roeck wrote: On 09/08/2015 08:58 PM, Greg KH wrote: On Tue, Sep 08, 2015 at 06:10:16PM -0700, Guenter Roeck wrote: Hi Emilio, On 09/08/2015 05:51 PM, Emilio López wrote: Hi Greg & Guenter, [ ... ] Unless I am missing something, this is not explained anywhere,

Re: [PATCH 1/3] sysfs: Fix is_visible() support for binary attributes

2015-09-09 Thread Guenter Roeck
On 09/09/2015 06:14 AM, Emilio López wrote: On 09/09/15 01:12, Guenter Roeck wrote: On 09/08/2015 08:58 PM, Greg KH wrote: On Tue, Sep 08, 2015 at 06:10:16PM -0700, Guenter Roeck wrote: Hi Emilio, On 09/08/2015 05:51 PM, Emilio López wrote: Hi Greg & Guenter, [ ... ] Unless I am missing

Re: [PATCH 1/3] sysfs: Fix is_visible() support for binary attributes

2015-09-09 Thread Greg KH
On Wed, Sep 09, 2015 at 10:14:46AM -0300, Emilio López wrote: > On 09/09/15 01:12, Guenter Roeck wrote: > >On 09/08/2015 08:58 PM, Greg KH wrote: > >>On Tue, Sep 08, 2015 at 06:10:16PM -0700, Guenter Roeck wrote: > >>>Hi Emilio, > >>> > >>>On 09/08/2015 05:51 PM, Emilio López wrote: > Hi Greg

Re: [PATCH 1/3] sysfs: Fix is_visible() support for binary attributes

2015-09-08 Thread Guenter Roeck
On Tue, Sep 08, 2015 at 12:10:02PM -0700, Greg KH wrote: > On Tue, Sep 08, 2015 at 08:30:13AM -0700, Guenter Roeck wrote: > > Emilio, > > > > On Tue, Sep 08, 2015 at 09:07:44AM -0300, Emilio López wrote: > > > According to the sysfs header file: > > > > > > "The returned value will replace

Re: [PATCH 1/3] sysfs: Fix is_visible() support for binary attributes

2015-09-08 Thread Greg KH
On Tue, Sep 08, 2015 at 08:30:13AM -0700, Guenter Roeck wrote: > Emilio, > > On Tue, Sep 08, 2015 at 09:07:44AM -0300, Emilio López wrote: > > According to the sysfs header file: > > > > "The returned value will replace static permissions defined in > > struct attribute or struct

Re: [PATCH 1/3] sysfs: Fix is_visible() support for binary attributes

2015-09-08 Thread Guenter Roeck
Emilio, On Tue, Sep 08, 2015 at 09:07:44AM -0300, Emilio López wrote: > According to the sysfs header file: > > "The returned value will replace static permissions defined in > struct attribute or struct bin_attribute." > > but this isn't the case, as is_visible is only called on >

Re: [PATCH 1/3] sysfs: Fix is_visible() support for binary attributes

2015-09-08 Thread Guenter Roeck
Hi Emilio, On 09/08/2015 05:51 PM, Emilio López wrote: Hi Greg & Guenter, [ ... ] Unless I am missing something, this is not explained anywhere, but it is not entirely trivial to understand. I think it should be documented. I agree. I couldn't find any mention of what this int was

Re: [PATCH 1/3] sysfs: Fix is_visible() support for binary attributes

2015-09-08 Thread Emilio López
Hi Greg & Guenter, On 08/09/15 16:30, Guenter Roeck wrote: On Tue, Sep 08, 2015 at 12:10:02PM -0700, Greg KH wrote: On Tue, Sep 08, 2015 at 08:30:13AM -0700, Guenter Roeck wrote: Emilio, On Tue, Sep 08, 2015 at 09:07:44AM -0300, Emilio López wrote: According to the sysfs header file:

Re: [PATCH 1/3] sysfs: Fix is_visible() support for binary attributes

2015-09-08 Thread Greg KH
On Tue, Sep 08, 2015 at 06:10:16PM -0700, Guenter Roeck wrote: > Hi Emilio, > > On 09/08/2015 05:51 PM, Emilio López wrote: > >Hi Greg & Guenter, > > > [ ... ] > > Unless I am missing something, this is not explained anywhere, but it is > not entirely trivial to understand. I think

Re: [PATCH 1/3] sysfs: Fix is_visible() support for binary attributes

2015-09-08 Thread Guenter Roeck
On 09/08/2015 08:58 PM, Greg KH wrote: On Tue, Sep 08, 2015 at 06:10:16PM -0700, Guenter Roeck wrote: Hi Emilio, On 09/08/2015 05:51 PM, Emilio López wrote: Hi Greg & Guenter, [ ... ] Unless I am missing something, this is not explained anywhere, but it is not entirely trivial to