Re: [PATCH RESEND v2 5/7] mfd: cros_ec: Instantiate ChromeOS EC character device

2015-01-21 Thread Javier Martinez Canillas
Hello Lee, On 01/20/2015 06:11 PM, Javier Martinez Canillas wrote: But is it really a chardev? Don't chardevs usually live in drivers/char? It probably uses a chardev node in /dev, but what does it really do? What information can/will userspace obtain from this memory block? Right,

Re: [PATCH RESEND v2 5/7] mfd: cros_ec: Instantiate ChromeOS EC character device

2015-01-20 Thread Lee Jones
On Fri, 02 Jan 2015, Javier Martinez Canillas wrote: The ChromeOS EC character device is an user-space interface to allow applications to access the Embedded Controller. Add a cell for this device so it's spawned from the mfd driver. Signed-off-by: Javier Martinez Canillas

Re: [PATCH RESEND v2 5/7] mfd: cros_ec: Instantiate ChromeOS EC character device

2015-01-20 Thread Javier Martinez Canillas
Hello Lee, On 01/20/2015 05:55 PM, Lee Jones wrote: On Tue, 20 Jan 2015, Javier Martinez Canillas wrote: Hello Lee, On 01/20/2015 05:29 PM, Lee Jones wrote: It's not a blocker, but it is a ridiculous name to use inside the driver/ directory 'cos almost everything is a dev(ice) here.

Re: [PATCH RESEND v2 5/7] mfd: cros_ec: Instantiate ChromeOS EC character device

2015-01-20 Thread Lee Jones
On Tue, 20 Jan 2015, Javier Martinez Canillas wrote: Hello Lee, On 01/20/2015 05:29 PM, Lee Jones wrote: It's not a blocker, but it is a ridiculous name to use inside the driver/ directory 'cos almost everything is a dev(ice) here. Right, do you think that cros-ec-chardev will be

Re: [PATCH RESEND v2 5/7] mfd: cros_ec: Instantiate ChromeOS EC character device

2015-01-20 Thread Javier Martinez Canillas
Hello Lee, Thanks a lot for your feedback. On 01/20/2015 09:20 AM, Lee Jones wrote: On Fri, 02 Jan 2015, Javier Martinez Canillas wrote: The ChromeOS EC character device is an user-space interface to allow applications to access the Embedded Controller. Add a cell for this device so it's

Re: [PATCH RESEND v2 5/7] mfd: cros_ec: Instantiate ChromeOS EC character device

2015-01-20 Thread Javier Martinez Canillas
Hello Lee, On 01/20/2015 05:29 PM, Lee Jones wrote: It's not a blocker, but it is a ridiculous name to use inside the driver/ directory 'cos almost everything is a dev(ice) here. Right, do you think that cros-ec-chardev will be a more suitable name? Sorry, I'm really bad at naming

Re: [PATCH RESEND v2 5/7] mfd: cros_ec: Instantiate ChromeOS EC character device

2015-01-20 Thread Lee Jones
On Tue, 20 Jan 2015, Javier Martinez Canillas wrote: Hello Lee, Thanks a lot for your feedback. On 01/20/2015 09:20 AM, Lee Jones wrote: On Fri, 02 Jan 2015, Javier Martinez Canillas wrote: The ChromeOS EC character device is an user-space interface to allow applications to access