Re: [PATCH v2] ARM: EXYNOS: Refactor the pm code to use DT based lookup

2014-08-06 Thread Vikas Sajjan
Hi Tomasz, On Wed, Aug 6, 2014 at 1:35 AM, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Vikas, Please see my comments inline. On 25.07.2014 13:49, Vikas Sajjan wrote: Refactoring the pm.c to avoid using soc_is_exynos checks, instead use the DT based lookup. While at it, consolidate the

Re: [PATCH v2] ARM: EXYNOS: Refactor the pm code to use DT based lookup

2014-08-06 Thread Tomasz Figa
On 06.08.2014 14:58, Vikas Sajjan wrote: On Wed, Aug 6, 2014 at 1:35 AM, Tomasz Figa tomasz.f...@gmail.com wrote: On 25.07.2014 13:49, Vikas Sajjan wrote: [snip] + + /* Disable USE_RETENTION of JPEG_MEM_OPTION */ + tmp = pmu_raw_readl(EXYNOS5_JPEG_MEM_OPTION); + tmp =

Re: [PATCH v2] ARM: EXYNOS: Refactor the pm code to use DT based lookup

2014-08-06 Thread Vikas Sajjan
Hi Tomasz, On Wed, Aug 6, 2014 at 6:57 PM, Tomasz Figa t.f...@samsung.com wrote: On 06.08.2014 14:58, Vikas Sajjan wrote: On Wed, Aug 6, 2014 at 1:35 AM, Tomasz Figa tomasz.f...@gmail.com wrote: On 25.07.2014 13:49, Vikas Sajjan wrote: [snip] + + /* Disable USE_RETENTION of

Re: [PATCH v2] ARM: EXYNOS: Refactor the pm code to use DT based lookup

2014-08-05 Thread Thomas Abraham
Hi Vikas, On Fri, Jul 25, 2014 at 5:19 PM, Vikas Sajjan vikas.saj...@samsung.com wrote: Refactoring the pm.c to avoid using soc_is_exynos checks, instead use the DT based lookup. While at it, consolidate the common code across SoCs and create a static helper functions. Signed-off-by: Vikas

Re: [PATCH v2] ARM: EXYNOS: Refactor the pm code to use DT based lookup

2014-08-05 Thread Tomasz Figa
Hi Vikas, Please see my comments inline. On 25.07.2014 13:49, Vikas Sajjan wrote: Refactoring the pm.c to avoid using soc_is_exynos checks, instead use the DT based lookup. While at it, consolidate the common code across SoCs and create a static helper functions. [snip] @@ -241,13

Re: [PATCH v2] ARM: EXYNOS: Refactor the pm code to use DT based lookup

2014-08-03 Thread Vikas Sajjan
Hi Kukjin, On Fri, Jul 25, 2014 at 5:34 PM, Vikas Sajjan vikas.saj...@samsung.com wrote: Refactoring the pm.c to avoid using soc_is_exynos checks, instead use the DT based lookup. While at it, consolidate the common code across SoCs and create a static helper functions. Signed-off-by: