Re: Unbalanced calls to spi_master_get in coldfire-qspi and s3c64xx SPI master drivers

2012-08-16 Thread Thomas Abraham
On 14 August 2012 03:14, Guenter Roeck li...@roeck-us.net wrote: Hi all, looking through SPI master drivers, I noticed that the following drivers call spi_master_get() in their suspend and resume functions. Yet, there is no matching call to spi_master_put(), meaning the reference count will

[PATCH] Add MFC device tree support

2012-08-16 Thread Arun Kumar K
This patch incorporates device tree support for the video codec IP (MFC) present in Exynos series SoCs. The driver side support for this will be posted as a separate patch in the linux-media mailing list. Naveen Krishna Chatradhi (1): ARM: EXYNOS: Add MFC device tree support

[PATCH] ARM: EXYNOS: Add MFC device tree support

2012-08-16 Thread Arun Kumar K
From: Naveen Krishna Chatradhi ch.nav...@samsung.com This patch adds device tree entry for MFC in the Exynos machines. Exynos4 SoCs support MFC v5 version and Exynos5 has MFC v6.x version. So making the required changes in the clock files and adds MFC to the DT device list. Signed-off-by: Naveen

[PATCH v6 1/6] thermal: add generic cpufreq cooling implementation

2012-08-16 Thread Amit Daniel Kachhap
This patchset introduces a new generic cooling device based on cpufreq that can be used on non-ACPI platforms. As a proof of concept, we have drivers for the following platforms using this mechanism now: * Samsung Exynos (Exynos4 and Exynos5) in the current patchset. * Freescale i.MX

[PATCH v6 0/6] thermal: Add kernel thermal support for exynos platform

2012-08-16 Thread Amit Daniel Kachhap
Hi Andrew/Zhang/Len, This current patchset is based on 3.6-rc1 and Zhang Rui's core thermal enhancement patches(http://permalink.gmane.org/gmane.linux.acpi.devel/54564). Version V5 is present in linux-next tree. Since Zhang Rui's implementation are already present in linux-next so requesting

[PATCH v6 2/6] hwmon: exynos4: move thermal sensor driver to driver/thermal directory

2012-08-16 Thread Amit Daniel Kachhap
This movement is needed because the hwmon entries and corresponding sysfs interface is a duplicate of utilities already provided by driver/thermal/thermal_sys.c. The goal is to place it in thermal folder and add necessary functions to use the in-kernel thermal interfaces. Signed-off-by: Amit

[PATCH v6 4/6] thermal: exynos: register the tmu sensor with the kernel thermal layer

2012-08-16 Thread Amit Daniel Kachhap
This code added creates a link between temperature sensors, linux thermal framework and cooling devices for samsung exynos platform. This layer monitors the temperature from the sensor and informs the generic thermal layer to take the necessary cooling action. [a...@linux-foundation.org: fix

[PATCH v6 5/6] ARM: exynos: add thermal sensor driver platform data support

2012-08-16 Thread Amit Daniel Kachhap
Add necessary default platform data support needed for TMU driver. The supplied dt/non-dt values are tested for origen exynos4210 and smdk exynos5250 platforms and only compile tested for exynos4412. Signed-off-by: Amit Daniel Kachhap amit.kach...@linaro.org Acked-by: Guenter Roeck

[PATCH v6 6/6] thermal: exynos: Use devm_* functions

2012-08-16 Thread Amit Daniel Kachhap
devm_* functions are used to replace kzalloc, request_mem_region, ioremap and request_irq functions in probe call. With the usage of devm_* functions explicit freeing and unmapping is not required. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Signed-off-by: Sachin Kamat

Re: [PATCH] ARM: EXYNOS: Add MFC device tree support

2012-08-16 Thread Thomas Abraham
On 16 August 2012 18:01, Arun Kumar K arun...@samsung.com wrote: From: Naveen Krishna Chatradhi ch.nav...@samsung.com This patch adds device tree entry for MFC in the Exynos machines. Exynos4 SoCs support MFC v5 version and Exynos5 has MFC v6.x version. So making the required changes in the

[PATCH v6 3/6] thermal: exynos5: add exynos5250 thermal sensor driver support

2012-08-16 Thread Amit Daniel Kachhap
Insert exynos5 TMU sensor changes into the thermal driver. Some exynos4 changes are made generic for exynos series. [a...@linux-foundation.org: fix comment layout] Signed-off-by: SangWook Ju sw...@samsung.com Signed-off-by: Amit Daniel Kachhap amit.kach...@linaro.org Acked-by: Guenter Roeck

Re: Unbalanced calls to spi_master_get in coldfire-qspi and s3c64xx SPI master drivers

2012-08-16 Thread Guenter Roeck
On Thu, Aug 16, 2012 at 02:27:49PM +0530, Thomas Abraham wrote: On 14 August 2012 03:14, Guenter Roeck li...@roeck-us.net wrote: Hi all, looking through SPI master drivers, I noticed that the following drivers call spi_master_get() in their suspend and resume functions. Yet, there is

Re: [linux-pm] [PATCH v6 1/6] thermal: add generic cpufreq cooling implementation

2012-08-16 Thread Valentin, Eduardo
Amit, Thanks again for keeping this up. On Thu, Aug 16, 2012 at 2:41 PM, Amit Daniel Kachhap amit.kach...@linaro.org wrote: This patchset introduces a new generic cooling device based on cpufreq that can be used on non-ACPI platforms. As a proof of concept, we have drivers for the following

[PATCH] mmc: sdhci-s3c: Add device tree support

2012-08-16 Thread Thomas Abraham
Add device tree based discovery support for Samsung's sdhci controller Cc: Ben Dooks ben-li...@fluff.org Cc: Kukjin Kim kgene@samsung.com Cc: Chris Ball c...@laptop.org Signed-off-by: Thomas Abraham thomas.abra...@linaro.org --- drivers/mmc/host/sdhci-s3c.c | 146

Re: [PATCH] mmc: sdhci-s3c: Add device tree support

2012-08-16 Thread Chris Ball
Hi Thomas, On Thu, Aug 16 2012, Thomas Abraham wrote: Add device tree based discovery support for Samsung's sdhci controller Cc: Ben Dooks ben-li...@fluff.org Cc: Kukjin Kim kgene@samsung.com Cc: Chris Ball c...@laptop.org Signed-off-by: Thomas Abraham thomas.abra...@linaro.org ---

Re: [PATCH] mmc: sdhci-s3c: Add device tree support

2012-08-16 Thread Thomas Abraham
Hi Chris, Thanks for your review. On 16 August 2012 21:17, Chris Ball c...@laptop.org wrote: Hi Thomas, On Thu, Aug 16 2012, Thomas Abraham wrote: Add device tree based discovery support for Samsung's sdhci controller Cc: Ben Dooks ben-li...@fluff.org Cc: Kukjin Kim kgene@samsung.com

[PATCH] mmc: sdhci-s3c: Add device tree support

2012-08-16 Thread Thomas Abraham
Add device tree based discovery support for Samsung's sdhci controller Cc: Ben Dooks ben-li...@fluff.org Cc: Kukjin Kim kgene@samsung.com Cc: Chris Ball c...@laptop.org Signed-off-by: Thomas Abraham thomas.abra...@linaro.org --- Changes since v3: The patch series that adds device tree

Re: [PATCH] mmc: sdhci-s3c: Add device tree support

2012-08-16 Thread Chris Ball
Hi, On Thu, Aug 16 2012, Thomas Abraham wrote: Add device tree based discovery support for Samsung's sdhci controller Cc: Ben Dooks ben-li...@fluff.org Cc: Kukjin Kim kgene@samsung.com Cc: Chris Ball c...@laptop.org Signed-off-by: Thomas Abraham thomas.abra...@linaro.org --- Changes

Re: [PATCH] mmc: sdhci-s3c: Add device tree support

2012-08-16 Thread Thomas Abraham
On 16 August 2012 21:59, Chris Ball c...@laptop.org wrote: Hi, On Thu, Aug 16 2012, Thomas Abraham wrote: Add device tree based discovery support for Samsung's sdhci controller Cc: Ben Dooks ben-li...@fluff.org Cc: Kukjin Kim kgene@samsung.com Cc: Chris Ball c...@laptop.org

[PATCH] ARM: dts: use generic mmc properties for Samsung Exynos4210 sdhci nodes

2012-08-16 Thread Thomas Abraham
The SDHCI controller nodes in platforms which are based on Samsung's Exynos4210 SoC are using the older custom Samsung SDHCI bindings. Remove the old Samsung specific bindings and use the generic mmc bindings that are defined for mmc controllers. Cc: Kukjin Kim kgene@samsung.com Cc: Chris

Re: [PATCH] mmc: sdhci-s3c: Add device tree support

2012-08-16 Thread Chris Ball
Hi Thomas, On Thu, Aug 16 2012, Thomas Abraham wrote: +Optional Board Specific Properties: +- One of the following properties for card detect type. + - samsung,sdhci-cd-internal: Card detect line from the card slot is +connected to the card detect pad of the sdhci controller. A gpio is

Re: [PATCH] mmc: sdhci-s3c: Add device tree support

2012-08-16 Thread Thomas Abraham
On 16 August 2012 22:22, Chris Ball c...@laptop.org wrote: Hi Thomas, On Thu, Aug 16 2012, Thomas Abraham wrote: +Optional Board Specific Properties: +- One of the following properties for card detect type. + - samsung,sdhci-cd-internal: Card detect line from the card slot is +

Re: [PATCH 1/2] ARM: dts: Add pinctrl node entries for Samsung Exynos4210 SoC

2012-08-16 Thread Matt Sealey
Re: samsung,pin-function samsung,pin-pud samsung,pin-drv - why can't these be one property, why take the space to define them individually instead of in an array of 3 values under one property name? -- Matt Sealey m...@genesi-usa.com Product Development Analyst, Genesi USA, Inc. On Wed, Aug

[PATCH] spi/s3c64xx: Drop extra calls to spi_master_get in suspend/remove functions

2012-08-16 Thread Guenter Roeck
Suspend and resume functions call spi_master_get() without matching spi_master_put(). The extra references are unnecessary and cause subsequent module unload attempts to fail. Drop the calls. Signed-off-by: Guenter Roeck li...@roeck-us.net --- drivers/spi/spi-s3c64xx.c |8 1 file

Re: [PATCH] spi/s3c64xx: Drop extra calls to spi_master_get in suspend/remove functions

2012-08-16 Thread Guenter Roeck
Sigh. s/remove/resume/ in headline. Guenter On Thu, Aug 16, 2012 at 08:14:25PM -0700, Guenter Roeck wrote: Suspend and resume functions call spi_master_get() without matching spi_master_put(). The extra references are unnecessary and cause subsequent module unload attempts to fail. Drop the

Re: [linux-pm] [PATCH v6 1/6] thermal: add generic cpufreq cooling implementation

2012-08-16 Thread Amit Kachhap
On 16 August 2012 20:22, Valentin, Eduardo eduardo.valen...@ti.com wrote: Amit, Thanks again for keeping this up. On Thu, Aug 16, 2012 at 2:41 PM, Amit Daniel Kachhap amit.kach...@linaro.org wrote: This patchset introduces a new generic cooling device based on cpufreq that can be used

Re: [PATCH v6 5/6] ARM: exynos: add thermal sensor driver platform data support

2012-08-16 Thread Thomas Abraham
On 16 August 2012 17:11, Amit Daniel Kachhap amit.kach...@linaro.org wrote: Add necessary default platform data support needed for TMU driver. The supplied dt/non-dt values are tested for origen exynos4210 and smdk exynos5250 platforms and only compile tested for exynos4412. Signed-off-by:

Re: [PATCH] ARM: EXYNOS: Add MFC device tree support

2012-08-16 Thread Arun Kumar K
Hi Thomas, Thank you for the comments. Please find my response inline. --- Original Message --- Sender : Thomas Abrahamthomas.abra...@linaro.org Date : Aug 16, 2012 17:12 (GMT+05:30) Title : Re: [PATCH] ARM: EXYNOS: Add MFC device tree support On 16 August 2012 18:01, Arun Kumar K

Re: [PATCH 1/2] ARM: dts: Add pinctrl node entries for Samsung Exynos4210 SoC

2012-08-16 Thread Thomas Abraham
On 17 August 2012 00:26, Matt Sealey m...@genesi-usa.com wrote: Re: samsung,pin-function samsung,pin-pud samsung,pin-drv - why can't these be one property, why take the space to define them individually instead of in an array of 3 values under one property name? Samsung pinctrl driver was