[PATCH 1/2] cpufreq: exynos: Fix unsigned variable being checked for negative value

2013-01-23 Thread Sachin Kamat
exynos_cpufreq_scale function returns signed value which was assigned to an unsigned variable and checked for negative value which is always false. Hence make it signed. Fixes the following smatch warnings: drivers/cpufreq/exynos-cpufreq.c:83 exynos_cpufreq_scale() warn: unsigned 'old_index' is

[PATCH 2/2] cpufreq: exynos: Initialise return variable

2013-01-23 Thread Sachin Kamat
'ret' is undefined when the function returns from the first 'if' condition. Without this patch we get the following warning: drivers/cpufreq/exynos-cpufreq.c: In function ‘exynos_target’: drivers/cpufreq/exynos-cpufreq.c:182:2: warning: ‘ret’ may be used uninitialized in this function

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-23 Thread Felipe Balbi
Hi, On Tue, Jan 22, 2013 at 02:04:56PM -0800, Kukjin Kim wrote: Felipe Balbi wrote: Hi, Hi Felipe, [...] Right, DWC has version number, but that being the kind of USB controller (USB 2.0 and USB 3.0) DWC2: USB High Speed controller (as also indicated in the patch from

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-23 Thread Vivek Gautam
Hi all, On Wed, Jan 23, 2013 at 3:20 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Tue, Jan 22, 2013 at 02:04:56PM -0800, Kukjin Kim wrote: Felipe Balbi wrote: Hi, Hi Felipe, [...] Right, DWC has version number, but that being the kind of USB controller (USB 2.0 and USB 3.0)

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-23 Thread Sylwester Nawrocki
Hi, On 01/23/2013 01:20 PM, Vivek Gautam wrote: - { .compatible = samsung,exynos-dwc3 }, + { .compatible = samsung,synopsis-dwc3 } You're both missing a point here. The synopsys IP driver is called dwc3.ko and that's compatible with synopsys,dwc3. Your glue layer driver

Re: [PATCH v4 3/4] ARM: Exynos5250: Add clock information for dwc3-exynos

2013-01-23 Thread Vivek Gautam
Hi Tomasz, On Wed, Jan 16, 2013 at 8:35 PM, Vivek Gautam gautamvivek1...@gmail.com wrote: Hi Tomasz, On Wed, Jan 16, 2013 at 1:19 PM, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Vivek, Don't you need also some clkdev lookup entry to make the clock available in the driver? This clock

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-23 Thread Vivek Gautam
Hi Sylwester, On Wed, Jan 23, 2013 at 6:10 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: Hi, On 01/23/2013 01:20 PM, Vivek Gautam wrote: - { .compatible = samsung,exynos-dwc3 }, + { .compatible = samsung,synopsis-dwc3 } You're both missing a point here. The synopsys IP

Re: [PATCH] ARM: dts: specify all the per-cpu interrupts of arch timer for exynos5440

2013-01-23 Thread Rob Herring
On 01/23/2013 04:36 AM, Mark Rutland wrote: On Tue, Jan 22, 2013 at 10:05:18PM +, Kukjin Kim wrote: Mark Rutland wrote: + devicetree-discuss, Grant Likely, Rob Herring and Tony Lindgren On Tue, Jan 22, 2013 at 01:41:27AM +, Kukjin Kim wrote: From: Thomas Abraham

Re: [PATCH] ARM: dts: add mshc controller node for Exynos4x12 SoCs

2013-01-23 Thread Dongjin Kim
Tested-by: Dongjin Kim tobet...@gmail.com This patch had been tested on v3.8-rc4 with ODROID-X hardware. On Wed, Jan 23, 2013 at 2:21 PM, Dongjin Kim tobet...@gmail.com wrote: Hello Thomas, Thank you. I will submit the change soon. Thanks again. Dongjin. On Wed, Jan 23, 2013 at 8:25 AM,

[PATCH RFC v3 00/14] V4L2 device tree bindings and OF helpers

2013-01-23 Thread Sylwester Nawrocki
This series includes the updated device tree bindings documentation and the V4L2 OF parser (v4). There were just couple minor changes since v3: - improved clock-lanes property description, - grammar corrections of the example dts snippet description, - minor comments corrections.

[PATCH RFC v4 01/14] [media] Add common video interfaces OF bindings documentation

2013-01-23 Thread Sylwester Nawrocki
From: Guennadi Liakhovetski g.liakhovet...@gmx.de This patch adds a document describing common OF bindings for video capture, output and video processing devices. It is curently mainly focused on video capture devices, with data busses defined by standards like ITU-R BT.656 or MIPI-CSI2. It also

[PATCH RFC v4 02/14] [media] Add a V4L2 OF parser

2013-01-23 Thread Sylwester Nawrocki
From: Guennadi Liakhovetski g.liakhovet...@gmx.de Add a V4L2 OF parser, implementing bindings documented in Documentation/devicetree/bindings/media/video-interfaces.txt. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de [s.nawro...@samsung.com: various corrections and improvements since

[PATCH RFC v3 03/14] s5p-csis: Add device tree support

2013-01-23 Thread Sylwester Nawrocki
s5p-csis is platform device driver for MIPI-CSI frontend to the FIMC device. This patch support for binding the driver to the MIPI-CSIS devices instantiated from device tree and for parsing all SoC and board specific properties. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com

[PATCH RFC v3 04/14] s5p-fimc: Add device tree support for FIMC devices

2013-01-23 Thread Sylwester Nawrocki
This patch adds support for FIMC devices instantiated from devicetree for S5PV210 and Exynos4 SoCs. The FIMC IP features include colorspace conversion and scaling (mem-to-mem) and parallel/MIPI CSI2 bus video capture interface. Multiple SoC revisions specific parameters are defined statically in

[PATCH RFC v3 05/14] s5p-fimc: Add device tree support for FIMC-LITE devices

2013-01-23 Thread Sylwester Nawrocki
This patch add support for binding the driver to FIMC-LITE devices instantiated from the device tree. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/media/soc/samsung-fimc.txt | 15 +

[PATCH RFC v3 06/14] s5p-fimc: Change platform subdevs registration method

2013-01-23 Thread Sylwester Nawrocki
The previous method of registering platform entities into the main driver using driver_find() and then iterating over devices bound to a driver was racy and is being removed here. Nothing was preventing module from unloading during a call to try_module_get(driver-owner). Instead, we look up a

[PATCH RFC v3 07/14] s5p-fimc: Add device tree support for the main media device driver

2013-01-23 Thread Sylwester Nawrocki
This patch adds changes required for the main camera media device driver to be initialized on systems instantiated from the device tree. The platform devices corresponding to child nodes of the 'camera' node are looked up and and registered as sub-devices to the common media device. The main

[PATCH RFC v3 08/14] s5p-fimc: Add device tree based sensors registration

2013-01-23 Thread Sylwester Nawrocki
The sensor (I2C and/or SPI client) devices are instantiated by their corresponding control bus drivers. Since the I2C client's master clock is often provided by a video bus receiver (host interface) or other than I2C/SPI controller device, the drivers of those client devices are not accessing

[PATCH RFC v3 10/14] ARM: dts: Add camera to node exynos4.dtsi

2013-01-23 Thread Sylwester Nawrocki
This patch adds common FIMC device nodes for all Exynos4 SoCs. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos4.dtsi | 64 1 file changed, 64 insertions(+)

[PATCH RFC v3 12/14] ARM: dts: Add FIMC and MIPI CSIS device nodes for Exynos4x12

2013-01-23 Thread Sylwester Nawrocki
Add common camera node and fimc nodes specific to Exynos4212 and Exynos4412 SoCs. fimc-is is a node for the Exynos4x12 FIMC-IS subsystem and fimc-lite nodes are created as its child nodes, among others due to FIMC-LITE device dependencies on FIMC-IS related clocks. Signed-off-by: Sylwester

[PATCH RFC v3 13/14] ARM: dts: Add camera pinctrl nodes for Exynos4x12 SoCs

2013-01-23 Thread Sylwester Nawrocki
Add separate nodes for the CAMCLK pin and turn off pull-up on camera ports A, B. The video bus pins and the clock output (CAMCLK) pin need separate nodes since full camera port is not used in some configurations, e.g. for MIPI CSI-2 bus on CAMCLK is required and data/clock signal use separate

[PATCH RFC v3 14/14] ARM: dts: Add camera device nodes nodes for PQ board

2013-01-23 Thread Sylwester Nawrocki
This patch adds all nodes for camera devices on an example Exynos4412 SoC based board. This is all what's required in the board dts file to enable rear facing camera (S5C73M3 sensor). The aliases node contains entries required for the camera processing data path entity drivers. The sensor nodes

Re: [PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-23 Thread Doug Anderson
Lars, On Wed, Jan 23, 2013 at 4:52 AM, Lars-Peter Clausen l...@metafoo.de wrote: Few doubts regarding the mappings and child device handling. Kindly, suggest me better methods. The patch looks mostly good now. As for the mappings, the problem is that we currently do not have any device tree

[PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-23 Thread Naveen Krishna Chatradhi
This patch adds driver for ADC IP found on EXYNOS5250 and EXYNOS5410 from Samsung. Also adds the Documentation for device tree bindings. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com --- Changes since v1: 1. Fixed comments from Lars 2. Added support for ADC on EXYNOS5410 Changes

[PATCH] iio: adc: add exynos5 adc driver under iio framwork

2013-01-23 Thread Naveen Krishna Chatradhi
This patch add an ADC IP found on EXYNOS5250 and EXYNOS5410 SoCs from Samsung. Also adds the Documentation for device tree bindings. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com --- Changes since v1: 1. Fixed comments from Lars 2. Added support for ADC on EXYNOS5410 Changes

[PATCH] ARM: DTS: exynos5250-arndale: Add initial board support file

2013-01-23 Thread Tushar Behera
From: Girish K S ks.g...@samsung.com Arndale is a low cost board based on the Samsung Exynos5250 SoC. This patch adds initial device tree support for this board. Signed-off-by: Girish K S ks.g...@samsung.com Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- arch/arm/boot/dts/Makefile

Re: [PATCH V6 01/10] ASoC: Samsung: Rename samsung i2s secondary device name

2013-01-23 Thread Mark Brown
On Fri, Jan 18, 2013 at 05:17:00PM +0530, Padmavathi Venna wrote: All Samsung SoCs has max 3 i2s controllers. So the i2s secondary fifo interface device id was named as samsung-i2s.4. Renaming this to samsung-i2s-sec to support device tree in i2s driver. Applied, thanks. signature.asc

Re: [PATCH] ARM: DTS: exynos5250-arndale: Add initial board support file

2013-01-23 Thread Alim Akhtar
Hi Tushar, On Thu, Jan 24, 2013 at 11:46 AM, Tushar Behera tushar.beh...@linaro.org wrote: From: Girish K S ks.g...@samsung.com Arndale is a low cost board based on the Samsung Exynos5250 SoC. This patch adds initial device tree support for this board. Signed-off-by: Girish K S

Re: [PATCH V2 0/4] i2c: s3c2410: Add devm_* apis and cleanup

2013-01-23 Thread Wolfram Sang
On Fri, Nov 23, 2012 at 02:11:51PM +0530, Tushar Behera wrote: This patchset cleans up the probe function of i2c-s3c2410 driver. These have been tested on Exynos4210 based Origen board. Changes since V1: * devm_request_mem_region and devm_ioremap calls were replaced by