[PATCH] spi/s3c64xx: Fix doubled clock disable on suspend

2013-10-21 Thread Krzysztof Kozlowski
Fix doubled clock disable and unprepare during PM suspend which triggered the warnings: WARNING: at drivers/clk/clk.c:800 clk_disable+0x18/0x24() Modules linked in: CPU: 0 PID: 1745 Comm: sh Not tainted 3.10.14-01211-ge2549bb-dirty #62 [] (unwind_backtrace+0x0/0x138) from [] (show_stack+0x10/0x14

Re: [PATCH 3/8] clk: max77686: Refactor successful exit of probe function

2013-10-21 Thread Sachin Kamat
Hi Tomasz, On 17 October 2013 22:00, Tomasz Figa wrote: > The function can simply return 0, without jumping to a separate label, > which does exactly the same. This patch does not introduce any > functional change, just a clean-up. > > Signed-off-by: Tomasz Figa > Signed-off-by: Kyungmin Park >

Re: [PATCH] spi/s3c64xx: Fix doubled clock disable on suspend

2013-10-21 Thread Sylwester Nawrocki
On 21/10/13 11:35, Krzysztof Kozlowski wrote: > Fix doubled clock disable and unprepare during PM suspend which triggered > the warnings: [...] > The clocks are already disabled before suspending. > > Additionally add PM runtime get() and put() during resume so device > won't sleep for the time of

Re: Arndale boot broken in -next

2013-10-21 Thread Tushar Behera
On 19 October 2013 22:05, Mark Brown wrote: > Hi, > > I've not yet had a chance to bisect this but it appears that Arndale > boot has broken for me recently in -next; I'm getting absolutely no > serial output at all afther the bootloader hands off to Linux so no > useful diagnostics. Is this a kn

Re: Arndale boot broken in -next

2013-10-21 Thread Tushar Behera
On 21 October 2013 15:50, Tushar Behera wrote: > On 19 October 2013 22:05, Mark Brown wrote: >> Hi, >> >> I've not yet had a chance to bisect this but it appears that Arndale >> boot has broken for me recently in -next; I'm getting absolutely no >> serial output at all afther the bootloader hands

Re: [PATCH] spi/s3c64xx: Fix doubled clock disable on suspend

2013-10-21 Thread Krzysztof Kozlowski
On Mon, 2013-10-21 at 11:42 +0200, Sylwester Nawrocki wrote: > pm_runtime_{get,put}* must not be called from drivers's system suspend/resume > callbacks. Please use pm_runtime_suspended() to check device runtime PM status > in s3c64xx_spi_{suspend,resume} callbacks and handle the clocks appropriate

Re: [PATCH V2] ARM: EXYNOS: Move arm core power down clock to exynos5250 common clock

2013-10-21 Thread Mike Turquette
Quoting Kukjin Kim (2013-10-20 14:34:29) > On 10/11/13 16:33, Tomasz Figa wrote: > > Hi Amit, > > > > On Friday 11 of October 2013 11:12:14 Amit Daniel Kachhap wrote: > >> Now with common clock support added for exynos5250 it is necessary to move > >> this code to exynos5250 common clock driver as

Re: [PATCH v2 6/8] clk: samsung: s3c64xx: Remove clock aliases of old DMA driver

2013-10-21 Thread Mike Turquette
Quoting Tomasz Figa (2013-10-16 12:10:57) > Since the old DMA driver got removed, these aliases are no longer > necessary. > > Signed-off-by: Tomasz Figa Acked-by: Mike Turquette > --- > drivers/clk/samsung/clk-s3c64xx.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/clk/s

Re: [PATCH v2 4/8] clk: samsung: s3c64xx: Add aliases for DMA clocks

2013-10-21 Thread Mike Turquette
Quoting Tomasz Figa (2013-10-16 12:10:55) > This patch adds clkdev aliases for clocks used by PL08x DMA driver. > > Signed-off-by: Tomasz Figa Acked-by: Mike Turquette > --- > drivers/clk/samsung/clk-s3c64xx.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/samsung/clk

Re: [PATCH v5 0/3] ARM: S5PV210: move to common clk framework

2013-10-21 Thread Mike Turquette
Quoting Kukjin Kim (2013-10-20 13:51:42) > On 10/20/13 01:03, Tomasz Figa wrote: > > Hi Mike, Kukjin, Rafael, > > > > On Tuesday 24 of September 2013 14:50:06 Mateusz Krawczuk wrote: > >> This patch series is the new s5pv210 clock implementation > >> (using common clk framework). > >> > >> This imp

Re: [PATCH v2 0/2] Add GPLL, APLL, KPLL, EPLL and VPLL freq table for exynos5420 and exynos5250

2013-10-21 Thread Vikas Sajjan
Hi Mike, On Thu, Aug 29, 2013 at 8:12 AM, Mike Turquette wrote: > Quoting Vikas Sajjan (2013-08-28 06:39:56) >> Adds GPLL, APLL, KPLL, EPLL and VPLL freq table for exynos5420 and >> exynos5250. >> >> changes since v1: >> - addressed comments from Tomasz Figa >> >> is rebased on Mike's >

[PATCH 1/2] spi/s3c64xx: Do not ignore return value of spi_master_resume/suspend

2013-10-21 Thread Krzysztof Kozlowski
During PM resume and suspend do not ignore the return value of spi_master_suspend() or spi_master_resume(). Instead pass it further. Signed-off-by: Krzysztof Kozlowski Signed-off-by: Kyungmin Park --- drivers/spi/spi-s3c64xx.c |8 1 file changed, 4 insertions(+), 4 deletions(-) di

[PATCH 2/2] spi/s3c64xx: Fix doubled clock disable on suspend

2013-10-21 Thread Krzysztof Kozlowski
Fix doubled clock disable and unprepare during PM suspend which triggered the warnings: WARNING: at drivers/clk/clk.c:800 clk_disable+0x18/0x24() Modules linked in: CPU: 0 PID: 1745 Comm: sh Not tainted 3.10.14-01211-ge2549bb-dirty #62 [] (unwind_backtrace+0x0/0x138) from [] (show_stack+0x10/0x14

Re: [PATCH 2/2] spi/s3c64xx: Fix doubled clock disable on suspend

2013-10-21 Thread Sylwester Nawrocki
On 21/10/13 15:42, Krzysztof Kozlowski wrote: > Fix doubled clock disable and unprepare during PM suspend which triggered > the warnings: > The clocks may be already disabled before suspending. Check PM runtime > suspend status and disable clocks only if device is not suspended. > During resume do

Re: [PATCH 1/2] spi/s3c64xx: Do not ignore return value of spi_master_resume/suspend

2013-10-21 Thread Sylwester Nawrocki
On 21/10/13 15:42, Krzysztof Kozlowski wrote: > During PM resume and suspend do not ignore the return value of > spi_master_suspend() or spi_master_resume(). Instead pass it further. > > Signed-off-by: Krzysztof Kozlowski > Signed-off-by: Kyungmin Park Reviewed-by: Sylwester Nawrocki -- To uns

[RFC 02/12] clk: exynos4: export sclk_hdmiphy clock

2013-10-21 Thread Tomasz Stanislawski
Export sclk_hdmiphy clock to be usable from DT. Signed-off-by: Tomasz Stanislawski --- .../devicetree/bindings/clock/exynos4-clock.txt|1 + drivers/clk/samsung/clk-exynos4.c |4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/devicet

[RFC 01/12] clk: propagate parent change up one level

2013-10-21 Thread Tomasz Stanislawski
This patch adds support for propagation of setup of clock's parent one level up. This feature is helpful when a driver changes topology of its clocks using clk_set_parent(). The problem occurs when on one platform/SoC driver's clock is located at MUX output but on the other platform/SoC there is

[RFC 00/12] Add DRM Exynos HDMI on SoCs from Exynos4 family

2013-10-21 Thread Tomasz Stanislawski
This patchset adds support for HDMI at SoCs from Exynos4 family. The patches are rebased on kishon/next. Additionally, The patchset contains small fixes to PHY and CLK frameworks. I preferred to keep all the patches together for the first version of the RFC. The interesting part might be 'propaga

[RFC 11/12] arm: dts: exynos4: add HDMI devices

2013-10-21 Thread Tomasz Stanislawski
This patch adds DT nodes for HDMI related devices on SoCs from Exynos4 family. Signed-off-by: Tomasz Stanislawski --- arch/arm/boot/dts/exynos4.dtsi| 27 +++ arch/arm/boot/dts/exynos4210.dtsi |4 2 files changed, 31 insertions(+) diff --git a/arch/arm/boot

[RFC 12/12] arm: dts: universal_c210: add HDMI devices

2013-10-21 Thread Tomasz Stanislawski
This patch adds configuration of HDMI devices on Universal C210 board. Signed-off-by: Tomasz Stanislawski --- arch/arm/boot/dts/exynos4210-universal_c210.dts | 53 +++ 1 file changed, 53 insertions(+) diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts b/arch/arm

[RFC 10/12] arm: dts: exynos4: add i2c controller for HDMIPHY

2013-10-21 Thread Tomasz Stanislawski
This patch adds DT nodes for I2C controller dedicated for HDMIPHY. Signed-off-by: Tomasz Stanislawski --- arch/arm/boot/dts/exynos4.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi index caadc02..a5f6b8b

[PATCH V4 5/6] USB: OHCI: Properly handle ohci-exynos suspend

2013-10-21 Thread Majunath Goudar
Suspend scenario in case of ohci-exynos glue was not properly handled as it was not suspending generic part of ohci controller. Alan Stern suggested, properly handle ohci-exynos suspend scenario. Calling explicitly the ohci_suspend() routine in exynos_ohci_suspend() will ensure proper handling of

[RFC 08/12] drm: exynos: hdmi: simplify extracting hpd-gpio from DT

2013-10-21 Thread Tomasz Stanislawski
This patch eliminates redundant checks while retrieving HPD gpio from DT during HDMI's probe(). Signed-off-by: Tomasz Stanislawski --- drivers/gpu/drm/exynos/exynos_hdmi.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/

[PATCH V4 3/6] USB: OHCI: Properly handle ohci-s3c2410 suspend

2013-10-21 Thread Majunath Goudar
Suspend scenario in case of ohci-s3c2410 glue was not properly handled as it was not suspending generic part of ohci controller. Alan Stern suggested, properly handle ohci-s3c2410 suspend scenario. Calling explicitly the ohci_suspend() routine in ohci_hcd_s3c2410_drv_suspend() will ensure proper h

[RFC 09/12] drm: exynos: add compatibles for HDMI and Mixer chips and exynos4210 SoC

2013-10-21 Thread Tomasz Stanislawski
This patch add proper compatibles for Mixer and HDMI chip available on exynos4210 SoCs. Signed-off-by: Tomasz Stanislawski --- drivers/gpu/drm/exynos/exynos_hdmi.c |3 +++ drivers/gpu/drm/exynos/exynos_mixer.c |3 +++ 2 files changed, 6 insertions(+) diff --git a/drivers/gpu/drm/exynos

[RFC 03/12] clk: exynos4: enable clk_set_parent() propagation for sclk_hdmi and sclk_mixer clocks

2013-10-21 Thread Tomasz Stanislawski
This patch enables clk_set_parent() propagation for clocks used by s5p-tv and exynos-drm drivers. Signed-off-by: Tomasz Stanislawski --- drivers/clk/samsung/clk-exynos4.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/clk/samsung/clk-exynos4.c b/drivers/clk

[RFC 06/12] Revert "drm/exynos: add mout_hdmi clock in hdmi driver to change parent"

2013-10-21 Thread Tomasz Stanislawski
This reverts commit 59956d35a8618235ea715280b49447bb36f2c975. --- drivers/gpu/drm/exynos/exynos_hdmi.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index a0e10ae..fcfa23a 100644 --

[RFC 04/12] phy: Add simple-phy driver

2013-10-21 Thread Tomasz Stanislawski
Add simple-phy driver to support a single register PHY interfaces present on Exynos4 SoC. Signed-off-by: Tomasz Stanislawski --- drivers/phy/Kconfig |5 ++ drivers/phy/Makefile |1 + drivers/phy/phy-simple.c | 128 ++ 3 files changed,

[RFC 07/12] drm: exynos: hdmi: use hdmiphy as PHY

2013-10-21 Thread Tomasz Stanislawski
The HDMIPHY (physical interface) is controlled by a single bit in a power controller's regiter. It was implemented as clock. It was a simple but effective hack. This patch makes HDMI driver to control HDMIPHY via PHY interface. Signed-off-by: Tomasz Stanislawski --- drivers/gpu/drm/exynos/exyno

[RFC 05/12] phy: use of_phy_simple_xlate for NULL xlate function

2013-10-21 Thread Tomasz Stanislawski
Use default handler of_phy_simple_xlate() when NULL is passed as argument to of_phy_provider_register(). Signed-off-by: Tomasz Stanislawski --- drivers/phy/phy-core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c index 03cf

Re: [PATCH v2] clk: exynos5420: fix cpll clock register offsets

2013-10-21 Thread Chander Kashyap
On 16 October 2013 11:10, Chander Kashyap wrote: > On 26 September 2013 14:36, Chander Kashyap > wrote: >> Fixes cpll control and lock register offset values for Exynos5420 SoC. >> >> Signed-off-by: Chander Kashyap >> Acked-by: Kukjin Kim >> --- >> Changes Since v1: >> - Fixed patch su