Re: [PATCH 1/2 v2] spi: s3c64xx: use cs-gpios from spi node instead of cs-gpio

2014-06-11 Thread Naveen Krishna Ch
Hello Doug, On 10 June 2014 23:56, Doug Anderson diand...@chromium.org wrote: Naveen, Not a full review, but a few quick things I happened to notice: On Tue, Jun 10, 2014 at 3:08 AM, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: @@ -94,7 +93,6 @@ Example:

Re: drm/exynos: consider deferred probe case

2014-06-11 Thread Inki Dae
Hello Dan, On 2014년 06월 10일 21:38, Dan Carpenter wrote: Hello Inki Dae, The patch df5225bc9a87: drm/exynos: consider deferred probe case from May 29, 2014, leads to the following static checker warning: drivers/gpu/drm/exynos/exynos_drm_fimd.c:996 fimd_probe() warn:

Re: [PATCH 1/2 v2] spi: s3c64xx: use cs-gpios from spi node instead of cs-gpio

2014-06-11 Thread Naveen Krishna Ch
Hello Tomasz, On 11 June 2014 01:19, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Naveen, On 10.06.2014 12:08, Naveen Krishna Chatradhi wrote: Currently, spi-s3c64xx.c needs cs-gpio chip select GPIO to be defined under controller-data node under each slave node. [snip] @@ -85,6 +83,7 @@

[PATCH 2/2 v3] ARM: DTS: move cs-gpio from controller-data to under spi node

2014-06-11 Thread Naveen Krishna Chatradhi
This patch moves the cs-gpio field from controller-data child node to under the spi device node. Respective changes are preposed to spi-s3c64xx.c driver. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com Acked-by: Rob Herring r...@kernel.org Cc: Javier Martinez Canillas

[patch] drm/exynos: change zero to NULL for sparse

2014-06-11 Thread Dan Carpenter
We recently changed this function to return a pointer instead of an int so we need to change this zero to a NULL or Sparse complains: drivers/gpu/drm/exynos/exynos_drm_drv.h:346:47: warning: Using plain integer as NULL pointer Signed-off-by: Dan Carpenter dan.carpen...@oracle.com

Re: [PATCH] Exynos4: cpuidle: support dual CPUs with AFTR state

2014-06-11 Thread Krzysztof Kozlowski
On pią, 2014-04-04 at 11:48 +0200, Daniel Lezcano wrote: The following driver is for exynos4210. I did not yet finished the other boards, so I created a specific driver for 4210 which could be merged later. The driver is based on Colin Cross's driver found at:

Re: [PATCH] ARM: EXYNOS: mcpm: Don't rely on firmware's secondary_cpu_start

2014-06-11 Thread Lorenzo Pieralisi
On Wed, Jun 11, 2014 at 05:52:10AM +0100, Chander Kashyap wrote: Hi Doug, On Tue, Jun 10, 2014 at 9:19 PM, Nicolas Pitre nicolas.pi...@linaro.org wrote: On Tue, 10 Jun 2014, Doug Anderson wrote: My S-state knowledge is not strong, but I believe that Lorenzo's questions matter if

Re: [PATCH 2/2 v3] ARM: DTS: move cs-gpio from controller-data to under spi node

2014-06-11 Thread Javier Martinez Canillas
Hello Naveen, On 06/11/2014 08:31 AM, Naveen Krishna Chatradhi wrote: This patch moves the cs-gpio field from controller-data child node to under the spi device node. Your patch looks good to me but I think that the commit message is inaccurate. It does not move the cs-gpio property to the

Re: [PATCH 2/2 v3] ARM: DTS: move cs-gpio from controller-data to under spi node

2014-06-11 Thread Naveen Krishna Ch
Hello Javier, On 11 June 2014 16:51, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Hello Naveen, On 06/11/2014 08:31 AM, Naveen Krishna Chatradhi wrote: This patch moves the cs-gpio field from controller-data child node to under the spi device node. Your patch looks good

Re: [PATCH 1/2 v3] spi: s3c64xx: use cs-gpios from spi node instead of cs-gpio

2014-06-11 Thread Naveen Krishna Ch
Hello Javier, On 11 June 2014 16:43, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Hello Naveen, Thanks a lot for your patches and sorry that I didn't review your prior two versions but I didn't have the time yesterday. On 06/11/2014 08:31 AM, Naveen Krishna Chatradhi

Re: [PATCH] ARM: EXYNOS: mcpm: Don't rely on firmware's secondary_cpu_start

2014-06-11 Thread Chander Kashyap
On Wed, Jun 11, 2014 at 3:43 PM, Lorenzo Pieralisi lorenzo.pieral...@arm.com wrote: On Wed, Jun 11, 2014 at 05:52:10AM +0100, Chander Kashyap wrote: Hi Doug, On Tue, Jun 10, 2014 at 9:19 PM, Nicolas Pitre nicolas.pi...@linaro.org wrote: On Tue, 10 Jun 2014, Doug Anderson wrote: My

Re: [PATCH 1/2 v2] spi: s3c64xx: use cs-gpios from spi node instead of cs-gpio

2014-06-11 Thread Sylwester Nawrocki
On 10/06/14 22:32, Rob Herring wrote: On Tue, Jun 10, 2014 at 1:09 PM, Doug Anderson diand...@chromium.org wrote: Naveen / Sylwester, On Tue, Jun 10, 2014 at 4:00 AM, Naveen Krishna Ch naveenkrishna...@gmail.com wrote: Can we support both cs-gpio and cs-gpios for backward compatibility ?

[PATCH] ARM: dts: use key code macros on exynos4 series boards

2014-06-11 Thread Beomho Seo
This patch use key code macros on exynos4 series boards. Using macros improve readability on device tree. Signed-off-by: Beomho Seo beomho@samsung.com --- arch/arm/boot/dts/exynos4.dtsi |1 + arch/arm/boot/dts/exynos4210-origen.dts |1 -

RE: [PATCH 1/2] ARM: exynos: cleanup kconfig option display

2014-06-11 Thread Kukjin Kim
Rob Herring wrote: From: Rob Herring r...@kernel.org The addition of Exynos to multi-platform configs creates a mess of config options with options appearing before the Exynos config option. This is due to arch/arm/plat-samsung/Kconfig being included out of order with the other Samsung

Re: [PATCH] ARM: EXYNOS: mcpm: Don't rely on firmware's secondary_cpu_start

2014-06-11 Thread Lorenzo Pieralisi
On Wed, Jun 11, 2014 at 01:14:21PM +0100, Chander Kashyap wrote: On Wed, Jun 11, 2014 at 3:43 PM, Lorenzo Pieralisi lorenzo.pieral...@arm.com wrote: On Wed, Jun 11, 2014 at 05:52:10AM +0100, Chander Kashyap wrote: Hi Doug, On Tue, Jun 10, 2014 at 9:19 PM, Nicolas Pitre

Re: [PATCH] ARM: EXYNOS: mcpm: Don't rely on firmware's secondary_cpu_start

2014-06-11 Thread Chander Kashyap
On 11 June 2014 18:45, Lorenzo Pieralisi lorenzo.pieral...@arm.com wrote: On Wed, Jun 11, 2014 at 01:14:21PM +0100, Chander Kashyap wrote: On Wed, Jun 11, 2014 at 3:43 PM, Lorenzo Pieralisi lorenzo.pieral...@arm.com wrote: On Wed, Jun 11, 2014 at 05:52:10AM +0100, Chander Kashyap wrote: Hi

Re: [PATCH] ARM: EXYNOS: mcpm: Don't rely on firmware's secondary_cpu_start

2014-06-11 Thread Abhilash Kesavan
Hi Lorenzo and Chander, On Wed, Jun 11, 2014 at 6:45 PM, Lorenzo Pieralisi lorenzo.pieral...@arm.com wrote: On Wed, Jun 11, 2014 at 01:14:21PM +0100, Chander Kashyap wrote: On Wed, Jun 11, 2014 at 3:43 PM, Lorenzo Pieralisi lorenzo.pieral...@arm.com wrote: On Wed, Jun 11, 2014 at 05:52:10AM

Re: [PATCH v3 5/7] mfd: cros_ec: Sync to the latest cros_ec_commands.h from EC sources

2014-06-11 Thread Doug Anderson
Paul, On Wed, Jun 11, 2014 at 3:37 AM, Paul Bolle pebo...@tiscali.nl wrote: On Tue, 2014-05-20 at 09:46 +0100, Lee Jones wrote: On Wed, 30 Apr 2014, Doug Anderson wrote: From: Bill Richardson wfric...@chromium.org This just updates include/linux/mfd/cros_ec_commands.h to match the

Re: [PATCH] ARM: Exynos : Fix build error with thumb2

2014-06-11 Thread Kukjin Kim
On 06/04/14 17:07, Santosh Shukla wrote: On 2 June 2014 15:40, Dave Martindave.mar...@arm.com wrote: On Mon, May 26, 2014 at 09:23:45PM +0530, Santosh Shukla wrote: From: santosh shuklasantosh.shu...@linaro.org Add non-global symbol .LLl2x0_regs_phys to avoid build break in thumb2 mode.

Re: [PATCH] ARM: EXYNOS: mcpm: Don't rely on firmware's secondary_cpu_start

2014-06-11 Thread Doug Anderson
Chander, On Tue, Jun 10, 2014 at 9:52 PM, Chander Kashyap k.chan...@samsung.com wrote: Hi Doug, On Tue, Jun 10, 2014 at 9:19 PM, Nicolas Pitre nicolas.pi...@linaro.org wrote: On Tue, 10 Jun 2014, Doug Anderson wrote: My S-state knowledge is not strong, but I believe that Lorenzo's

Re: [PATCH] ARM: EXYNOS: mcpm: Don't rely on firmware's secondary_cpu_start

2014-06-11 Thread Kukjin Kim
On 06/12/14 00:19, Doug Anderson wrote: Chander, On Tue, Jun 10, 2014 at 9:52 PM, Chander Kashyapk.chan...@samsung.com wrote: Hi Doug, On Tue, Jun 10, 2014 at 9:19 PM, Nicolas Pitrenicolas.pi...@linaro.org wrote: On Tue, 10 Jun 2014, Doug Anderson wrote: My S-state knowledge is not

[PATCH 0/5] Handle non-secure L2C initialization on Exynos4

2014-06-11 Thread Tomasz Figa
This series intends to add support for L2 cache on Exynos4 SoCs on boards running under secure firmware, which requires certain initialization steps to be done with help of firmware, as selected registers are writable only from secure mode. First three patches extend existing support for secure

[PATCH 3/5] ARM: mm: cache-l2x0: Use l2c_write_sec() for LATENCY_CTRL registers

2014-06-11 Thread Tomasz Figa
According to the documentation, TAG_LATENCY_CTRL and DATA_LATENCY_CTRL registers of L2C-310 can be written only in secure mode, so l2c_write_sec() should be used to change them, instead of plain writel_relaxed(). Signed-off-by: Tomasz Figa t.f...@samsung.com --- arch/arm/mm/cache-l2x0.c | 8

[PATCH 5/5] ARM: dts: exynos4: Add nodes for L2 cache controller

2014-06-11 Thread Tomasz Figa
This patch adds device tree nodes for L2 cache controller present on Exynos4 SoCs. Signed-off-by: Tomasz Figa t.f...@samsung.com --- arch/arm/boot/dts/exynos4210.dtsi | 9 + arch/arm/boot/dts/exynos4x12.dtsi | 9 + 2 files changed, 18 insertions(+) diff --git

[PATCH 4/5] ARM: EXYNOS: Add .write_sec outer cache callback for L2C-310

2014-06-11 Thread Tomasz Figa
Exynos4 SoCs equipped with an L2C-310 cache controller and running under secure firmware require certain registers of aforementioned IP to be accessed only from secure mode. This means that SMC calls are required for certain register writes. To handle this, an implementation of .write_sec callback

[PATCH 2/5] ARM: Get outer cache .write_sec callback from mach_desc only if not NULL

2014-06-11 Thread Tomasz Figa
Certain platforms (i.e. Exynos) might need to set .write_sec callback from firmware initialization which is happenning in .init_early callback of machine descriptor. However current code will overwrite the pointer with whatever is present in machine descriptor, even though it can be already set

[PATCH 1/5] ARM: mm: cache-l2x0: Add base address argument to write_sec callback

2014-06-11 Thread Tomasz Figa
For certain platforms (e.g. Exynos) it is necessary to read back some values from registers before they can be written (i.e. SMC calls that set multiple registers per call), so base address of L2C controller is needed for .write_sec operation. This patch adds base argument to .write_sec callback

Re: [PATCH v2 1/2] usb: ehci-exynos: Make provision for vdd regulators

2014-06-11 Thread Alan Stern
On Fri, 6 Jun 2014, Vivek Gautam wrote: Facilitate getting required 3.3V and 1.0V VDD supply for EHCI controller on Exynos. With patches for regulators' nodes merged in 3.15: c8c253f ARM: dts: Add regulator entries to smdk5420 275dcd2 ARM: dts: add max77686 pmic node for smdk5250,

Re: [PATCH] ARM: dts: exynos4: Fix reg sizes of GIC

2014-06-11 Thread Kukjin Kim
On 06/11/14 00:28, Tomasz Figa wrote: Hi Kukjin, Hi Tomasz, On 30.05.2014 20:18, Kukjin Kim wrote: On 05/30/14 20:41, Tomasz Figa wrote: Hi, On 23.05.2014 16:39, Tomasz Figa wrote: This patch fixes reg entry sizes in GIC node that were not large enough to cover whole regions.

Re: exynos5420-peach-pi: linux-next boot fails unless mau_epll left enabled?

2014-06-11 Thread Javier Martinez Canillas
Hello Tushar, On 06/11/2014 07:39 AM, Tushar Behera wrote: On 06/11/2014 01:56 AM, Doug Anderson wrote: Javier, On Tue, Jun 10, 2014 at 1:03 PM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Yes, I did not have this issue before. However... I installed the latest Peach

Re: [PATCH 1/5] ARM: mm: cache-l2x0: Add base address argument to write_sec callback

2014-06-11 Thread Jon Loeliger
diff --git a/arch/arm/include/asm/mach/arch.h b/arch/arm/include/asm/mach/arch.h index 060a75e..ddaebcd 100644 --- a/arch/arm/include/asm/mach/arch.h +++ b/arch/arm/include/asm/mach/arch.h @@ -46,7 +46,8 @@ struct machine_desc { enum reboot_modereboot_mode;/* default

Re: [PATCH 1/3] clk: exynos-audss: Keep the parent of mout_audss always enabled

2014-06-11 Thread Javier Martinez Canillas
On Wed, Jun 11, 2014 at 7:32 AM, Tushar Behera tusha...@samsung.com wrote: When the output clock of AUDSS mux is disabled, we are getting kernel oops while doing a clk_get() on other clocks provided by AUDSS. Though user manual doesn't specify this dependency, we came across this issue while

Re: [PATCH 1/3] clk: exynos-audss: Keep the parent of mout_audss always enabled

2014-06-11 Thread Mike Turquette
Quoting Tushar Behera (2014-06-10 22:32:17) When the output clock of AUDSS mux is disabled, we are getting kernel oops while doing a clk_get() on other clocks provided by AUDSS. Though user manual doesn't specify this dependency, we came across this issue while disabling the parent of AUDSS

Re: [PATCH 1/3] clk: exynos-audss: Keep the parent of mout_audss always enabled

2014-06-11 Thread Kevin Hilman
Tushar Behera tusha...@samsung.com writes: When the output clock of AUDSS mux is disabled, we are getting kernel oops while doing a clk_get() on other clocks provided by AUDSS. Though user manual doesn't specify this dependency, we came across this issue while disabling the parent of AUDSS

Re: [PATCH 1/2 v3] spi: s3c64xx: use cs-gpios from spi node instead of cs-gpio

2014-06-11 Thread Javier Martinez Canillas
Hello Naveen, On 06/11/2014 01:38 PM, Naveen Krishna Ch wrote: Hello Javier, On 11 June 2014 16:43, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Hello Naveen, Thanks a lot for your patches and sorry that I didn't review your prior two versions but I didn't have the

Re: [PATCH 1/3] clk: exynos-audss: Keep the parent of mout_audss always enabled

2014-06-11 Thread Tomasz Figa
Hi Tushar, On 11.06.2014 07:32, Tushar Behera wrote: When the output clock of AUDSS mux is disabled, we are getting kernel oops while doing a clk_get() on other clocks provided by AUDSS. Though user manual doesn't specify this dependency, we came across this issue while disabling the parent

Re: [PATCH 1/2 v3] spi: s3c64xx: use cs-gpios from spi node instead of cs-gpio

2014-06-11 Thread Tomasz Figa
On 11.06.2014 19:27, Javier Martinez Canillas wrote: On 06/11/2014 01:38 PM, Naveen Krishna Ch wrote: On 11 June 2014 16:43, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: On 06/11/2014 08:31 AM, Naveen Krishna Chatradhi wrote: [snip] return ERR_PTR(-EINVAL);

Re: [PATCH 1/2 v3] spi: s3c64xx: use cs-gpios from spi node instead of cs-gpio

2014-06-11 Thread Naveen Krishna Ch
Hello Tomasz, On 11 June 2014 23:20, Tomasz Figa tomasz.f...@gmail.com wrote: On 11.06.2014 19:27, Javier Martinez Canillas wrote: On 06/11/2014 01:38 PM, Naveen Krishna Ch wrote: On 11 June 2014 16:43, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: On 06/11/2014 08:31 AM,

Re: [PATCH 1/2 v3] spi: s3c64xx: use cs-gpios from spi node instead of cs-gpio

2014-06-11 Thread Mark Brown
On Wed, Jun 11, 2014 at 11:53:30PM +0530, Naveen Krishna Ch wrote: On 11 June 2014 23:20, Tomasz Figa tomasz.f...@gmail.com wrote: - in DT case, don't do anything in the driver about the GPIO chip select, because it will be handled automatically by the core. But, i see that

[PATCH V4 00/10] drm: exynos: few patches to enhance bridge chip support

2014-06-11 Thread Ajay Kumar
This series is based on exynos-drm-next branch of Inki Dae's tree at: git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git I have tested this after adding few DT changes for exynos5250-snow, exynos5420-peach-pit and exynos5800-peach-pi boards. This patchset also consolidates

Re: [PATCH 1/2 v3] spi: s3c64xx: use cs-gpios from spi node instead of cs-gpio

2014-06-11 Thread Tomasz Figa
On 11.06.2014 20:23, Naveen Krishna Ch wrote: Hello Tomasz, On 11 June 2014 23:20, Tomasz Figa tomasz.f...@gmail.com wrote: On 11.06.2014 19:27, Javier Martinez Canillas wrote: On 06/11/2014 01:38 PM, Naveen Krishna Ch wrote: On 11 June 2014 16:43, Javier Martinez Canillas

[PATCH V4 05/10] drm/bridge: add helper functions to support bridge chain

2014-06-11 Thread Ajay Kumar
Add helper functions to create bridge chain and to call the corresponding next_bridge functions. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com Suggested-by: Rob Clark robdcl...@gmail.com --- include/drm/drm_crtc.h | 72 1 file changed, 72

[PATCH V4 08/10] drm/exynos: dp: create bridge chain using ptn3460 and panel_binder

2014-06-11 Thread Ajay Kumar
exynos_dp supports a simple bridge chain with ptn3460 bridge and an LVDS panel attached to it. This patch creates the bridge chain with ptn3460 as the head of the list and panel_binder being the tail. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com --- drivers/gpu/drm/exynos/exynos_dp_core.c

[PATCH V4 04/10] drm/panel: Add driver for lvds/edp based panels

2014-06-11 Thread Ajay Kumar
This patch adds a simple driver to handle all the LCD and LED powerup/down routines needed to support eDP/LVDS panels. The LCD and LED units are usually powered up via regulators, and almost on all boards, we will have a BACKLIGHT_EN pin to enable/ disable the backlight. Sometimes, we can have

[PATCH V4 01/10] drm/exynos: Move DP setup out of hotplug workqueue

2014-06-11 Thread Ajay Kumar
Move the DP training and video enable from the hotplug handler into a seperate function and call the same during dpms ON. With existing code, DP HPD should be generated just few ms before calling enable_irq in dp_poweron. This patch removes that stringent time constraint. Signed-off-by: Ajay

[PATCH V4 10/10] drm/exynos: Add ps8622 lvds bridge discovery to DP driver

2014-06-11 Thread Ajay Kumar
From: Rahul Sharma rahul.sha...@samsung.com This patch adds ps8622 lvds bridge discovery code to the dp driver. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com Signed-off-by: Ajay Kumar ajaykumar...@samsung.com --- drivers/gpu/drm/exynos/exynos_dp_core.c |5 + 1 file changed, 5

[PATCH V4 07/10] drm/bridge: ptn3460: Support bridge chaining

2014-06-11 Thread Ajay Kumar
Modify the driver to invoke callbacks for the next bridge in the bridge chain. Also, remove the drm_connector implementation from ptn3460, since the same is implemented using panel_binder. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com --- drivers/gpu/drm/bridge/ptn3460.c| 136

Kernel panic or hang for Linaro Linux kernel 3.15 on arndale exynos5250

2014-06-11 Thread Li Wang
Hi, I am running lubuntu 14.04 with the latest Linaro kernel (git.linaro.org/kernel/linux-linaro-tracking) on arndale, I found once X is started ('xinit' is enough) , any one of the following operations will very easily cause kernel panic or hang, (1) Ctrl+Alt+F1 and Alt+F7 switch between

Re: [PATCH v2 1/2] usb: ehci-exynos: Make provision for vdd regulators

2014-06-11 Thread Jingoo Han
On Thursday, June 12, 2014 12:39 AM, Alan Stern wrote: On Fri, 6 Jun 2014, Vivek Gautam wrote: Facilitate getting required 3.3V and 1.0V VDD supply for EHCI controller on Exynos. With patches for regulators' nodes merged in 3.15: c8c253f ARM: dts: Add regulator entries to smdk5420