[PATCH 0/4] Arndale: Adding Sound Machine Driver for ALC5631 Codec

2014-10-27 Thread Krishna Mohan Dani
These patches add machine driver to instantiate I2S based realtek's ALC5631 based sound card on Arndale board. There are other variants of Audio Daughter Cards for Arndale Board for which support already exists but there is no support for Realtek's alc5631 codec based card hence support for

[PATCH 1/4] ASoC: ALC5631: Add device tree binding documentation

2014-10-27 Thread Krishna Mohan Dani
Document the device tree binding for the ALC5631 codec and update vendor specific prefix for the Realtek. Signed-off-by: Krishna Mohan Dani krishna...@samsung.com --- Documentation/devicetree/bindings/sound/rt5631.txt | 41 1 file changed, 41 insertions(+) create mode

[PATCH 4/4] Sound: DT: Adding Device Tree compatibility to Realtek's ALC5631 codec driver

2014-10-27 Thread Krishna Mohan Dani
Signed-off-by: Krishna Mohan Dani krishna...@samsung.com --- sound/soc/codecs/rt5631.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/sound/soc/codecs/rt5631.c b/sound/soc/codecs/rt5631.c index 1ba27db..d7c3f42 100644 --- a/sound/soc/codecs/rt5631.c +++

[PATCH 2/4] Sound: Samsung: Add sound card machine driver for Arndale Board

2014-10-27 Thread Krishna Mohan Dani
Adding machine driver to instantiate I2S based realtek's ALC5631 sound card on Arndale board. There are other variants of Audio Daughter Cards for Arndale Board for which support already exists but there is no support for Realtek's alc5631 codec hence support for ALC5631 based machine driver is

[PATCH 3/4] Sound: Kconfig: Adding the description of the codec

2014-10-27 Thread Krishna Mohan Dani
Signed-off-by: Krishna Mohan Dani krishna...@samsung.com --- sound/soc/codecs/Kconfig |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index a68d173..2d85887 100644 --- a/sound/soc/codecs/Kconfig +++

Re: [PATCH v2 10/10] usb: dwc2/gadget: rework suspend/resume code to correctly restore gadget state

2014-10-27 Thread Marek Szyprowski
Hello, On 2014-10-25 03:16, Paul Zimmerman wrote: From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] Sent: Monday, October 20, 2014 3:46 AM Suspend/resume code assumed that the gadget was always enabled and connected to usb bus. This means that the actual state of the gadget

[PATCH 1/1] ARM: exynos_defconfig: Enable max77802 rtc and clock drivers

2014-10-27 Thread Javier Martinez Canillas
Commit 6e80e3d87549 (ARM: exynos_defconfig: Enable MAX77802) enabled support for the max77802 regulators but the PMIC also has a Real-Time-Clock (RTC) and 2-channel 32kHz clock outputs. Enable the kernel config options to have the drivers for these devices built-in since they are present in many

[PATCH v4 0/3] regulator: max77686/trats2: Disable some regulators in suspend

2014-10-27 Thread Krzysztof Kozlowski
Hi, Changes since v3 1. Dropped patch 3/4 (mfd/regulator: dt-bindings: max77686: Document regulators off in suspend), applied by Lee Jones. 2. Patch 2/3: Fix missing shift when checking if current opmode is equal to off in suspend. The shift is various so I added a simple

[PATCH v4 3/3] ARM: dts: exynos4412-trats: Add suspend configuration for max77686 regulators

2014-10-27 Thread Krzysztof Kozlowski
Add suspend to RAM configuration for max77686 regulators. Some LDOs and bucks are disabled. This reduces energy consumption during S2R, approximately from 17 mA to 9 mA. Additionally remove old and not supported bindings: - regulator-mem-off - regulator-mem-idle - regulator-mem-on The max77686

[PATCH v4 2/3] regulator: max77686: Implement suspend disable for some LDOs

2014-10-27 Thread Krzysztof Kozlowski
Some LDOs of Maxim 77686 PMIC support disabling during system suspend (LDO{2,6,7,8,10,11,12,14,15,16}). This was already implemented as part of set_suspend_mode function. In that case the mode was one of: - disable, - normal mode, - low power mode. However there are no bindings for setting the

[PATCH v4 1/3] regulator: max77686: Replace hard-coded opmode values with defines

2014-10-27 Thread Krzysztof Kozlowski
Add defines for regulator operating modes which should be more readable, especially if one does not have Maxim 77686 datasheet. The patch does not introduce any functional change. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Suggested-by: Javier Martinez Canillas

Re: [PATCH v4 2/3] regulator: max77686: Implement suspend disable for some LDOs

2014-10-27 Thread Javier Martinez Canillas
Hello Krzysztof, On 10/27/2014 10:44 AM, Krzysztof Kozlowski wrote: Some LDOs of Maxim 77686 PMIC support disabling during system suspend (LDO{2,6,7,8,10,11,12,14,15,16}). This was already implemented as part of set_suspend_mode function. In that case the mode was one of: - disable, -

Re: [PATCH v4 2/3] regulator: max77686: Implement suspend disable for some LDOs

2014-10-27 Thread Krzysztof Kozlowski
On pon, 2014-10-27 at 11:08 +0100, Javier Martinez Canillas wrote: Hello Krzysztof, On 10/27/2014 10:44 AM, Krzysztof Kozlowski wrote: Some LDOs of Maxim 77686 PMIC support disabling during system suspend (LDO{2,6,7,8,10,11,12,14,15,16}). This was already implemented as part of

Re: [PATCH v4 2/3] regulator: max77686: Implement suspend disable for some LDOs

2014-10-27 Thread Javier Martinez Canillas
On 10/27/2014 11:27 AM, Krzysztof Kozlowski wrote: Storing opmode in non-shifted form is intuitive also to me. That's way I slipped the bug in previous version. Great. I'll change this to non-shifted opmode. The patch will grow bigger but the code should be more readable. Maybe split

Re: [PATCH v4 2/3] regulator: max77686: Implement suspend disable for some LDOs

2014-10-27 Thread Krzysztof Kozlowski
On pon, 2014-10-27 at 11:32 +0100, Javier Martinez Canillas wrote: On 10/27/2014 11:27 AM, Krzysztof Kozlowski wrote: Storing opmode in non-shifted form is intuitive also to me. That's way I slipped the bug in previous version. Great. I'll change this to non-shifted opmode. The

Re: [PATCHv3 0/2] clk: samsung: Add clock controller driver for Exynos4415 SoC

2014-10-27 Thread Sylwester Nawrocki
On 27/10/14 02:11, Chanwoo Choi wrote: Chanwoo Choi (2): clk: samsung: exynos4415: Add clocks using common clock framework clk: samsung: Document binding for Exynos4415 clock controller Added both to my tree, thanks. In future please put DT binding documentation first in the series, before

Re: [PATCHv3 0/2] clk: samsung: Add clock controller driver for Exynos4415 SoC

2014-10-27 Thread Chanwoo Choi
On 10/27/2014 07:39 PM, Sylwester Nawrocki wrote: On 27/10/14 02:11, Chanwoo Choi wrote: Chanwoo Choi (2): clk: samsung: exynos4415: Add clocks using common clock framework clk: samsung: Document binding for Exynos4415 clock controller Added both to my tree, thanks. In future please put

[PATCH v6 4/7] ARM: l2c: Add support for overriding prefetch settings

2014-10-27 Thread Marek Szyprowski
From: Tomasz Figa t.f...@samsung.com Firmware on certain boards (e.g. ODROID-U3) can leave incorrect L2C prefetch settings configured in registers leading to crashes if L2C is enabled without overriding them. This patch introduces bindings to enable prefetch settings to be specified from DT and

[PATCH v6 6/7] ARM: EXYNOS: Add support for non-secure L2X0 resume

2014-10-27 Thread Marek Szyprowski
From: Tomasz Figa t.f...@samsung.com On Exynos SoCs it is necessary to resume operation of L2C early in assembly code, because otherwise certain systems will crash. This patch adds necessary code to non-secure resume handler. Signed-off-by: Tomasz Figa t.f...@samsung.com [rewrote the code

[PATCH v6 5/7] ARM: EXYNOS: Add .write_sec outer cache callback for L2C-310

2014-10-27 Thread Marek Szyprowski
From: Tomasz Figa t.f...@samsung.com Exynos4 SoCs equipped with an L2C-310 cache controller and running under secure firmware require certain registers of aforementioned IP to be accessed only from secure mode. This means that SMC calls are required for certain register writes. To handle this, an

[PATCH v6 7/7] ARM: dts: exynos4: Add nodes for L2 cache controller

2014-10-27 Thread Marek Szyprowski
From: Tomasz Figa t.f...@samsung.com This patch adds device tree nodes for L2 cache controller present on Exynos4 SoCs. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com --- arch/arm/boot/dts/exynos4210.dtsi | 9 +

[PATCH v6 3/7] ARM: l2c: Get outer cache .write_sec callback from mach_desc only if not NULL

2014-10-27 Thread Marek Szyprowski
From: Tomasz Figa t.f...@samsung.com Certain platforms (i.e. Exynos) might need to set .write_sec callback from firmware initialization which is happenning in .init_early callback of machine descriptor. However current code will overwrite the pointer with whatever is present in machine

[PATCH v6 2/7] ARM: l2c: Add interface to ask hypervisor to configure L2C

2014-10-27 Thread Marek Szyprowski
From: Tomasz Figa t.f...@samsung.com Because certain secure hypervisor do not allow writes to individual L2C registers, but rather expect set of parameters to be passed as argument to secure monitor calls, there is a need to provide an interface for the L2C driver to ask the firmware to configure

[PATCH v6 1/7] ARM: l2c: Refactor the driver to use commit-like interface

2014-10-27 Thread Marek Szyprowski
From: Tomasz Figa t.f...@samsung.com Certain implementations of secure hypervisors (namely the one found on Samsung Exynos-based boards) do not provide access to individual L2C registers. This makes the .write_sec()-based interface insufficient and provoking ugly hacks. This patch is first step

[PATCH v6 0/7] Enable L2 cache support on Exynos4210/4x12 SoCs

2014-10-27 Thread Marek Szyprowski
This is an updated patchset, which intends to add support for L2 cache on Exynos4 SoCs on boards running under secure firmware, which requires certain initialization steps to be done with help of firmware, as selected registers are writable only from secure mode. First four patches extend

Re: [PATCH v6 4/7] ARM: l2c: Add support for overriding prefetch settings

2014-10-27 Thread Russell King - ARM Linux
On Mon, Oct 27, 2014 at 12:05:47PM +0100, Marek Szyprowski wrote: From: Tomasz Figa t.f...@samsung.com Firmware on certain boards (e.g. ODROID-U3) can leave incorrect L2C prefetch settings configured in registers leading to crashes if L2C is enabled without overriding them. This patch

Re: [PATCH v6 4/7] ARM: l2c: Add support for overriding prefetch settings

2014-10-27 Thread Marek Szyprowski
Hello, On 2014-10-27 12:14, Russell King - ARM Linux wrote: On Mon, Oct 27, 2014 at 12:05:47PM +0100, Marek Szyprowski wrote: From: Tomasz Figa t.f...@samsung.com Firmware on certain boards (e.g. ODROID-U3) can leave incorrect L2C prefetch settings configured in registers leading to crashes

[PATCH v5 3/4] regulator: max77686: Add suspend disable for some LDOs

2014-10-27 Thread Krzysztof Kozlowski
Some LDOs of Maxim 77686 PMIC support disabling during system suspend (LDO{2,6,7,8,10,11,12,14,15,16}). This was already implemented as part of set_suspend_mode function. In that case the mode was one of: - disable, - normal mode, - low power mode. However there are no bindings for setting the

[PATCH v5 4/4] ARM: dts: exynos4412-trats: Add suspend configuration for max77686 regulators

2014-10-27 Thread Krzysztof Kozlowski
Add suspend to RAM configuration for max77686 regulators. Some LDOs and bucks are disabled. This reduces energy consumption during S2R, approximately from 17 mA to 9 mA. Additionally remove old and not supported bindings: - regulator-mem-off - regulator-mem-idle - regulator-mem-on The max77686

[PATCH v5 0/4] regulator: max77686/trats2: Disable some regulators in suspend

2014-10-27 Thread Krzysztof Kozlowski
Hi, Changes since v4 1. New patch: 2/4. Store the current value of opmode in non-shifted form. Along with changes in defines used for opmodes this simplifies everything a lot. Suggested by Javier. 2. Drop Javier's review-by from patch 1 because I changed the defines to

[PATCH v5 1/4] regulator: max77686: Replace hard-coded opmode values with defines

2014-10-27 Thread Krzysztof Kozlowski
Add defines for regulator operating modes which should be more readable, especially if one does not have Maxim 77686 datasheet. The patch does not introduce any functional change. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Suggested-by: Javier Martinez Canillas

[PATCH v5 2/4] regulator: max77686: Store opmode non-shifted

2014-10-27 Thread Krzysztof Kozlowski
Introduce simple helper for calculating the shift for OPMODE field in registers. This allows storing the current value of opmode in non-shifted form and simplifies a little set_suspend_disable and enable functions. Additionally this will allow adding support LDOs to the existing

Re: [PATCH v5 2/4] regulator: max77686: Store opmode non-shifted

2014-10-27 Thread Javier Martinez Canillas
Hello Krzysztof, On 10/27/2014 01:11 PM, Krzysztof Kozlowski wrote: Introduce simple helper for calculating the shift for OPMODE field in registers. This allows storing the current value of opmode in non-shifted form and simplifies a little set_suspend_disable and enable functions.

Re: [PATCH v5 3/4] regulator: max77686: Add suspend disable for some LDOs

2014-10-27 Thread Javier Martinez Canillas
Hello Krzysztof, On 10/27/2014 01:11 PM, Krzysztof Kozlowski wrote: Some LDOs of Maxim 77686 PMIC support disabling during system suspend (LDO{2,6,7,8,10,11,12,14,15,16}). This was already implemented as part of set_suspend_mode function. In that case the mode was one of: - disable, -

Re: [PATCH v5 2/4] regulator: max77686: Store opmode non-shifted

2014-10-27 Thread Krzysztof Kozlowski
On pon, 2014-10-27 at 14:37 +0100, Javier Martinez Canillas wrote: Hello Krzysztof, On 10/27/2014 01:11 PM, Krzysztof Kozlowski wrote: Introduce simple helper for calculating the shift for OPMODE field in registers. This allows storing the current value of opmode in non-shifted form and

Re: [PATCH v2 06/10] usb: dwc2/gadget: decouple setting soft-disconnect from s3c_hsotg_core_init

2014-10-27 Thread Marek Szyprowski
Hello, On 2014-10-25 02:35, Paul Zimmerman wrote: From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] Sent: Monday, October 20, 2014 3:46 AM This patch changes s3c_hsotg_core_init function to leave hardware in soft disconnect mode, so the moment of coupling the hardware to the usb bus can

[PATCH] ARM: dts: exynos4412-trats: Add micro SD card SDHCI node

2014-10-27 Thread Krzysztof Kozlowski
Add SDHCI node for supporting the micro SD card. On Trats2 board the SDHCI does not use sd2_cd pins (gpk2-2) for card detect but gpx3-4 instead. Power is supplied from LDO21 regulator which in off state is controlled by external GPIO pin. Signed-off-by: Krzysztof Kozlowski

[PATCH v2] ARM: dts: exynos4412-trats: Add micro SD card SDHCI node

2014-10-27 Thread Krzysztof Kozlowski
Add SDHCI node for supporting the micro SD card. On Trats2 board the SDHCI does not use sd2_cd pins (gpk2-2) for card detect but gpx3-4 instead. Power is supplied from LDO21 regulator which in off state is controlled by external GPIO pin. Signed-off-by: Krzysztof Kozlowski

[PATCH 0/8] regulator: max77686: Add GPIO control

2014-10-27 Thread Krzysztof Kozlowski
Hi, This patch helps in proper description of max77686 regulators in DTS by allowing to control them over GPIO. This allows removal of fixed regulators from DTS which duplicate the description of hardware. The first five patches are cleanups, including board support removal. The whole patchset

[PATCH 8/8] ARM: dts: exynos4412-trats: Switch max77686 regulators to GPIO control

2014-10-27 Thread Krzysztof Kozlowski
Remove fixed regulators (duplicating what max77686 provides) and add GPIO control to max77686 regulators. This gives the system full control over those regulators. Previously the state of such regulators was a mixture of what max77686 driver set over I2C and what regulator-fixed set through GPIO.

[PATCH 3/8] mfd: max77686/802: Remove support for board files

2014-10-27 Thread Krzysztof Kozlowski
The driver is used only on Exynos based boards with DTS support. Convert the driver to DTS-only version. This simplifies a little the code: 1. No dead (unused) entries in platform_data structure. 2. More code removed (from all three patches: 34 insertions(+), 107 deletions). 3. Regulator driver

[PATCH 2/8] regulator: max77686: Remove support for board files

2014-10-27 Thread Krzysztof Kozlowski
The driver is used only on Exynos4 based boards with DTS support. Convert the driver to DTS-only version. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/regulator/max77686.c | 51 +--- 1 file changed, 19 insertions(+), 32

[PATCH 4/8] regulator: max77686: Make regulator_desc array const

2014-10-27 Thread Krzysztof Kozlowski
The regulator_register() expects array of 'regulator_desc' to be const. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/regulator/max77686.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/max77686.c b/drivers/regulator/max77686.c

[PATCH 1/8] regulator: max77802: Remove support for board files

2014-10-27 Thread Krzysztof Kozlowski
The driver is used only on Exynos based boards with DTS support. Convert the driver to DTS-only version. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/regulator/max77802.c | 44 +++- 1 file changed, 15 insertions(+), 29

[PATCH 7/8] mfd/regulator: dt-bindings: max77686: Document gpio property

2014-10-27 Thread Krzysztof Kozlowski
Document usage of gpio property which turns on external control over regulator. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- Documentation/devicetree/bindings/mfd/max77686.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH 5/8] regulator: max77686: Initialize opmode explicitly to normal mode

2014-10-27 Thread Krzysztof Kozlowski
Minor nit: Initialize the opmode for each regulator to normal mode in a readable explicit way. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Suggested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- drivers/regulator/max77686.c | 4 ++-- 1 file changed, 2

[PATCH 6/8] regulator: max77686: Add external GPIO control

2014-10-27 Thread Krzysztof Kozlowski
Add control over GPIO for regulators supporting this: LDO20, LDO21, LDO22, buck8 and buck9. This is needed for proper (and full) configuration of the Maxim 77686 PMIC without creating redundant 'regulator-fixed' entries. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com ---

[PATCH v3 35/47] arm: Register with kernel power-off handler

2014-10-27 Thread Guenter Roeck
Register with kernel power-off handler instead of setting pm_power_off directly. Always use register_power_off_handler_simple as there is no indication that more than one power-off handler is registered. If the power-off handler only resets the system or puts the CPU in sleep mode, select the

Re: [PATCH v2 3/7] clk: samsung: exynos7: add clocks for RTC block

2014-10-27 Thread Sylwester Nawrocki
Hi, On 21/10/14 07:43, Abhilash Kesavan wrote: From: Naveen Krishna Ch naveenkrishna...@gmail.com Add clock support for the RTC block in Exynos7. Signed-off-by: Naveen Krishna Ch naveenkrishna...@gmail.com Signed-off-by: Abhilash Kesavan a.kesa...@samsung.com ---

Re: [PATCH v5 0/8] arch: arm64: Enable support for Samsung Exynos7 SoC

2014-10-27 Thread Sylwester Nawrocki
Hi Abhilash, On 24/10/14 16:32, Abhilash Kesavan wrote: On Wed, Oct 8, 2014 at 11:18 AM, Abhilash Kesavan kesavan.abhil...@gmail.com wrote: On Tue, Oct 7, 2014 at 9:46 AM, Kukjin Kim kg...@kernel.org wrote: Tomasz Figa wrote: On 30.09.2014 17:12, Abhilash Kesavan wrote: On Mon, Sep 22, 2014

Re: [PATCH V7 03/12] drm/bridge: Add helper functions for drm_bridge

2014-10-27 Thread Daniel Vetter
So don't ask why but I accidentally ended up in a branch looking at this patch and didn't like it. So very quickgrumpy review. First, please make the patch subject more descriptive: I'd expect a helper function scaffolding like the various crtc/probe/dp ... helpers we already have. You instead

Re: exynos5422-odroid-xu3: MCPM: only 6 of 8 CPUs coming online

2014-10-27 Thread Kevin Hilman
Mauro Ribeiro mdr...@gmail.com writes: As I wrote you previously outside the list this is the commit ARM: EXYNOS: SWRESET is needed to boot secondary CPU on exynos3250 that I was expecting it to fix XU3 as well and apparently it is.. I'm not sure about that, since I haven't been able to get

Re: [PATCH 1/8] regulator: max77802: Remove support for board files

2014-10-27 Thread Javier Martinez Canillas
Hello Krzysztof, On 10/27/2014 04:03 PM, Krzysztof Kozlowski wrote: The driver is used only on Exynos based boards with DTS support. Convert the driver to DTS-only version. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/regulator/max77802.c | 44

Re: [PATCH 2/8] regulator: max77686: Remove support for board files

2014-10-27 Thread Javier Martinez Canillas
Hello Krzysztof, On 10/27/2014 04:03 PM, Krzysztof Kozlowski wrote: The driver is used only on Exynos4 based boards with DTS support. Convert the driver to DTS-only version. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/regulator/max77686.c | 51

Re: [PATCH 3/8] mfd: max77686/802: Remove support for board files

2014-10-27 Thread Javier Martinez Canillas
Hello Krzysztof, On 10/27/2014 04:03 PM, Krzysztof Kozlowski wrote: The driver is used only on Exynos based boards with DTS support. Convert the driver to DTS-only version. This simplifies a little the code: 1. No dead (unused) entries in platform_data structure. 2. More code removed (from

Re: [PATCH 4/8] regulator: max77686: Make regulator_desc array const

2014-10-27 Thread Javier Martinez Canillas
Hello Krzysztof, On 10/27/2014 04:03 PM, Krzysztof Kozlowski wrote: The regulator_register() expects array of 'regulator_desc' to be const. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/regulator/max77686.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH V7 02/12] drm/bridge: do not pass drm_bridge_funcs to drm_bridge_init

2014-10-27 Thread Sean Paul
On Wed, Aug 27, 2014 at 10:29 AM, Ajay Kumar ajaykumar...@samsung.com wrote: Assign the pointer to bridge ops structure(drm_bridge_funcs) in the bridge driver itself, instead of passing it to drm_bridge_init. This will allow bridge driver developer to pack bridge private information inside

Re: [PATCH 5/8] regulator: max77686: Initialize opmode explicitly to normal mode

2014-10-27 Thread Javier Martinez Canillas
Hello Krzysztof, On 10/27/2014 04:03 PM, Krzysztof Kozlowski wrote: Minor nit: Initialize the opmode for each regulator to normal mode in a readable explicit way. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Suggested-by: Javier Martinez Canillas

Re: [PATCH V7 03/12] drm/bridge: Add helper functions for drm_bridge

2014-10-27 Thread Sean Paul
On Mon, Oct 27, 2014 at 3:01 PM, Daniel Vetter dan...@ffwll.ch wrote: So don't ask why but I accidentally ended up in a branch looking at this patch and didn't like it. So very quickgrumpy review. First, please make the patch subject more descriptive: I'd expect a helper function scaffolding

Re: [PATCH 6/8] regulator: max77686: Add external GPIO control

2014-10-27 Thread Javier Martinez Canillas
Hello Krzysztof, On 10/27/2014 04:03 PM, Krzysztof Kozlowski wrote: @@ -85,6 +91,9 @@ struct max77686_data { struct max77686_regulator_data *regulators; int num_regulators; + /* Array of size num_regulators with GPIOs for external control. */ + int *ext_control_gpio;

Re: [PATCH V7 03/12] drm/bridge: Add helper functions for drm_bridge

2014-10-27 Thread Sean Paul
On Wed, Aug 27, 2014 at 10:29 AM, Ajay Kumar ajaykumar...@samsung.com wrote: A set of helper functions are defined in this patch to make bridge driver probe independent of the drm flow. The bridge devices register themselves on a lookup table when they get probed by calling drm_bridge_add.

Re: [PATCH 7/8] mfd/regulator: dt-bindings: max77686: Document gpio property

2014-10-27 Thread Javier Martinez Canillas
Hello Krzysztof, On 10/27/2014 04:03 PM, Krzysztof Kozlowski wrote: Document usage of gpio property which turns on external control over regulator. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- Documentation/devicetree/bindings/mfd/max77686.txt | 3 +++ 1 file changed, 3

Re: PROBLEM: BUG appearing when trying to allocate interrupt on Exynos MCT after CPU hotplug

2014-10-27 Thread Stephen Boyd
On 10/24/2014 06:22 AM, Marcin Jabrzyk wrote: On 23/10/14 20:41, Stephen Boyd wrote: On 10/23/2014 07:06 AM, Russell King - ARM Linux wrote: The CPU notifier is called via notify_cpu_starting(), which is called with interrupts disabled, and a reason code of CPU_STARTING. Interrupts at

Re: [PATCH V7 03/12] drm/bridge: Add helper functions for drm_bridge

2014-10-27 Thread Daniel Vetter
On Mon, Oct 27, 2014 at 8:58 PM, Sean Paul seanp...@chromium.org wrote: @@ -660,8 +662,11 @@ struct drm_bridge_funcs { * @driver_private: pointer to the bridge driver's internal context */ struct drm_bridge { - struct drm_device *dev; + struct device *dev; Please don't rename

Re: [PATCH V7 03/12] drm/bridge: Add helper functions for drm_bridge

2014-10-27 Thread Daniel Vetter
On Mon, Oct 27, 2014 at 11:20 PM, Daniel Vetter dan...@ffwll.ch wrote: On Mon, Oct 27, 2014 at 8:58 PM, Sean Paul seanp...@chromium.org wrote: @@ -660,8 +662,11 @@ struct drm_bridge_funcs { * @driver_private: pointer to the bridge driver's internal context */ struct drm_bridge { -

Re: [PATCHv4 0/3] ARM: dts: Add new board dts file for Exynos3250-based Rinato board

2014-10-27 Thread Chanwoo Choi
Dear Kukjin, Did you please pick up this patchset on 3.19 queue? Best Regards, Chanwoo Choi On 10/24/2014 10:12 PM, Chanwoo Choi wrote: This patchset adds new board dts file for Samsung Rinato board (Gear 2) which is based on Exynos3250 SoC and adds sleep mode pin configuration using pinctrl

Re: [PATCH V7 03/12] drm/bridge: Add helper functions for drm_bridge

2014-10-27 Thread Russell King - ARM Linux
On Mon, Oct 27, 2014 at 11:26:30PM +0100, Daniel Vetter wrote: Looking at the of_drm_find_panel function I actually wonder how that works - the drm_panel doesn't really need to stick around afaics. After all panel_list is global so some other driver can unload. Russell's of support for

RE: [PATCHv4 0/3] ARM: dts: Add new board dts file for Exynos3250-based Rinato board

2014-10-27 Thread Kukjin Kim
Chanwoo Choi wrote: Dear Kukjin, Hi, Did you please pick up this patchset on 3.19 queue? I'll apply this series once my previous pull-request which has been sent out last week is merged into arm-soc tree. If any comments on this series, I'll let you know. Thanks, Kukjin Best Regards,

Re: [PATCHv4 0/3] ARM: dts: Add new board dts file for Exynos3250-based Rinato board

2014-10-27 Thread Chanwoo Choi
Dear Kukjin, On 10/28/2014 09:19 AM, Kukjin Kim wrote: Chanwoo Choi wrote: Dear Kukjin, Hi, Did you please pick up this patchset on 3.19 queue? I'll apply this series once my previous pull-request which has been sent out last week is merged into arm-soc tree. If any comments on this

Re: [PATCH 2/8] regulator: max77686: Remove support for board files

2014-10-27 Thread Mark Brown
On Mon, Oct 27, 2014 at 04:03:40PM +0100, Krzysztof Kozlowski wrote: The driver is used only on Exynos4 based boards with DTS support. Convert the driver to DTS-only version. This doesn't seem like a particularly persuasive reason honestly and if you're going to mess around with this stuff

Re: [PATCH 4/8] regulator: max77686: Make regulator_desc array const

2014-10-27 Thread Mark Brown
On Mon, Oct 27, 2014 at 04:03:42PM +0100, Krzysztof Kozlowski wrote: The regulator_register() expects array of 'regulator_desc' to be const. Applied, thanks. signature.asc Description: Digital signature

[GIT PULL 2/3 v2] 1st Round of Samsung PM updates for v3.19

2014-10-27 Thread Kukjin Kim
Hi, I'm sending new pull-request for tags/samsung-pm-v2 instead of tags/samsung-pm. Note that just added fix build with ARM_CPU_SUSPEND=n from Arnd, please pull. Thanks, Kukjin The following changes since commit f114040e3ea6e07372334ade75d1ee0775c355e1: Linux 3.18-rc1

Re: [PATCHv2 1/2] ARM: EXYNOS: Add EXYNOS4415 SoC ID

2014-10-27 Thread Chanwoo Choi
Dear Kukjin, On 10/28/2014 12:48 PM, Kukjin Kim wrote: Chanwoo Choi wrote: This patch add Exynos4415's SoC ID. Since the CPU ID has been removed as per comments, need to update the commit message accordingly. OK, I'll update it. Exynos4415 is based on the 32-bit RISC processor for

RE: [PATCHv3 0/2] clk: samsung: Add clock controller driver for Exynos4415 SoC

2014-10-27 Thread Kukjin Kim
Sylwester Nawrocki wrote: On 27/10/14 02:11, Chanwoo Choi wrote: Chanwoo Choi (2): clk: samsung: exynos4415: Add clocks using common clock framework clk: samsung: Document binding for Exynos4415 clock controller Added both to my tree, thanks. In future please put DT binding

RE: [PATCHv2 1/2] ARM: EXYNOS: Add EXYNOS4415 SoC ID

2014-10-27 Thread Kukjin Kim
Chanwoo Choi wrote: Dear Kukjin, [...] +config SOC_EXYNOS4415 + bool SAMSUNG EXYNOS4415 + default y + depends on ARCH_EXYNOS4 + I think, this is not required more... But, The clock driver must need to CONFIG_SOC_EXYNOS4415 configuration to build it. The clock

[PATCHv3 0/2] ARM: EXYNOS: Support new Exynos4415 SoC based on Cortex-A9 quad cores

2014-10-27 Thread Chanwoo Choi
This patchset support new Exynos4415 Samsung SoC based on Cortex-A9 quad cores. Exynos4415 is a System-On-Chip (SoC) that is based on 32-bit RISC processor for Smartphone. It is desigend with the 28nm low-power high-K metal gate process and provides the best performance features. This patchset

[PATCHv3 1/2] ARM: EXYNOS: Add EXYNOS4415 SoC

2014-10-27 Thread Chanwoo Choi
This patch add Exynos4415's SoC. Exynos4415 is based on the 32-bit RISC processor for Smartphone. Exynos4415 uses Cortex A9 quad-cores and has a target speed of 1.6GHz and provides 8.5GB/s memory bandwidth. Cc: Kukjin Kim kgene@samsung.com Signed-off-by: Chanwoo Choi cw00.c...@samsung.com

[PATCHv3 2/2] ARM: dts: Add dts files for Exynos4415 SoC

2014-10-27 Thread Chanwoo Choi
This patch adds new exynos4415.dtsi to support Exynos4415 SoC based on Cortex-A9 quad cores and includes following dt nodes: - GIC interrupt controller (GIC-400) - Pinctrl to control three GPIO parts - CMU (Clock Management Unit) for CMU/CMU_DMC/AUDSS - CPU information (Cortex-A9 quad cores) -