Re: [PATCH v2 01/10] usb: dwc2/gadget: report disconnect event from 'end session' irq

2014-10-31 Thread Marek Szyprowski
Hello, On 2014-10-25 03:23, Paul Zimmerman wrote: From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] Sent: Monday, October 20, 2014 3:46 AM This patch adds a call to s3c_hsotg_disconnect() from 'end session' interrupt (GOTGINT_SES_END_DET) to correctly notify gadget subsystem about

Re: [PATCH 6/8] regulator: max77686: Add external GPIO control

2014-10-31 Thread Krzysztof Kozlowski
On pią, 2014-10-31 at 12:31 +0900, Alexandre Courbot wrote: On Fri, Oct 31, 2014 at 12:03 AM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: On czw, 2014-10-30 at 22:56 +0900, Alexandre Courbot wrote: Hi, and thanks for bringing this issue to us! On Wed, Oct 29, 2014 at 7:49 PM,

[PATCH v3] usb: dwc2/gadget: report disconnect event from 'end session' irq

2014-10-31 Thread Marek Szyprowski
This patch adds a call to s3c_hsotg_disconnect() from 'end session' interrupt (GOTGINT_SES_END_DET) to correctly notify gadget subsystem about unplugged usb cable. 'disconnected' interrupt (DISCONNINT) might look a bit more suitable for this event, but it is asserted only in host mode, so in

Re: [PATCH v3 0/9] PM / Domains: Fix race conditions during boot

2014-10-31 Thread Ulf Hansson
On 24 October 2014 18:12, Kevin Hilman khil...@kernel.org wrote: Ulf Hansson ulf.hans...@linaro.org writes: Changes in v3: -Rework the entire intermediate step which was suggested in v2. That means solving the race condition, but also cope with PM domains that are

Re: [PATCH v3 4/9] drivercore / platform: Keep PM domain powered during -probe()

2014-10-31 Thread Ulf Hansson
On 30 October 2014 21:47, Kevin Hilman khil...@kernel.org wrote: Ulf Hansson ulf.hans...@linaro.org writes: To sucessfully probe some devices their corresponding PM domains may need to be powered. Isn't that what pm_runtime_get*() is supposed to be doing? Why isn't that working? Let stay

Re: [PATCH v3 4/9] drivercore / platform: Keep PM domain powered during -probe()

2014-10-31 Thread Ulf Hansson
On 31 October 2014 01:07, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Thu, Oct 30, 2014 at 01:47:27PM -0700, Kevin Hilman wrote: Ulf Hansson ulf.hans...@linaro.org writes: To sucessfully probe some devices their corresponding PM domains may need to be powered. Isn't that what

Re: [PATCHv3 0/2] clk: samsung: Add clock controller driver for Exynos4415 SoC

2014-10-31 Thread Sylwester Nawrocki
On 28/10/14 05:09, Kukjin Kim wrote: Sylwester Nawrocki wrote: On 27/10/14 02:11, Chanwoo Choi wrote: Chanwoo Choi (2): clk: samsung: exynos4415: Add clocks using common clock framework clk: samsung: Document binding for Exynos4415 clock controller [...] Can you please provide a topic

Re: [PATCH v2 10/10] usb: dwc2/gadget: rework suspend/resume code to correctly restore gadget state

2014-10-31 Thread Marek Szyprowski
Hello, On 2014-10-27 08:18, Marek Szyprowski wrote: On 2014-10-25 03:16, Paul Zimmerman wrote: From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] Sent: Monday, October 20, 2014 3:46 AM Suspend/resume code assumed that the gadget was always enabled and connected to usb bus. This means

[PATCH v3 1/2] usb: dwc2/gadget: add mutex to serialize init/deinit calls

2014-10-31 Thread Marek Szyprowski
This patch adds mutex, which protects initialization and deinitialization procedures against suspend/resume methods. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com --- drivers/usb/dwc2/core.h | 1 + drivers/usb/dwc2/gadget.c | 20 2 files changed, 21

[PATCH v3 2/2] usb: dwc2/gadget: rework suspend/resume code to correctly restore gadget state

2014-10-31 Thread Marek Szyprowski
Suspend/resume code assumed that the gadget was always enabled and connected to usb bus. This means that the actual state of the gadget (soft-enabled/disabled or connected/disconnected) was not correctly preserved on suspend/resume cycle. This patch fixes this issue. Signed-off-by: Marek

Re: [PATCH 6/8] regulator: max77686: Add external GPIO control

2014-10-31 Thread Mark Brown
On Fri, Oct 31, 2014 at 08:51:38AM +0100, Krzysztof Kozlowski wrote: However new DT style parsing (regulator_of_get_init_data()) does the basic parsing stuff and this removes a lot of code from driver. The driver no longer parses all regulaotrs but the regulator core does it. Unfortunately

Re: [PATCH 6/8] regulator: max77686: Add external GPIO control

2014-10-31 Thread Krzysztof Kozlowski
On pią, 2014-10-31 at 10:32 +, Mark Brown wrote: On Fri, Oct 31, 2014 at 08:51:38AM +0100, Krzysztof Kozlowski wrote: However new DT style parsing (regulator_of_get_init_data()) does the basic parsing stuff and this removes a lot of code from driver. The driver no longer parses all

Re: [PATCH 6/8] regulator: max77686: Add external GPIO control

2014-10-31 Thread Mark Brown
On Fri, Oct 31, 2014 at 12:45:47PM +0100, Krzysztof Kozlowski wrote: Then I'll add it. Mark, what device should be assigned to config.dev during registration of regulators? The regulator driver's device or its parent (MFD main driver)? Various drivers do this differently. Normally the

Re: [PATCH v3 01/14] mfd: max77686/802: Map regulator driver to its own of_node

2014-10-31 Thread Mark Brown
On Thu, Oct 30, 2014 at 12:20:40PM +0100, Krzysztof Kozlowski wrote: Add of_compatible fields for max77686 and max77802 regulator drivers. The driver's node should be the same as voltage-regulators node. This simplifies parsing of regulators init data from DTS. No, this is broken. You're

Re: [PATCH v6 1/3] regulator: max77686: Add suspend disable for some LDOs

2014-10-31 Thread Mark Brown
On Wed, Oct 29, 2014 at 12:14:52PM +0100, Krzysztof Kozlowski wrote: Some LDOs of Maxim 77686 PMIC support disabling during system suspend (LDO{2,6,7,8,10,11,12,14,15,16}). This was already implemented as part of set_suspend_mode function. In that case the mode was one of: Applied, thanks.

Re: [PATCH v3 01/14] mfd: max77686/802: Map regulator driver to its own of_node

2014-10-31 Thread Krzysztof Kozlowski
On pią, 2014-10-31 at 12:23 +, Mark Brown wrote: On Thu, Oct 30, 2014 at 12:20:40PM +0100, Krzysztof Kozlowski wrote: Add of_compatible fields for max77686 and max77802 regulator drivers. The driver's node should be the same as voltage-regulators node. This simplifies parsing of

[PATCH v7 0/2] Fine tune USB 3.0 PHY on exynos5420

2014-10-31 Thread Vivek Gautam
This series is tested with V3 of Heikki's patches for simpliefied phy lookup table: [PATCHv3 0/6] phy: simplified phy lookup [1] on 'usb-next' branch. V4 of this series is giving some issue, which i have already pointed out in the patch: [PATCHv4 2/6] phy: improved lookup method Changes since

[PATCH v7 2/2] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-10-31 Thread Vivek Gautam
Adding phy calibration sequence for USB 3.0 DRD PHY present on Exynos5420/5800 systems. This calibration facilitates setting certain PHY parameters viz. the Loss-of-Signal (LOS) Detector Threshold Level, as well as Tx-Vboost-Level for Super-Speed operations. Additionally we also set proper time to

[PATCH v7 1/2] usb: host: xhci-plat: Get PHYs for xhci's hcds

2014-10-31 Thread Vivek Gautam
The host controller by itself may sometimes need to handle PHY and re-initialize it to re-configure some of the PHY parameters to get full support out of the PHY controller. Therefore, facilitate getting the two possible PHYs, viz. USB 2.0 type (UTMI+) and USB 3.0 type (PIPE3), and initialize

[PATCH] ARM: dts: Fix CLK_UART_ISP_SCLK clock assignment in exynos4x12.dtsi

2014-10-31 Thread Sylwester Nawrocki
Assign proper FIMC-IS UART gate clock in the device DT node and not use the SRC_MASK gate. This fixes regression introduced in commit a37c82a3b3c0910019abfd22a97be1f (clk: samsung: exynos4: Remove SRC_MASK_ISP gates). Without this change exynos4 fimc-is driver fails to probe with an error log: [

Re: [PATCH v7 1/2] usb: host: xhci-plat: Get PHYs for xhci's hcds

2014-10-31 Thread Sergei Shtylyov
Hello. On 10/31/2014 4:26 PM, Vivek Gautam wrote: The host controller by itself may sometimes need to handle PHY and re-initialize it to re-configure some of the PHY parameters to get full support out of the PHY controller. Therefore, facilitate getting the two possible PHYs, viz. USB 2.0 type

[PATCH 4/9] drm/exynos: Replace repeated declaration by include drm/drmP.h

2014-10-31 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk Re-declare struct is not a good practice, let's use the original drm declarations. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_drv.h | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH 5/9] drm/exynos: Replace repeated declarations by #include exynos_drm_drv.h

2014-10-31 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk Re-declare struct is not a good practice, let's use the original drm and exynos declarations. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_crtc.h | 5 + 1 file changed, 1

[PATCH 7/9] drm/exynos: Save up space using bool var as bitfields

2014-10-31 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk Save a few bytes by compiling them all in the same byte. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_drv.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff

[PATCH 9/9] drm/exynos: remove leftover hdmi function declarations

2014-10-31 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk They are not implemented anywhere, so wipe them out. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_drv.h | 11 --- 1 file changed, 11 deletions(-) diff --git

[PATCH 1/9] drm/exynos: remove uneeded declaration of struct dma_iommu_mapping

2014-10-31 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk It is not even used in this header anymore. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_iommu.h | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 8/9] drm/exynos: update documentation to reflect code changes

2014-10-31 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk Description of the @create_connector callback was missing, and the @manager was no longer needed. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_drv.h | 3 +-- 1 file changed, 1

[PATCH 2/9] drm/exynos: remove extra declaration of struct exynos_drm_manager

2014-10-31 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk The struct is defined in the same file, declare it here is just unnecessary. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_encoder.h | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 3/9] drm/exynos: remove extra declaration of struct exynos_overlay

2014-10-31 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk The struct is defined in the same file, declare it here is just unnecessary Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_drv.h | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 6/9] drm/exynos: remove unused wait_for macro

2014-10-31 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk This is a leftover, all code using this macro have been removed/ changed already. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_drv.h | 14 -- 1 file changed, 14 deletions(-)

Re: [PATCH V7 03/12] drm/bridge: Add helper functions for drm_bridge

2014-10-31 Thread Daniel Vetter
On Wed, Oct 29, 2014 at 10:14:37AM +0100, Thierry Reding wrote: On Wed, Oct 29, 2014 at 09:57:02AM +0100, Daniel Vetter wrote: That makes the entire thing a bit non-trivial, which is why I think it would be better as some generic helper. Which then gets embedded or instantiated for specific

Re: [PATCH V7 03/12] drm/bridge: Add helper functions for drm_bridge

2014-10-31 Thread Daniel Vetter
On Thu, Oct 30, 2014 at 10:09:28AM +, Russell King - ARM Linux wrote: On Thu, Oct 30, 2014 at 11:01:02AM +0100, Andrzej Hajda wrote: On 10/29/2014 10:14 AM, Thierry Reding wrote: On Wed, Oct 29, 2014 at 09:57:02AM +0100, Daniel Vetter wrote: I think we nee try_get_module for the code

Re: [PATCH V7 03/12] drm/bridge: Add helper functions for drm_bridge

2014-10-31 Thread Daniel Vetter
On Wed, Oct 29, 2014 at 10:16:49AM +0100, Thierry Reding wrote: On Wed, Oct 29, 2014 at 08:51:27AM +0100, Daniel Vetter wrote: On Tue, Oct 28, 2014 at 03:29:47PM +0100, Thierry Reding wrote: On Mon, Oct 27, 2014 at 11:20:31PM +0100, Daniel Vetter wrote: On Mon, Oct 27, 2014 at 8:58 PM,

Re: [PATCH V7 03/12] drm/bridge: Add helper functions for drm_bridge

2014-10-31 Thread Daniel Vetter
On Wed, Oct 29, 2014 at 10:09:04AM +0100, Andrzej Hajda wrote: On 10/29/2014 08:58 AM, Daniel Vetter wrote: On Tue, Oct 28, 2014 at 04:05:34PM +0100, Thierry Reding wrote: On Tue, Oct 28, 2014 at 08:16:44PM +0530, Ajay kumar wrote: On Tue, Oct 28, 2014 at 8:11 PM, Thierry Reding

[GIT PULL] Samsung clock changes for 3.19

2014-10-31 Thread Sylwester Nawrocki
Hi Mike, I've collected Exynos clk patches in this pull request, as Tomasz has been busy recently. This includes addition of clock controller drivers for Exynos4415 and Exynos7 SoCs and related refactoring of the Samsung common clk API. As I mentioned in my other e-mail, it might be sensible

Re: exynos5420/arndale-octa: imprecise external aborts on exynos_defconfig

2014-10-31 Thread Kevin Hilman
On Wed, Sep 17, 2014 at 5:39 PM, Kevin Hilman khil...@kernel.org wrote: Thomas Abraham ta.oma...@gmail.com writes: On Thu, Sep 11, 2014 at 12:16 AM, Kevin Hilman khil...@kernel.org wrote: Tyler Baker tyler.ba...@linaro.org writes: Exynos5420-based Arndale octa boards have recently started

Re: [PATCH v3 01/14] mfd: max77686/802: Map regulator driver to its own of_node

2014-10-31 Thread Mark Brown
On Fri, Oct 31, 2014 at 02:07:54PM +0100, Krzysztof Kozlowski wrote: On pią, 2014-10-31 at 12:23 +, Mark Brown wrote: I'm getting very frustrated with what's going on with these drivers, there seem to be a lot of rather large sets of patches spawning lots of discussion but also

RE: [PATCH v3] usb: dwc2/gadget: report disconnect event from 'end session' irq

2014-10-31 Thread Paul Zimmerman
From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] Sent: Friday, October 31, 2014 1:04 AM To: linux-...@vger.kernel.org; linux-samsung-soc@vger.kernel.org Cc: Marek Szyprowski; Kyungmin Park; Robert Baldyga; Paul Zimmerman; Krzysztof Kozlowski; Felipe Balbi Subject: [PATCH v3] usb:

RE: [PATCH v3 1/2] usb: dwc2/gadget: add mutex to serialize init/deinit calls

2014-10-31 Thread Paul Zimmerman
From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] Sent: Friday, October 31, 2014 3:13 AM This patch adds mutex, which protects initialization and deinitialization procedures against suspend/resume methods. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com ---

[PATCH] ARM: exynos_defconfig: disable CONFIG_EXYNOS5420_MCPM; not stable

2014-10-31 Thread Kevin Hilman
From: Kevin Hilman khil...@linaro.org The option CONFIG_EXYNOS5420_MCPM is causing imprecise external aborts during boot testing, causing various userspace startup failures. Disable until it has gotten more testing. Cc: Kukjin Kim kgene@samsung.com, Cc: Javier Martinez Canillas

Re: [PATCH v2 1/1] ARM: exynos_defconfig: Enable options for display panel support

2014-10-31 Thread Javier Martinez Canillas
Hello Kukjin, On Mon, Aug 25, 2014 at 10:45 AM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Many Exynos devices have a display panel. Most of them just have a simple panel while others have more complex configurations that requires an embedded DisplayPort (eDP) to LVDS

Re: [PATCH v3 0/9] PM / Domains: Fix race conditions during boot

2014-10-31 Thread Rafael J. Wysocki
On Friday, October 31, 2014 10:16:14 AM Ulf Hansson wrote: On 24 October 2014 18:12, Kevin Hilman khil...@kernel.org wrote: Ulf Hansson ulf.hans...@linaro.org writes: Changes in v3: -Rework the entire intermediate step which was suggested in v2. That means solving the race

Re: [PATCH v3 4/9] drivercore / platform: Keep PM domain powered during -probe()

2014-10-31 Thread Rafael J. Wysocki
On Friday, October 31, 2014 10:23:00 AM Ulf Hansson wrote: On 31 October 2014 01:07, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Thu, Oct 30, 2014 at 01:47:27PM -0700, Kevin Hilman wrote: Ulf Hansson ulf.hans...@linaro.org writes: To sucessfully probe some devices their

pm_runtime_enable() in -probe() (was: Re: [PATCH v3 0/9] PM / Domains: Fix race conditions during boot)

2014-10-31 Thread Rafael J. Wysocki
On Saturday, November 01, 2014 01:20:38 AM Rafael J. Wysocki wrote: On Friday, October 31, 2014 10:16:14 AM Ulf Hansson wrote: On 24 October 2014 18:12, Kevin Hilman khil...@kernel.org wrote: [cut] 1) It's bad practice to use pm_runtime_get_sync() in the -probe() path, Honestly, I'm

Re: pm_runtime_enable() in -probe() (was: Re: [PATCH v3 0/9] PM / Domains: Fix race conditions during boot)

2014-10-31 Thread Rafael J. Wysocki
On Saturday, November 01, 2014 02:08:57 AM Rafael J. Wysocki wrote: On Saturday, November 01, 2014 01:20:38 AM Rafael J. Wysocki wrote: On Friday, October 31, 2014 10:16:14 AM Ulf Hansson wrote: On 24 October 2014 18:12, Kevin Hilman khil...@kernel.org wrote: [cut] 1) It's bad

Re: [PATCH 6/8] regulator: max77686: Add external GPIO control

2014-10-31 Thread Alexandre Courbot
On Fri, Oct 31, 2014 at 4:51 PM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: On pią, 2014-10-31 at 12:31 +0900, Alexandre Courbot wrote: On Fri, Oct 31, 2014 at 12:03 AM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: On czw, 2014-10-30 at 22:56 +0900, Alexandre Courbot wrote: