Re: [PATCH 1/1] ARM: dts: Use more descriptive names for Exynos5420 PDs

2015-02-06 Thread Javier Martinez Canillas
Hello Sergei, Thanks a lot for your feedback. On 02/06/2015 08:09 PM, Sergei Shtylyov wrote: Hello. On 02/06/2015 08:37 PM, Javier Martinez Canillas wrote: All the device nodes for the Exynos5420 power-domains have a quite generic power-domain name. And this is in conformance to

Re: [PATCH 1/1] ARM: dts: Use more descriptive names for Exynos5420 PDs

2015-02-06 Thread Sergei Shtylyov
Hello. On 02/06/2015 08:37 PM, Javier Martinez Canillas wrote: All the device nodes for the Exynos5420 power-domains have a quite generic power-domain name. And this is in conformance to the ePAPR standard. So in case of an error, the Exynos PD driver shows the following (not very

[PATCH -v2 04/14] drm/exynos: make zpos property immutable

2015-02-06 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk We already set each plane zpos at init, after that changes to zpos are not expected. This patch turns zpos into a read-only property so now it is impossible to set zpos. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk ---

[PATCH -v2 10/14] drm/exynos: atomic phase 1: add atomic_begin()/atomic_flush()

2015-02-06 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk Add CRTC callbacks .atomic_begin() .atomic_flush(). On exynos they unprotect the windows before the commit and protects it after based on a plane mask tha store which plane will be updated. For that we create two new exynos_crtc callbacks:

[PATCH -v2 03/14] drm/exynos: preset zpos value for overlay planes

2015-02-06 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk Usually userspace don't want to have two overlay planes on the same zpos so this change assign a different zpos for each plane. Before this change a zpos of value zero was created for all planes so the userspace had to set up the zpos of every

[PATCH -v2 06/14] drm/exynos: remove leftover functions declarations

2015-02-06 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk These functions were already removed by previous cleanup work, but these ones were left behind. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk Acked-by: Joonyoung Shim jy0922.s...@samsung.com ---

[PATCH -v2 01/14] drm/exynos: remove unused exynos_crtc-win_enable() callback

2015-02-06 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk None of the exynos crtc drivers implements win_enable() so remove it for better clarity of the code. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_drv.h | 2 -- 1 file changed, 2

[PATCH -v2 02/14] drm/exynos: remove struct *_win_data abstraction on planes

2015-02-06 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk struct {fimd,mixer,vidi}_win_data was just keeping the same data as struct exynos_drm_plane thus get ride of it and use exynos_drm_plane directly. It changes how planes are created and remove .win_mode_set() callback that was only filling all

[PATCH -v2 05/14] drm/exynos: remove exynos_plane_destroy()

2015-02-06 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk The .destroy() callback for exynos can be replaced by drm_plane_cleanup(). The only extra operation on exynos_plane_destroy() was a call to exynos_plane_disable() but the plane is already disabled by a earlier call to drm_framebuffer_remove().

[PATCH -v2 09/14] drm/exynos: atomic phase 1: use drm_plane_helper_disable()

2015-02-06 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk The atomic helper to disable planes also uses the optional .atomic_disable() helper. The unique operation it does is calling .win_disable() exynos_drm_fb_get_buf_cnt() needs a fb check too to avoid a null pointer. Signed-off-by: Gustavo

[PATCH -v2 14/14] drm/exynos: make exynos_plane_mode_set() static

2015-02-06 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk It is not used outside of the plane scope anymore. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_plane.c | 11 ++- drivers/gpu/drm/exynos/exynos_drm_plane.h | 5 - 2 files

[PATCH -v2 07/14] drm/exynos: track vblank events on a per crtc basis

2015-02-06 Thread Gustavo Padovan
From: Mandeep Singh Baines m...@chromium.org The goal of the change is to make sure we send the vblank event on the current vblank. My hope is to fix any races that might be causing flicker. After this change I only see a flicker in the transition plymouth and X11. Simplified the code by

[PATCH -v2 11/14] drm/exynos: atomic phase 1: add .mode_set_nofb() callback

2015-02-06 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk The new atomic infrastructure needs the .mode_set_nofb() callback to update CRTC timings before setting any plane. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 60

[PATCH -v2 13/14] drm/exynos: atomic phase 2: keep track of framebuffer pointer

2015-02-06 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk Use drm_atomic_set_fb_for_plane() in the legacy page_flip path to keep track of the framebuffer pointer and reference. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 3 +++ 1

[PATCH -v2 00/14] drm/exynos: clean up + atomic phase 1 and 2

2015-02-06 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk Hi, This is the v2 of this patchset. The only difference here is that I added the zpos refactor to this series after the review of v1 today. No changes were made to atomic patches besides solving conflicts after the new zpos changes. This

[PATCH -v2 12/14] drm/exynos: atomic phase 2: wire up state reset(), duplicate() and destroy()

2015-02-06 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk Set CRTC, planes and connectors to use the default implementations from the atomic helper library. The helpers will work to keep track of state for each DRM object. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk ---

[PATCH -v2 08/14] drm/exynos: atomic phase 1: use drm_plane_helper_update()

2015-02-06 Thread Gustavo Padovan
From: Gustavo Padovan gustavo.pado...@collabora.co.uk Rip out the check from exynos_update_plane() and create exynos_check_plane() for the check phase enabling use to use the atomic helpers to call our check and update phases when updating planes. Update all users of exynos_update_plane()

Re: [PATCH 1/20] mtd: s3c2410: fix misspelling of current function in string

2015-02-06 Thread Brian Norris
On Mon, Dec 08, 2014 at 10:16:37AM +0100, Richard Weinberger wrote: Am 08.12.2014 um 08:11 schrieb Julia Lawall: diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c index 35aef5e..0a9c41f 100644 --- a/drivers/mtd/nand/s3c2410.c +++ b/drivers/mtd/nand/s3c2410.c @@ -948,7

Re: [RFC PATCH v2 3/3] ARM: dts: exynos5420: add async-bridge clocks to disp1 power domain

2015-02-06 Thread Javier Martinez Canillas
Hello Andrzej, On 02/06/2015 11:55 AM, Andrzej Hajda wrote: FIMD and MIXER IPs in disp1 power domain have async-bridges (to GSCALER), therefore their clocks should be enabled during power domain switch. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- Hi, This is 2nd version of the

Re: [GIT PULL 3/3] Samsung CPUIdle updates for v3.20

2015-02-06 Thread Olof Johansson
On Wed, Feb 04, 2015 at 11:31:42PM +0900, Kukjin Kim wrote: Hi, This is cpuidle update for v3.20. Please pull. Thanks, Kukjin The following changes since commit 97bf6af1f928216fd6c5a66e8a57bfa95a659672: Linux 3.19-rc1 (2014-12-20 17:08:50 -0800) are available in the git

Re: [RESEND PATCH V3 15/15] ARM: dts: Fix I2S1, I2S2 compatible for exynos4 SoCs

2015-02-06 Thread Sylwester Nawrocki
On 05/02/15 20:41, Mark Brown wrote: On Tue, Feb 03, 2015 at 03:06:22PM +0100, Sylwester Nawrocki wrote: I2S1, I2S2 on Exynos4 SoC series have limited functionality compared to I2S0, samsung,s3c6410-i2s compatible should be used for them. I've applied this even though I really shouldn't in

[RFC PATCH v2 3/3] ARM: dts: exynos5420: add async-bridge clocks to disp1 power domain

2015-02-06 Thread Andrzej Hajda
FIMD and MIXER IPs in disp1 power domain have async-bridges (to GSCALER), therefore their clocks should be enabled during power domain switch. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- Hi, This is 2nd version of the patch. After decrypting manual and discussion with Marek I guess this

Re: [GIT PULL 1/3] Samsung exynos_defconfig updates for v3.20

2015-02-06 Thread Olof Johansson
On Wed, Feb 04, 2015 at 11:31:23PM +0900, Kukjin Kim wrote: Hi Arnd, Olof, Kevin Here is late pull request for exynos_defconfig updates for v3.20 and if you're OK please pull. Note this is based on previous exynos_defconfig pull-request during v3.19-rc. Thanks, Kukjin The

Re: [RESEND PATCH V3 15/15] ARM: dts: Fix I2S1, I2S2 compatible for exynos4 SoCs

2015-02-06 Thread Mark Brown
On Fri, Feb 06, 2015 at 12:30:45PM +0100, Sylwester Nawrocki wrote: Thank you for merging it. I hope you picked up the previous 2 as well, I couldn't see them in your tree. I probably will if I don't hear anything but since they don't need to go as a bug fix I can leave Kukjin a bit longer to

Re: [RFC PATCH 0/3] Fix power domains handling on exynos542x

2015-02-06 Thread Javier Martinez Canillas
Hello Joonyoung, On 02/06/2015 06:27 AM, Joonyoung Shim wrote: On 02/05/2015 11:45 PM, Javier Martinez Canillas wrote: I also tested on an Exynos5420 Peach Pit Chromebook and both the Power domain power-domain disable failed message and the system crash are gone. Really gone out Power

Re: [GIT PULL 2/3] Samsung 4th DT updates for v3.20

2015-02-06 Thread Olof Johansson
On Wed, Feb 04, 2015 at 11:31:33PM +0900, Kukjin Kim wrote: Hi, Here is 4th DT updates for v3.20. Please pull. Note there are several dt updates in my tree which has a dependency with driver side for v3.20 and I hope it can be sent to upstream via arm-soc during late merge window. If it

Re: [PATCH 1/4] drm/exynos: remove struct *_win_data abstraction on planes

2015-02-06 Thread Gustavo Padovan
Hi, 2015-02-06 Joonyoung Shim jy0922.s...@samsung.com: Hi Gustavo, On 02/06/2015 02:59 AM, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk struct {fimd,mixer,vidi}_win_data was just keeping the same data as struct exynos_drm_plane thus get ride of it and

[PATCH v2 3/3] clk: samsung: add cpu clock configuration data and instantiate cpu clock

2015-02-06 Thread Abhilash Kesavan
Add the Atlas CPU clock configuration data and instantiate the CPU clock type for Exynos7. Signed-off-by: Abhilash Kesavan a.kesa...@samsung.com --- drivers/clk/samsung/clk-cpu.h |5 + drivers/clk/samsung/clk-exynos7.c | 33 ++-

[PATCH v2 0/3] Add CPU clock support for Exynos7

2015-02-06 Thread Abhilash Kesavan
This patch set adds the atlas clock hierarchy on Exynos7. It also modifies the existing cpu clock infrastructure to handle exynos7 differences. These patches are a pre-requisite for enabling CPUFreq on Exynos7. This patch set has been tested on next-20150202 with samsung clk tree

[PATCH v2 1/3] clk: samsung: exynos7: add clocks for CPU block

2015-02-06 Thread Abhilash Kesavan
Add clock support for the Atlas CPU block in Exynos7. Signed-off-by: Abhilash Kesavan a.kesa...@samsung.com --- .../devicetree/bindings/clock/exynos7-clock.txt|6 + drivers/clk/samsung/clk-exynos7.c | 121 include/dt-bindings/clock/exynos7-clk.h

[PATCH v2 2/3] clk: samsung: add cpu clock support for Exynos7

2015-02-06 Thread Abhilash Kesavan
The divider and mux register offsets and bits are different on Exynos7 from the older SoCs. Add new pre/post rate change callbacks for Exynos7 to handle these differences. To do this: - Add a new exynos_cpuclk_soc_data structure that will hold the SoC-specific pre/post rate change

Re: [PATCH v2 2/2] arm/dma-mapping: Respect NO_KERNEL_MAPPING when we don't have an IOMMU

2015-02-06 Thread Marek Szyprowski
Hello, On 2015-02-05 11:13, Carlo Caione wrote: On Wed, Feb 4, 2015 at 11:21 AM, Marek Szyprowski m.szyprow...@samsung.com wrote: On 2015-02-04 10:23, Carlo Caione wrote: From: Jasper St. Pierre jstpie...@mecheye.net Even without an iommu, NO_KERNEL_MAPPING is still convenient to save on

[PATCH] thermal: exynos: fix: Check if data-tmu_read callback is present before read

2015-02-06 Thread Lukasz Majewski
The exynos_tmu_data() function should on entrance test not only for valid data pointer, but also for data-tmu_read one. It is important, since afterwards it is dereferenced to get temperature code. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- drivers/thermal/samsung/exynos_tmu.c | 2

[PATCH 1/1] ARM: dts: Use more descriptive names for Exynos5420 PDs

2015-02-06 Thread Javier Martinez Canillas
All the device nodes for the Exynos5420 power-domains have a quite generic power-domain name. So in case of an error, the Exynos PD driver shows the following (not very useful) message: Power domain power-domain disable failed Use descriptive names to know on which PD enable or disable failed.

[PATCH 1/1] ARM: exynos_defconfig: Enable HDMI support

2015-02-06 Thread Javier Martinez Canillas
Many Exynos boards have an HDMI port so enable Exynos DRM HDMI support. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- Exynos DRM HDMI has some issues that were fixed by Andrzej's [0] series. So now is safe to HDMI support for Exynos boards. [0]:

[PATCH v2 1/1] ARM: dts: Add mclk entry for Snow and Peach Pit/Pi boards

2015-02-06 Thread Javier Martinez Canillas
From: Tushar Behera tusha...@samsung.com On Snow, Peach Pit and Peach Pi boards, the Exynos SoC XCLKOUT output pin provides the master clock (mclk) to codecs. So make them a clock consumer. Signed-off-by: Tushar Behera tusha...@samsung.com Signed-off-by: Javier Martinez Canillas

[PATCH 1/1] ARM: dts: Add mclk entry for Snow and Peach Pit/Pi boards

2015-02-06 Thread Javier Martinez Canillas
From: Tushar Behera tusha...@samsung.com On Snow, Peach Pit and Peach Pi boards, the Exynos SoC XCLKOUT output pin provides the master clock (mclk) to codecs. So make them a clock consumer. Signed-off-by: Tushar Behera tusha...@samsung.com Signed-off-by: Javier Martinez Canillas

[PATCH v3 7/8] hwmon: pwm-fan: Read PWM FAN configuration from device tree

2015-02-06 Thread Lukasz Majewski
This patch provides code for reading PWM FAN configuration data via device tree. The pwm-fan can work with full speed when configuration is not provided. However, errors are propagated when wrong DT bindings are found. Additionally the struct pwm_fan_ctx has been extended. Signed-off-by: Lukasz

[PATCH v3 6/8] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle

2015-02-06 Thread Lukasz Majewski
It was necessary to decouple code handling writing to sysfs from the one responsible for setting PWM of the fan. Due to that, new __set_pwm() method was extracted, which is responsible for only setting new PWM duty cycle. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v2: -

[PATCH v3 3/8] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device

2015-02-06 Thread Lukasz Majewski
Explanation of several properties, which allow PWM fan working as a cooling device, have been embraced in this commit. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v2: - Rename cooling-pwm-values to cooling-levels - Remove default-pulse-width property and stick to default

[PATCH v3 4/8] ARM: dts: Add pwm-fan node to the Odroid-U3 board

2015-02-06 Thread Lukasz Majewski
From: Kamil Debski k.deb...@samsung.com Add pwm-fan node to the Odroid-U3 board file to enable PWM control of the cooling fan. In addition, add the pwm label to the pwm@139D node in the exynos4412.dtsi. Signed-off-by: Kamil Debski k.deb...@samsung.com [Rebased on the newest mainline by

[PATCH v3 1/8] thermal: Provide stub for thermal_of_cooling_device_register() function

2015-02-06 Thread Lukasz Majewski
Odroid U3 fan can work without being registered as OF cooling device (with CONFIG_THERMAL_OF disabled). In this situation it can be controlled via PWM entry at /sys/class/hwmon/hwmon0/pwm1. Therefore, the thermal_of_cooling_device_register() function needs a stub to allow clean compilation.

[PATCH v3 8/8] hwmon: pwm-fan: Code for using PWM FAN as a cooling device

2015-02-06 Thread Lukasz Majewski
The PWM FAN device can now be used as a thermal cooling device. Necessary infrastructure has been added in this commit. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v2: - Replace pwm_fan_cooling_states with pwm_fan_cooling_levels - Update ctx-pwm_fan_state when correct

[PATCH v3 2/8] thermal: Provide stub for thermal_cdev_update() function

2015-02-06 Thread Lukasz Majewski
Odroid U3 fan can work without being registered as OF cooling device (with CONFIG_THERMAL{_OF|} disabled). In this situation it can be controlled via PWM entry at /sys/class/hwmon/hwmon0/pwm1. Therefore, the thermal_cdev_update() function needs a stub to allow clean compilation. Signed-off-by:

[PATCH v3 5/8] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3

2015-02-06 Thread Lukasz Majewski
With those bindings it is possible to use pwm-fan device available in Odroid U3 as a cooling device. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v2: - Rename cooling-pwm-values property to cooling-levels Changes for v3: - Change patch's topic to ARM dts - Reduce maximal

[PATCH v3 0/8] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan

2015-02-06 Thread Lukasz Majewski
Presented patches add support for Odroid's U3 optional CPU FAN, which uses PWM subsystem for low level control. After successful probe it registers itself as a cooling device for thermal subsystem. To preserve the ability to use this fan as a PWM device stubs for

Re: [PATCH v3 6/8] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle

2015-02-06 Thread Guenter Roeck
On Fri, Feb 06, 2015 at 05:59:06PM +0100, Lukasz Majewski wrote: It was necessary to decouple code handling writing to sysfs from the one responsible for setting PWM of the fan. Due to that, new __set_pwm() method was extracted, which is responsible for only setting new PWM duty cycle.

Re: [PATCH v3 7/8] hwmon: pwm-fan: Read PWM FAN configuration from device tree

2015-02-06 Thread Guenter Roeck
On Fri, Feb 06, 2015 at 05:59:07PM +0100, Lukasz Majewski wrote: This patch provides code for reading PWM FAN configuration data via device tree. The pwm-fan can work with full speed when configuration is not provided. However, errors are propagated when wrong DT bindings are found.