Re: [PATCH v5 0/7] platform/chrome: Add user-space dev inferface support

2015-02-26 Thread Javier Martinez Canillas
Hello, On 02/27/2015 01:11 AM, Olof Johansson wrote: On Thu, Feb 26, 2015 at 3:35 PM, Gwendal Grignou gwen...@chromium.org wrote: Tested-by: Gwendal Grignou gwen...@chromium.org Reviewed-by: Gwendal Grignou gwen...@chromium.org Tested on a chromebook pixel with kernel 4.0.0-rc1 and ectool

Re: [PATCH 1/1] ARM: exynos_defconfig: Disable IOMMU support

2015-02-26 Thread Javier Martinez Canillas
Hello Kukjin, On 02/17/2015 12:38 PM, Javier Martinez Canillas wrote: Enabling Exynos DRM IOMMU support for Exynos is currently broken and causes a BUG on exynos-iommu driver. This was not an issue since the options was disabled in exynos_defconfig but after commit 8dcc14f82f06 (drm/exynos:

[PATCH v6 6/6] hwmon: pwm-fan: Code for using PWM FAN as a cooling device

2015-02-26 Thread Lukasz Majewski
The PWM FAN device can now be used as a thermal cooling device. Necessary infrastructure has been added in this commit. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Acked-by: Eduardo Valentin edubez...@gmail.com --- Changes for v2: - Replace pwm_fan_cooling_states with

[PATCH v6 2/6] ARM: dts: Add pwm-fan node to the Odroid-U3 board

2015-02-26 Thread Lukasz Majewski
From: Kamil Debski k.deb...@samsung.com Add pwm-fan node to the Odroid-U3 board file to enable PWM control of the cooling fan. In addition, add the pwm label to the pwm@139D node in the exynos4412.dtsi. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Lukasz Majewski

[PATCH v6 3/6] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3

2015-02-26 Thread Lukasz Majewski
With those bindings it is possible to use pwm-fan device available in Odroid U3 as a cooling device. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Acked-by: Eduardo Valentin edubez...@gmail.com --- Changes for v2: - Rename cooling-pwm-values property to cooling-levels Changes for v3: -

[PATCH 1/2] drm/exynos: hdmi: Add support for Exynos7 HDMI

2015-02-26 Thread Ajay Kumar
Modify the exynos HDMI driver to support Exynos7 HDMI 1.4. * Add phy configs for Exynos7. * Exynos7 has a different clock structure for HDMI, so introduce the new clocks. * Add sysreg support to enable HDMI SYSREG on Exynos7. * Exynos7 based boards need a DCDC_EN and LS_EN pins for powering up

[PATCH 3/3] ARM: dts: Add mclk entry for Peach Pit/Pi boards

2015-02-26 Thread Javier Martinez Canillas
From: Tushar Behera tusha...@samsung.com On Peach Pit and Pi boards, the Exynos SoC XCLKOUT pin provides master clock (mclk) to the codec. So make it a clock consumer. Signed-off-by: Tushar Behera tusha...@samsung.com Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk ---

[PATCH 2/3] ARM: dts: Add WiFi module support for Peach boards

2015-02-26 Thread Javier Martinez Canillas
Peach Pit and Pi boards have a WiFi module that is always powered but needs toggling an enable pin and ungating a 32kHz reference clock as part of their power sequencing. Add a dev node for the SDIO slot and a MMC power sequence provider. Signed-off-by: Javier Martinez Canillas

[PATCH 0/3] ARM: dts: Peach boards WiFi and audio support

2015-02-26 Thread Javier Martinez Canillas
Hello Kukjin, This series adds support for the remaining peripherals that were not supported in the Exynos5420 Peach Pit and Exynos5800 Peach Pi boards. Javier Martinez Canillas (2): ARM: dts: Mux XMMCnDATA[0] pad correctly for Exynos5420 boards. ARM: dts: Add WiFi module support for Peach

[PATCH 1/3] ARM: dts: Mux XMMCnDATA[0] pad correctly for Exynos5420 boards.

2015-02-26 Thread Javier Martinez Canillas
The Exynos5420 SoC has 3 sets of 8 pads used as data lines for the 3 MMC/SD/SDIO slots. These needs to be muxed as SD_n_DATA instead of a GPIO or external interrupt to allow the MMC controller to communicate with the attached cards or SDIO devices. Which data lines needs to be muxed as SD_n_DATA

Re: [PATCH v6 00/18] thermal: exynos: Thermal code rework to use device tree

2015-02-26 Thread Lukasz Majewski
Hi Kukjin, Lukasz Majewski wrote: Hi Kukjin, Eduardo Hi, On 01/25/15 06:49, Eduardo Valentin wrote: On Fri, Jan 23, 2015 at 01:09:53PM +0100, Lukasz Majewski wrote: 1. Introduction Following patches aim to clean up the current implementation of the thermal

Re: [PATCH 0/3] ARM: dts: Peach boards WiFi and audio support

2015-02-26 Thread Javier Martinez Canillas
Hello Kukjin, On 02/26/2015 04:55 PM, Kukjin Kim wrote: Javier Martinez Canillas wrote: After this series all the peripherals in the Peach boards are working at least at a basic level, more work is needed to make the ASoC audio driver more robust or the WiFi chip to support highspeed mode

Re: [PATCH v5 0/7] platform/chrome: Add user-space dev inferface support

2015-02-26 Thread Simon Glass
Hi Olof, On 25 February 2015 at 17:59, Olof Johansson o...@lixom.net wrote: On Tue, Feb 17, 2015 at 07:26:50PM -0700, Simon Glass wrote: Hi, On 16 February 2015 at 01:19, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Hello Olof, On 02/02/2015 12:26 PM, Javier Martinez

RE: [PATCH 0/3] ARM: dts: Peach boards WiFi and audio support

2015-02-26 Thread Kukjin Kim
Javier Martinez Canillas wrote: Hello Kukjin, Hi, This series adds support for the remaining peripherals that were not supported in the Exynos5420 Peach Pit and Exynos5800 Peach Pi boards. Javier Martinez Canillas (2): ARM: dts: Mux XMMCnDATA[0] pad correctly for Exynos5420 boards.

[PATCH v6 0/6] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan

2015-02-26 Thread Lukasz Majewski
Presented patches add support for Odroid's U3 optional CPU FAN, which uses PWM subsystem for low level control. After successful probe it registers itself as a cooling device for thermal subsystem. This driver also supports devices without DTS specified. To provide correct functionality, new

[PATCH v6 1/6] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device

2015-02-26 Thread Lukasz Majewski
Explanation of several properties, which allow PWM fan working as a cooling device, have been embraced in this commit. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Acked-by: Eduardo Valentin edubez...@gmail.com --- Changes for v2: - Rename cooling-pwm-values to cooling-levels - Remove

[PATCH v6 4/6] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle

2015-02-26 Thread Lukasz Majewski
It was necessary to decouple code handling writing to sysfs from the one responsible for setting PWM of the fan. Due to that, new __set_pwm() method was extracted, which is responsible for only setting new PWM duty cycle. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- Changes for v2: -

[PATCH v6 5/6] hwmon: pwm-fan: Read PWM FAN configuration from device tree

2015-02-26 Thread Lukasz Majewski
This patch provides code for reading PWM FAN configuration data via device tree. The pwm-fan can work with full speed when configuration is not provided. However, errors are propagated when wrong DT bindings are found. Additionally the struct pwm_fan_ctx has been extended. Signed-off-by: Lukasz

Re: [PATCH v6 6/6] hwmon: pwm-fan: Code for using PWM FAN as a cooling device

2015-02-26 Thread Guenter Roeck
On 02/26/2015 05:59 AM, Lukasz Majewski wrote: The PWM FAN device can now be used as a thermal cooling device. Necessary infrastructure has been added in this commit. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Acked-by: Eduardo Valentin edubez...@gmail.com --- Changes for v2: -

Re: [PATCH v6 6/6] hwmon: pwm-fan: Code for using PWM FAN as a cooling device

2015-02-26 Thread Lukasz Majewski
Hi Guenter, On 02/26/2015 05:59 AM, Lukasz Majewski wrote: The PWM FAN device can now be used as a thermal cooling device. Necessary infrastructure has been added in this commit. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Acked-by: Eduardo Valentin edubez...@gmail.com ---

Re: [PATCH v5 4/7] platform/chrome: Add Chrome OS EC userspace device interface

2015-02-26 Thread Olof Johansson
On Thu, Feb 26, 2015 at 1:08 AM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: Hello Olof, Thanks a lot for your feedback. On 02/26/2015 02:13 AM, Gwendal Grignou wrote: Olof, I think the way Javier did it is fine, the 'major' of the ioctl is 0xEC, from ':'. Gwendal.

Re: [PATCH v2] cpufreq: exynos: Use simple approach to asses if cpu cooling can be used

2015-02-26 Thread Eduardo Valentin
On Thu, Feb 26, 2015 at 11:36:24AM +0100, Lukasz Majewski wrote: Hi Eduardo, Commit: e725d26c4857e5e41975b5e74e64ce6ab09a7121 provided possibility to use device tree to asses if cpu can be used as cooling device. Since the code was somewhat awkward, simpler approach has been proposed.

Re: [PATCH] ARM: EXYNOS: Don't use LDREX and STREX after disabling cache coherency

2015-02-26 Thread Kukjin Kim
On 02/18/15 07:24, Stephen Boyd wrote: On 02/16/15 05:36, Krzysztof Kozlowski wrote: During CPU shutdown the exynos_cpu_power_down() is called after disabling cache coherency and it uses LDREX and STREX instructions (by calling of_machine_is_compatible() - kobject_get() - kref_get()). The

Re: [PATCH] ARM: exynos: Fix wrong hwirq of RTC interrupt for Exynos3250 SoC

2015-02-26 Thread Kukjin Kim
On 02/10/15 17:05, Krzysztof Kozlowski wrote: 2015-02-10 4:09 GMT+01:00 Chanwoo Choi cw00.c...@samsung.com: This patch fixes wrong hwirq of RTC irq for Exynos3250 SoC. When entering suspend state, 'enable_irq_wake fail' happen because of the mismatch of RTC hwirq. [ 429.200937]

Re: [PATCH v6 00/18] thermal: exynos: Thermal code rework to use device tree

2015-02-26 Thread Kukjin Kim
On 02/27/15 00:56, Lukasz Majewski wrote: Hi Kukjin, Lukasz Majewski wrote: Hi Kukjin, Eduardo Hi, [...] Kukjin, could you add missing DTS files and send this to upstream. Unfortunately, I couldn't take the DT changes in Samsung tree at that time because of missing header file and it

Re: [PATCH] ARM: fix exynos randconfig build error

2015-02-26 Thread Kukjin Kim
On 02/25/15 20:46, Krzysztof Kozlowski wrote: 2015-02-25 12:26 GMT+01:00 Russell King rmk+ker...@arm.linux.org.uk: The following error was observed with SMP=n in v4.0-rc1: arch/arm/mach-exynos/pm.c: In function 'exynos_cpu0_enter_aftr': arch/arm/mach-exynos/pm.c:246:4: error: implicit

Re: [PATCH v4 2/8] arm64: dts: exynos: Add dts files for 64-bit Exynos5433 SoC

2015-02-26 Thread Chanwoo Choi
On 02/24/2015 08:59 PM, Arnd Bergmann wrote: On Tuesday 24 February 2015 20:04:17 Chanwoo Choi wrote: On 02/24/2015 06:48 PM, Arnd Bergmann wrote: On Tuesday 24 February 2015 17:52:01 Chanwoo Choi wrote: But, I have a question. If we put the aliases into the board dts file instaed of SoC

Re: [PATCH v4 1/8] arm64: exynos5433: Enable ARMv8 based Exynos5433 (SoC) support

2015-02-26 Thread Chanwoo Choi
On 02/24/2015 05:31 PM, Arnd Bergmann wrote: On Tuesday 24 February 2015 14:16:44 Chanwoo Choi wrote: diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 1b8e973..d83cea0 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -154,6 +154,17 @@ config ARCH_EXYNOS help

Re: [PATCH v4 2/8] arm64: dts: exynos: Add dts files for 64-bit Exynos5433 SoC

2015-02-26 Thread Chanwoo Choi
Hi Arnd, On 02/26/2015 05:18 PM, Chanwoo Choi wrote: On 02/24/2015 08:59 PM, Arnd Bergmann wrote: On Tuesday 24 February 2015 20:04:17 Chanwoo Choi wrote: On 02/24/2015 06:48 PM, Arnd Bergmann wrote: On Tuesday 24 February 2015 17:52:01 Chanwoo Choi wrote: But, I have a question. If we put

Re: [PATCH v5 4/7] platform/chrome: Add Chrome OS EC userspace device interface

2015-02-26 Thread Javier Martinez Canillas
Hello Olof, Thanks a lot for your feedback. On 02/26/2015 02:13 AM, Gwendal Grignou wrote: Olof, I think the way Javier did it is fine, the 'major' of the ioctl is 0xEC, from ':'. Gwendal. As Gwendal said, I deliberately changed the IOCTL mayor number to make it different in both

Re: [PATCH] phy: exynos-mipi-video: Fixup the test for state-regmap

2015-02-26 Thread Sylwester Nawrocki
On 26/02/15 04:48, Axel Lin wrote: syscon_regmap_lookup_by_phandle() returns ERR_PTR on error. Thus don't use null test against state-regmap. Signed-off-by: Axel Lin axel@ingics.com Thanks for the patch, I had this on my todo list. Acked-by: Sylwester Nawrocki s.nawro...@samsung.com --

Re: [PATCH v2] cpufreq: exynos: Use simple approach to asses if cpu cooling can be used

2015-02-26 Thread Lukasz Majewski
Hi Eduardo, Commit: e725d26c4857e5e41975b5e74e64ce6ab09a7121 provided possibility to use device tree to asses if cpu can be used as cooling device. Since the code was somewhat awkward, simpler approach has been proposed. Test HW: Exynos 4412 - Odroid U3. Suggested-by: Viresh Kumar

[PATCH 2/3] arm64: dts: exynos: Add TMU sensor dt node for Exynos5433 SoC

2015-02-26 Thread Chanwoo Choi
This patch adds the TMU (Thermal Management Unit) sensor devicetree node for Exynos5433. The Exynos5433 includes the five temperature sensors as following: - two temperature sensor for Cortex-A57 (ATLAS) - one temperature sensor for Cortex-A53 (APOLLO) - one temperature sensor for G3D IP - one

[PATCH 3/3] arm64: dts: exynos: Add thermal-zones dt node for Exynos5433 SoC

2015-02-26 Thread Chanwoo Choi
This patch adds the thermal-zones devicetree node for Exynos5433 SoC. The thermal-zones has five thermal-zones and then each thermal-zone contains each thermal-sensor to monitor the temperature of own IP. The {atlas0|apollo}_ thermal zone have the eight trip-points for interrupt method to detect

[PATCH 1/3] thermal: exynos: Add the support for Exynos5433 TMU

2015-02-26 Thread Chanwoo Choi
This patch adds the support for Exynos5433's TMU (Thermal Management Unit). Exynos5433 has a little different register bit fields as following description: - Support the eight trip points for rising/falling interrupt by using two registers - Read the calibration type (1-point or 2-point) and

[PATCH 0/3] thermal: exynos: Add support for Exynos5433 TMU

2015-02-26 Thread Chanwoo Choi
This patch add the support for Exynos5433 TMU (Thermal Management Unit). Exynos5433 TMU includes five sensors as following and each sensor support the eight rising/falling interrupt according to threshold value. Exynos5433 TMU has a little difference register map from Exynos4/Exynos7. - two

[PATCH v2] drm: exynos: clean up dma_addr_t use

2015-02-26 Thread Arnd Bergmann
dma_addr_t may be 32 or 64 bits long on 32-bit CPUs, so we cannot cast it to a pointer without getting a compiler warning: drivers/gpu/drm/exynos/exynos_drm_buf.c: In function 'lowlevel_buffer_allocate': drivers/gpu/drm/exynos/exynos_drm_buf.c:109:18: warning: cast from pointer to integer of

Re: [PATCH] drm: exynos: clean up dma_addr_t use

2015-02-26 Thread Arnd Bergmann
On Wednesday 25 February 2015 16:36:46 Arnd Bergmann wrote: @@ -671,6 +671,7 @@ static void fimd_win_commit(struct exynos_drm_crtc *crtc, int zpos) struct fimd_win_data *win_data; int win = zpos; unsigned long val, alpha, size; + dma_addr_t end; unsigned int

Re: [PATCH v5 0/7] platform/chrome: Add user-space dev inferface support

2015-02-26 Thread Olof Johansson
On Thu, Feb 26, 2015 at 3:35 PM, Gwendal Grignou gwen...@chromium.org wrote: Tested-by: Gwendal Grignou gwen...@chromium.org Reviewed-by: Gwendal Grignou gwen...@chromium.org Tested on a chromebook pixel with kernel 4.0.0-rc1 and ectool using the enclosed patch in chromiumos platform/ec tree.

Re: [PATCH v5 0/7] platform/chrome: Add user-space dev inferface support

2015-02-26 Thread Gwendal Grignou
Tested-by: Gwendal Grignou gwen...@chromium.org Reviewed-by: Gwendal Grignou gwen...@chromium.org Tested on a chromebook pixel with kernel 4.0.0-rc1 and ectool using the enclosed patch in chromiumos platform/ec tree. I checked the lightbar is working, check the calls with strace ectool ..., check

Re: [PATCH v2] cpufreq: exynos: Use simple approach to asses if cpu cooling can be used

2015-02-26 Thread Lukasz Majewski
Hi Eduardo, On Thu, Feb 26, 2015 at 11:36:24AM +0100, Lukasz Majewski wrote: Hi Eduardo, Commit: e725d26c4857e5e41975b5e74e64ce6ab09a7121 provided possibility to use device tree to asses if cpu can be used as cooling device. Since the code was somewhat awkward, simpler approach

[PATCH RFT] phy: exynos-mipi-video: Use spin_lock to protct state-regmap rmw operations

2015-02-26 Thread Axel Lin
The state-regmap is initialized by devm_regmap_init_mmio(). So it's fine to use spin_lock rather than mutex to protct state-regmap rmw operations. Signed-off-by: Axel Lin axel@ingics.com --- Hi Sylwester, I don't have this hardware handy, so can you test if this patch works. This patch is on

[PATCH] phy: exynos-dp-video: Kill exynos_dp_video_phy_pwr_isol function

2015-02-26 Thread Axel Lin
If IS_ERR(state-regs) the .probe fails. So IS_ERR(state-regs) test in exynos_dp_video_phy_pwr_isol() is not necessary. exynos_dp_video_phy_pwr_isol() simply does a regmap_update_bits() call now, just call regmap_update_bits() instead and return proper return value. Signed-off-by: Axel Lin