RE: [PATCH v3 1/4] Documentation: dt-bindings: Describe SROMc configuration

Hello! > >> Any vendor prefix here? How generic is this? > > > > I just don't know... Does *everything* really need a vendor prefix? How > > readable would that > be? "compatible" property already says > > that it's samsung-exynos-specific. And IMHO it's quite obvious that > > properties of

Re: [rtc-linux] Re: [PATCH v4 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-10-29 20:20 GMT+09:00 Alim Akhtar : >>> I am testing this patch before sending them, what I have found is if you >>> don't update WUDR the time does not changes in rtc. >>> e.g. >>> if you don't do above changes then you will see below: >>> - >>> # date --set="Oct

[PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration

Add documentation for new subnode properties, allowing bank configuration. Based on u-boot implementation, but heavily reworked. Signed-off-by: Pavel Fedin --- .../bindings/arm/samsung/exynos-srom.txt | 50 +- 1 file changed, 48 insertions(+),

[PATCH v4 0/4] [PATCH v4 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410

This patch extends Exynos SROM controller driver with ability to configure controller outputs and enables SMSC9115 Ethernet chip on SMDK5410 board, which is connected via SROMc bank #3. With this patchset, support for the whole existing SMDK range can be added. Actually, only bank number is

[PATCH v4 2/4] ARM: dts: Add SROMc to Exynos 5410

This machine uses own SoC device tree file, add missing part. Signed-off-by: Pavel Fedin --- arch/arm/boot/dts/exynos5410.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm/boot/dts/exynos5410.dtsi b/arch/arm/boot/dts/exynos5410.dtsi index

[PATCH v4 3/4] drivers: exynos-srom: Add support for bank configuration

Implement handling properties in subnodes and adding child devices to the system. Child devices will not be added if configuration fails. Since the driver now does more than suspend-resume support, dependency on CONFIG_PM is removed. Signed-off-by: Pavel Fedin ---

[PATCH v4 4/4] ARM: dts: Add Ethernet chip to SMDK5410

The chip is smsc9115, connected via SROMc bank 3. Additionally, some GPIO initialization is required. Signed-off-by: Pavel Fedin --- arch/arm/boot/dts/exynos5410-smdk5410.dts | 41 +++ 1 file changed, 41 insertions(+) diff --git

Re: [rtc-linux] Re: [PATCH v4 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

Hi Krzysztof, On Thu, Oct 29, 2015 at 5:05 PM, Krzysztof Kozlowski wrote: > 2015-10-29 20:20 GMT+09:00 Alim Akhtar : I am testing this patch before sending them, what I have found is if you don't update WUDR the time does not changes in

[PATCH] ARM: multi_v7_defconfig: enable Exynos DRM Mixer driver

Mixer driver is selected by CONFIG_DRM_EXYNOS_HDMI option. Since Exynos5433 HDMI does not require Mixer and there are separate options to select Mixer and HDMI. Signed-off-by: Andrzej Hajda --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH v4 0/4] [PATCH v4 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410

On 29 October 2015 at 18:12, Pavel Fedin wrote: > This patch extends Exynos SROM controller driver with ability to configure > controller outputs and enables SMSC9115 Ethernet chip on SMDK5410 board, > which is connected via SROMc bank #3. > > With this patchset, support for

Re: [PATCH v4 4/4] ARM: dts: Add Ethernet chip to SMDK5410

Hi Pavel, On 29 October 2015 at 18:12, Pavel Fedin wrote: > The chip is smsc9115, connected via SROMc bank 3. Additionally, some GPIO > initialization is required. > > Signed-off-by: Pavel Fedin > --- > arch/arm/boot/dts/exynos5410-smdk5410.dts | 41 >

Re: [PATCH v8 0/17] Add Analogix Core Display Port Driver

Am Mittwoch, 28. Oktober 2015, 16:15:43 schrieb Yakir Yang: > Hi all, > >The Samsung Exynos eDP controller and Rockchip RK3288 eDP controller > share the same IP, so a lot of parts can be re-used. I split the common > code into bridge directory, then rk3288 and exynos only need to keep > some

Re: [PATCH v4 2/4] ARM: dts: Add SROMc to Exynos 5410

Hi Pavel, On 29 October 2015 at 18:12, Pavel Fedin wrote: > This machine uses own SoC device tree file, add missing part. > > Signed-off-by: Pavel Fedin > --- > arch/arm/boot/dts/exynos5410.dtsi | 15 +++ > 1 file changed, 15 insertions(+)

Re: [PATCH] ARM: multi_v7_defconfig: enable Exynos DRM Mixer driver

On 29.10.2015 23:25, Andrzej Hajda wrote: > Mixer driver is selected by CONFIG_DRM_EXYNOS_HDMI option. Since Exynos5433 > HDMI does not require Mixer and there are separate options to select Mixer > and HDMI. > > Signed-off-by: Andrzej Hajda > --- >

[PATCH v9 15/17] drm: bridge: analogix/dp: try force hpd after plug in lookup failed

Some edp screen do not have hpd signal, so we can't just return failed when hpd plug in detect failed. This is an hardware property, so we need add a devicetree property "analogix,need-force-hpd" to indicate this sutiation. Tested-by: Heiko Stuebner Tested-by: Javier Martinez

Re: [PATCH 0/3] ARM: dts: Enable Exynos RNG module

On 25.10.2015 08:58, Tobias Jakobi wrote: > Hello Krzysztof, > > > Krzysztof Kozlowski wrote: >> On 20.10.2015 01:11, Tobias Jakobi wrote: >>> Hello Krzysztof, >>> >>> I can confirm that this also works on a Odroid-X2, so I guess it's safe >>> to enable the PRNG for all Exynos4412-based Odroid

RE: [PATCH] ARM: exynos: Bring back reboot on Exynos5410

Hello! > Patch looks ok, but after Alim's patch series [1] to handle poweroff > and reboot via generic syscon based driver gets merged, this will > become redundant entry into PMU driver in the absence of any PMU data > for Exynos5410. Alim has taken care of adding power-off and reboot > device

Re: [PATCH v4 2/4] mfd: sec: Add support for S2MPS15 PMIC

On Thu, 29 Oct 2015, Alim Akhtar wrote: > From: Thomas Abraham > > Add support for S2MPS15 PMIC which is similar to S2MPS11 PMIC. The S2MPS15 > PMIC supports 27 LDO regulators, 10 buck regulators, RTC, three 32.768KHz > clock outputs and battery charger. This patch adds

Re: [PATCH v4 3/4] regulator: s2mps11: add support for S2MPS15 regulators

On Thu, 29 Oct 2015, Alim Akhtar wrote: > From: Thomas Abraham > > The S2MPS15 PMIC is similar in functionality to S2MPS11/14 PMIC. It contains > 27 LDO and 10 Buck regulators and allows programming these regulators via a > I2C interface. This patch adds initial support

Re: [PATCH v2] ARM: exynos: Bring back reboot on Exynos5410

On 29.10.2015 16:01, Pavel Fedin wrote: > Since 8cfc7fdd33080e30b86d21b1a8c9ad0686427ddc > ("ARM: EXYNOS: move restart code into pmu driver") PMU support is required > in order for the reboot to work. Unfortunately, there is currently no PMU > support for 5410. > > This patch adds exynos5410-pmu

Re: [PATCH v4 1/4] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC

On 10/29/2015 11:27 AM, Krzysztof Kozlowski wrote: On 29.10.2015 13:58, Alim Akhtar wrote: From: Thomas Abraham Add dt-binding documentation for s2mps15 PMIC device. The s2mps15 device is similar to s2mps11/14 PMIC device and has 27 LDO and 10 buck regulators. Cc:

RE: [PATCH v3 3/4] drivers: exynos-srom: Add support for bank configuration

Hello! > > + for_each_child_of_node(np, child) > > + decode_sromc(srom, child); > > You ignore the return value here so bank may be not configured but > device probe will return 0. Yes, so that banks which are described correctly, will still be configured. > Maybe clean up and

Re: [PATCH v3 3/4] drivers: exynos-srom: Add support for bank configuration

On 29.10.2015 15:54, Pavel Fedin wrote: > Hello! > Where is the contents of email and patch? >>> + for_each_child_of_node(np, child) >>> + decode_sromc(srom, child); >> >> You ignore the return value here so bank may be not configured but >> device probe will return 0. > > Yes,

[PATCH v2] ARM: exynos: Bring back reboot on Exynos5410

Since 8cfc7fdd33080e30b86d21b1a8c9ad0686427ddc ("ARM: EXYNOS: move restart code into pmu driver") PMU support is required in order for the reboot to work. Unfortunately, there is currently no PMU support for 5410. This patch adds exynos5410-pmu to the list of recognized devices. It is okay for

Re: [PATCH v4 3/4] regulator: s2mps11: add support for S2MPS15 regulators

On 29.10.2015 17:08, Lee Jones wrote: > On Thu, 29 Oct 2015, Alim Akhtar wrote: > >> From: Thomas Abraham >> >> The S2MPS15 PMIC is similar in functionality to S2MPS11/14 PMIC. It contains >> 27 LDO and 10 Buck regulators and allows programming these regulators via a >>

RE: [PATCH v3 3/4] drivers: exynos-srom: Add support for bank configuration

Hello! > But the system won't get any information about the failure. Device using > these banks should not probe in such case. In order to achieve this effect, i believe, it's not enough to fail SROMc probe. Peripherials (such as smsc) should then be declared as subnodes. There's one problem

Re: [PATCH v4 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

Hello Krzysztof, On 10/29/2015 11:24 AM, Krzysztof Kozlowski wrote: On 29.10.2015 13:58, Alim Akhtar wrote: RTC found in s2mps15 is almost same as one found on s2mps14/13 with few differences in RTC_UPDATE register fields, like bit fields are changed for WUDR and AUDR. This patch add required

[PATCH v2 RESEND] ARM: exynos: Bring back reboot on Exynos5410

Since 8cfc7fdd33080e30b86d21b1a8c9ad0686427ddc ("ARM: EXYNOS: move restart code into pmu driver") PMU support is required in order for the reboot to work. Unfortunately, there is currently no PMU support for 5410. This patch adds exynos5410-pmu to the list of recognized devices. It is okay for

RE: [PATCH v3 1/4] Documentation: dt-bindings: Describe SROMc configuration

Hello! > You missed here a lot of potential Cc. Please use get_maintainer.pl > script. It *must* be sent to devicetree list. > > Please send it also to DeviceTree maintainers because you are adding > quite generic names for bindings so they may have interesting thoughts > on this. > > LKML

RE: [PATCH] ARM: exynos: Bring back reboot on Exynos5410

Hello! > These patches are not adding any new code, except DT entry. Infact > restart handler will be removed from PMU driver and we will be using > generic syscon based implementation for reboot, which is already present > in Linux kernel. Ah, got it. So syscon is a very generic thing,

Re: [PATCH v4 2/4] mfd: sec: Add support for S2MPS15 PMIC

Hi On 10/29/2015 01:36 PM, Lee Jones wrote: On Thu, 29 Oct 2015, Alim Akhtar wrote: From: Thomas Abraham Add support for S2MPS15 PMIC which is similar to S2MPS11 PMIC. The S2MPS15 PMIC supports 27 LDO regulators, 10 buck regulators, RTC, three 32.768KHz clock outputs

Re: [PATCH] ARM: exynos: Bring back reboot on Exynos5410

On Thursday 29 October 2015 02:13 PM, Pavel Fedin wrote: Hello! These patches are not adding any new code, except DT entry. Infact restart handler will be removed from PMU driver and we will be using generic syscon based implementation for reboot, which is already present in Linux kernel.

Re: [PATCH v3 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-10-29 16:45 GMT+09:00 Pavel Fedin : > Hello! > >> You missed here a lot of potential Cc. Please use get_maintainer.pl >> script. It *must* be sent to devicetree list. >> >> Please send it also to DeviceTree maintainers because you are adding >> quite generic names for

Re: [PATCH v4 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-10-29 16:47 GMT+09:00 Alim Akhtar : > Hello Krzysztof, > > > On 10/29/2015 11:24 AM, Krzysztof Kozlowski wrote: >> >> On 29.10.2015 13:58, Alim Akhtar wrote: >>> >>> RTC found in s2mps15 is almost same as one found on s2mps14/13 >>> with few differences in RTC_UPDATE

Re: [PATCH v4 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

On 10/29/2015 04:33 PM, Krzysztof Kozlowski wrote: 2015-10-29 16:47 GMT+09:00 Alim Akhtar : Hello Krzysztof, On 10/29/2015 11:24 AM, Krzysztof Kozlowski wrote: On 29.10.2015 13:58, Alim Akhtar wrote: RTC found in s2mps15 is almost same as one found on s2mps14/13