Re: [RFC PATCH 00/16] pinctrl: samsung: Usability and extensibiltiy improvements

2012-10-01 Thread Linus Walleij
On Fri, Sep 28, 2012 at 4:28 PM, Tomasz Figa t.f...@samsung.com wrote:

 This RFC series is a work on improving usability and extensibiltiy of the
 pinctrl-samsung driver. It consists of three main parts:
  - moving SoC-specific data to device tree
  - converting the driver to use one GPIO chip and one IRQ domain per pin bank
  - introducing generic wake-up interrupt capability description

Overall this looks good to me.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH 0/2] ARM: Exynos4: Migrate to common clock framework.

2012-10-01 Thread chander . kashyap
From: Thomas Abraham thomas.abra...@linaro.org

This patch series migrates Exynos4 clock support to common clock framework.
The first patch in this series removes the existing Exynos4 clock support
that uses the Samsung specific clock framework. The second patch in this
series add Exynos4 clock support using common clock framework.

Thomas Abraham (2):
  ARM: Exynos4: Remove Samsung clock type support
  ARM: Exynos4: Register clocks via common clock framework

 arch/arm/mach-exynos/Kconfig   |1 +
 arch/arm/mach-exynos/Makefile  |3 -
 arch/arm/mach-exynos/clock-exynos4.c   | 1572 
 arch/arm/mach-exynos/clock-exynos4.h   |   35 -
 arch/arm/mach-exynos/clock-exynos4210.c|  188 
 arch/arm/mach-exynos/clock-exynos4212.c|  192 
 arch/arm/mach-exynos/common.c  |   18 +-
 arch/arm/mach-exynos/common.h  |3 +
 arch/arm/mach-exynos/mach-armlex4210.c |1 -
 arch/arm/mach-exynos/mach-exynos4-dt.c |1 -
 arch/arm/mach-exynos/mach-nuri.c   |1 -
 arch/arm/mach-exynos/mach-origen.c |1 -
 arch/arm/mach-exynos/mach-smdk4x12.c   |1 -
 arch/arm/mach-exynos/mach-smdkv310.c   |1 -
 arch/arm/mach-exynos/mach-universal_c210.c |1 -
 arch/arm/mach-exynos/mct.c |   11 +-
 arch/arm/plat-samsung/Kconfig  |4 +-
 drivers/clk/Makefile   |1 +
 drivers/clk/clk.c  |   12 +-
 drivers/clk/samsung/Makefile   |6 +
 drivers/clk/samsung/clk-exynos4.c  |  585 +++
 drivers/clk/samsung/clk.c  |  231 
 drivers/clk/samsung/clk.h  |  190 
 23 files changed, 1043 insertions(+), 2016 deletions(-)
 delete mode 100644 arch/arm/mach-exynos/clock-exynos4.c
 delete mode 100644 arch/arm/mach-exynos/clock-exynos4.h
 delete mode 100644 arch/arm/mach-exynos/clock-exynos4210.c
 delete mode 100644 arch/arm/mach-exynos/clock-exynos4212.c
 create mode 100644 drivers/clk/samsung/Makefile
 create mode 100644 drivers/clk/samsung/clk-exynos4.c
 create mode 100644 drivers/clk/samsung/clk.c
 create mode 100644 drivers/clk/samsung/clk.h

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH V6 2/2] video: drm: exynos: Add device tree support

2012-10-01 Thread Stephen Warren
On 09/30/2012 11:29 PM, Leela Krishna Amudala wrote:
 Hello Stephen Warren,
 
 The binding names that I use in my dts file should match with the
 names given in 
 http://lists.freedesktop.org/archives/dri-devel/2012-July/024875.html
 right?

I don't think so; the binding in that link is for example:

 + - xres, yres: Display resolution
 + - left-margin, right-margin, hsync-len: Horizontal Display timing parameters
 +   in pixels
 +   upper-margin, lower-margin, vsync-len: Vertical display timing parameters 
 in
 +   lines
 + - clock: displayclock in Hz

i.e. a bunch of separate properties, one for each value needed to
describe the display timing. However, your patch contains:

 + - samsung,fimd-display: This property should specify the phandle of the
 +   display device node which holds the video interface timing with the
 +   below mentioned properties.
 +
 +   - lcd-htiming: Specifies the horizontal timing for the overlay. The
 + horizontal timing includes four parameters in the following order.
 +
 + - horizontal back porch (in number of lcd clocks)
 + - horizontal front porch (in number of lcd clocks)
 + - hsync pulse width (in number of lcd clocks)
 + - Display panels X resolution.

A single lcd-htiming property, which contains 4 values. (and a similar
construct for the vertical timing).

That seems entirely different to me...
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Spurious IPIs on secondary cpu bringup with EXYNOS 4412

2012-10-01 Thread Matthew Leach
Hi,

I applied the secondary CPU bringup patch [1] to mainline, however when
booting I get the following spurious IPIs after each core has booted:

[0.05] CPU1: Booted secondary processor
[0.075000] CPU1: thread -1, cpu 1, socket 10, mpidr 8a01
[0.08] CPU1: Unknown IPI message 0x1
[0.09] CPU2: Booted secondary processor
[0.115000] CPU2: thread -1, cpu 2, socket 10, mpidr 8a02
[0.12] CPU2: Unknown IPI message 0x1
[0.13] CPU3: Booted secondary processor
[0.155000] CPU3: thread -1, cpu 3, socket 10, mpidr 8a03
[0.16] CPU3: Unknown IPI message 0x1

Has anyone that has access to the documentation for the 4412 know what
this could be?

[1]: ARM: EXYNOS: Add support for secondary CPU bring-up on Exynos4412

---

Thanks,
Matt
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Problem using S3C2416's HSSPI

2012-10-01 Thread José Miguel Gonçalves

Hi,

I'm trying to use the HSSPI controller on a S3C2416 based board but I'm having 
some problems.


I've added s3c64xx_device_spi0 to my array of platform devices and added a call 
to s3c64xx_spi0_set_platdata(NULL, 0, 1) before platform_add_devices(). When the 
kernel starts I see the following error:


s3c64xx-spi s3c6410-spi.0: Unable to acquire clock 'spi'
s3c64xx-spi: probe of s3c6410-spi.0 failed with error -2

So I reckon I'm still missing some kind of initialization. Can someone help me on 
this?


Best regards,
José Gonçalves

--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: Problem using S3C2416's HSSPI

2012-10-01 Thread Heiko Stübner
Hi José,

Am Montag, 1. Oktober 2012, 19:32:15 schrieb José Miguel Gonçalves:
 I'm trying to use the HSSPI controller on a S3C2416 based board but I'm
 having some problems.
 
 I've added s3c64xx_device_spi0 to my array of platform devices and added
 a call to s3c64xx_spi0_set_platdata(NULL, 0, 1) before
 platform_add_devices(). When the kernel starts I see the following error:
 
 s3c64xx-spi s3c6410-spi.0: Unable to acquire clock 'spi'
 s3c64xx-spi: probe of s3c6410-spi.0 failed with error -2

what kernel version do you use?

I.e. the clock support for the s3c64xx-spi on s3c2443 and s3c2416 was added
through [1] in march - so it's not this old. 


Heiko


[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2012-March/089086.html
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: Problem using S3C2416's HSSPI

2012-10-01 Thread Sylwester Nawrocki
Hi,

On 10/01/2012 09:18 PM, Heiko Stübner wrote:
 Hi José,
 
 Am Montag, 1. Oktober 2012, 19:32:15 schrieb José Miguel Gonçalves:
 I'm trying to use the HSSPI controller on a S3C2416 based board but I'm
 having some problems.

 I've added s3c64xx_device_spi0 to my array of platform devices and added
 a call to s3c64xx_spi0_set_platdata(NULL, 0, 1) before
 platform_add_devices(). When the kernel starts I see the following error:

 s3c64xx-spi s3c6410-spi.0: Unable to acquire clock 'spi'
 s3c64xx-spi: probe of s3c6410-spi.0 failed with error -2
 
 what kernel version do you use?
 
 I.e. the clock support for the s3c64xx-spi on s3c2443 and s3c2416 was added
 through [1] in march - so it's not this old.

In this commit

commit a5238e360b715e9a1bb39d7d3537f78cc9e9e286
Author: Thomas Abraham thomas.abra...@linaro.org
Date:   Fri Jul 13 07:15:14 2012 +0900

spi: s3c64xx: move controller information into driver data

Platform data is used to specify controller hardware specific information
such as the tx/rx fifo level mask and bit offset of rx fifo level. Such
information is not suitable to be supplied from device tree. Instead,
it can be moved into the driver data and removed from platform data.

Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
Acked-by: Jaswinder Singh jaswinder.si...@linaro.org
Acked-by: Grant Likely grant.lik...@secretlab.ca
Signed-off-by: Kukjin Kim kgene@samsung.com

All s3c64xx-spi.0 devname fields that you added were replaced with 
s3c24xx-spi.0.
I wonder if that's not the reason clk_get(..., spi); fails in the spi-s3c64xx 
driver
used on mach-s3c24xx. But it of course depends on the kernel version, we need 
to first 
clarify that.
 
diff --git a/arch/arm/mach-s3c24xx/common-s3c2443.c 
b/arch/arm/mach-s3c24xx/common-s3c2443.c
index aeeb2be..aeb4a24 100644
--- a/arch/arm/mach-s3c24xx/common-s3c2443.c
+++ b/arch/arm/mach-s3c24xx/common-s3c2443.c
@@ -559,7 +559,7 @@ static struct clk hsmmc1_clk = {
 
 static struct clk hsspi_clk = {
.name   = spi,
-   .devname= s3c64xx-spi.0,
+   .devname= s3c2443-spi.0,
.parent = clk_p,
.enable = s3c2443_clkcon_enable_p,
.ctrlbit= S3C2443_PCLKCON_HSSPI,
@@ -633,7 +633,7 @@ static struct clk_lookup s3c2443_clk_lookup[] = {
CLKDEV_INIT(NULL, clk_uart_baud2, clk_p),
CLKDEV_INIT(NULL, clk_uart_baud3, clk_esys_uart.clk),
CLKDEV_INIT(s3c-sdhci.1, mmc_busclk.0, hsmmc1_clk),
-   CLKDEV_INIT(s3c64xx-spi.0, spi_busclk0, hsspi_clk),
+   CLKDEV_INIT(s3c2443-spi.0, spi_busclk0, hsspi_clk),
 };


 [1] 
 http://lists.infradead.org/pipermail/linux-arm-kernel/2012-March/089086.html

--

Regards,
Sylwester
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: Problem using S3C2416's HSSPI

2012-10-01 Thread José Miguel Gonçalves

On 10/01/2012 08:18 PM, Heiko Stübner wrote:

Hi José,

Am Montag, 1. Oktober 2012, 19:32:15 schrieb José Miguel Gonçalves:

I'm trying to use the HSSPI controller on a S3C2416 based board but I'm
having some problems.

I've added s3c64xx_device_spi0 to my array of platform devices and added
a call to s3c64xx_spi0_set_platdata(NULL, 0, 1) before
platform_add_devices(). When the kernel starts I see the following error:

s3c64xx-spi s3c6410-spi.0: Unable to acquire clock 'spi'
s3c64xx-spi: probe of s3c6410-spi.0 failed with error -2

what kernel version do you use?



I'm now using kernel 3.6.

José Gonçalves
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: Problem using S3C2416's HSSPI

2012-10-01 Thread Heiko Stübner
Am Montag, 1. Oktober 2012, 21:40:35 schrieb Sylwester Nawrocki:
 On 10/01/2012 09:18 PM, Heiko Stübner wrote:
  Hi José,
  
  Am Montag, 1. Oktober 2012, 19:32:15 schrieb José Miguel Gonçalves:
  I'm trying to use the HSSPI controller on a S3C2416 based board but I'm
  having some problems.
  
  I've added s3c64xx_device_spi0 to my array of platform devices and
  added a call to s3c64xx_spi0_set_platdata(NULL, 0, 1) before
  platform_add_devices(). When the kernel starts I see the following
  error:
  
  s3c64xx-spi s3c6410-spi.0: Unable to acquire clock 'spi'
  s3c64xx-spi: probe of s3c6410-spi.0 failed with error -2
  
  what kernel version do you use?
  
  I.e. the clock support for the s3c64xx-spi on s3c2443 and s3c2416 was
  added through [1] in march - so it's not this old.
 
 In this commit
 
 commit a5238e360b715e9a1bb39d7d3537f78cc9e9e286
 Author: Thomas Abraham thomas.abra...@linaro.org
 Date:   Fri Jul 13 07:15:14 2012 +0900
 
 spi: s3c64xx: move controller information into driver data
 
 Platform data is used to specify controller hardware specific
 information such as the tx/rx fifo level mask and bit offset of rx fifo
 level. Such information is not suitable to be supplied from device tree.
 Instead, it can be moved into the driver data and removed from platform
 data.
 
 Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
 Acked-by: Jaswinder Singh jaswinder.si...@linaro.org
 Acked-by: Grant Likely grant.lik...@secretlab.ca
 Signed-off-by: Kukjin Kim kgene@samsung.com
 
 All s3c64xx-spi.0 devname fields that you added were replaced with
 s3c24xx-spi.0. I wonder if that's not the reason clk_get(..., spi);
 fails in the spi-s3c64xx driver used on mach-s3c24xx. But it of course
 depends on the kernel version, we need to first clarify that.
 
 diff --git a/arch/arm/mach-s3c24xx/common-s3c2443.c
 b/arch/arm/mach-s3c24xx/common-s3c2443.c index aeeb2be..aeb4a24 100644
 --- a/arch/arm/mach-s3c24xx/common-s3c2443.c
 +++ b/arch/arm/mach-s3c24xx/common-s3c2443.c
 @@ -559,7 +559,7 @@ static struct clk hsmmc1_clk = {
 
  static struct clk hsspi_clk = {
 .name   = spi,
 -   .devname= s3c64xx-spi.0,
 +   .devname= s3c2443-spi.0,
 .parent = clk_p,
 .enable = s3c2443_clkcon_enable_p,
 .ctrlbit= S3C2443_PCLKCON_HSSPI,
 @@ -633,7 +633,7 @@ static struct clk_lookup s3c2443_clk_lookup[] = {
 CLKDEV_INIT(NULL, clk_uart_baud2, clk_p),
 CLKDEV_INIT(NULL, clk_uart_baud3, clk_esys_uart.clk),
 CLKDEV_INIT(s3c-sdhci.1, mmc_busclk.0, hsmmc1_clk),
 -   CLKDEV_INIT(s3c64xx-spi.0, spi_busclk0, hsspi_clk),
 +   CLKDEV_INIT(s3c2443-spi.0, spi_busclk0, hsspi_clk),
  };

ahaa ... that's the cause. As far as I was able to determine, in the patchset 
only the clocks were renamed and the different device names introduced.

The spi devices did not get a function to set the name, like for the rtc, adc 
and nand. The devices are named s3c6410-spi by default, so it seems only the 
s3c64xx machines should have a working spi currently.

I'm working on a patch to fix this for all Samsung arches.


Heiko
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html