Re: [PATCH 2/2] ARM: Exynos4: Register clocks via common clock framework

2012-10-08 Thread Thomas Abraham
Hi Tomasz, On 3 October 2012 17:25, Tomasz Figa t.f...@samsung.com wrote: Hi Chander, Thomas, I think this patch could be split into several smaller, while retaining logical integrity of particular patches, e.g.: - the change introduced to __clk_init (with proper description and rationale

Re: [PATCH 2/2] ARM: Exynos4: Register clocks via common clock framework

2012-10-08 Thread Thomas Abraham
Hi Tomasz, On 3 October 2012 19:40, Tomasz Figa t.f...@samsung.com wrote: Hi Chander, Thomas, I can see one more problem here. Based on the fact that sdhci-s3c driver receives only the endpoint gate clock (hsmmc), doesn't the following setup make the driver unable to change the frequency

Re: [PATCH 2/2] ARM: Exynos4: Register clocks via common clock framework

2012-10-08 Thread Thomas Abraham
Hi Sylwester, Thanks for reviewing this patch series. On 6 October 2012 00:21, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: Hello, On 10/01/2012 02:09 PM, chander.kash...@linaro.org wrote: From: Thomas Abrahamthomas.abra...@linaro.org Register clocks for Exynos4 platfotms using

Re: [PATCH 2/2] ARM: Exynos4: Register clocks via common clock framework

2012-10-08 Thread Tomasz Figa
On Monday 08 of October 2012 12:04:18 Thomas Abraham wrote: Hi Tomasz, On 3 October 2012 19:40, Tomasz Figa t.f...@samsung.com wrote: Hi Chander, Thomas, I can see one more problem here. Based on the fact that sdhci-s3c driver receives only the endpoint gate clock (hsmmc),

Re: [PATCH v2 2/5] clk: exynos4: register clocks using common clock framework

2012-10-08 Thread Tomasz Figa
Hi Thomas, The whole series looks much better now. Although there is still one more thing from my comments to previous version unresolved, see the inline comment. On Monday 08 of October 2012 02:10:52 Thomas Abraham wrote: For legacy Exynos4 platforms, the available clocks are statically

[PATCH 00/16] pinctrl: samsung: Usability and extensibiltiy improvements

2012-10-08 Thread Tomasz Figa
This patch series is a work on improving usability and extensibiltiy of the pinctrl-samsung driver. It consists of three main parts: - moving SoC-specific data to device tree - converting the driver to use one GPIO chip and one IRQ domain per pin bank - introducing generic wake-up interrupt

[PATCH 01/16] ARM: dts: exynos4210: Replace legacy GPIO bank nodes with pinctrl bank nodes

2012-10-08 Thread Tomasz Figa
Seuqential patches from this series introduce SoC-specific data parsing from device tree. This patch removes legacy GPIO bank nodes from exynos4210.dtsi and replaces them with nodes and properties required for these patches. Signed-off-by: Tomasz Figa t.f...@samsung.com ---

[PATCH 02/16] pinctrl: exynos: Parse wakeup-eint parameters from DT

2012-10-08 Thread Tomasz Figa
This patch converts the pinctrl-exynos driver to parse wakeup interrupt count and register offsets from device tree. It reduces the amount of static platform-specific data and facilitates adding further SoC variants to pinctrl-samsung driver. Signed-off-by: Tomasz Figa t.f...@samsung.com ---

[PATCH 04/16] pinctrl: samsung: Parse pin banks from DT

2012-10-08 Thread Tomasz Figa
Currently SoC-specific properties such as list of pin banks, register offsets and bitfield sizes are being taken from static data structures residing in pinctrl-exynos.c. This patch modifies the pinctrl-samsung driver to parse all SoC-specific data from device tree, which will allow to remove the

[PATCH 06/16] pinctrl: samsung: Parse bank-specific eint offset from DT

2012-10-08 Thread Tomasz Figa
Some SoCs, like Exynos4x12, have non-sequential layout of EINT control registers and so current way of calculating register addresses does not work correctly for them. This patch adds parsing of samsung,eint-offset property from bank nodes and uses the read values instead of calculating the

[PATCH 07/16] pinctrl: samsung: Hold OF node of pin bank in bank struct

2012-10-08 Thread Tomasz Figa
The node pointer will be used in extensions added by patches that will follow. Signed-off-by: Tomasz Figa t.f...@samsung.com --- drivers/pinctrl/pinctrl-samsung.c | 1 + drivers/pinctrl/pinctrl-samsung.h | 3 +++ 2 files changed, 4 insertions(+) diff --git a/drivers/pinctrl/pinctrl-samsung.c

[PATCH 08/16] pinctrl: samsung: Hold pointer to driver data in bank struct

2012-10-08 Thread Tomasz Figa
The pointer will be used by further extensions added to the driver. Signed-off-by: Tomasz Figa t.f...@samsung.com --- drivers/pinctrl/pinctrl-samsung.c | 20 +++- drivers/pinctrl/pinctrl-samsung.h | 2 ++ 2 files changed, 13 insertions(+), 9 deletions(-) diff --git

[PATCH 03/16] pinctrl: samsung: Detect and handle unsupported configuration types

2012-10-08 Thread Tomasz Figa
This patch modifies the pinctrl-samsung driver to detect when width of a bit field is set to zero (which means that such configuraton type is not supported) and return an error instead of trying to modify an inexistent register. Signed-off-by: Tomasz Figa t.f...@samsung.com ---

[PATCH 09/16] pinctrl: exynos: Use one IRQ domain per pin bank

2012-10-08 Thread Tomasz Figa
Instead of registering one IRQ domain for all pin banks of a pin controller, this patch implements registration of per-bank domains. At a cost of a little memory overhead (~2.5KiB for all GPIO interrupts of Exynos4x12) it simplifies driver code and device tree sources, because GPIO interrupts can

[PATCH 10/16] pinctrl: samsung: Do not pass gpio_chip to pin_to_reg_bank

2012-10-08 Thread Tomasz Figa
The pointer to gpio_chip passed to pin_to_reg_bank utility function is used only to retrieve a pointer to samsung_pinctrl_drv_data structure. This patch modifies the function and its users to pass a pointer to samsung_pinctrl_drv_data directly. Signed-off-by: Tomasz Figa t.f...@samsung.com ---

[PATCH 11/16] pinctrl: samsung: Use one GPIO chip per pin bank

2012-10-08 Thread Tomasz Figa
This patch modifies the pinctrl-samsung driver to register one GPIO chip per pin bank, instead of a single chip for all pin banks of the controller. It simplifies GPIO accesses a lot (constant time instead of looping through the list of banks to find the right one) and should have a good effect

[PATCH 12/16] pinctrl: samsung: Use per-bank IRQ domain for wake-up interrupts

2012-10-08 Thread Tomasz Figa
This patch reworks wake-up interrupt handling in pinctrl-exynos driver, so each pin bank, which provides wake-up interrupts, has its own IRQ domain. Information about whether given pin bank provides wake-up interrupts, how many and whether they are separate or muxed are parsed from device tree.

[PATCH 13/16] pinctrl: exynos: Set pin function to EINT in irq_set_type of wake-up EINT

2012-10-08 Thread Tomasz Figa
Pins used as wake-up interrupts need to be configured as EINTs. This patch adds the required configuration code to exynos_wkup_irq_set_type, to set the pin as EINT when its interrupt trigger type is configured. Signed-off-by: Tomasz Figa t.f...@samsung.com --- drivers/pinctrl/pinctrl-exynos.c |

[PATCH 14/16] pinctrl: samsung: Parse offsets of particular registers from DT

2012-10-08 Thread Tomasz Figa
The order and availability of pin control registers vary with SoC. This patch modifies the driver to parse register offsets from device tree as a part of bank type definition. Signed-off-by: Tomasz Figa t.f...@samsung.com --- drivers/pinctrl/pinctrl-exynos.c | 12 ++---

[PATCH 15/16] pinctrl: samsung: Add GPIO to IRQ translation

2012-10-08 Thread Tomasz Figa
Some drivers require a way to translate GPIO pins to their IRQ numbers. This patch adds the .to_irq() gpiolib callback to pinctrl-samsung driver, which creates (if not present yet) and returns an IRQ mapping for given GPIO pin. Signed-off-by: Tomasz Figa t.f...@samsung.com ---

[PATCH 16/16] Documentation: Update samsung-pinctrl device tree bindings documentation

2012-10-08 Thread Tomasz Figa
Signed-off-by: Tomasz Figa t.f...@samsung.com --- .../bindings/pinctrl/samsung-pinctrl.txt | 212 ++--- 1 file changed, 187 insertions(+), 25 deletions(-) diff --git a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt

[PATCH] mmc: dw_mmc: enable controller interrupt before calling mmc_start_host

2012-10-08 Thread Yuvaraj CD
As mmc_start_host is getting called before enabling the dw_mmc controller interrupt, there is a problem of missing the SDMMC_INT_CMD_DONE for the very first command sent by the sdio_reset. This problem occurs only when we disable MMC debugging i.e, MMC_DEBUG [=n]. Hence this patch enables the

Re: [PATCH] mmc: dw_mmc: enable controller interrupt before calling mmc_start_host

2012-10-08 Thread Girish K S
On 8 October 2012 17:59, Yuvaraj CD yuvaraj...@gmail.com wrote: As mmc_start_host is getting called before enabling the dw_mmc controller interrupt, there is a problem of missing the SDMMC_INT_CMD_DONE for the very first command sent by the sdio_reset. This problem occurs only when we disable

Re: [PATCH] mmc: dw_mmc: enable controller interrupt before calling mmc_start_host

2012-10-08 Thread Will Newton
On Mon, Oct 8, 2012 at 9:59 AM, Yuvaraj CD yuvaraj...@gmail.com wrote: As mmc_start_host is getting called before enabling the dw_mmc controller interrupt, there is a problem of missing the SDMMC_INT_CMD_DONE for the very first command sent by the sdio_reset. This problem occurs only when we

[PATCH 0/4] ARM: EXYNOS: Kconfig cleanup

2012-10-08 Thread Tomasz Figa
This patch series aims to consolidate low level Kconfig entries for Exynos SoC series by adding missing or removing wrong dependencies, renaming entries to match a single naming convention and introducing a common parent entry for EXYNOS4212 and EXYNOS4412. See particular patches for more

[PATCH 1/4] ARM: EXYNOS: Kconfig: Rename CPU_EXYNOS4210 to SOC_EXYNOS4210

2012-10-08 Thread Tomasz Figa
This patch renames CONFIG_CPU_EXYNOS4210 to CONFIG_SOC_EXYNOS4210 to match the convention used by rest of Exynos SoCs and correctly represent the reality (Exynos4210 is a SoC, not a CPU). Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

[PATCH 2/4] ARM: EXYNOS: Kconfig: Sort out dependencies between options

2012-10-08 Thread Tomasz Figa
This patch modifies the dependencies between Exynos-related Kconfig options to represent the real dependencies between code units more closely. Originally it was possible to enable ARCH_EXYNOS{4,5} without any SOC_EXYNOS_{4,5}.* enabled, which could end with compilation or link errors. Now

[PATCH 3/4] ARM: EXYNOS: Kconfig: Group EXYNOS{4212,4412} into EXYNOS4X12

2012-10-08 Thread Tomasz Figa
This patch adds CONFIG_EXYNOS4X12, which is automatically selected whenever there is at least one SoC from Exynos4x12 line enabled. All the shared dependencies of EXYNOS{4212,4412} are moved to this new option. This fixes build with Exynos4412 enabled and Exynos4212 and Exynos4210 disabled and

[PATCH 4/4] ARM: EXYNOS: Kconfig: Remove dependencies on particular SoCs from DT machines

2012-10-08 Thread Tomasz Figa
MACH_EXYNOS{4,5}_DT are used for whole SoC lines, so they should depend on ARCH_EXYNOS{4,5} rather than on particular SoCs. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos/Kconfig | 2 -- 1 file changed, 2 deletions(-)

[PATCH] ARM: dts: exynos4: Enable serial controllers on Origen and SMDKV310

2012-10-08 Thread Tomasz Figa
This patch adds status override of serial nodes to enable used serial ports on Origen and SMDKV310 board. Signed-off-by: Tomasz Figa t.f...@samsung.com --- arch/arm/boot/dts/exynos4210-origen.dts | 16 arch/arm/boot/dts/exynos4210-smdkv310.dts | 16 2 files

Re: [PATCH] ARM: dts: exynos4: Enable serial controllers on Origen and SMDKV310

2012-10-08 Thread Tomasz Figa
Hi Kgene, On Monday 08 of October 2012 15:12:48 Tomasz Figa wrote: This patch adds status override of serial nodes to enable used serial ports on Origen and SMDKV310 board. Signed-off-by: Tomasz Figa t.f...@samsung.com --- arch/arm/boot/dts/exynos4210-origen.dts | 16

[PATCH 15/32 v3] USB: ohci: merge ohci_finish_controller_resume with ohci_resume

2012-10-08 Thread Florian Fainelli
Merge ohci_finish_controller_resume with ohci_resume as suggested by Alan Stern. Since ohci_finish_controller_resume no longer exists, update the various OHCI drivers to call ohci_resume() instead. Some drivers used to set themselves the bit HCD_FLAG_HW_ACCESSIBLE, which is now handled by

[PATCH 0/5] Adding usb2.0 host-phy support for exynos5250

2012-10-08 Thread Vivek Gautam
This patchset is based on the work by Praveen Paneri for samsung-usbphy driver: http://comments.gmane.org/gmane.linux.kernel.samsung-soc/12653 Tested on smdk5250 target with usb-next branch along with arch patches for exynos5250: http://thread.gmane.org/gmane.linux.kernel.samsung-soc/13042

[PATCH 1/5] usb: phy: samsung: Add host phy support to samsung-phy driver

2012-10-08 Thread Vivek Gautam
This patch adds host phy support for samsung's exynos5250. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- drivers/usb/phy/Kconfig |1 - drivers/usb/phy/samsung-usbphy.c | 362 -- include/linux/platform_data/samsung-usbphy.h

[PATCH 2/5] ARM: S3C64XX: Add phy_type to pmu_isolation

2012-10-08 Thread Vivek Gautam
It adds 'type' argument to pmu_isolation function, aligning with other platforms, which keeps track of usbphy_type. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- arch/arm/mach-s3c64xx/setup-usb-phy.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH 3/5] ARM: Exynos5250: Enabling samsung-usbphy driver

2012-10-08 Thread Vivek Gautam
Adding usbphy node for Exynos5250 along with the platform data. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- .../devicetree/bindings/usb/samsung-usbphy.txt | 12 - arch/arm/boot/dts/exynos5250.dtsi |5 ++ arch/arm/mach-exynos/Kconfig

[PATCH 4/5] usb: s5p-ehci: Adding phy driver support

2012-10-08 Thread Vivek Gautam
Adding the transceiver to ehci driver. Keeping the platform data for continuing the smooth operation for boards which still uses it Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- drivers/usb/host/ehci-s5p.c | 62 +- 1 files changed, 43

[PATCH 5/5] usb: exynos-ohci: Adding phy driver support

2012-10-08 Thread Vivek Gautam
Adding the transceiver to ohci driver. Keeping the platform data for continuing the smooth operation for boards which still uses it Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- drivers/usb/host/ohci-exynos.c | 62 +++ 1 files changed, 43

Re: [PATCH 2/5] ARM: S3C64XX: Add phy_type to pmu_isolation

2012-10-08 Thread kishon
Hi, On Monday 08 October 2012 07:42 PM, Vivek Gautam wrote: It adds 'type' argument to pmu_isolation function, aligning with other platforms, which keeps track of usbphy_type. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- arch/arm/mach-s3c64xx/setup-usb-phy.c |2 +- 1 files