Re: [PATCH v5] ARM: EXYNOS: Add MFC device tree support

2012-10-23 Thread 김승우
Hi Arun, On 2012년 09월 28일 02:09, Arun Kumar K wrote: This patch adds device tree entry for MFC v6 in the Exynos5 SoC. Makes the required changes in the clock files and adds MFC to the DT device list. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com Signed-off-by: Arun Kumar K

Re: [PATCH v5] ARM: EXYNOS: Add MFC device tree support

2012-10-23 Thread Arun Kumar K
Hi Seungwoo Kim, Thank you for the review. + + /* Reserve memory for MFC only if it's available */ + mfc_mem.compatible = samsung,mfc-v6; + if (of_scan_flat_dt(s5p_fdt_find_mfc_mem, mfc_mem)) of_scan_flat_dt() is called but it does not have __init on its definition. So this

RE: [PATCH] ARM: EXYNOS: Remove wrong I2S0 clock from peril clock

2012-10-23 Thread Kukjin Kim
Sangbeom Kim wrote: On Friday, Oct 05, 2012 at 4:37 PM, Sangsu Park wrote: Remove I2S0 clk from peril since peril clock doesn't have I2S0 clk for EXYNOS4. Audio Subsystem block has I2S0 clk. Signed-off-by: Sangsu Park sangsu4u.p...@samsung.com Peril control bit 19 is reserved.

RE: [PATCH 1/2] ARM: samsung: clock: add clock_tree debugfs file

2012-10-23 Thread Kukjin Kim
최종환 wrote: From: Colin Cross ccr...@android.com Add a clock/clock_tree debugfs file that shows the entire clock hierarchy including usage counts and rates. Signed-off-by: Colin Cross ccr...@android.com Signed-off-by: Jonghwan Choi jhbird.c...@samsung.com ---

RE: [PATCH 2/2] ARM: samsung: call clk_get_rate for debugfs rate files

2012-10-23 Thread Kukjin Kim
최종환 wrote: From: Colin Cross ccr...@android.com c-rate is rarely set, call clk_get_rate on the clock to print the value in /d/clock/.../rate. Signed-off-by: Colin Cross ccr...@android.com Signed-off-by: Jonghwan Choi jhbird.c...@samsung.com --- arch/arm/plat-samsung/clock.c | 10

RE: [PATCH v2] ASoC: Samsung: Update Kconfig for Exynos5250 and Exynos4412

2012-10-23 Thread Kukjin Kim
Tushar Behera wrote: On 09/28/2012 03:23 PM, Sangsu Park wrote: On Thu, Sep 27, 2012 at 07:30 PM, Padmavathi Venna wrote: [...] @@ -63,7 +63,7 @@ config SND_SOC_SAMSUNG_SMDK_WM8580 config SND_SOC_SAMSUNG_SMDK_WM8994 tristate SoC I2S Audio support for WM8994 on SMDK -

RE: [PATCH v2] ARM: EXYNOS: Add support for secondary CPU bring-up on Exynos4412

2012-10-23 Thread Kukjin Kim
Tomasz Figa wrote: Exynos4412 uses different information register for each core. This patch adjusts the bring-up code to take that into account. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos/platsmp.c | 27

RE: [PATCH] ARM: dts: exynos4: Enable serial controllers on Origen and SMDKV310

2012-10-23 Thread Kukjin Kim
Tomasz Figa wrote: However I think this should be considered a fix, because without it serial console on Origen and SMDKV310 will be broken. Well, I couldn't find any broken due to miss this for v3.7. I think, there is no usage of serial controller in mainline for Origen and SMDKV310 now. So

RE: [PATCH 1/4] ARM: EXYNOS: Kconfig: Rename CPU_EXYNOS4210 to SOC_EXYNOS4210

2012-10-23 Thread Kukjin Kim
Tomasz Figa wrote: This patch renames CONFIG_CPU_EXYNOS4210 to CONFIG_SOC_EXYNOS4210 to match the convention used by rest of Exynos SoCs and correctly represent the reality (Exynos4210 is a SoC, not a CPU). Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park

RE: [PATCH 2/4] ARM: EXYNOS: Kconfig: Sort out dependencies between options

2012-10-23 Thread Kukjin Kim
Tomasz Figa wrote: This patch modifies the dependencies between Exynos-related Kconfig options to represent the real dependencies between code units more closely. Originally it was possible to enable ARCH_EXYNOS{4,5} without any SOC_EXYNOS_{4,5}.* enabled, which could end with compilation

RE: [PATCH 3/4] ARM: EXYNOS: Kconfig: Group EXYNOS{4212,4412} into EXYNOS4X12

2012-10-23 Thread Kukjin Kim
Tomasz Figa wrote: This patch adds CONFIG_EXYNOS4X12, which is automatically selected whenever there is at least one SoC from Exynos4x12 line enabled. All the shared dependencies of EXYNOS{4212,4412} are moved to this new option. This fixes build with Exynos4412 enabled and Exynos4212 and

RE: [PATCH 4/4] ARM: EXYNOS: Kconfig: Remove dependencies on particular SoCs from DT machines

2012-10-23 Thread Kukjin Kim
Tomasz Figa wrote: MACH_EXYNOS{4,5}_DT are used for whole SoC lines, so they should depend on ARCH_EXYNOS{4,5} rather than on particular SoCs. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos/Kconfig | 2 -- 1

RE: [PATCH v4 1/5] ARM: EXYNOS: Add set_irq_affinity function for combiner_irq

2012-10-23 Thread Kukjin Kim
Chanho Park wrote: This patch adds set_irq_affinity function for combiner_irq. We need this function to enable a arm-pmu because the pmu of exynos has combined type irqs. Reviewed-by: Thomas Abraham thomas.abra...@linaro.org Signed-off-by: Chanho Park chanho61.p...@samsung.com

RE: [PATCH v4 2/5] ARM: EXYNOS: Correct combined IRQs for exynos4

2012-10-23 Thread Kukjin Kim
Chanho Park wrote: This patch corrects combined IRQs for exynos4 series platform. The exynos4412 has four extra combined irq group and the exynos4212 has two more combined irqs than exynos4210. Each irq is mapped to IRQ_SPI(xx). Unfortunately, extra 4 combined IRQs isn't sequential. So, we

RE: [PATCH v4 3/5] ARM: EXYNOS: Enable PMUs for exynos4

2012-10-23 Thread Kukjin Kim
Chanho Park wrote: This patch defines irq numbers of ARM performance monitoring unit for exynos4. Firs of all, we need to fix IRQ_PMU correctly and to split pmu initialization of exynos from plat-samsung for easily defining it. The number of CPU cores and PMU irq numbers are vary

RE: [PATCH v4 4/5] ARM: EXYNOS: Add arm-pmu DT binding for exynos5250

2012-10-23 Thread Kukjin Kim
Chanho Park wrote: This patch enables arm-pmu to bind device tree for exynos5250. The exynos5250 has two pmus which have combiner irq type. Reviewed-by: Thomas Abraham thomas.abra...@linaro.org Signed-off-by: Chanho Park chanho61.p...@samsung.com Signed-off-by: Kyungmin Park

RE: [PATCH v4 5/5] ARM: EXYNOS: Add arm-pmu DT binding for exynos421x

2012-10-23 Thread Kukjin Kim
Chanho Park wrote: This patch adds a arm-pmu node to bind device tree for exynos4210. The exynos4210 and 4212 have two cpus which includes a pmu. In contrast, the exynos4412 has 4 cpus and pmus. We need to define two more pmus for this type board. However, supporting arm-pmu for the

RE: [PATCH v4 0/6] arm: exynos: add dt based support for exynos5 hdmi

2012-10-23 Thread Kukjin Kim
Rahul Sharma wrote: This patch set adds the DT based support for Samsung's Exynos5250. It adds device tree nodes for hdmi, mixer, hdmiphy and hdmiddc. The name of these devices are changed to the one matching with drivers. Exynos-drm and exynos hdmi-drm-commmon devices are removed from

RE: [PATCH V3] gpio: samsung: use pr_* instead of printk

2012-10-23 Thread Kukjin Kim
Linus Walleij wrote: On Mon, Oct 22, 2012 at 3:02 AM, Jingoo Han jg1@samsung.com wrote: On Friday, October 19, 2012 7:09 PM Linus Walleij wrote On Wed, Oct 17, 2012 at 3:52 AM, Jingoo Han jg1@samsung.com wrote: This patch uses pr_* instead of printk. Also, gpio_dbg is

RE: [PATCH 2/2] gpio: samsung: Fix input mode setting function for GPIO int

2012-10-23 Thread Kukjin Kim
Linus Walleij wrote: On Thu, Sep 27, 2012 at 5:55 AM, Eunki Kim eunki_...@samsung.com wrote: This patch makes GPIO pin to INTERRUPT mode or INPUT mode according to bitmap_gpio_int. When the related bit of bitmap_gpio_int is set, it makes GPIO pin to INTERRUPT mode instrad of INPUT mode

RE: [PATCH 1/2] ARM: SAMSUNG: Insert bitmap_gpio_int member in samsung_gpio_chip

2012-10-23 Thread Kukjin Kim
Eunki Kim wrote: When a device uses GPIO interrupt, its driver assumes that GPIO should be INPUT mode. However, GPIO of SAMSUNG SoC is sepated to INPUT mode and INTERRUPT mode. They are set by 0x0 and 0xF in GPIO control register. If the register is set to INPUT mode, the interrupt never

RE: [PATCH v5] ARM: EXYNOS: Add MFC device tree support

2012-10-23 Thread Kukjin Kim
Arun Kumar K wrote: This patch adds device tree entry for MFC v6 in the Exynos5 SoC. Makes the required changes in the clock files and adds MFC to the DT device list. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com Signed-off-by: Arun Kumar K arun...@samsung.com ---

ERROR: read_current_timer [fs/ext4/ext4.ko] undefined

2012-10-23 Thread Kukjin Kim
Hi all, Now, v3.7-rc2 happens following build error with s3c2410_defconfig... ERROR: read_current_timer [fs/ext4/ext4.ko] undefined! make[2]: *** [__modpost] Error 1 make[1]: *** [modules] Error 2 make[1]: *** Waiting for unfinished jobs Any idea on this? Thanks. K-Gene kg...@kernel.org

Re: [PATCH v2] ASoC: Samsung: Update Kconfig for Exynos5250 and Exynos4412

2012-10-23 Thread Olof Johansson
2012/10/23 Kukjin Kim kgene@samsung.com: Tushar Behera wrote: On 09/28/2012 03:23 PM, Sangsu Park wrote: On Thu, Sep 27, 2012 at 07:30 PM, Padmavathi Venna wrote: [...] @@ -63,7 +63,7 @@ config SND_SOC_SAMSUNG_SMDK_WM8580 config SND_SOC_SAMSUNG_SMDK_WM8994 tristate SoC

Re: ERROR: read_current_timer [fs/ext4/ext4.ko] undefined

2012-10-23 Thread Marc Zyngier
On 23/10/12 15:48, Kukjin Kim wrote: Hi all, Now, v3.7-rc2 happens following build error with s3c2410_defconfig... ERROR: read_current_timer [fs/ext4/ext4.ko] undefined! make[2]: *** [__modpost] Error 1 make[1]: *** [modules] Error 2 make[1]: *** Waiting for unfinished jobs Any

Re: ERROR: read_current_timer [fs/ext4/ext4.ko] undefined

2012-10-23 Thread Will Deacon
On Tue, Oct 23, 2012 at 03:48:21PM +0100, Kukjin Kim wrote: Hi all, Now, v3.7-rc2 happens following build error with s3c2410_defconfig... ERROR: read_current_timer [fs/ext4/ext4.ko] undefined! make[2]: *** [__modpost] Error 1 make[1]: *** [modules] Error 2 make[1]: *** Waiting for

Re: [PATCH] ARM: dts: exynos4: Enable serial controllers on Origen and SMDKV310

2012-10-23 Thread Tomasz Figa
On Tuesday 23 of October 2012 21:03:01 Kukjin Kim wrote: Tomasz Figa wrote: However I think this should be considered a fix, because without it serial console on Origen and SMDKV310 will be broken. Well, I couldn't find any broken due to miss this for v3.7. I think, there is no usage of

Re: [PATCH v2] ARM: EXYNOS: Add support for secondary CPU bring-up on Exynos4412

2012-10-23 Thread Tomasz Figa
Hi Kgene, On Tuesday 23 of October 2012 20:57:33 Kukjin Kim wrote: Tomasz Figa wrote: Exynos4412 uses different information register for each core. This patch adjusts the bring-up code to take that into account. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin

Re: [PATCH 1/4] ARM: EXYNOS: Kconfig: Rename CPU_EXYNOS4210 to SOC_EXYNOS4210

2012-10-23 Thread Tomasz Figa
Hi Kgene, Thanks for your comments. On Tuesday 23 of October 2012 21:24:54 Kukjin Kim wrote: Tomasz Figa wrote: This patch renames CONFIG_CPU_EXYNOS4210 to CONFIG_SOC_EXYNOS4210 to match the convention used by rest of Exynos SoCs and correctly represent the reality (Exynos4210 is a SoC,

Re: [PATCH 2/4] ARM: EXYNOS: Kconfig: Sort out dependencies between options

2012-10-23 Thread Tomasz Figa
On Tuesday 23 of October 2012 21:35:32 Kukjin Kim wrote: Tomasz Figa wrote: This patch modifies the dependencies between Exynos-related Kconfig options to represent the real dependencies between code units more closely. Originally it was possible to enable ARCH_EXYNOS{4,5} without any

Re: [PATCH 3/4] ARM: EXYNOS: Kconfig: Group EXYNOS{4212,4412} into EXYNOS4X12

2012-10-23 Thread Tomasz Figa
On Tuesday 23 of October 2012 21:42:04 Kukjin Kim wrote: Tomasz Figa wrote: This patch adds CONFIG_EXYNOS4X12, which is automatically selected whenever there is at least one SoC from Exynos4x12 line enabled. All the shared dependencies of EXYNOS{4212,4412} are moved to this new option.

Re: [PATCH 4/4] ARM: EXYNOS: Kconfig: Remove dependencies on particular SoCs from DT machines

2012-10-23 Thread Tomasz Figa
On Tuesday 23 of October 2012 22:27:41 Kukjin Kim wrote: Tomasz Figa wrote: MACH_EXYNOS{4,5}_DT are used for whole SoC lines, so they should depend on ARCH_EXYNOS{4,5} rather than on particular SoCs. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park

Re: [PATCH] mmc: sdhci-s3c: use clk_prepare_enable and clk_disable_unprepare

2012-10-23 Thread Chris Ball
Hi, On Tue, Oct 02 2012, Thomas Abraham wrote: Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare calls as required by common clock framework. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org Thanks, pushed to mmc-next for 3.8. - Chris. -- Chris Ball

Re: [PATCH] mmc: dw_mmc: enable controller interrupt before calling mmc_start_host

2012-10-23 Thread Chris Ball
Hi, On Mon, Oct 08 2012, Yuvaraj CD wrote: As mmc_start_host is getting called before enabling the dw_mmc controller interrupt, there is a problem of missing the SDMMC_INT_CMD_DONE for the very first command sent by the sdio_reset. This problem occurs only when we disable MMC debugging i.e,

Re: [PATCH v5] ARM: EXYNOS: Add MFC device tree support

2012-10-23 Thread Kukjin Kim
On 10/23/12 19:12, Arun Kumar K wrote: Hi Seungwoo Kim, Thank you for the review. + + /* Reserve memory for MFC only if it's available */ + mfc_mem.compatible = samsung,mfc-v6; + if (of_scan_flat_dt(s5p_fdt_find_mfc_mem,mfc_mem)) of_scan_flat_dt() is called but it does not have

RE: [PATCH v4 2/5] ARM: EXYNOS: Correct combined IRQs for exynos4

2012-10-23 Thread Chanho Park
-Original Message- From: linux-arm-kernel-boun...@lists.infradead.org [mailto:linux-arm- kernel-boun...@lists.infradead.org] On Behalf Of Kukjin Kim Sent: Tuesday, October 23, 2012 10:59 PM To: 'Chanho Park'; ben-li...@fluff.org; linux-arm-ker...@lists.infradead.org;

Re: [PATCH v2 2/4] DMA: PL330: Change allocation method to properly free DMA descriptors

2012-10-23 Thread Vinod Koul
On Fri, 2012-10-05 at 15:47 +0530, Inderpal Singh wrote: In probe, memory for multiple DMA descriptors were being allocated at once and then it was being split and added into DMA pool one by one. The address of this memory allocation is not being saved anywhere. To free this memory, the

Re: [PATCH v2 3/4] DMA: PL330: Balance module remove function with probe

2012-10-23 Thread Vinod Koul
On Fri, 2012-10-05 at 15:47 +0530, Inderpal Singh wrote: Since peripheral channel resources are not being allocated at probe, no need to flush the channels and free the resources in remove function. In case, the channel is in use by some client, return EBUSY. Signed-off-by: Inderpal Singh

Re: [PATCH v2 1/4] DMA: PL330: Free memory allocated for peripheral channels

2012-10-23 Thread Vinod Koul
On Fri, 2012-10-05 at 15:47 +0530, Inderpal Singh wrote: The allocated memory for peripheral channels is not being freed upon failure in probe and in module's remove funtion. It will lead to memory leakage. Hence free the allocated memory. Signed-off-by: Inderpal Singh

[PATCH v5 0/5] Add support to enable ARM PMU for EXYNOS

2012-10-23 Thread Chanho Park
This patchset fixes irq numbers of ARM Performance Monitoring unit and enable it for Perf(Performance Counter) on the exynos 4 and 5. The exynos4 and 5 have 2 more cpu cores which has its own pmu. The exynos uses combiner-irq type for arm-pmu. Especially, the exynos4412 has 4 extra combined irq

[PATCH v5 2/5] ARM: EXYNOS: Correct combined IRQs for exynos4

2012-10-23 Thread Chanho Park
This patch corrects combined IRQs for exynos4 series platform. The exynos4412 has four extra combined irq group and the exynos4212 has two more combined irqs than exynos4210. Each irq is mapped to IRQ_SPI(xx). Unfortunately, extra 4 combined IRQs isn't sequential. So, we need to map the irqs

[PATCH v5 5/5] ARM: EXYNOS: Add arm-pmu DT binding for exynos421x

2012-10-23 Thread Chanho Park
This patch adds a arm-pmu node to bind device tree for exynos4210. The exynos4210 and 4212 have two cpus which includes a pmu. In contrast, the exynos4412 has 4 cpus and pmus. We need to define two more pmus for this type board. However, supporting arm-pmu for the exynos4412 will handle it later

[PATCH v5 3/5] ARM: EXYNOS: Enable PMUs for exynos4

2012-10-23 Thread Chanho Park
This patch defines irq numbers of ARM performance monitoring unit for exynos4. Firs of all, we need to fix IRQ_PMU correctly and to split pmu initialization of exynos from plat-samsung for easily defining it. The number of CPU cores and PMU irq numbers are vary according to soc types. So, we need

[PATCH v5 4/5] ARM: EXYNOS: Add arm-pmu DT binding for exynos5250

2012-10-23 Thread Chanho Park
This patch enables arm-pmu to bind device tree for exynos5250. The exynos5250 has two pmus which have combiner irq type. Reviewed-by: Thomas Abraham thomas.abra...@linaro.org Signed-off-by: Chanho Park chanho61.p...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

[PATCH v5 1/5] ARM: EXYNOS: Add set_irq_affinity function for combiner_irq

2012-10-23 Thread Chanho Park
This patch adds set_irq_affinity function for combiner_irq. We need this function to enable a arm-pmu because the pmu of exynos has combined type irqs. Reviewed-by: Thomas Abraham thomas.abra...@linaro.org Signed-off-by: Chanho Park chanho61.p...@samsung.com Signed-off-by: Kyungmin Park