[PATCH] arm: exynos4: Fix suspend/resume hang

2013-01-10 Thread Inderpal Singh
commit d0341c61a2 removed the l2 cache save/restore from pm.c and commit 7c6035b63b added the l2 cache restoration in sleep.s to early enable the cache in resume path. With these changes the system hangs while resuming when vdd_arm is turned off in suspended state. The cache needs to be invalidate

Re: [PATCH] ARM: dts: sorting the device nodes in alphabetical order for EXYNOS DT

2013-01-10 Thread Olof Johansson
On Thu, Jan 10, 2013 at 3:38 PM, Kukjin Kim wrote: > To reduce merge conflicts it would be easier maintain the device nodes > under the root node sorted in alphabetical order. > > Cc: Tomasz Figa > Cc: Thomas Abraham > Cc: Olof Johansson > Signed-off-by: Kukjin Kim While this would be good to

Re: [REPOST PATCH v3 1/4] mmc: dw_mmc: Add "disable-wp" device tree property

2013-01-10 Thread Doug Anderson
Hi, A followup as I did more investigation here... On Thu, Jan 10, 2013 at 3:23 PM, Doug Anderson wrote: > Olof, > > Thanks for your comments. > > On Thu, Jan 10, 2013 at 3:01 PM, Olof Johansson wrote: >> >> The previous code used the controller-common quirk field to set a >> per-controller DW_

[PATCH] ARM: dts: sorting the device nodes in alphabetical order for EXYNOS DT

2013-01-10 Thread Kukjin Kim
To reduce merge conflicts it would be easier maintain the device nodes under the root node sorted in alphabetical order. Cc: Tomasz Figa Cc: Thomas Abraham Cc: Olof Johansson Signed-off-by: Kukjin Kim --- arch/arm/boot/dts/exynos4.dtsi| 270 +- arch/arm/boot/dts/e

Re: [REPOST PATCH v3 1/4] mmc: dw_mmc: Add "disable-wp" device tree property

2013-01-10 Thread Doug Anderson
Olof, Thanks for your comments. On Thu, Jan 10, 2013 at 3:01 PM, Olof Johansson wrote: > > The previous code used the controller-common quirk field to set a > per-controller DW_MCI_QUIRK_NO_WRITE_PROTECT. Is there really need to > do this per-slot? And if so, please explain in the commit message

Audio support on Mini6410 board [was Re: Hi again]

2013-01-10 Thread Sylwester Nawrocki
Hi Alexander, Cc: linux-samsung-soc@vger.kernel.org On 12/21/2012 07:39 PM, Alexander Nestorov wrote: Hi once again :) After some more work there is some (really small) progress. I'm able to make the kernel throw errors about something related with AC97 and/or ALSA This is the kernel log: htt

Re: [REPOST PATCH v3 1/4] mmc: dw_mmc: Add "disable-wp" device tree property

2013-01-10 Thread Olof Johansson
On Thu, Jan 10, 2013 at 10:24:26AM -0800, Doug Anderson wrote: > The "disable-wp" property is used to specify that a given SD card slot > doesn't have a concept of write protect. This eliminates the need for > special case code for SD slots that should never be write protected > (like a micro SD s

Re: [PATCH 5/5] ARM: exynos: enable/disable cpuidle when cpu1 is down/up

2013-01-10 Thread amit daniel kachhap
On Thu, Jan 10, 2013 at 1:32 PM, Daniel Lezcano wrote: > On 01/10/2013 09:07 PM, amit daniel kachhap wrote: >> Hi Daniel, > > Hi Amit Daniel, > >> This hotplug noifiers looks fine. I suppose it should add extra state >> C1 in cpu0. If it is done like below than for normal cases(when all >> cpu's a

Re: [PATCH 5/5] ARM: exynos: enable/disable cpuidle when cpu1 is down/up

2013-01-10 Thread Daniel Lezcano
On 01/10/2013 09:07 PM, amit daniel kachhap wrote: > Hi Daniel, Hi Amit Daniel, > This hotplug noifiers looks fine. I suppose it should add extra state > C1 in cpu0. If it is done like below than for normal cases(when all > cpu's are online) there wont be any statistics for C0 state I guess you

Re: [PATCH 5/5] ARM: exynos: enable/disable cpuidle when cpu1 is down/up

2013-01-10 Thread amit daniel kachhap
Hi Daniel, This hotplug noifiers looks fine. I suppose it should add extra state C1 in cpu0. If it is done like below than for normal cases(when all cpu's are online) there wont be any statistics for C0 state also which is required. Other patches look good. Thanks, Amit On Fri, Jan 4, 2013 at 8:

RE: [PATCH v6 00/12] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2013-01-10 Thread Kukjin Kim
'Joerg Roedel' wrote: > > On Thu, Jan 10, 2013 at 10:34:48AM -0800, Kukjin Kim wrote: > > Hmm, I think, just one [7/12] patch does matter so if you could create topic > > branch and apply [7/12] patch firstly before other drivers/ changes would > be > > better to me. It's OK on both trees if I jus

Re: [PATCH v6 00/12] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2013-01-10 Thread 'Joerg Roedel'
On Thu, Jan 10, 2013 at 10:34:48AM -0800, Kukjin Kim wrote: > Hmm, I think, just one [7/12] patch does matter so if you could create topic > branch and apply [7/12] patch firstly before other drivers/ changes would be > better to me. It's OK on both trees if I just _merge_ the first [7/12] > commit

RE: [PATCH 09/26] ARM: SAMSUNG: cleanup mach/gpio-fns.h gpio-track.h and gpio-nrs.h

2013-01-10 Thread Kukjin Kim
Linus Walleij wrote: > > On Wed, Jan 2, 2013 at 11:23 PM, Kukjin Kim > wrote: > > > remove , and > > > > Cc: Linus Walleij > > Cc: Grant Likely > > Signed-off-by: Kukjin Kim > > This really needs cleanup so Yes! And sorry for late ;-) Just note, I'm working on cleanup for other Samsung gp

RE: [PATCH 01/26] gpio: samsung: remove inclusion

2013-01-10 Thread Kukjin Kim
Linus Walleij wrote: > > On Wed, Jan 2, 2013 at 11:23 PM, Kukjin Kim > wrote: > > > The is not needed for gpio-samsung. > > > > Cc: Linus Walleij > > Cc: Grant Likely > > Signed-off-by: Kukjin Kim > > Applied to fixes, thanks. > Thanks :-) BTW, do you have any comments on following patche

Re: [PATCH v6 00/12] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2013-01-10 Thread 'Joerg Roedel'
On Thu, Jan 10, 2013 at 10:06:24AM -0800, Kukjin Kim wrote: > You know, we have several options to avoid it. When you take this series in > your tree, you can provide topic branch for me. Or this series should be > separated for arch/arm/ and drivers/ for both trees, then only drivers/iommu > chang

RE: [PATCH v6 00/12] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2013-01-10 Thread Kukjin Kim
Kukjin Kim wrote: > > 'Joerg Roedel' wrote: > > > > On Mon, Dec 31, 2012 at 10:18:46AM -0800, Kukjin Kim wrote: > > > Cho KyongHo wrote: > > > > > > Diffstats: > > > > arch/arm/boot/dts/exynos5250-smdk5250.dts |2 +- > > > > arch/arm/boot/dts/exynos5250.dtsi | 27 +- > > > > arch/

[REPOST PATCH v3 4/4] mmc: dw_mmc: Handle wp-gpios from device tree

2013-01-10 Thread Doug Anderson
On some SoCs (like exynos5250) you need to use an external GPIO for write protect. Add support for wp-gpios to the core dw_mmc driver since it could be useful across multiple SoCs. With this change I am able to make use of the write protect for the external SD slot on exynos5250-snow. Signed-off

[REPOST PATCH v3 2/4] ARM: dts: Add disable-wp for sd card slot on smdk5250

2013-01-10 Thread Doug Anderson
The next change will remove the code from the dw_mmc-exynos that added the DW_MCI_QUIRK_NO_WRITE_PROTECT. Keep existing functionality of having no write protect pin on smdk5250 by adding the disable-wp property. Signed-off-by: Doug Anderson Acked-by: Seungwon Jeon --- Changes in v3: - New for t

[REPOST PATCH v3 3/4] mmc: dw_mmc: exynos: Remove code for wp-gpios

2013-01-10 Thread Doug Anderson
The exynos code claimed the write protect with devm_gpio_request() but never did anything with it. That meant that anyone using a write protect GPIO would effectively be write protected all the time. The handling for wp-gpios belongs in the main dw_mmc driver and has been moved there. Signed-off

[REPOST PATCH v3 1/4] mmc: dw_mmc: Add "disable-wp" device tree property

2013-01-10 Thread Doug Anderson
The "disable-wp" property is used to specify that a given SD card slot doesn't have a concept of write protect. This eliminates the need for special case code for SD slots that should never be write protected (like a micro SD slot or a dev board). The dw_mmc driver is special in needing to specif

RE: [PATCH v6 00/12] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2013-01-10 Thread Kukjin Kim
'Joerg Roedel' wrote: > > On Mon, Dec 31, 2012 at 10:18:46AM -0800, Kukjin Kim wrote: > > Cho KyongHo wrote: > > > > Diffstats: > > > arch/arm/boot/dts/exynos5250-smdk5250.dts |2 +- > > > arch/arm/boot/dts/exynos5250.dtsi | 27 +- > > > arch/arm/mach-exynos/Kconfig

Re: [PATCH v6 00/12] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2013-01-10 Thread 'Joerg Roedel'
On Mon, Dec 31, 2012 at 10:18:46AM -0800, Kukjin Kim wrote: > Cho KyongHo wrote: > > Diffstats: > > arch/arm/boot/dts/exynos5250-smdk5250.dts |2 +- > > arch/arm/boot/dts/exynos5250.dtsi | 27 +- > > arch/arm/mach-exynos/Kconfig |5 - > > arch/arm/mach-exynos/Mak

[PATCH 1/1] ARM: S3C24XX: Fix warnings in irq-s3c2416.c

2013-01-10 Thread Sachin Kamat
Fixes the following warnings: arch/arm/mach-s3c24xx/irq-s3c2416.c:226:17: warning: symbol 's3c2416_irq_second' was not declared. Should it be static? arch/arm/mach-s3c24xx/irq-s3c2416.c:332:5: warning: symbol 's3c2416_irq_suspend' was not declared. Should it be static? arch/arm/mach-s3c24xx/irq-s3c

Re: [RFC PATCH 1/7] ARM: common: vic: Parse interrupt and resume masks from device tree

2013-01-10 Thread Mark Brown
On Thu, Jan 10, 2013 at 12:10:38PM +0100, Tomasz Figa wrote: > This is not the runtime interrupt/wakeup mask, but a global mask of > available interrupt/wakeup lines on particular platform, which still have > to be configured and enabled appropriately by user. Ah, OK. Reviewed-by: Mark Brown

Re: [RFC PATCH 3/7] ARM: s3c64xx: Add support for OF-based VIC initialization

2013-01-10 Thread Mark Brown
On Thu, Jan 10, 2013 at 12:41:45AM +0100, Tomasz Figa wrote: > This patch modifies IRQ initialization code of S3C64xx to support > Device Tree-based initialization of VICs. Reviewed-by: Mark Brown signature.asc Description: Digital signature

Re: [RFC PATCH 1/7] ARM: common: vic: Parse interrupt and resume masks from device tree

2013-01-10 Thread Tomasz Figa
On Thursday 10 of January 2013 11:03:14 Mark Brown wrote: > On Thu, Jan 10, 2013 at 12:41:43AM +0100, Tomasz Figa wrote: > > +- interrupt-mask : Bit mask of valid interrupt sources (defaults to > > all valid) +- wakeup-mask : Bit mask of interrupt sources that can > > wake up the system + (default

Re: [PATCH v4 14/19] ARM: remove unneeded vic.h includes

2013-01-10 Thread Linus Walleij
On Thu, Jan 3, 2013 at 6:54 PM, Rob Herring wrote: > From: Rob Herring > > Numerous includes of asm/hardware/vic.h aren't needed, so remove them. Acked-by: Linus Walleij Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a messa

Re: [RFC PATCH 1/7] ARM: common: vic: Parse interrupt and resume masks from device tree

2013-01-10 Thread Mark Brown
On Thu, Jan 10, 2013 at 12:41:43AM +0100, Tomasz Figa wrote: > +- interrupt-mask : Bit mask of valid interrupt sources (defaults to all > valid) > +- wakeup-mask : Bit mask of interrupt sources that can wake up the system > + (defaults to all allowed) Should this really be configured in the VIC

Re: [PATCH v4 19/19] irqchip: Move ARM vic.h to include/linux/irqchip/arm-vic.h

2013-01-10 Thread Linus Walleij
On Thu, Jan 3, 2013 at 6:54 PM, Rob Herring wrote: > From: Rob Herring > > Now that we have VIC moved to drivers/irqchip and all VIC DT init for > platforms using irqchip_init, move gic.h and update the remaining > includes. This will need to be rebased on fixes merged for -rc3. Apart from tha

Re: [RFC PATCH 5/7] ARM: s3c64xx: Add board file for boot using Device Tree

2013-01-10 Thread Tomasz Figa
Hi Mark, On Thursday 10 of January 2013 10:52:22 Mark Brown wrote: > On Thu, Jan 10, 2013 at 12:41:47AM +0100, Tomasz Figa wrote: > > + * The following lookup table is used to override device names when > > devices + * are registered from device tree. This is temporarily > > added to enable + * de

Re: [PATCH 09/26] ARM: SAMSUNG: cleanup mach/gpio-fns.h gpio-track.h and gpio-nrs.h

2013-01-10 Thread Linus Walleij
On Wed, Jan 2, 2013 at 11:23 PM, Kukjin Kim wrote: > remove , and > > Cc: Linus Walleij > Cc: Grant Likely > Signed-off-by: Kukjin Kim This really needs cleanup so Acked-by: Linus Walleij I guess you will carry this through the Samsung tree? Yours, Linus Walleij -- To unsubscribe from th

Re: [PATCH 01/26] gpio: samsung: remove inclusion

2013-01-10 Thread Linus Walleij
On Wed, Jan 2, 2013 at 11:23 PM, Kukjin Kim wrote: > The is not needed for gpio-samsung. > > Cc: Linus Walleij > Cc: Grant Likely > Signed-off-by: Kukjin Kim Applied to fixes, thanks. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the

Re: [RFC PATCH 5/7] ARM: s3c64xx: Add board file for boot using Device Tree

2013-01-10 Thread Mark Brown
On Thu, Jan 10, 2013 at 12:41:47AM +0100, Tomasz Figa wrote: > + * The following lookup table is used to override device names when devices > + * are registered from device tree. This is temporarily added to enable > + * device tree support addition for the Exynos4 architecture. Cut'n'paste. si

[PATCH 1/1] ARM: S3C24XX: Make 'clk_msysclk' static

2013-01-10 Thread Sachin Kamat
Fixes the following warning: arch/arm/mach-s3c24xx/common-s3c2443.c:135:19: warning: symbol 'clk_msysclk' was not declared. Should it be static? Signed-off-by: Sachin Kamat --- arch/arm/mach-s3c24xx/common-s3c2443.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/a

Re: [PATCH v5] usb: phy: samsung: Add support to set pmu isolation

2013-01-10 Thread Vivek Gautam
Hi Sylwester, On Thu, Jan 10, 2013 at 3:12 AM, Sylwester Nawrocki wrote: > Hi, > > > On 12/28/2012 10:13 AM, Vivek Gautam wrote: >> >> Adding support to parse device node data in order to get >> required properties to set pmu isolation for usb-phy. >> >> Signed-off-by: Vivek Gautam > > ... > >>