Re: [PATCH v7] usb: phy: samsung: Add support to set pmu isolation
HI Kukjin, On Fri, Jan 18, 2013 at 6:46 AM, Kukjin Kim wrote: > Vivek Gautam wrote: >> >> Adding support to parse device node data in order to get >> required properties to set pmu isolation for usb-phy. >> >> Signed-off-by: Vivek Gautam >> Reviewed-by: Sylwester Nawrocki >> Reviewed-by: Doug Anderson > > This looks good to me, > Acked-by: Kukjin Kim > Thanks > Vivek, could you please re-send following in one series? > - [PATCH v9 1/2] usb: phy: samsung: Introducing usb phy driver for hsotg > - [PATCH v8 2/2] usb: s3c-hsotg: Adding phy driver support > Praveen will re-send this patch-series asap. > As I know, this should be applied on top of above patches. > -- Thanks & Regards Vivek -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] arch/arm/mach-s5pv210: adding ifdef CONFIG_CPU_S5PV210to fix compiling issue
On 01/18/2013 11:33 AM, Kukjin Kim wrote: > Chen,Gang( ??) wrote: >> thank you, I should notice it next time. >> an incorrect subject is not easy to get maintainer's notice >> maybe it is the reason why you can not reply in time, since you can not >> notice it. >> >> :-) >> > Just I was busy ;-) sorry for late my reply. > not mind, most of us are often busy, I will have more patience, next time. > Anyway Gang, don't post with html typed e-mail, probably, you got some kind > of error that your previous reply wasn't accepted from mailing list mail > server. Please make sure that your e-mail is plain text type for mailing list. > > [...] thank you, I should notice, next time. -- Chen Gang Asianux Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [linux-pm] [PATCH] cpufreq: exynos: Show list of available frequencies
amit kachhap wrote:
>
> On Tue, Jan 8, 2013 at 2:50 AM, Inderpal Singh
> wrote:
> > Add freq_attr attribute to show list of available frequencies.
> >
> > Signed-off-by: Donggeun Kim
> > Signed-off-by: MyungJoo Ham
> > Signed-off-by: KyungMin Park
> > Signed-off-by: Inderpal Singh
> > ---
> > drivers/cpufreq/exynos-cpufreq.c | 13 +
> > 1 file changed, 13 insertions(+)
> >
> > diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-
> cpufreq.c
> > index 7012ea8..bc1e833 100644
> > --- a/drivers/cpufreq/exynos-cpufreq.c
> > +++ b/drivers/cpufreq/exynos-cpufreq.c
> > @@ -244,13 +244,26 @@ static int exynos_cpufreq_cpu_init(struct
> cpufreq_policy *policy)
> > return cpufreq_frequency_table_cpuinfo(policy, exynos_info-
> >freq_table);
> > }
> >
> > +static int exynos_cpufreq_cpu_exit(struct cpufreq_policy *policy)
> > +{
> > + cpufreq_frequency_table_put_attr(policy->cpu);
> > + return 0;
> > +}
> > +
> > +static struct freq_attr *exynos_cpufreq_attr[] = {
> > + &cpufreq_freq_attr_scaling_available_freqs,
> > + NULL,
> > +};
> > +
>
> This change looks fine. I guess this was posted before also but could
> not go mainline.
> Reviewed-by: Amit Daniel Kachhap
>
Looks OK to me, applied.
Thanks.
- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] cpufreq: exynos: Get booting freq value in exynos_cpufreq_init
Jonghwan Choi wrote:
>
> Boot_freq is for saving booting freq. But exynos_cpufreq_cpu_init
> is called in hotplug. If boot_freq is existed in exynos_cpufreq_cpu_init,
> boot_freq could be changed.
>
> Signed-off-by: Jonghwan Choi
> ---
> drivers/cpufreq/exynos-cpufreq.c |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/exynos-cpufreq.c
> b/drivers/cpufreq/exynos-cpufreq.c
> index 7012ea8..41fc550 100644
> --- a/drivers/cpufreq/exynos-cpufreq.c
> +++ b/drivers/cpufreq/exynos-cpufreq.c
> @@ -222,8 +222,6 @@ static int exynos_cpufreq_cpu_init(struct
> cpufreq_policy
> *policy)
>
> cpufreq_frequency_table_get_attr(exynos_info->freq_table,
> policy->cpu);
>
> - locking_frequency = exynos_getspeed(0);
> -
> /* set the transition latency value */
> policy->cpuinfo.transition_latency = 10;
>
> @@ -288,6 +286,8 @@ static int __init exynos_cpufreq_init(void)
> goto err_vdd_arm;
> }
>
> + locking_frequency = exynos_getspeed(0);
> +
> register_pm_notifier(&exynos_cpufreq_nb);
>
> if (cpufreq_register_driver(&exynos_driver)) {
> --
> 1.7.4.1
Applied, thanks.
- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] arm: mach-s3c24xx/common.c: fix uninitialized variable warning
Cong Ding wrote:
>
> the use of variable tmp is uninitialized, so we fix it.
>
> Signed-off-by: Cong Ding
> ---
> arch/arm/mach-s3c24xx/common.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-s3c24xx/common.c b/arch/arm/mach-
> s3c24xx/common.c
> index 0c9e9a7..6bcf87f 100644
> --- a/arch/arm/mach-s3c24xx/common.c
> +++ b/arch/arm/mach-s3c24xx/common.c
> @@ -197,7 +197,7 @@ static unsigned long s3c24xx_read_idcode_v4(void)
>
> static void s3c24xx_default_idle(void)
> {
> - unsigned long tmp;
> + unsigned long tmp = 0;
> int i;
>
> /* idle the system by using the idle mode which will wait for an
> --
> 1.7.9.5
Yes, correct. Applied.
Thanks.
- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 5/5] ARM: exynos: enable/disable cpuidle when cpu1 is down/up
Daniel Lezcano wrote: > > On 01/10/2013 11:33 PM, amit daniel kachhap wrote: > > On Thu, Jan 10, 2013 at 1:32 PM, Daniel Lezcano > wrote: > >> On 01/10/2013 09:07 PM, amit daniel kachhap wrote: > >>> Hi Daniel, > >> > >> Hi Amit Daniel, > >> > >>> This hotplug noifiers looks fine. I suppose it should add extra state > >>> C1 in cpu0. If it is done like below than for normal cases(when all > >>> cpu's are online) there wont be any statistics for C0 state > >> > >> I guess you meant state 0 which is WFI, right ? > >> C0 state is the intel semantic for cpu fully turned on. > > Yes I meant C0 as wfi > >> > >>> also which > >>> is required. Other patches look good. > >> > >> Ok, that makes sense to have statistics even if they are only doing WFI. > >> > >> Then the patch 4/5 is not ok, no ? > > yes I suppose patch 4 and patch 5 are related and depends how you > > frame patch 5. I think it is better to create C0/C1 sysfs and other > > things in the beginning because it is a filesystem call and may > > increase the cpu hotplug time which is not worth. May be if cpuidle > > framework exposes some API to enable/disable states then it is better. > > > > For patch 1,2 and 3, > > Acked-by: Amit Daniel Kachhap > > Hi Kukjin, > > is it possible to take these patches [1-3/5] ? > Looks OK to me, I will apply with Amit's ack. > The patches [3-4/5] could be ignored. > Probably, you mean [4-5/5] :-) Thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/2] ARM: dts: Fix compatible value of pinctrl module on EXYNOS5440
Rob Herring wrote: [...] > > As long as we're consistently inconsistent... What about 4210 and 4x12? > Hopefully, the reason was to avoid breaking them. > > This creates horrible incompatibilities between dts and kernel versions > by changing both. Any prior kernel will not work with this dts or later. > And more importantly this kernel version or newer will not work with > existing dtb's. We've been pretty lax on this as DT support has been > under heavy development, but things need to start tightening up. That > being said, if this isn't yet a concern for this platform, then I don't > really care. > I think, this can be applied for v3.8 and this two fixes should be harmless for DT compatibility of Samsung stuff. If there is no other concerns, let me pick up with Linus Walleij's ack. Thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v2] arch/arm/mach-s5pv210: adding ifdef CONFIG_CPU_S5PV210to fix compiling issue
Chen,Gang( ??) wrote: > > > > For subject: > > Please see the git log before your commit, it should be helpful to you. > > In this case, 'ARM: S5PV210: ...' is used. > > thank you, I should notice it next time. > an incorrect subject is not easy to get maintainer's notice > maybe it is the reason why you can not reply in time, since you can not > notice it. > > :-) > Just I was busy ;-) sorry for late my reply. Anyway Gang, don't post with html typed e-mail, probably, you got some kind of error that your previous reply wasn't accepted from mailing list mail server. Please make sure that your e-mail is plain text type for mailing list. [...] > > I don't think so, because common.c in mach-s5pv210 should be built with > > selecting CONFIG_CPU_S5PV210, actually it depends on CONFIG_ARCH_S5PV210 > > though. > > > > Any concerns, please let me know. > > ok, thank you. > and > is it suitable to delete the reletive code of " define NULL in common.h > for s5pv210_* " ? > it seems they are wast. > Yes, right. We don't need more that. I missed it when I introduced common.[ch] local at the commit 3fa754c2. Thanks for pointing out and I will sort out. [...] Thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] ARM: dts: Fix compatible value of pinctrl module on EXYNOS5440
On 01/17/2013 02:34 AM, Linus Walleij wrote:
> On Thu, Jan 3, 2013 at 1:20 AM, Kukjin Kim wrote:
>
>> From: Thomas Abraham
>>
>> Fix the incorrect compatible property value of pin-controller module
>> EXYNOS5440 SoC.
>>
> (...)
>>
>> pinctrl {
>> - compatible = "samsung,pinctrl-exynos5440";
>> + compatible = "samsung,exynos5440-pinctrl";
>> reg = <0xE 0x1000>;
>> interrupt-controller;
>> #interrupt-cells = <2>;
>> diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
>> index 953737d..cac4b45 100644
>> --- a/drivers/gpio/gpio-samsung.c
>> +++ b/drivers/gpio/gpio-samsung.c
>> @@ -3026,7 +3026,7 @@ static __init int samsung_gpiolib_init(void)
>> static const struct of_device_id exynos_pinctrl_ids[] = {
>> { .compatible = "samsung,pinctrl-exynos4210", },
>> { .compatible = "samsung,pinctrl-exynos4x12", },
>> - { .compatible = "samsung,pinctrl-exynos5440", },
>> + { .compatible = "samsung,exynos5440-pinctrl", },
>> };
>> for_each_matching_node(pctrl_np, exynos_pinctrl_ids)
>> if (pctrl_np && of_device_is_available(pctrl_np))
>
> I am tempted to apply this patch just to annoy people with
> obsessive-compulsive disorder (but that's a bit mean).
> Reference:
> http://izismile.com/2011/08/16/obnoxious_ways_to_drive_people_with_ocd_nuts_16_pics.html
>
> But I'd like a word from Rob, Grant or Stephen so I have some
> guidance here.
As long as we're consistently inconsistent... What about 4210 and 4x12?
Hopefully, the reason was to avoid breaking them.
This creates horrible incompatibilities between dts and kernel versions
by changing both. Any prior kernel will not work with this dts or later.
And more importantly this kernel version or newer will not work with
existing dtb's. We've been pretty lax on this as DT support has been
under heavy development, but things need to start tightening up. That
being said, if this isn't yet a concern for this platform, then I don't
really care.
Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v7] usb: phy: samsung: Add support to set pmu isolation
Vivek Gautam wrote: > > Adding support to parse device node data in order to get > required properties to set pmu isolation for usb-phy. > > Signed-off-by: Vivek Gautam > Reviewed-by: Sylwester Nawrocki > Reviewed-by: Doug Anderson This looks good to me, Acked-by: Kukjin Kim Vivek, could you please re-send following in one series? - [PATCH v9 1/2] usb: phy: samsung: Introducing usb phy driver for hsotg - [PATCH v8 2/2] usb: s3c-hsotg: Adding phy driver support As I know, this should be applied on top of above patches. Thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PULL] Samsung cleanup-header for v3.9
Hi, Arnd, Olof
Here is cleanup headers for Samsung stuff.
AS I commented, this makes local so that they could be removed.
Please pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
next/cleanup-header
If any problems, please kindly let me know.
Thanks
- Kukjin
The following changes since commit a49f0d1ea3ec94fc7cf33a7c36a16343b74bd565:
Linux 3.8-rc1 (2012-12-21 17:19:00 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
next/cleanup-header
for you to fetch changes up to 3a71c5c375e29fc9c1493b5ead1cf36572139c3e:
ARM: S3C64XX: Fix missing header error with CONFIG_CPU_IDLE enabled
(2013-01-10 10:45:41 -0800)
Kukjin Kim (25):
cpufreq: exynos: cleanup exynos-cpufreq header
ARM: S5P64X0: remove gpiolib.c file in mach-s5p64x0
ARM: S5P64X0: move i2c.h into local directory
ARM: S5P64X0: move s5p64x0-clock.h into local directory
ARM: S5PV210: move regs-sys.h into setup-usb-phy.c file
ARM: EXYNOS: move mach/pmu.h file into common.h
ARM: SAMSUNG: cleanup mach/regs-audss.h file
ARM: SAMSUNG: cleanup mach/gpio-fns.h gpio-track.h and gpio-nrs.h
ARM: S3C24XX: make anubis-cpld, anubis-irq and anubis-map local
ARM: S3C24XX: make bast-cpld.h, bast-irq.h and bast-map.h local
ARM: S3C24XX: make gta02.h local
ARM: S3C24XX: make h1940.h and h1940-latch.h local
ARM: S3C24XX: make osiris-cpld.h and osiris-map.h local
ARM: S3C24XX: make otom-map.h local
ARM: S3C24XX: make vr1000-cpld.h, vr1000-irq.h and vr1000-map.h local
ARM: S3C2416: remove regs-s3c2416-mem.h and regs-s3c2416.h
ARM: S3C2412: cleanup regs-s3c2412.h
ARM: S3C24XX: remove idle.h
ARM: S3C24XX: remove dsc.c and make regs-dsc.h local
ARM: S3C64XX: make crag6410.h local
ARM: S3C64XX: make regs-gpio-memport.h local
ARM: S3C64XX: make regs-modem.h local
ARM: S3C64XX: make regs-srom.h local
ARM: S3C64XX: make regs-sys.h local
ARM: S3C64XX: make regs-syscon-power.h local
Tomasz Figa (1):
ARM: S3C64XX: Fix missing header error with CONFIG_CPU_IDLE enabled
arch/arm/mach-exynos/common.c |1 -
arch/arm/mach-exynos/common.h | 20 +
arch/arm/mach-exynos/cpuidle.c |3 +-
arch/arm/mach-exynos/dev-audio.c |3 +-
arch/arm/mach-exynos/include/mach/pmu.h| 34 --
arch/arm/mach-exynos/include/mach/regs-audss.h | 18 -
arch/arm/mach-exynos/pm.c |3 +-
arch/arm/mach-exynos/pmu.c |3 +-
arch/arm/mach-s3c2440/Makefile |2 -
arch/arm/mach-s3c2440/dsc.c| 54 ---
arch/arm/mach-s3c24xx/anubis.h | 53 ++
arch/arm/mach-s3c24xx/bast-ide.c | 18 +-
arch/arm/mach-s3c24xx/bast-irq.c | 19 +-
arch/arm/mach-s3c24xx/bast.h | 197
arch/arm/mach-s3c24xx/{include/mach => }/gta02.h | 14 +-
arch/arm/mach-s3c24xx/h1940-bluetooth.c|6 +-
.../{include/mach/h1940-latch.h => h1940.h}| 22 +-
arch/arm/mach-s3c24xx/include/mach/anubis-cpld.h | 25 -
arch/arm/mach-s3c24xx/include/mach/anubis-irq.h| 21 -
arch/arm/mach-s3c24xx/include/mach/anubis-map.h| 38 --
arch/arm/mach-s3c24xx/include/mach/bast-cpld.h | 53 --
arch/arm/mach-s3c24xx/include/mach/bast-irq.h | 29 --
arch/arm/mach-s3c24xx/include/mach/bast-map.h | 146 --
arch/arm/mach-s3c24xx/include/mach/gpio-fns.h |1 -
arch/arm/mach-s3c24xx/include/mach/gpio-nrs.h | 97
arch/arm/mach-s3c24xx/include/mach/gpio-track.h| 33 --
arch/arm/mach-s3c24xx/include/mach/gpio.h | 87 +++-
arch/arm/mach-s3c24xx/include/mach/h1940.h | 24 -
arch/arm/mach-s3c24xx/include/mach/idle.h | 24 -
arch/arm/mach-s3c24xx/include/mach/osiris-cpld.h | 30 --
arch/arm/mach-s3c24xx/include/mach/regs-gpio.h |2 -
arch/arm/mach-s3c24xx/include/mach/regs-s3c2412.h | 23 -
.../mach-s3c24xx/include/mach/regs-s3c2416-mem.h | 30 --
arch/arm/mach-s3c24xx/include/mach/regs-s3c2416.h | 24 -
arch/arm/mach-s3c24xx/include/mach/vr1000-cpld.h | 18 -
arch/arm/mach-s3c24xx/include/mach/vr1000-irq.h| 26 -
arch/arm/mach-s3c24xx/include/mach/vr1000-map.h| 110 -
arch/arm/mach-s3c24xx/mach-anubis.c| 13 +-
arch/arm/mach-s3c24xx/mach-at2440evb.c |1 +
arch/arm/mach-s3c24xx/mach-bast.c | 52 +-
arch/arm/mach-s3c24xx/mach-gta02.c | 59 ++-
arch/arm/mach-s3c24xx/mach-h1940.c | 37 +-
arch/arm/mach-s3c24xx/mach-osiris.c| 27 +-
arch/arm/mach-s3c24xx/mach-otom.c | 20 +-
arch/arm/
RE: [PATCH v2] arch/arm/mach-s5pv210: adding ifdef CONFIG_CPU_S5PV210 to fix compiling issue
Chen Gang wrote:
>
Firstly, thanks for your posting.
But there are some comments.
For subject:
Please see the git log before your commit, it should be helpful to you.
In this case, 'ARM: S5PV210: ...' is used.
>
> if not define CONFIG_CPU_S5PV210
>
> it will define NULL in common.h for:
> s5pv210_map_io, s5pv210_init_clocks, s5pv210_init,
s5pv210_init_uarts
>
> so need using #ifdef CONFIG_CPU_S5PV210 for them too, in common.c.
> or compiling issue will occur.
>
I don't think so, because common.c in mach-s5pv210 should be built with
selecting CONFIG_CPU_S5PV210, actually it depends on CONFIG_ARCH_S5PV210
though.
Any concerns, please let me know.
>
> Signed-off-by: Chen Gang
> ---
> arch/arm/mach-s5pv210/common.c |9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/mach-s5pv210/common.c b/arch/arm/mach-
> s5pv210/common.c
> index 9dfe93e..5c88f88 100644
> --- a/arch/arm/mach-s5pv210/common.c
> +++ b/arch/arm/mach-s5pv210/common.c
> @@ -167,6 +167,8 @@ void __init s5pv210_init_io(struct map_desc
> *mach_desc, int size)
> s3c_init_cpu(samsung_cpu_id, cpu_ids, ARRAY_SIZE(cpu_ids));
> }
>
> +#ifdef CONFIG_CPU_S5PV210
> +
> void __init s5pv210_map_io(void)
> {
> /* initialise device information early */
> @@ -209,6 +211,9 @@ void __init s5pv210_init_clocks(int xtal)
> s5pv210_setup_clocks();
> }
>
> +#endif /* CONFIG_CPU_S5PV210 */
> +
> +
Generally, no need double empty lines here.
> void __init s5pv210_init_irq(void)
> {
> u32 vic[4]; /* S5PV210 supports 4 VIC */
> @@ -227,6 +232,8 @@ struct bus_type s5pv210_subsys = {
> .dev_name = "s5pv210-core",
> };
>
> +#ifdef CONFIG_CPU_S5PV210
> +
> static struct device s5pv210_dev = {
> .bus= &s5pv210_subsys,
> };
> @@ -249,3 +256,5 @@ void __init s5pv210_init_uarts(struct s3c2410_uartcfg
> *cfg, int no)
> {
> s3c24xx_init_uartdevs("s5pv210-uart", s5p_uart_resources, cfg, no);
> }
> +
> +#endif /* CONFIG_CPU_S5PV210 */
> --
> 1.7.10.4
Thanks.
- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/2] ARM: dts: Add vmmc regulator node in exynos4412-origen.dts
Tomasz Figa wrote:
>
> Hi Sachin,
>
> On Thursday 17 of January 2013 11:18:12 Sachin Kamat wrote:
> > Added vmmc regulator node in exynos4412-origen.dts file.
> >
> > Signed-off-by: Sachin Kamat
> > ---
> > arch/arm/boot/dts/exynos4412-origen.dts |9 +
> > 1 files changed, 9 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos4412-origen.dts
> > b/arch/arm/boot/dts/exynos4412-origen.dts index df880c4..fe70bc6
> 100644
> > --- a/arch/arm/boot/dts/exynos4412-origen.dts
> > +++ b/arch/arm/boot/dts/exynos4412-origen.dts
> > @@ -27,6 +27,15 @@
> > bootargs ="console=ttySAC2,115200";
> > };
> >
> > + mmc_reg: voltage-regulator {
> > + compatible = "regulator-fixed";
> > + regulator-name = "VMEM_VDD_2.8V";
> > + regulator-min-microvolt = <280>;
> > + regulator-max-microvolt = <280>;
> > + gpio = <&gpx1 1 0>;
> > + enable-active-high;
> > + };
> > +
> > serial@1380 {
> > status = "okay";
> > };
>
> Reviewed-by: Tomasz Figa
>
Looks good to me, applied 1/2 and 2/2.
Thanks for review and posting.
- Kukjin
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] cpufreq: exynos: fix hang in pm handler due to frequency mismatch
From: Jonghwan Choi
When pm handler set freq & voltage, frequency mismatch occurred.
Because freqs.new isn't set in pm handler.
Reported-by: Abhilash Kesavan
Signed-off-by: Jonghwan Choi
Cc: Rafael J. Wysocki
Signed-off-by: Kukjin Kim
---
drivers/cpufreq/exynos-cpufreq.c |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c
index 6d6ba0d..48ee439 100644
--- a/drivers/cpufreq/exynos-cpufreq.c
+++ b/drivers/cpufreq/exynos-cpufreq.c
@@ -69,9 +69,10 @@ static int exynos_cpufreq_scale(unsigned int target_freq)
int ret = 0;
freqs.old = policy->cur;
+ freqs.new = target_freq;
freqs.cpu = policy->cpu;
- if (target_freq == freqs.old)
+ if (freqs.new == freqs.old)
goto out;
/*
@@ -159,6 +160,7 @@ static int exynos_target(struct cpufreq_policy *policy,
{
struct cpufreq_frequency_table *freq_table = exynos_info->freq_table;
unsigned int index;
+ unsigned int new_freq;
int ret = 0;
mutex_lock(&cpufreq_lock);
@@ -172,9 +174,9 @@ static int exynos_target(struct cpufreq_policy *policy,
goto out;
}
- freqs.new = freq_table[index].frequency;
+ new_freq = freq_table[index].frequency;
- ret = exynos_cpufreq_scale(freqs.new);
+ ret = exynos_cpufreq_scale(new_freq);
out:
mutex_unlock(&cpufreq_lock);
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] cpufreq: exynos: fix uninitialized warning in exynos-cpufreq.c
From: Jonghwan Choi
Fix "warning: 'ret' may be used uninitialized in this function"
Signed-off-by: Jonghwan Choi
Cc: Rafael J. Wysocki
Signed-off-by: Kukjin Kim
---
drivers/cpufreq/exynos-cpufreq.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c
index 459f7f6..6d6ba0d 100644
--- a/drivers/cpufreq/exynos-cpufreq.c
+++ b/drivers/cpufreq/exynos-cpufreq.c
@@ -159,7 +159,7 @@ static int exynos_target(struct cpufreq_policy *policy,
{
struct cpufreq_frequency_table *freq_table = exynos_info->freq_table;
unsigned int index;
- int ret;
+ int ret = 0;
mutex_lock(&cpufreq_lock);
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2 0/3] thermal: Add support for interrupt based notification to thermal layer
Hi Rui, Any update? Please merge these patch series as they have many critical fixes. Thanks, Amit Daniel On Sun, Jan 6, 2013 at 3:57 PM, amit daniel kachhap wrote: > Hi Rui, > > Any comment on these patches? These are based on new quick cooling > macros introduced. > Also my linaro ID is not valid so using samsung ID. > > Thanks, > Amit Daniel > > On Mon, Nov 26, 2012 at 5:47 AM, Amit Daniel Kachhap > wrote: >> Changes since V1: Used the new thermal trend type macro >> >> The patch submitted by Jonghwa Lee >> (https://patchwork.kernel.org/patch/1683441/) >> adds support for interrupt based notification to thermal layer. This is a >> good >> feature but the current code need more fixes to support that feature so >> using 2 new thermal >> trend type to implement this feature and some falling interrupt fixes. >> >> All these patches are based on thermal maintainer thermal branch. >> git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git thermal >> >> Amit Daniel Kachhap (2): >> thermal: exynos: Miscellaneous fixes to support falling threshold >> interrupt >> thermal: exynos: Use the new thermal trend type for quick cooling >> action. >> >> Jonghwa Lee (1): >> Thermal: exynos: Add support for temperature falling interrupt. >> >> drivers/thermal/exynos_thermal.c | 108 >> +++--- >> include/linux/platform_data/exynos_thermal.h |3 + >> 2 files changed, 67 insertions(+), 44 deletions(-) >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" >> in >> the body of a message to majord...@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 06/14] ARM: EXYNOS: add System MMU definition to DT
Hi Hiroshi, On Wed, Jan 16, 2013 at 04:43:21PM +, Hiroshi Doyu wrote: > Will Deacon wrote @ Wed, 16 Jan 2013 12:51:14 +0100: > > Given that this information is not discoverable, it needs to be encoded > > in the device tree, but where? I can see two approaches: > > > > 1. For each IOMMU node, list phandles to the devices connected to it > > and have a corresponding list of StreamIDs. > > > > or > > > > 2. For each device wishing to use an IOMMU, have a phandle to the > > IOMMU node and a separate StreamID property. The IOMMU would then > > parse this information when the device is added to the bus. > > > > Although I prefer the second approach, it has the downside of affecting > > all device bindings that wish to use an IOMMU, so I'm open to any other > > ideas. > > Actually the above summarize tegra SMMU situation well too. For > example, each IOMMU'able device has IOVA constraint that some of the > address area isn't available because of its MMIO. This info needs to > be described in DT. If + some parametes are embedded > in a device node, that info could be dealt at a bus notifier(*1). > > *1: http://lists.linuxfoundation.org/pipermail/iommu/2012-November/004934.html I've been thinking about this a bit more and, unfortunately, my conclusion is that method (2) above is problematic, so we do need something similar to (1). The reason for this comes about when dealing with chained IOMMUs. In this case, each IOMMU in the chain needs to know about all of the masters hanging beneath it (potentially behind other IOMMUs) but may also need to supplement each device with additional data relevant to that point in the IOMMU chain. In the case of the ARM System MMU, this could be StreamID information (as the StreamID for a device can change as the transaction stream passes through an SMMU) and for your case it could be that the DMA window is widened along the chain. So, extending the mmu-master property described in this thread to be "mmu-masters : a list of phandles to device nodes representing bus masters for which the IOMMU can provide a translation" is probably a good start. Will -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] ARM: dts: Fix compatible value of pinctrl module on EXYNOS5440
On 01/17/2013 01:34 AM, Linus Walleij wrote:
> On Thu, Jan 3, 2013 at 1:20 AM, Kukjin Kim wrote:
>
>> From: Thomas Abraham
>>
>> Fix the incorrect compatible property value of pin-controller module
>> EXYNOS5440 SoC.
>>
> (...)
>>
>> pinctrl {
>> - compatible = "samsung,pinctrl-exynos5440";
>> + compatible = "samsung,exynos5440-pinctrl";
>> reg = <0xE 0x1000>;
>> interrupt-controller;
>> #interrupt-cells = <2>;
>> diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
>> index 953737d..cac4b45 100644
>> --- a/drivers/gpio/gpio-samsung.c
>> +++ b/drivers/gpio/gpio-samsung.c
>> @@ -3026,7 +3026,7 @@ static __init int samsung_gpiolib_init(void)
>> static const struct of_device_id exynos_pinctrl_ids[] = {
>> { .compatible = "samsung,pinctrl-exynos4210", },
>> { .compatible = "samsung,pinctrl-exynos4x12", },
>> - { .compatible = "samsung,pinctrl-exynos5440", },
>> + { .compatible = "samsung,exynos5440-pinctrl", },
>> };
>> for_each_matching_node(pctrl_np, exynos_pinctrl_ids)
>> if (pctrl_np && of_device_is_available(pctrl_np))
>
> I am tempted to apply this patch just to annoy people with
> obsessive-compulsive disorder (but that's a bit mean).
> Reference:
> http://izismile.com/2011/08/16/obnoxious_ways_to_drive_people_with_ocd_nuts_16_pics.html
Aargh. Those pencils are wrong:-)
> But I'd like a word from Rob, Grant or Stephen so I have some
> guidance here.
Yes, the existing order looks odd c.f. existing practice.
I notice that only one of the strangely ordered entries in
exynos_pinctrl_ids[] is fixed. Surely they should all be fixed?
It's probably worth adding the new names to exynos_pinctrl_ids[] rather
than replacing them. That allows the driver to be backwards-compatible
with older DTBs, and partially decouples the driver change from the
.dts/.dtsi file. Still, the whole backwards-compatible DTB thing seems a
little irrelevant when the .dts files are in the kernel source tree anyway.
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] ARM: dts: fix compatible value for exynos pinctrl
On Thu, Jan 3, 2013 at 1:20 AM, Kukjin Kim wrote: > Fix the incorrect compatible property value of pinctrl for EXYNOS4 SoCs. > > Cc: Thomas Abraham > Cc: Linus Walleij > Cc: Grant Likely > Signed-off-by: Kukjin Kim > Cc: devicetree-disc...@lists.ozlabs.org Acked-by: Linus Walleij Thanks! Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] ARM: dts: fix compatible value for exynos pinctrl
Hi Kukjin,
On Wednesday 02 of January 2013 16:20:23 Kukjin Kim wrote:
> Fix the incorrect compatible property value of pinctrl for EXYNOS4 SoCs.
>
> Cc: Thomas Abraham
> Cc: Linus Walleij
> Cc: Grant Likely
> Signed-off-by: Kukjin Kim
> Cc: devicetree-disc...@lists.ozlabs.org
> ---
> .../devicetree/bindings/pinctrl/samsung-pinctrl.txt| 12
> ++-- arch/arm/boot/dts/exynos4210.dtsi
> |6 +++--- arch/arm/boot/dts/exynos4x12.dtsi
> |8 arch/arm/mach-exynos/common.c
> |4 ++-- drivers/gpio/gpio-samsung.c
>|4 ++-- drivers/pinctrl/pinctrl-samsung.c
> |4 ++-- 6 files changed, 19 insertions(+), 19 deletions(-)
>
> diff --git
> a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
> b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt index
> e97a278..4598a47 100644
> --- a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt
> @@ -7,9 +7,9 @@ on-chip controllers onto these pads.
>
> Required Properties:
> - compatible: should be one of the following.
> - - "samsung,pinctrl-exynos4210": for Exynos4210 compatible
> pin-controller. - - "samsung,pinctrl-exynos4x12": for Exynos4x12
> compatible pin-controller. - - "samsung,pinctrl-exynos5250": for
> Exynos5250 compatible pin-controller. + -
> "samsung,exynos4210-pinctrl": for Exynos4210 compatible pin-controller.
> + - "samsung,exynos4x12-pinctrl": for Exynos4x12 compatible
> pin-controller. + - "samsung,exynos5250-pinctrl": for Exynos5250
> compatible pin-controller.
>
> - reg: Base address of the pin controller hardware module and length of
> the address space it occupies.
> @@ -142,7 +142,7 @@ the following format 'pinctrl{n}' where n is a
> unique number for the alias. Example: A pin-controller node with pin
> banks:
>
> pinctrl_0: pinctrl@1140 {
> - compatible = "samsung,pinctrl-exynos4210";
> + compatible = "samsung,exynos4210-pinctrl";
> reg = <0x1140 0x1000>;
> interrupts = <0 47 0>;
>
> @@ -185,7 +185,7 @@ Example: A pin-controller node with pin banks:
> Example 1: A pin-controller node with pin groups.
>
> pinctrl_0: pinctrl@1140 {
> - compatible = "samsung,pinctrl-exynos4210";
> + compatible = "samsung,exynos4210-pinctrl";
> reg = <0x1140 0x1000>;
> interrupts = <0 47 0>;
>
> @@ -230,7 +230,7 @@ Example 1: A pin-controller node with pin groups.
> Example 2: A pin-controller node with external wakeup interrupt
> controller node.
>
> pinctrl_1: pinctrl@1100 {
> - compatible = "samsung,pinctrl-exynos4210";
> + compatible = "samsung,exynos4210-pinctrl";
> reg = <0x1100 0x1000>;
> interrupts = <0 46 0>
>
> diff --git a/arch/arm/boot/dts/exynos4210.dtsi
> b/arch/arm/boot/dts/exynos4210.dtsi index e31bfc4..2feffc7 100644
> --- a/arch/arm/boot/dts/exynos4210.dtsi
> +++ b/arch/arm/boot/dts/exynos4210.dtsi
> @@ -48,13 +48,13 @@
> };
>
> pinctrl_0: pinctrl@1140 {
> - compatible = "samsung,pinctrl-exynos4210";
> + compatible = "samsung,exynos4210-pinctrl";
> reg = <0x1140 0x1000>;
> interrupts = <0 47 0>;
> };
>
> pinctrl_1: pinctrl@1100 {
> - compatible = "samsung,pinctrl-exynos4210";
> + compatible = "samsung,exynos4210-pinctrl";
> reg = <0x1100 0x1000>;
> interrupts = <0 46 0>;
>
> @@ -66,7 +66,7 @@
> };
>
> pinctrl_2: pinctrl@0386 {
> - compatible = "samsung,pinctrl-exynos4210";
> + compatible = "samsung,exynos4210-pinctrl";
> reg = <0x0386 0x1000>;
> };
>
> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi
> b/arch/arm/boot/dts/exynos4x12.dtsi index 179a62e..9a87806 100644
> --- a/arch/arm/boot/dts/exynos4x12.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
> @@ -37,13 +37,13 @@
> };
>
> pinctrl_0: pinctrl@1140 {
> - compatible = "samsung,pinctrl-exynos4x12";
> + compatible = "samsung,exynos4x12-pinctrl";
> reg = <0x1140 0x1000>;
> interrupts = <0 47 0>;
> };
>
> pinctrl_1: pinctrl@1100 {
> - compatible = "samsung,pinctrl-exynos4x12";
> + compatible = "samsung,exynos4x12-pinctrl";
> reg = <0x1100 0x1000>;
> interrupts = <0 46 0>;
>
> @@ -55,14 +55,14 @@
> };
>
> pinctrl_2: pinctrl@0386 {
> - compatible = "samsung,pinctrl-exynos4x12";
> + compatible = "samsung,exynos4x12-pinctrl";
> reg = <0x0386 0x1000>;
> interrupt-parent = <&combiner>;
>
Re: [PATCH] gpio: samsung: skip gpio lib registration for EXYNOS5440
On Thu, Dec 20, 2012 at 8:08 PM, Kukjin Kim wrote: > Since exynos5440 can support pinctrl so skip the legacy > gpiolib registration. If not, happens following. > > WARNING: at drivers/gpio/gpio-samsung.c:3102 samsung_gpiolib_init+0x68/0x8c() > Unknown SoC in gpio-samsung, no GPIOs added > > Acked-by: Thomas Abraham > Signed-off-by: Kukjin Kim Appled to fixes. Thanks! Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 01/26] gpio: samsung: remove inclusion
On Thu, Jan 10, 2013 at 7:41 PM, Kukjin Kim wrote: > BTW, do you have any comments on following patches? > > [PATCH] gpio: samsung: silent build warning for EXYNOS5 > http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg14443.html Merged to fixes. > [PATCH] gpio: samsung: fix pinctrl condition for exynos and exynos5440 > http://comments.gmane.org/gmane.linux.kernel.samsung-soc/14758 Merged to fixes. > [PATCH] gpio: samsung: skip gpio lib registration for EXYNOS5440 > http://permalink.gmane.org/gmane.linux.kernel.samsung-soc/14673 I'll check it out, may have missed it. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] ARM: dts: fix compatible value for exynos pinctrl
Hi Olof, On Saturday 05 of January 2013 14:57:54 Olof Johansson wrote: > On Wed, Jan 2, 2013 at 4:20 PM, Kukjin Kim wrote: > > Fix the incorrect compatible property value of pinctrl for EXYNOS4 > > SoCs. > Ah, this answers my question from the previous patch. So, why do 5450 > as a separate patch? > > > diff --git > > a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt > > b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt index > > e97a278..4598a47 100644 > > --- a/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt > > +++ b/Documentation/devicetree/bindings/pinctrl/samsung-pinctrl.txt > > @@ -7,9 +7,9 @@ on-chip controllers onto these pads. > > > > Required Properties: > > - compatible: should be one of the following. > > > > - - "samsung,pinctrl-exynos4210": for Exynos4210 compatible > > pin-controller. - - "samsung,pinctrl-exynos4x12": for Exynos4x12 > > compatible pin-controller. - - "samsung,pinctrl-exynos5250": for > > Exynos5250 compatible pin-controller. + - > > "samsung,exynos4210-pinctrl": for Exynos4210 compatible > > pin-controller. + - "samsung,exynos4x12-pinctrl": for Exynos4x12 > > compatible pin-controller. + - "samsung,exynos5250-pinctrl": for > > Exynos5250 compatible pin-controller. > Do we care about backwards compatibility for ARM device trees yet? > It's becoming time to start caring soon, if we don't. So while this > might be OK for this time around, we should start requiring some > backwards compatibility for bindings that have been used in at least > one released kernel. This also brings the general problem of dts verification. As of now, we don't have any way of checking dts files for compliance with defined bindings. Moreover we don't even have a way of defining those bindings other than plain text documentation. Now, the problem is that anyone can put anything in their device tree sources and we can't check if the information is specified correctly by any other means that someone reading it and confirming with documentation and/or driver code (the documentation isn't always up to date...). I remember there was some effort going towards encoding device tree bindings using something like XML schemas, but I'm not sure to what point it got and what was the conclusion. (Personally I think that it was a bit overcomplicated, but I never had time to polish and implement some of my ideas, eventually letting the problem fade off from my mind.) Best regards, -- Tomasz Figa Samsung Poland R&D Center SW Solution Development, Linux Platform -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] ARM: dts: Add vmmc regulator node in exynos4412-origen.dts
Hi Tomasz On 17 January 2013 14:56, Tomasz Figa wrote: > Hi Sachin, > > On Thursday 17 of January 2013 11:18:12 Sachin Kamat wrote: >> Added vmmc regulator node in exynos4412-origen.dts file. >> >> Signed-off-by: Sachin Kamat >> --- > > > Reviewed-by: Tomasz Figa > Thank you for reviewing the patches. -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/2] ARM: dts: Add sdhci node for exynos4412-origen
Hi Sachin,
On Thursday 17 of January 2013 11:18:13 Sachin Kamat wrote:
> Added sdhci node for exynos4412-origen.
>
> Signed-off-by: Sachin Kamat
> ---
> arch/arm/boot/dts/exynos4412-origen.dts |8
> 1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4412-origen.dts
> b/arch/arm/boot/dts/exynos4412-origen.dts index fe70bc6..4eba374 100644
> --- a/arch/arm/boot/dts/exynos4412-origen.dts
> +++ b/arch/arm/boot/dts/exynos4412-origen.dts
> @@ -36,6 +36,14 @@
> enable-active-high;
> };
>
> + sdhci@1253 {
> + bus-width = <4>;
> + pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus4 &sd2_cd>;
> + pinctrl-names = "default";
> + vmmc-supply = <&mmc_reg>;
> + status = "okay";
> + };
> +
> serial@1380 {
> status = "okay";
> };
Reviewed-by: Tomasz Figa
Best regards,
--
Tomasz Figa
Samsung Poland R&D Center
SW Solution Development, Linux Platform
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] ARM: dts: Add vmmc regulator node in exynos4412-origen.dts
Hi Sachin,
On Thursday 17 of January 2013 11:18:12 Sachin Kamat wrote:
> Added vmmc regulator node in exynos4412-origen.dts file.
>
> Signed-off-by: Sachin Kamat
> ---
> arch/arm/boot/dts/exynos4412-origen.dts |9 +
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos4412-origen.dts
> b/arch/arm/boot/dts/exynos4412-origen.dts index df880c4..fe70bc6 100644
> --- a/arch/arm/boot/dts/exynos4412-origen.dts
> +++ b/arch/arm/boot/dts/exynos4412-origen.dts
> @@ -27,6 +27,15 @@
> bootargs ="console=ttySAC2,115200";
> };
>
> + mmc_reg: voltage-regulator {
> + compatible = "regulator-fixed";
> + regulator-name = "VMEM_VDD_2.8V";
> + regulator-min-microvolt = <280>;
> + regulator-max-microvolt = <280>;
> + gpio = <&gpx1 1 0>;
> + enable-active-high;
> + };
> +
> serial@1380 {
> status = "okay";
> };
Reviewed-by: Tomasz Figa
Best regards,
--
Tomasz Figa
Samsung Poland R&D Center
SW Solution Development, Linux Platform
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] ARM: dts: Fix compatible value of pinctrl module on EXYNOS5440
On Thu, Jan 3, 2013 at 1:20 AM, Kukjin Kim wrote:
> From: Thomas Abraham
>
> Fix the incorrect compatible property value of pin-controller module
> EXYNOS5440 SoC.
>
(...)
>
> pinctrl {
> - compatible = "samsung,pinctrl-exynos5440";
> + compatible = "samsung,exynos5440-pinctrl";
> reg = <0xE 0x1000>;
> interrupt-controller;
> #interrupt-cells = <2>;
> diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
> index 953737d..cac4b45 100644
> --- a/drivers/gpio/gpio-samsung.c
> +++ b/drivers/gpio/gpio-samsung.c
> @@ -3026,7 +3026,7 @@ static __init int samsung_gpiolib_init(void)
> static const struct of_device_id exynos_pinctrl_ids[] = {
> { .compatible = "samsung,pinctrl-exynos4210", },
> { .compatible = "samsung,pinctrl-exynos4x12", },
> - { .compatible = "samsung,pinctrl-exynos5440", },
> + { .compatible = "samsung,exynos5440-pinctrl", },
> };
> for_each_matching_node(pctrl_np, exynos_pinctrl_ids)
> if (pctrl_np && of_device_is_available(pctrl_np))
I am tempted to apply this patch just to annoy people with
obsessive-compulsive disorder (but that's a bit mean).
Reference:
http://izismile.com/2011/08/16/obnoxious_ways_to_drive_people_with_ocd_nuts_16_pics.html
But I'd like a word from Rob, Grant or Stephen so I have some
guidance here.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] gpio: samsung: silent build warning for EXYNOS5 SoCs
On Thu, Dec 27, 2012 at 7:12 PM, Kukjin Kim wrote: > This patch fixes following warning: > > drivers/gpio/gpio-samsung.c:450:32: warning: 'exynos_gpio_cfg' defined but > not used [-Wunused-variable] > drivers/gpio/gpio-samsung.c:2450:33: warning: 'exynos5_gpios_1' defined but > not used [-Wunused-variable] > drivers/gpio/gpio-samsung.c:2618:33: warning: 'exynos5_gpios_2' defined but > not used [-Wunused-variable] > drivers/gpio/gpio-samsung.c:2679:33: warning: 'exynos5_gpios_3' defined but > not used [-Wunused-variable] > drivers/gpio/gpio-samsung.c:2715:33: warning: 'exynos5_gpios_4' defined but > not used [-Wunused-variable] > > Because current gpio-samsung is valid only on EXYNOS5250. > > Cc: Thomas Abraham > Signed-off-by: Kukjin Kim Patch applied, thanks! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] gpio: samsung: fix pinctrl condition for exynos and exynos5440
On Thu, Dec 27, 2012 at 7:11 PM, Kukjin Kim wrote: > Since EXYNOS5440 can select PINCTRL_EXYNOS5440 without PINCTRL_SAMSUNG, > it should be fixed. In detail, PINCTRL_SAMSUNG is a kind of frame work > for supporting pinctrl on most Samsung SoCs including S3C, S5P as well > except EXYNOS5440 so PINCTRL_EXYNOS5440 has been implemented separated. > > Cc: Thomas Abraham > Signed-off-by: Kukjin Kim Patch applied, thanks. Sorry for taking an eternity for getting to these patches :-( Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] gpio: samsung: add GPIO interrupt registration for exynos5
On Fri, Dec 14, 2012 at 11:44 AM, Joonyoung Shim wrote: > This adds GPIO interrupt registration and modification needs to register > GPIO interrupt rightly for exynos5 SoCs. EXYNOS5_GPYx gpios shouldn't be > counted to GPIO interrupt group register number because they doesn't > support GPIO interrupt, so their struct samsung_gpio_cfg should be > initialized to &samsung_gpio_cfgs[8] in declaration ahead. > > Signed-off-by: Joonyoung Shim This patch has been floating for a while, Kyungmin, Kukjin, Thomas: shall it be applied? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
