Re: [PATCH 1/4] clk: samsung: register clk_div_tables for divider clocks

2013-03-12 Thread Thomas Abraham
On 12 March 2013 05:13, Heiko Stübner he...@sntech.de wrote: On some Samsung platforms divider clocks only use specific divider combinations like the armdiv on s3c2443 and s3c2416. For these usecases the generic divider clock already provides the option of providing a lookup table mapping

Re: [PATCH 2/4] clk: samsung: remove np check in clock init

2013-03-12 Thread Thomas Abraham
On 12 March 2013 05:14, Heiko Stübner he...@sntech.de wrote: This let to the suspend init never being reached on non-DT platforms. Signed-off-by: Heiko Stueber he...@sntech.de --- drivers/clk/samsung/clk.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 2/4] clk: samsung: remove np check in clock init

2013-03-12 Thread Heiko Stübner
Am Dienstag, 12. März 2013, 09:53:00 schrieb Thomas Abraham: On 12 March 2013 05:14, Heiko Stübner he...@sntech.de wrote: This let to the suspend init never being reached on non-DT platforms. Signed-off-by: Heiko Stueber he...@sntech.de --- drivers/clk/samsung/clk.c |2 -- 1

Re: [PATCH 2/4] clk: samsung: remove np check in clock init

2013-03-12 Thread Heiko Stübner
Am Dienstag, 12. März 2013, 10:02:55 schrieb Heiko Stübner: Am Dienstag, 12. März 2013, 09:53:00 schrieb Thomas Abraham: On 12 March 2013 05:14, Heiko Stübner he...@sntech.de wrote: This let to the suspend init never being reached on non-DT platforms. Signed-off-by: Heiko Stueber

Re: [PATCH 2/4] clk: samsung: remove np check in clock init

2013-03-12 Thread Thomas Abraham
On 12 March 2013 14:47, Heiko Stübner he...@sntech.de wrote: Am Dienstag, 12. März 2013, 10:02:55 schrieb Heiko Stübner: Am Dienstag, 12. März 2013, 09:53:00 schrieb Thomas Abraham: On 12 March 2013 05:14, Heiko Stübner he...@sntech.de wrote: This let to the suspend init never being reached

Re: [PATCH 2/4] clk: samsung: remove np check in clock init

2013-03-12 Thread Heiko Stübner
Am Dienstag, 12. März 2013, 10:36:54 schrieb Thomas Abraham: On 12 March 2013 14:47, Heiko Stübner he...@sntech.de wrote: Am Dienstag, 12. März 2013, 10:02:55 schrieb Heiko Stübner: Am Dienstag, 12. März 2013, 09:53:00 schrieb Thomas Abraham: On 12 March 2013 05:14, Heiko Stübner

Re: [PATCH 4/4] clk: samsung: add infrastructure to add separate aliases

2013-03-12 Thread Thomas Abraham
On 12 March 2013 05:15, Heiko Stübner he...@sntech.de wrote: The current code adds aliases, if necessary, directly when adding the clock, limiting the number of possible aliases to one. Some platforms need more than one alias, like the hsmmc pclocks on s3c2416 which need a hsmmc and

[PATCH V4 0/4] cpufreq: exynos5440: support for cpufreq driver

2013-03-12 Thread Amit Daniel Kachhap
Submitting the V4 version of exynos5440 cpufreq driver. This patchset addresses all the coding and design concerns raised especially by Viresh. Changes in V4: * Added dev_err logs instead of pr_err. * Used the devm_ioremap_resource API. * Implemented several coding guidelines and minor error

[PATCH V4 1/4] cpufreq: exynos: Adding cpufreq driver for exynos5440

2013-03-12 Thread Amit Daniel Kachhap
This patch adds dvfs support for exynos5440 SOC. This soc has 4 cores and they scale at same frequency. The nature of exynos5440 clock controller is different from previous exynos controllers so not using the common exynos cpufreq framework. The major difference being interrupt notfication for

[PATCH V4 2/4] cpufreq: exynos: Remove error return even if no soc is found

2013-03-12 Thread Amit Daniel Kachhap
This patch helps to have single binary for exynos5440 and previous exynos soc's. This change is needed for adding exynos5440 cpufreq driver which does not uses exynos-cpufreq common file and adds it own driver. Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com ---

[PATCH V4 3/4] arm: exynos: Enable OPP library support for exynos5440

2013-03-12 Thread Amit Daniel Kachhap
The OPP library support is needed for exynos5440 cpu frequency dynamic scaling driver. Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com --- arch/arm/mach-exynos/Kconfig |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-exynos/Kconfig

[PATCH V4 4/4] dts: Add cpufreq controller node for Exynos5440 SoC

2013-03-12 Thread Amit Daniel Kachhap
Add cpufreq controller device node for Exynos5440 SoC for passing parameters like controller base address, interrupt and cpufreq table. This node is added outside cpu0 as this driver is now a platform driver and a new device structure is needed. Signed-off-by: Amit Daniel Kachhap

Re: [PATCH 4/4] clk: samsung: add infrastructure to add separate aliases

2013-03-12 Thread Heiko Stübner
Am Dienstag, 12. März 2013, 10:57:30 schrieb Thomas Abraham: On 12 March 2013 05:15, Heiko Stübner he...@sntech.de wrote: The current code adds aliases, if necessary, directly when adding the clock, limiting the number of possible aliases to one. Some platforms need more than one alias,

Re: [PATCH 4/4] clk: samsung: add infrastructure to add separate aliases

2013-03-12 Thread Thomas Abraham
On 12 March 2013 15:34, Heiko Stübner he...@sntech.de wrote: Am Dienstag, 12. März 2013, 10:57:30 schrieb Thomas Abraham: On 12 March 2013 05:15, Heiko Stübner he...@sntech.de wrote: The current code adds aliases, if necessary, directly when adding the clock, limiting the number of possible

Re: [PATCH V4 1/4] cpufreq: exynos: Adding cpufreq driver for exynos5440

2013-03-12 Thread Viresh Kumar
This is what Russell told me a long time back: Don't use Adding, Fixing, etc words as this work is not something, which is already done. So your subject should have been: cpufreq: exynos: Add cpufreq driver for exynos5440 Fix it if you need another version, which i believe you do :) On Tue, Mar

Re: [PATCH 3/4] clk: samsung: always allocate the clk_table

2013-03-12 Thread Heiko Stübner
Am Dienstag, 12. März 2013, 10:54:47 schrieb Thomas Abraham: On 12 March 2013 05:14, Heiko Stübner he...@sntech.de wrote: This is needed to allow looking up previous created clocks when adding separate aliases to them. Signed-off-by: Heiko Stuebner he...@sntech.de ---

Re: [PATCH 3/4] clk: samsung: always allocate the clk_table

2013-03-12 Thread Sylwester Nawrocki
Hi, On 03/12/2013 10:54 AM, Thomas Abraham wrote: This change is fine but one point that should be considered is that on non-dt platforms, the memory allocation of clk_table cannot really be justified just because few clocks require two or more aliases. Instead, the optional alias passed for

Re: [PATCH 3/4] clk: samsung: always allocate the clk_table

2013-03-12 Thread Thomas Abraham
On 12 March 2013 16:20, Heiko Stübner he...@sntech.de wrote: Am Dienstag, 12. März 2013, 10:54:47 schrieb Thomas Abraham: On 12 March 2013 05:14, Heiko Stübner he...@sntech.de wrote: This is needed to allow looking up previous created clocks when adding separate aliases to them.

Re: [PATCH 1/7] clk: samsung: add plls used in s3c2416 and s3c2443

2013-03-12 Thread Russell King - ARM Linux
On Tue, Mar 12, 2013 at 01:42:19AM +0100, Heiko Stübner wrote: + clk = clk_register(NULL, pll-hw); + if (IS_ERR(clk)) { + pr_err(%s: failed to register pll clock %s\n, __func__, + name); + kfree(pll); + } + + if

Re: [PATCH 3/4] clk: samsung: always allocate the clk_table

2013-03-12 Thread Thomas Abraham
On 12 March 2013 16:53, Sylwester Nawrocki s.nawro...@samsung.com wrote: Hi, On 03/12/2013 10:54 AM, Thomas Abraham wrote: This change is fine but one point that should be considered is that on non-dt platforms, the memory allocation of clk_table cannot really be justified just because few

Re: [PATCH 1/7] clk: samsung: add plls used in s3c2416 and s3c2443

2013-03-12 Thread Heiko Stübner
Am Dienstag, 12. März 2013, 13:10:42 schrieb Sylwester Nawrocki: Hi, On 03/12/2013 01:42 AM, Heiko Stübner wrote: This adds support for pll2126x, pll3000x, pll6552x and pll6553x. Signed-off-by: Heiko Stuebner he...@sntech.de --- drivers/clk/samsung/clk-pll.c | 376

Re: [PATCH 1/7] clk: samsung: add plls used in s3c2416 and s3c2443

2013-03-12 Thread Sylwester Nawrocki
On 03/12/2013 01:21 PM, Heiko Stübner wrote: Thanks for the hint ... this is what I rightfully get for mindlessly copying from the other plls in the file;-) . :) What about the other plls in the pll-file, they should be affected in the same way, right? Yes, they're of course also

Re: [PATCH 3/4] clk: samsung: always allocate the clk_table

2013-03-12 Thread Sylwester Nawrocki
On 03/12/2013 12:46 PM, Thomas Abraham wrote: And, you mentioned Exynos4 will be dt-only from 3.10. Does that mean we just drop support for universal and nuri non-dt board support? Or, will there be a equivalent dt support added for these boards? I think Tomasz has some initial dts files for

Re: [RFC 04/12] s5p-csis: Adding Exynos5250 compatibility

2013-03-12 Thread Sylwester Nawrocki
Hi Shaik, On 03/11/2013 07:58 AM, Shaik Ameer Basha wrote: Hi Sylwester, On Mon, Mar 11, 2013 at 2:10 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: Please don't leave the change log empty. I'll apply this patch. I'm just

Re: [PATCH 3/4] clk: samsung: always allocate the clk_table

2013-03-12 Thread Thomas Abraham
On 12 March 2013 19:18, Sylwester Nawrocki s.nawro...@samsung.com wrote: On 03/12/2013 12:46 PM, Thomas Abraham wrote: And, you mentioned Exynos4 will be dt-only from 3.10. Does that mean we just drop support for universal and nuri non-dt board support? Or, will there be a equivalent dt

Re: [RFC PATCH 1/8] s5p-fimc: Add Exynos4x12 FIMC-IS driver

2013-03-12 Thread Hans Verkuil
On Mon 11 March 2013 20:44:45 Sylwester Nawrocki wrote: This patch adds a set of core files of the Exynos4x12 FIMC-IS V4L2 driver. This includes main functionality like allocating memory, loading the firmware, FIMC-IS register interface and host CPU - IS command and error code definitions.

Re: [RFC PATCH 5/8] s5p-fimc: Add ISP video capture driver stubs

2013-03-12 Thread Hans Verkuil
On Mon 11 March 2013 20:44:49 Sylwester Nawrocki wrote: This patch adds a video capture node for the FIMC-IS ISP IP block and Makefile/Kconfig to actually enable the driver's compilation. The ISP video capture driver is still a work in progress. Signed-off-by: Sylwester Nawrocki

Re: [RFC 12/12] mipi-csis: Enable all interrupts for fimc-is usage

2013-03-12 Thread Sylwester Nawrocki
Hi Arun, On 03/08/2013 03:59 PM, Arun Kumar K wrote: FIMC-IS firmware needs all the MIPI-CSIS interrupts to be enabled. This patch enables all those MIPI interrupts. Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-fimc/mipi-csis.c |2 +- 1 file changed,

Re: [PATCH v2] iio: adc: exynos5_adc: fix compilation warnings

2013-03-12 Thread Doug Anderson
Naveen, On Wed, Mar 6, 2013 at 7:09 PM, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: - unsigned intversion; + unsigned intversion; Given that you've changed exynos_adc_get_version() to return an int, shouldn't this be an int too (not unsigned)?

[PATCH] ASoC: samsung: remove last traces of neo1973-gta01

2013-03-12 Thread Paul Bolle
The (rudimentary) support for the Openmoko Neo1973 GTA01 got removed in commit 1ae5cbc52e7c6619a3f44b87809fd25370df31bb (ASoC: neo1973_wm8753: remove references to the neo1973-gta01 machine). Remove its last traces in the Kconfig file too. Signed-off-by: Paul Bolle pebo...@tiscali.nl ---

[PATCH] USB: ehci-s5p: Fix phy reset

2013-03-12 Thread Alexander Graf
On my Exynos 5 based Arndale system, I need to pull the reset line down and then let it go up again to actually perform a reset. Without that reset, I can't find any USB hubs on my bus, rendering the USB controller useless. So this patch implements the above logic, making EHCI and OHCI work on

Re: [PATCH 3/4] clk: samsung: always allocate the clk_table

2013-03-12 Thread Alim Akhtar
Hi All On Tue, Mar 12, 2013 at 7:54 PM, Thomas Abraham thomas.abra...@linaro.org wrote: On 12 March 2013 19:18, Sylwester Nawrocki s.nawro...@samsung.com wrote: On 03/12/2013 12:46 PM, Thomas Abraham wrote: And, you mentioned Exynos4 will be dt-only from 3.10. Does that mean we just drop

Re: [PATCH 3/4] clk: samsung: always allocate the clk_table

2013-03-12 Thread Sachin Kamat
So except Universal_c210 and Nuri the only ones not supporting booting from DT are these two simple boards, which seem to be maintained by Samsung: arch/arm/mach-exynos/mach-smdk4x12.c SMDK4412 is already supported through DT (exynos4412-smdk4412.dts) as you already pointed out. I am not

Re: [RFC 12/12] mipi-csis: Enable all interrupts for fimc-is usage

2013-03-12 Thread Arun Kumar K
Hi Sylwester, /* Interrupt mask */ #define S5PCSIS_INTMSK 0x10 -#define S5PCSIS_INTMSK_EN_ALL0xf000103f +#define S5PCSIS_INTMSK_EN_ALL0xfc00103f Do you know what interrupts are assigned to the CSIS_INTMSK bits 26, 27 ? In the

[PATCH v3] iio: adc: exynos5_adc: fix compilation warnings

2013-03-12 Thread Naveen Krishna Chatradhi
Fixes the compilation warnings and potential NULL pointer dereferencing pointed out by Dan Carpenter. Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com Cc: Jonathan Cameron ji...@cam.ac.uk Cc: Lars-Peter Clausen l...@metafoo.de Series-To: linux-...@vger.kernel.org Cc:

[GIT PULL] Samsung fixes for v3.9

2013-03-12 Thread Kukjin Kim
Hi Arnd, Olof, Here is Samsung fixes for v3.9. Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git v3.9-samsung-fixes-1 There are two commits for fix pl330 dma clkdev entries on s5pv210 and generic dma binding support on exynos stuff. If any problems, please

Re: [PATCH 3/4] clk: samsung: always allocate the clk_table

2013-03-12 Thread Kyungmin Park
On Tue, Mar 12, 2013 at 10:48 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: On 03/12/2013 12:46 PM, Thomas Abraham wrote: And, you mentioned Exynos4 will be dt-only from 3.10. Does that mean we just drop support for universal and nuri non-dt board support? Or, will there be a equivalent

[PATCH 3/3] ARM: dts: Add keypad entries to SMDK4412

2013-03-12 Thread Sachin Kamat
Added keypad node entries to SMDK4412 board DT file. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/boot/dts/exynos4412-smdk4412.dts | 87 + 1 files changed, 87 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/exynos4412-smdk4412.dts

Re: [PATCH V2] DMA: PL330: Add check if device tree compatible

2013-03-12 Thread Padma Venkat
Hi, On Tue, Mar 5, 2013 at 2:55 PM, Padmavathi Venna padm...@samsung.com wrote: This patch register the dma controller with generic dma helpers only in DT case. This also adds some extra error handling in the driver. Signed-off-by: Padmavathi Venna padm...@samsung.com Reported-by: Sachin