Re: [PATCHv2 1/2] iommu/exynos: add devices attached to the System MMU to an IOMMU group

2013-07-25 Thread Sachin Kamat
Hi Antonios, On 25 July 2013 21:04, Antonios Motakis wrote: > IOMMU groups are expected by certain users of the IOMMU API, > e.g. VFIO. Since each device is behind its own System MMU, we > can allocate a new IOMMU group for each device. > > This patch depends on Cho KyongHo's patch series titled

Re: [PATCH 1/3] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

2013-07-25 Thread Doug Anderson
Tomasz, On Thu, Jul 25, 2013 at 3:27 AM, Tomasz Figa wrote: > Hi Leela, > > On Wednesday 24 of July 2013 15:08:17 Leela Krishna Amudala wrote: >> This patch parses the watchdog node to read pmu wdt sys registers >> addresses and do mask/unmask enable/disable of WDT in probe and s2r >> scenarios.

Re: [PATCH] clk: exynos4: Add CLK_GET_RATE_NOCACHE flag for the Exynos4x12 ISP clocks

2013-07-25 Thread Sylwester Nawrocki
On 07/25/2013 10:23 PM, Mike Turquette wrote: Quoting Sylwester Nawrocki (2013-07-22 05:14:40) On 06/24/2013 08:42 PM, Sylwester Nawrocki wrote: The ISP clock registers belong to the ISP power domain and may change their values if this power domain is switched off/on. Add CLK_GET_RATE_NOCACHE f

[PATCH v2] clk: exynos4: Add CLK_GET_RATE_NOCACHE flag for the Exynos4x12 ISP clocks

2013-07-25 Thread Sylwester Nawrocki
From: Sylwester Nawrocki The ISP clock registers belong to the ISP power domain and may change their values if this power domain is switched off/on. Add CLK_GET_RATE_NOCACHE flags to ensure we do not rely on invalid cached data when setting or getting frequency of those clocks. Signed-off-by: Sy

Re: [PATCH 2/3] ARM: exynos5420: dt: add clock entries to watchdog node

2013-07-25 Thread Stephen Warren
On 07/24/2013 07:14 AM, Tomasz Figa wrote: > On Wednesday 24 of July 2013 16:51:06 Sachin Kamat wrote: ... >> This is contrary to the fact that we disable everything by default in >> the top level dt files and only enable them as required in the board >> dts files. > > No, we don't disable everyth

Re: [PATCH v5 4/5] clk: add CLK_SET_RATE_NO_REPARENT flag

2013-07-25 Thread Mike Turquette
Quoting James Hogan (2013-07-25 05:55:09) > Hi Sylwester > > On 25/07/13 13:34, Sylwester Nawrocki wrote: > > On 06/13/2013 06:06 PM, James Hogan wrote: > >> Add a CLK_SET_RATE_NO_REPARENT clock flag, which will prevent muxes > >> being reparented during clk_set_rate. > >> > >> To avoid breaking e

Re: [PATCH] V4L: Add driver for Samsung S5K5BAF camera sensor

2013-07-25 Thread Sylwester Nawrocki
Hi Hans, On 07/25/2013 04:42 PM, Hans Verkuil wrote: > > Would it be an idea to create a library with rectangle manipulation functions? > Looking at this driver and similar ones as well that I had to deal with that > support cropping/scaling/composing I see a lot of rectangle manipulation. > > Mo

[PATCH 2/2] iommu/exynos: Follow kernel coding style for __sysmmu_enable return type

2013-07-25 Thread Antonios Motakis
On success, the __sysmmu_enable returns 1 instead of 0, which does not respect the convention described in Chapter 16 of the Linux kernel coding style. In fact, this return value is propagated all the way up to iommu_attach_device() and iommu_attach_device() in drivers/iommu.c, which results into

[PATCHv2 1/2] iommu/exynos: add devices attached to the System MMU to an IOMMU group

2013-07-25 Thread Antonios Motakis
IOMMU groups are expected by certain users of the IOMMU API, e.g. VFIO. Since each device is behind its own System MMU, we can allocate a new IOMMU group for each device. This patch depends on Cho KyongHo's patch series titled "[PATCH v7 00/12] iommu/exynos: Fixes and Enhancements of System MMU dr

Re: [PATCH] V4L: Add driver for Samsung S5K5BAF camera sensor

2013-07-25 Thread Hans Verkuil
On Wed 24 July 2013 19:51:03 Sylwester Nawrocki wrote: > From: Andrzej Hajda > > This patch adds V4L2 subdev driver for Samsung S5K5BAF CMOS > image sensor with embedded SoC ISP. > > The driver exposes two V4L2 subdevices: > - S5K5BAF-CIS - pure CMOS Image Sensor, fixed 1600x1200 format, > no

XCLKOUT in exynos5250 clock driver

2013-07-25 Thread Mark Brown
I appear to be missing something in the clock driver for the exynos5250. I'm looking at the Arndale schematic and I see that the audio master clock is connected to XCLKOUT on the SoC. However I can't see any reference to XCLKOUT or anything similar in the clock driver or any of the DTS files - whe

Re: [PATCH v5 4/5] clk: add CLK_SET_RATE_NO_REPARENT flag

2013-07-25 Thread James Hogan
Hi Sylwester On 25/07/13 13:34, Sylwester Nawrocki wrote: > On 06/13/2013 06:06 PM, James Hogan wrote: >> Add a CLK_SET_RATE_NO_REPARENT clock flag, which will prevent muxes >> being reparented during clk_set_rate. >> >> To avoid breaking existing platforms, all callers of clk_register_mux() >> ar

Re: [PATCH v5 4/5] clk: add CLK_SET_RATE_NO_REPARENT flag

2013-07-25 Thread Sylwester Nawrocki
Hi James, On 06/13/2013 06:06 PM, James Hogan wrote: > Add a CLK_SET_RATE_NO_REPARENT clock flag, which will prevent muxes > being reparented during clk_set_rate. > > To avoid breaking existing platforms, all callers of clk_register_mux() > are adjusted to pass the new flag. Platform maintainers

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-25 Thread Mark Brown
On Thu, Jul 25, 2013 at 01:00:49PM +0200, Arnd Bergmann wrote: > I'm not saying that we can't support legacy board files with the common > PHY framework, but I'd expect things to be much easier if we focus on those > platforms that are actively being worked on for now, to bring an end to the > poi

Re: [PATCH] ARM: EXYNOS: cpuidle: Skip C1 cpuidle state for exynos5440

2013-07-25 Thread Bartlomiej Zolnierkiewicz
[ added Daniel and linux-pm to cc: ] Hi, On Wednesday, July 24, 2013 03:23:35 PM Amit Daniel Kachhap wrote: > This patch skips the deep C1(AFTR -Arm off top running) state for exynos5440 > soc as this soc does not support this state. All the cpu's only allows the > basic > C0 state. > > Signed

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-25 Thread Laurent Pinchart
Hi Arnd, On Thursday 25 July 2013 13:00:49 Arnd Bergmann wrote: > On Thursday 25 July 2013, Laurent Pinchart wrote: > > On Wednesday 24 July 2013 20:32:03 Arnd Bergmann wrote: > > > On Tuesday 23 July 2013, Tomasz Figa wrote: > > > > On Tuesday 23 of July 2013 17:14:20 Alan Stern wrote: > > > > > O

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-25 Thread Arnd Bergmann
On Thursday 25 July 2013, Laurent Pinchart wrote: > On Wednesday 24 July 2013 20:32:03 Arnd Bergmann wrote: > > On Tuesday 23 July 2013, Tomasz Figa wrote: > > > On Tuesday 23 of July 2013 17:14:20 Alan Stern wrote: > > > > On Tue, 23 Jul 2013, Tomasz Figa wrote: > > > > > Where would you want to h

Re: [PATCH 1/3] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

2013-07-25 Thread Tomasz Figa
Hi Leela, On Wednesday 24 of July 2013 15:08:17 Leela Krishna Amudala wrote: > This patch parses the watchdog node to read pmu wdt sys registers > addresses and do mask/unmask enable/disable of WDT in probe and s2r > scenarios. > > Reviewed-by: Doug Anderson > Signed-off-by: Leela Krishna Amudal

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-25 Thread Laurent Pinchart
Hi Arnd, On Wednesday 24 July 2013 20:32:03 Arnd Bergmann wrote: > On Tuesday 23 July 2013, Tomasz Figa wrote: > > On Tuesday 23 of July 2013 17:14:20 Alan Stern wrote: > > > On Tue, 23 Jul 2013, Tomasz Figa wrote: > > > > Where would you want to have those phy_address arrays stored? There > > > >

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-25 Thread Mark Brown
On Wed, Jul 24, 2013 at 08:32:03PM +0200, Arnd Bergmann wrote: > Sorry for jumping in to the middle of the discussion, but why does a *new* > framework even bother defining an interface for board files? > Can't we just drop any interfaces for platform data passing in the phy > framework and put t

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-25 Thread Sylwester Nawrocki
On 07/24/2013 08:32 PM, Arnd Bergmann wrote: > On Tuesday 23 July 2013, Tomasz Figa wrote: >> On Tuesday 23 of July 2013 17:14:20 Alan Stern wrote: >>> On Tue, 23 Jul 2013, Tomasz Figa wrote: Where would you want to have those phy_address arrays stored? There are no board files when booti

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-25 Thread Arnd Bergmann
On Thursday 25 July 2013, Kishon Vijay Abraham I wrote: > On Thursday 25 July 2013 12:02 AM, Arnd Bergmann wrote: > > On Tuesday 23 July 2013, Tomasz Figa wrote: > >> On Tuesday 23 of July 2013 17:14:20 Alan Stern wrote: > >>> On Tue, 23 Jul 2013, Tomasz Figa wrote: > Where would you want to h

Re: [PATCH v3 07/22] ARM: dts: Remove '0x's from Exynos4210 DTSI file

2013-07-25 Thread Lee Jones
On Wed, 24 Jul 2013, Tomasz Figa wrote: > On Wednesday 24 of July 2013 16:09:37 Lee Jones wrote: > > ... for the sake of consistency and assumed convention. > > > > Cc: Kukjin Kim > > Cc: linux-samsung-soc@vger.kernel.org > > Signed-off-by: Lee Jones > > > > diff --git a/arch/arm/boot/dts/exyn

[PATCH v3 3/9] ARM: dts: exynos5250: move common i2c properties to exynos5 dtsi

2013-07-25 Thread Rahul Sharma
I2C nodes shares many properties across exynos5 SoCs (exynos5250 and exyno5420). Common code is moved to exynos5.dtsi which is included in exyno5250 and exynos5420 SoC files. Signed-off-by: Rahul Sharma --- arch/arm/boot/dts/exynos5.dtsi| 36 + arch/arm/

[PATCH v3 6/9] ARM: dts: exynos5420: add dt nodes for hdmi subsystem

2013-07-25 Thread Rahul Sharma
Add hdmi, mixer, ddc device tree nodes for Exynos 5420 SoC. Signed-off-by: Rahul Sharma --- arch/arm/boot/dts/exynos5420-smdk5420.dts | 20 arch/arm/boot/dts/exynos5420.dtsi |8 2 files changed, 28 insertions(+) diff --git a/arch/arm/boot/dts/exynos54

[PATCH v3 8/9] ARM: dts: exynos5420: add hdmi hpd gpio pinctrl node

2013-07-25 Thread Rahul Sharma
Add pinctrl node for hdmi-hpd gpio pin to exynos5420 device tree files. Signed-off-by: Rahul Sharma --- arch/arm/boot/dts/exynos5420-smdk5420.dts | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.

[PATCH v3 1/9] ARM: dts: exynos5250: add mixer clocks to mixer node

2013-07-25 Thread Rahul Sharma
From: Sean Paul This patch adds the mixer clocks to the mixer node in the exynos 5250 dts file. Signed-off-by: Sean Paul Signed-off-by: Rahul Sharma --- arch/arm/boot/dts/exynos5250.dtsi |2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boo

[PATCH v3 9/9] of/documentation: update with clock information for exynos hdmi subsystem

2013-07-25 Thread Rahul Sharma
Adding information about clocks to the binding documentation for exynos mixer and hdmi. Signed-off-by: Rahul Sharma --- Documentation/devicetree/bindings/video/exynos_hdmi.txt | 14 +- Documentation/devicetree/bindings/video/exynos_mixer.txt |4 2 files changed, 17 insert

[PATCH v3 4/9] ARM: dts: exynos5420: add i2c device nodes

2013-07-25 Thread Rahul Sharma
From: Andrew Bresticker This adds device-tree nodes for the i2c busses on Exynos 5420 platforms. Signed-off-by: Andrew Bresticker Signed-off-by: Rahul Sharma --- arch/arm/boot/dts/exynos5420.dtsi | 32 1 file changed, 32 insertions(+) diff --git a/arch/arm/

[PATCH v3 7/9] ARM: dts: exynos5420: add clocks for hdmi subsystem

2013-07-25 Thread Rahul Sharma
Add clocks for hdmi and mixer for exynos5420 SoC. Signed-off-by: Rahul Sharma --- arch/arm/boot/dts/exynos5420.dtsi |6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi index 93caef7..5fa4093 100644 --- a/arch/arm/boo

[PATCH v3 0/9] ARM: dts: exynos: add support for hdmi subsystem

2013-07-25 Thread Rahul Sharma
Common properties for I2C and Hdmi Subsystem is moved to exynos5 dtsi file. It also adds Device tree nodes and clocks information for exynos5420 and exynos5250 SoCs. It adds pinctrl node for hdmi hpd gpio and update binding documents. This set is based on kukjin's for-next branch at http://git.ker

[PATCH v3 2/9] ARM: dts: exynos5250: add clocks to hdmi dt node

2013-07-25 Thread Rahul Sharma
Fix wrong clock numbers in hdmi dt node. Removed hdmiphy clock which was a dummy clock earlier and not required now. Also added mux clock to change the clock parent. Signed-off-by: Rahul Sharma --- arch/arm/boot/dts/exynos5250.dtsi |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH v3 5/9] ARM: dts: exynos5250: move common hdmi properties to exynos5 dtsi

2013-07-25 Thread Rahul Sharma
Hdmi Subsystem nodes shares many properties across exynos5 SoCs (exynos5250 and exyno5420). Common code is moved to exynos5.dtsi which is included in exyno5250 and exynos5420 SoC files. It also renames the hdmi and mixer nodes as per dt naming convention in the format name@phy_add. Signed-off-by: