Re: [PATCH v8 12/12] V4L: Add driver for s5k4e5 image sensor

2013-09-15 Thread Arun Kumar K
Hi Philipp, >> +Example: >> + >> + i2c-isp@1313 { >> + s5k4e5@20 { >> + compatible = "samsung,s5k4e5"; >> + reg = <0x20>; >> + gpios = <&gpx1 2 1>; > > This probably should be 'reset-gpios', too. > Yes thats right. I

[PATCH] irqchip: exynos-combiner: remove hard-coded irq_base value

2013-09-15 Thread Chander Kashyap
Pass '0' in place of hardcoded "irq_base" value as "first_irq" parameter to "irq_domain_add_simple" in order to use linear irq domain. Signed-off-by: Chander Kashyap --- drivers/irqchip/exynos-combiner.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drive

Re: [PATCH v3 2/4] [media] exynos-scaler: Add core functionality for the SCALER driver

2013-09-15 Thread Sylwester Nawrocki
Hi Shaik, Thanks for addressing my comments, it really looks much better now. I have few more comments, mostly minor issues. On 09/12/2013 03:09 PM, Shaik Ameer Basha wrote: This patch adds the core functionality for the SCALER driver. Signed-off-by: Shaik Ameer Basha --- drivers/media/platf

Re: [PATCH RFC 6/7] exynos-gsc: Use mem-to-mem ioctl helpers

2013-09-15 Thread Sylwester Nawrocki
Hi Shaik, On 09/13/2013 04:12 PM, Shaik Ameer Basha wrote: [...] -static int gsc_m2m_streamon(struct file *file, void *fh, - enum v4l2_buf_type type) -{ - struct gsc_ctx *ctx = fh_to_ctx(fh); - - /* The source and target color format need to be set */ -

Re: [PATCH RFC 1/7] V4L: Add mem2mem ioctl and file operation helpers

2013-09-15 Thread Sylwester Nawrocki
Hi Philipp, On 09/13/2013 03:13 PM, Philipp Zabel wrote: Am Freitag, den 13.09.2013, 14:56 +0200 schrieb Sylwester Nawrocki: This patch adds ioctl helpers to the V4L2 mem-to-mem API, so we can avoid several ioctl handlers in the mem-to-mem video node drivers that are simply a pass-through to th

Re: [PATCH RFC 2/7] mem2mem_testdev: Use mem-to-mem ioctl and vb2 helpers

2013-09-15 Thread Sylwester Nawrocki
Hi Philipp, On 09/13/2013 03:08 PM, Philipp Zabel wrote: Am Freitag, den 13.09.2013, 14:56 +0200 schrieb Sylwester Nawrocki: [...] @@ -865,6 +793,7 @@ static int queue_init(void *priv, struct vb2_queue *src_vq, struct vb2_queue *ds dst_vq->ops =&m2mtest_qops; dst_vq->mem_ops =