Re: [PATCH 3/6] thermal: exynos: Provide initial setting for TMU's test MUX address at Exynos4412

2013-09-30 Thread Lukasz Majewski
Hi Amit, > Hi, > > On Tue, Sep 24, 2013 at 1:38 PM, Lukasz Majewski > wrote: > > The commit d0a0ce3e77c795258d47f9163e92d5031d0c5221 ("thermal: > > exynos: Add missing definations and code cleanup") has removed > > setting of test MUX address value at TMU configuration setting. > > > > This fiel

Re: [PATCH 1/3] ahci: exynos: add ahci sata support on Exynos platform

2013-09-30 Thread Sachin Kamat
Hi Yuvaraj, On 1 October 2013 12:03, Yuvaraj Kumar C D wrote: > Exynos5250 contains one Synopsys AHCI SATA controller.The avalaible > ahci_platform driver is not sufficient to handle the AHCI PHY and PHY > clock related initialization. > +err_out: > + platform_set_drvdata(pdev, NUL

Re: [PATCH 3/3] ARM: dts: Enable ahci sata and sata phy

2013-09-30 Thread Sachin Kamat
Hi Yuvaraj, On 1 October 2013 12:03, Yuvaraj Kumar C D wrote: > This patch adds dt entry for ahci sata controller and its > corresponding phy controller.phy node has been added w.r.t > new generic phy framework. [snip] > + > + sata-phy { Shouldn't this be sata-phy@38? > +

[PATCH 2/3] Phy: Exynos: Add Exynos5250 sata phy driver

2013-09-30 Thread Yuvaraj Kumar C D
This patch adds the sata phy driver for Exynos5250.Exynos5250 sata phy comprises of CMU and TRSV blocks which are of I2C register Map. So this patch also adds a i2c client driver, which is used configure the CMU and TRSV block of exynos5250 SATA PHY. This patch incorporates the generic phy framewo

[PATCH 3/3] ARM: dts: Enable ahci sata and sata phy

2013-09-30 Thread Yuvaraj Kumar C D
This patch adds dt entry for ahci sata controller and its corresponding phy controller.phy node has been added w.r.t new generic phy framework. Signed-off-by: Yuvaraj Kumar C D --- arch/arm/boot/dts/exynos5250-arndale.dts |9 - arch/arm/boot/dts/exynos5250-smdk5250.dts |6 +-

[PATCH 0/3] Exynos5250 SATA Support

2013-09-30 Thread Yuvaraj Kumar C D
This series adds the SATA support on exynos5250 SOC.Also it uses generic phy framework patch[1] posted by Kishon Vijay Abraham I. [1].drivers: phy: add generic PHY framework. Yuvaraj Kumar C D (3): ahci: exynos: add ahci sata support on Exynos platform Phy: Exynos: Add Exynos5250 sa

[PATCH 1/3] ahci: exynos: add ahci sata support on Exynos platform

2013-09-30 Thread Yuvaraj Kumar C D
Exynos5250 contains one Synopsys AHCI SATA controller.The avalaible ahci_platform driver is not sufficient to handle the AHCI PHY and PHY clock related initialization. This patch adds exynos specific ahci sata driver,contained the exynos specific initialized codes, re-use the generic ahci_platform

Re: [PATCH V5 1/5] ARM: dts: Add MIPI PHY node to exynos4.dtsi

2013-09-30 Thread Kishon Vijay Abraham I
Hi, On Sunday 29 September 2013 12:57 AM, Sylwester Nawrocki wrote: > Add PHY provider node for the MIPI CSIS and MIPI DSIM PHYs. > > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Kyungmin Park > Acked-by: Felipe Balbi Can this patch be taken through exynos dt tree? Thanks Kishon > ---

RE: [PATCH 1/7] drm/exynos: move hdmiphy related code to hdmiphy driver

2013-09-30 Thread Inki Dae
> -Original Message- > From: linux-samsung-soc-ow...@vger.kernel.org [mailto:linux-samsung-soc- > ow...@vger.kernel.org] On Behalf Of Tomasz Figa > Sent: Monday, September 30, 2013 8:13 AM > To: Sylwester Nawrocki > Cc: Inki Dae; Rahul Sharma; devicet...@vger.kernel.org; linux-samsung-soc

RE: [PATCH 1/7] drm/exynos: move hdmiphy related code to hdmiphy driver

2013-09-30 Thread Inki Dae
> -Original Message- > From: Sylwester Nawrocki [mailto:sylvester.nawro...@gmail.com] > Sent: Monday, September 30, 2013 7:09 AM > To: Inki Dae > Cc: Rahul Sharma; devicet...@vger.kernel.org; linux-samsung-soc; > sw0312.kim; sunil joshi; dri-devel; kgene.kim; Shirish S; Sylwester > Nawroc

[PATCH] ARM: dts: Add HDMI related I2C nodes for Arndale board

2013-09-30 Thread Tushar Behera
From: Sachin Kamat Updated I2C nodes for HDMI-DDC and HDMI-PHY for Arndale board. Signed-off-by: Sachin Kamat Signed-off-by: Tushar Behera --- arch/arm/boot/dts/exynos5250-arndale.dts | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/

Re: [PATCH] PCI: exynos: missing clk_disable_unprepare() on error in exynos_pcie_probe()

2013-09-30 Thread Jingoo Han
On Sunday, September 29, 2013 11:29 AM, Wei Yongjun wrote: > > From: Wei Yongjun > > Add the missing clk_disable_unprepare() before return > from exynos_pcie_probe() in the error handling case. > > Signed-off-by: Wei Yongjun Acked-by: Jingoo Han However, the commit name should be fixed as b

Re: [PATCH 2/7] Initial skeleton of VFIO support for Device Tree based devices

2013-09-30 Thread Alex Williamson
On Mon, 2013-09-30 at 17:28 +0200, Antonios Motakis wrote: > Platform devices in the Linux kernel are usually managed by the DT > interface. This patch forms the base to support these kind of devices > with VFIO. > > Signed-off-by: Antonios Motakis > --- > drivers/vfio/Kconfig | 11 +++

Re: [RFC PATCH v2 0/7] VFIO for device tree based platform devices (work in progress)

2013-09-30 Thread Alex Williamson
On Mon, 2013-09-30 at 17:28 +0200, Antonios Motakis wrote: > This is a preview of the base work, towards VFIO support on ARM platforms > with an IOMMU. It forms a base on to which to implement the functionality > necessary to enable using device tree devices on ARM (and other platforms > based on d

Re: [PATCH 3/7] Return info for device and its memory regions and interrupts

2013-09-30 Thread Alex Williamson
On Mon, 2013-09-30 at 17:28 +0200, Antonios Motakis wrote: > A VFIO userspace driver will start by opening the VFIO device > that corresponds to an IOMMU group, and will use the ioctl interface > to get the basic device info, such as number of memory regions and > interrupts, and their properties.

Re: [PATCH 1/7] VFIO_IOMMU_TYPE1 workaround to build for platform devices

2013-09-30 Thread Alex Williamson
On Mon, 2013-09-30 at 17:28 +0200, Antonios Motakis wrote: > This is a workaround to make the VFIO_IOMMU_TYPE1 driver usable with > platform devices instead of PCI. A future permanent fix should support > both. This is required in order to use the Exynos SMMU, or ARM SMMU > driver with VFIO. > > S

Re: [PATCH 6/7] VFIO: Update documentation for VFIO_IOMMU_TYPE1 driver

2013-09-30 Thread Alex Williamson
On Mon, 2013-09-30 at 17:28 +0200, Antonios Motakis wrote: > The VFIO documentation is slightly out of date. This minor correction > replaces references to VFIO_IOMMU_X86 with the correct reference to > VFIO_IOMMU_TYPE1 > > Signed-off-by: Antonios Motakis > --- > Documentation/vfio.txt | 8 -

Re: [PATCH 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

2013-09-30 Thread Tomasz Figa
Doug, On Monday 30 of September 2013 09:54:33 Doug Anderson wrote: > Tomasz, > > On Sat, Sep 28, 2013 at 6:49 PM, Tomasz Figa wrote: > >> On Fri, Sep 27, 2013 at 11:14 AM, Tomasz Figa > > wrote: > >> >> So isn't the register in the PMU there to save power in the case that > >> >> the watchdog t

Re: [PATCH 3/4] watchdog: s3c2410_wdt: parse watchdog dt node to read PMU registers adresses

2013-09-30 Thread Doug Anderson
Tomasz, On Sat, Sep 28, 2013 at 6:49 PM, Tomasz Figa wrote: >> On Fri, Sep 27, 2013 at 11:14 AM, Tomasz Figa > wrote: >> >> So isn't the register in the PMU there to save power in the case that >> >> the watchdog timer isn't being used? How is the PMU "driver" to know >> >> whether the watchdog

RE: [PATCH 3/7] Return info for device and its memory regions and interrupts

2013-09-30 Thread Bhushan Bharat-R65777
> -Original Message- > From: iommu-boun...@lists.linux-foundation.org [mailto:iommu- > boun...@lists.linux-foundation.org] On Behalf Of Antonios Motakis > Sent: Monday, September 30, 2013 8:59 PM > To: kvm...@lists.cs.columbia.edu; alex.william...@redhat.com > Cc: linux-samsung-soc@vger.k

RE: [PATCH 2/7] Initial skeleton of VFIO support for Device Tree based devices

2013-09-30 Thread Bhushan Bharat-R65777
> -Original Message- > From: iommu-boun...@lists.linux-foundation.org [mailto:iommu- > boun...@lists.linux-foundation.org] On Behalf Of Antonios Motakis > Sent: Monday, September 30, 2013 8:59 PM > To: kvm...@lists.cs.columbia.edu; alex.william...@redhat.com > Cc: linux-samsung-soc@vger.k

[RFC PATCH v2 0/7] VFIO for device tree based platform devices (work in progress)

2013-09-30 Thread Antonios Motakis
This is a preview of the base work, towards VFIO support on ARM platforms with an IOMMU. It forms a base on to which to implement the functionality necessary to enable using device tree devices on ARM (and other platforms based on device trees) with VFIO. This patch series has been subjected to li

[PATCH 3/7] Return info for device and its memory regions and interrupts

2013-09-30 Thread Antonios Motakis
A VFIO userspace driver will start by opening the VFIO device that corresponds to an IOMMU group, and will use the ioctl interface to get the basic device info, such as number of memory regions and interrupts, and their properties. This patch implements the IOCTLs: - VFIO_DEVICE_GET_INFO - VFIO_

[PATCH 4/7] VFIO: DT: Support MMAP of MMIO regions

2013-09-30 Thread Antonios Motakis
Signed-off-by: Antonios Motakis --- drivers/vfio/vfio_platform.c | 44 1 file changed, 44 insertions(+) diff --git a/drivers/vfio/vfio_platform.c b/drivers/vfio/vfio_platform.c index a0abcfa..6364316 100644 --- a/drivers/vfio/vfio_platform.c +++ b/dri

[PATCH 6/7] VFIO: Update documentation for VFIO_IOMMU_TYPE1 driver

2013-09-30 Thread Antonios Motakis
The VFIO documentation is slightly out of date. This minor correction replaces references to VFIO_IOMMU_X86 with the correct reference to VFIO_IOMMU_TYPE1 Signed-off-by: Antonios Motakis --- Documentation/vfio.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Docume

[PATCH 7/7] VFIO: VFIO_PLATFORM: Update documentation for platform specific devices

2013-09-30 Thread Antonios Motakis
Update Documentation/vfio.txt with information regarding the device tree based platform devices support. What is still missing in this RFC series, is information on how to bind the driver to platform devices, as there is currently for PCI. This will be added when proper VFIO driver binding is impl

[PATCH 5/7] VFIO: DT: Read and write support for the device fd

2013-09-30 Thread Antonios Motakis
VFIO returns a file descriptor which we can use to manipulate the memory regions of the device. Since some memory regions we cannot mmap due to security concerns, we also allow to read and write to this file descriptor directly. Signed-off-by: Antonios Motakis --- drivers/vfio/vfio_platform.c |

[PATCH 2/7] Initial skeleton of VFIO support for Device Tree based devices

2013-09-30 Thread Antonios Motakis
Platform devices in the Linux kernel are usually managed by the DT interface. This patch forms the base to support these kind of devices with VFIO. Signed-off-by: Antonios Motakis --- drivers/vfio/Kconfig | 11 +++ drivers/vfio/Makefile| 1 + drivers/vfio/vfio_platform.c | 187

[PATCH 1/7] VFIO_IOMMU_TYPE1 workaround to build for platform devices

2013-09-30 Thread Antonios Motakis
This is a workaround to make the VFIO_IOMMU_TYPE1 driver usable with platform devices instead of PCI. A future permanent fix should support both. This is required in order to use the Exynos SMMU, or ARM SMMU driver with VFIO. Signed-off-by: Antonios Motakis --- drivers/vfio/Kconfig|

Re: [RFC/PATCH] spi: s3c64xx: Enable Word transfer

2013-09-30 Thread Mark Brown
On Mon, Sep 30, 2013 at 01:32:43PM +0530, Rajeshwari Birje wrote: > Please do let me know if you have any comments on this patch. Don't top post. You need to follow Tomasz's advice and send the patch to me (using the above address from get_maintainer.pl) after addressing the issues he identified

Re: [PATCH v9 09/13] [media] exynos5-fimc-is: Add the hardware pipeline control

2013-09-30 Thread Hans Verkuil
On 09/27/2013 12:59 PM, Arun Kumar K wrote: > This patch adds the crucial hardware pipeline control for the > fimc-is driver. All the subdev nodes will call this pipeline > interfaces to reach the hardware. Responsibilities of this module > involves configuring and maintaining the hardware pipeline

Re: [PATCH v3 3/4] [media] exynos-scaler: Add m2m functionality for the SCALER driver

2013-09-30 Thread Hans Verkuil
On 09/30/2013 12:48 PM, Shaik Ameer Basha wrote: > Hi Hans, > > > On Mon, Sep 30, 2013 at 4:02 PM, Hans Verkuil wrote: >> On 09/30/2013 11:32 AM, Shaik Ameer Basha wrote: >>> Hi Hans, >>> >>> Thanks for pointing it out. >>> >>> >>> On Mon, Sep 30, 2013 at 1:38 PM, Hans Verkuil wrote: Hi Sh

Re: [PATCH 19/51] DMA-API: media: dt3155v4l: replace dma_set_mask()+dma_set_coherent_mask() with new helper

2013-09-30 Thread Hans Verkuil
On 09/19/2013 11:44 PM, Russell King wrote: > Replace the following sequence: > > dma_set_mask(dev, mask); > dma_set_coherent_mask(dev, mask); > > with a call to the new helper dma_set_mask_and_coherent(). > > Signed-off-by: Russell King Acked-by: Hans Verkuil Regards, H

Re: [PATCH 4/6] thermal: exynos: Replace SOC_ARCH_EXYNOS with SOC_ARCH_EXYNOS5250

2013-09-30 Thread amit daniel kachhap
On Tue, Sep 24, 2013 at 1:38 PM, Lukasz Majewski wrote: > The TMU data definition is now separated to Exynos4412 and Exynos5250. > > Now SOC_ARCH_EXYNOS only refers to Exynos5250. Hence the name > SOC_ARCH_EXYNOS has been changed to SOC_ARCH_EXYNOS5250. > > Signed-off-by: Lukasz Majewski Changes

Re: [PATCH 3/6] thermal: exynos: Provide initial setting for TMU's test MUX address at Exynos4412

2013-09-30 Thread amit daniel kachhap
Hi, On Tue, Sep 24, 2013 at 1:38 PM, Lukasz Majewski wrote: > The commit d0a0ce3e77c795258d47f9163e92d5031d0c5221 ("thermal: exynos: Add > missing definations and code cleanup") has removed setting of test MUX address > value at TMU configuration setting. > > This field is not present on Exynos42

Re: [PATCH 2/6] thermal: exynos: Provide separate TMU data for Exynos4412

2013-09-30 Thread amit daniel kachhap
On Tue, Sep 24, 2013 at 1:38 PM, Lukasz Majewski wrote: > Up till now Exynos5250 and Exynos4412 had the same definitions for TMU > data. Following commit changes that, by introducing separate > exynos4412_default_tmu_data structure. > > Since Exynos4412 was chronologically first, the corresponding

Re: [PATCH v3 3/4] [media] exynos-scaler: Add m2m functionality for the SCALER driver

2013-09-30 Thread Shaik Ameer Basha
On Mon, Sep 30, 2013 at 4:18 PM, Shaik Ameer Basha wrote: > Hi Hans, > > > On Mon, Sep 30, 2013 at 4:02 PM, Hans Verkuil wrote: >> On 09/30/2013 11:32 AM, Shaik Ameer Basha wrote: >>> Hi Hans, >>> >>> Thanks for pointing it out. >>> >>> >>> On Mon, Sep 30, 2013 at 1:38 PM, Hans Verkuil wrote: >>

Re: [PATCH 1/6] thermal: exynos: fix: Return from exynos_report_trigger() when therm_dev is NULL

2013-09-30 Thread amit daniel kachhap
On Tue, Sep 24, 2013 at 1:38 PM, Lukasz Majewski wrote: > The commit 4de0bdaa9677d11406c9becb70c60887c957e1f0 > ("thermal: exynos: Add support for instance based register/unregister") > broke check for presence of therm_dev at global thermal zone in > exynos_report_trigger(). > > The resulting wro

Re: [PATCH 1/7] drm/exynos: move hdmiphy related code to hdmiphy driver

2013-09-30 Thread Tushar Behera
On 30 August 2013 12:29, Rahul Sharma wrote: > Exynos hdmiphy operations and configs are kept inside > the hdmi driver. Hdmiphy related code is tightly coupled > with hdmi IP driver. > > This patche moves hdmiphy related code to hdmiphy driver. > It will help in cleanly supporting the hdmiphy vari

Re: [PATCH v3 3/4] [media] exynos-scaler: Add m2m functionality for the SCALER driver

2013-09-30 Thread Shaik Ameer Basha
Hi Hans, On Mon, Sep 30, 2013 at 4:02 PM, Hans Verkuil wrote: > On 09/30/2013 11:32 AM, Shaik Ameer Basha wrote: >> Hi Hans, >> >> Thanks for pointing it out. >> >> >> On Mon, Sep 30, 2013 at 1:38 PM, Hans Verkuil wrote: >>> Hi Shaik, >>> >>> I have a few questions regarding the selection part.

RE: [PATCH v2 00/12] clk/exynos convert clock IDs to macros

2013-09-30 Thread Kukjin Kim
Mike Turquette wrote: > > Quoting Sylwester Nawrocki (2013-09-16 07:33:45) > > On 09/12/2013 12:50 PM, Kukjin Kim wrote: > > > Well...I'm not sure changing to use macro is better or not at this > moment... > > > > I think it is. ;) It's really less error prone to have symbolic names > instead > >

Re: [PATCH v3 3/4] [media] exynos-scaler: Add m2m functionality for the SCALER driver

2013-09-30 Thread Hans Verkuil
On 09/30/2013 11:32 AM, Shaik Ameer Basha wrote: > Hi Hans, > > Thanks for pointing it out. > > > On Mon, Sep 30, 2013 at 1:38 PM, Hans Verkuil wrote: >> Hi Shaik, >> >> I have a few questions regarding the selection part... >> >> On 09/12/2013 03:09 PM, Shaik Ameer Basha wrote: >>> This patch

Re: [PATCH RFC 4/7] s5p-jpeg: Use mem-to-mem ioctl helpers

2013-09-30 Thread Hans Verkuil
On 09/13/2013 02:56 PM, Sylwester Nawrocki wrote: > Simplify the driver by using the m2m ioctl and vb2 helpers. > > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Kyugmin Park Acked-by: Hans Verkuil Regards, Hans > --- > drivers/media/platform/s5p-jpeg/jpeg-core.c | 111 > ++

Re: [PATCH RFC 2/7] mem2mem_testdev: Use mem-to-mem ioctl and vb2 helpers

2013-09-30 Thread Hans Verkuil
On 09/13/2013 02:56 PM, Sylwester Nawrocki wrote: > Simplify the driver by using the m2m ioctl and vb2 helpers. > > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Kyugmin Park Acked-by: Hans Verkuil Regards, Hans > --- > drivers/media/platform/mem2mem_testdev.c | 94 > --

RE: [PATCH v2 1/3] ARM: dts: exynos4210-origen: Add fixed voltage regulator to simple bus

2013-09-30 Thread Kukjin Kim
Sachin Kamat wrote: > > This has been done for Arndale board vide commit aa3edb65 > ("ARM: dts: Put Arndale fixed voltage regulators on a simple-bus"). > Replicate here for consistency and correctness. > > Signed-off-by: Sachin Kamat > --- > Based on Kukjin's for-next branch. > Changes since v1:

Re: [PATCH RFC 6/7] exynos-gsc: Use mem-to-mem ioctl helpers

2013-09-30 Thread Hans Verkuil
On 09/13/2013 02:56 PM, Sylwester Nawrocki wrote: > Simplify the driver by using the m2m ioctl and vb2 helpers. > > TODO: Add setting of default initial format. So this patch can't be applied yet. Other than that it looks good, but I won't ack it since it introduces a regression as long as the

Re: [PATCH RFC 7/7] s5p-g2d: Use mem-to-mem ioctl helpers

2013-09-30 Thread Hans Verkuil
On 09/13/2013 02:56 PM, Sylwester Nawrocki wrote: > Simplify the driver by using the m2m ioctl and vb2 helpers. > > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Kyugmin Park Acked-by: Hans Verkuil Regards, Hans > --- > drivers/media/platform/s5p-g2d/g2d.c | 103 > --

Re: [PATCH RFC 5/7] mx2-emmaprp: Use mem-to-mem ioctl helpers

2013-09-30 Thread Hans Verkuil
On 09/13/2013 02:56 PM, Sylwester Nawrocki wrote: > Simplify the driver by using the m2m ioctl and vb2 helpers. > > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Kyugmin Park > --- > drivers/media/platform/mx2_emmaprp.c | 108 > -- > 1 file changed, 11 ins

Re: [PATCH RFC 3/7] exynos4-is: Use mem-to-mem ioctl helpers

2013-09-30 Thread Hans Verkuil
On 09/13/2013 02:56 PM, Sylwester Nawrocki wrote: > Simplify the FIMC mem-to-mem driver by using the m2m ioctl and vb2 helpers. > > Signed-off-by: Sylwester Nawrocki > Signed-off-by: Kyugmin Park Acked-by: Hans Verkuil Regards, Hans > --- > drivers/media/platform/exynos4-is/fimc-m2

Re: [PATCH RFC 1/7] V4L: Add mem2mem ioctl and file operation helpers

2013-09-30 Thread Hans Verkuil
On 09/13/2013 02:56 PM, Sylwester Nawrocki wrote: > This patch adds ioctl helpers to the V4L2 mem-to-mem API, so we > can avoid several ioctl handlers in the mem-to-mem video node > drivers that are simply a pass-through to the v4l2_m2m_* calls. > These helpers will only be useful for drivers that

Re: Ask for help on SPI slave side driver support

2013-09-30 Thread Mark Brown
On Mon, Sep 30, 2013 at 01:20:42AM +0200, Tomasz Figa wrote: > Mark will probably know better, but AFAIK there is no API for slave mode > SPI available in Linux kernel. Please correct me if I'm wrong. That's correct. > The code mentioned in the post from your link was some internal vendor > co

Re: [PATCH v3 3/4] [media] exynos-scaler: Add m2m functionality for the SCALER driver

2013-09-30 Thread Shaik Ameer Basha
Hi Hans, Thanks for pointing it out. On Mon, Sep 30, 2013 at 1:38 PM, Hans Verkuil wrote: > Hi Shaik, > > I have a few questions regarding the selection part... > > On 09/12/2013 03:09 PM, Shaik Ameer Basha wrote: >> This patch adds the Makefile and memory to memory (m2m) interface >> functiona

Re: [PATCH V2] ARM: EXYNOS: implement pm_power_off for EXYNOS5440

2013-09-30 Thread Tomasz Figa
On Monday 30 of September 2013 13:56:39 Sachin Kamat wrote: > On 30 September 2013 12:55, Kukjin Kim wrote: > > I think current patch looks good to me, and in this case I don't have > > any idea why we should macro for just one time usage. > > It is not the question of one time usage, it is just

Re: [PATCH V2] ARM: EXYNOS: implement pm_power_off for EXYNOS5440

2013-09-30 Thread Sachin Kamat
On 30 September 2013 12:55, Kukjin Kim wrote: >> > I think current patch looks good to me, and in this case I don't have any > idea why we should macro for just one time usage. It is not the question of one time usage, it is just to make the code more readable. -- With warm regards, Sachin --

Re: [PATCH v8] s5k5baf: add camera sensor driver

2013-09-30 Thread Mark Rutland
> >> diff --git a/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt > >> b/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt > >> new file mode 100644 > >> index 000..7704a1e > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt > >> @@ -

Re: [PATCH v3 3/4] [media] exynos-scaler: Add m2m functionality for the SCALER driver

2013-09-30 Thread Hans Verkuil
Hi Shaik, I have a few questions regarding the selection part... On 09/12/2013 03:09 PM, Shaik Ameer Basha wrote: > This patch adds the Makefile and memory to memory (m2m) interface > functionality for the SCALER driver. > > Signed-off-by: Shaik Ameer Basha > --- > drivers/media/platform/Kconf

Re: [RFC/PATCH] spi: s3c64xx: Enable Word transfer

2013-09-30 Thread Rajeshwari Birje
Hi Mark Brown, Please do let me know if you have any comments on this patch. Regards, Rajeshwari Shinde. On Wed, Sep 25, 2013 at 4:59 PM, Rajeshwari Birje wrote: > Hi Tomasz > > Sorry for the previous mail with incomplete comments, sent the same by > mistake. > > > On Wed, Sep 25, 2013 at 4:3

[PATCH V8 3/3] video: exynos_dp: Use the generic PHY driver

2013-09-30 Thread Jingoo Han
Use the generic PHY API to control the DP PHY. Signed-off-by: Jingoo Han Reviewed-by: Tomasz Figa --- Documentation/devicetree/bindings/video/exynos_dp.txt | 17 + drivers/video/exynos/exynos_dp_core.c | 16 drivers/video/exynos/exynos_dp_cor

[PATCH V8 2/3] video: exynos_dp: remove non-DT support for Exynos Display Port

2013-09-30 Thread Jingoo Han
Exynos Display Port can be used only for Exynos SoCs. In addition, non-DT for EXYNOS SoCs is not supported from v3.11; thus, there is no need to support non-DT for Exynos Display Port. The 'include/video/exynos_dp.h' file has been used for non-DT support and the content of file include/video/exyno

[PATCH V8 1/3] phy: Add driver for Exynos DP PHY

2013-09-30 Thread Jingoo Han
Add a PHY provider driver for the Samsung Exynos SoC Display Port PHY. Signed-off-by: Jingoo Han Reviewed-by: Tomasz Figa Cc: Sylwester Nawrocki Acked-by: Felipe Balbi --- .../devicetree/bindings/phy/samsung-phy.txt|8 ++ drivers/phy/Kconfig|7 +

[PATCH V8 0/3] Generic PHY driver for the Exynos SoC DP PHY

2013-09-30 Thread Jingoo Han
This patch series adds a simple driver for the Samsung Exynos SoC series DP transmitter PHY, using the generic PHY framework [1]. Previously the DP PHY used an internal DT node to control the PHY power enable bit. This PATCH v8 follows: * PATCH v7, sent on August, 26th 2013 * PATCH v6, sent on J

RE: [PATCH v7 0/6] ARM: dts: add support for exynos hdmi subsystem

2013-09-30 Thread Kukjin Kim
Rahul Sharma wrote: > > On 29 August 2013 19:05, Tomasz Figa wrote: > > Hi Rahul, > > > > On Thursday 29 of August 2013 19:22:51 Rahul Sharma wrote: > >> It adds Device tree nodes and clocks information for HDMI subsystem > >> for exynos5420 and exynos5250 SoCs. It adds pinctrl node for hdmi > >>

RE: [PATCH V2] ARM: EXYNOS: implement pm_power_off for EXYNOS5440

2013-09-30 Thread Kukjin Kim
Jungseok Lee wrote: > > On Monday, September 30, 2013 12:04 PM, Sachin Kamat wrote: > > On 30 September 2013 07:02, Jungseok Lee wrote: > > > > > + /* turn off all power domains */ > > > + addr = of_iomap(np, 0) + 0x14; > > > + __raw_writel(0x1, addr); > > > > Actually my commen

RE: [PATCH 1/5] ARM: Kconfig: Move if ARCH_S3C64XX statement to mach-s3c64xx/Kconfig

2013-09-30 Thread Kukjin Kim
Tomasz Figa wrote: > > All other platforms have this condition checked inside their own Kconfig > files, so for consistency this patch makes it this way for mach-s3c64xx > as well. > > Signed-off-by: Tomasz Figa > --- > arch/arm/Kconfig | 2 -- > arch/arm/mach-s3c64xx/Kconfig | 4 +