Re: [PATCH 4/7] ARM: dts: exynos5440: fix PCIe interrupt mapping
On Monday, March 03, 2014 4:41 PM, Jingoo Han wrote: > On Saturday, March 01, 2014 2:29 AM, Lucas Stach wrote: > > > > So it actually works. > > > > Signed-off-by: Lucas Stach > > --- > > arch/arm/boot/dts/exynos5440.dtsi | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/boot/dts/exynos5440.dtsi > > b/arch/arm/boot/dts/exynos5440.dtsi > > index 02a0a1226cef..65d425d9ec27 100644 > > --- a/arch/arm/boot/dts/exynos5440.dtsi > > +++ b/arch/arm/boot/dts/exynos5440.dtsi > > @@ -274,7 +274,7 @@ > > 0x8200 0 0x40011000 0x40011000 0 0x1ffef000>; /* > > non-prefetchable memory */ > > #interrupt-cells = <1>; > > interrupt-map-mask = <0 0 0 0>; > > - interrupt-map = <0x0 0 &gic 53>; > > + interrupt-map = <0 0 0 0 &gic GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>; > > It makes build errors as below: > > DTC arch/arm/boot/dts/exynos5440-ssdk5440.dtb > Error: arch/arm/boot/dts/exynos5440.dtsi:289.33-34 syntax error > FATAL ERROR: Unable to parse input tree > make[1]: *** [arch/arm/boot/dts/exynos5440-ssdk5440.dtb] Error 1 > make: *** [exynos5440-ssdk5440.dtb] Error 2 > > Would you fix it? I fixed build errors after including 'arm-gic.h' as below: --- a/arch/arm/boot/dts/exynos5440.dtsi +++ b/arch/arm/boot/dts/exynos5440.dtsi @@ -9,6 +9,8 @@ * published by the Free Software Foundation. */ +#include + #include "skeleton.dtsi" Would you confirm this? Best regards, Jingoo Han > > > num-lanes = <4>; > > status = "disabled"; > > }; > > @@ -295,7 +295,7 @@ > > 0x8200 0 0x60011000 0x60011000 0 0x1ffef000>; /* > > non-prefetchable memory */ > > #interrupt-cells = <1>; > > interrupt-map-mask = <0 0 0 0>; > > - interrupt-map = <0x0 0 &gic 56>; > > + interrupt-map = <0 0 0 0 &gic GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>; > > num-lanes = <4>; > > status = "disabled"; > > }; > > -- > > 1.8.5.3 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 4/7] ARM: dts: exynos5440: fix PCIe interrupt mapping
On Saturday, March 01, 2014 2:29 AM, Lucas Stach wrote: > > So it actually works. > > Signed-off-by: Lucas Stach > --- > arch/arm/boot/dts/exynos5440.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5440.dtsi > b/arch/arm/boot/dts/exynos5440.dtsi > index 02a0a1226cef..65d425d9ec27 100644 > --- a/arch/arm/boot/dts/exynos5440.dtsi > +++ b/arch/arm/boot/dts/exynos5440.dtsi > @@ -274,7 +274,7 @@ > 0x8200 0 0x40011000 0x40011000 0 0x1ffef000>; /* > non-prefetchable memory */ > #interrupt-cells = <1>; > interrupt-map-mask = <0 0 0 0>; > - interrupt-map = <0x0 0 &gic 53>; > + interrupt-map = <0 0 0 0 &gic GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>; It makes build errors as below: DTC arch/arm/boot/dts/exynos5440-ssdk5440.dtb Error: arch/arm/boot/dts/exynos5440.dtsi:289.33-34 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [arch/arm/boot/dts/exynos5440-ssdk5440.dtb] Error 1 make: *** [exynos5440-ssdk5440.dtb] Error 2 Would you fix it? Best regards, Jingoo Han > num-lanes = <4>; > status = "disabled"; > }; > @@ -295,7 +295,7 @@ > 0x8200 0 0x60011000 0x60011000 0 0x1ffef000>; /* > non-prefetchable memory */ > #interrupt-cells = <1>; > interrupt-map-mask = <0 0 0 0>; > - interrupt-map = <0x0 0 &gic 56>; > + interrupt-map = <0 0 0 0 &gic GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>; > num-lanes = <4>; > status = "disabled"; > }; > -- > 1.8.5.3 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/3] regulator: s2mps11: Copy supported regulators from initconst
On Fri, Feb 28, 2014 at 11:01:50AM +0100, Krzysztof Kozlowski wrote: > Add __initconst to 'regulator_desc' array with supported regulators. > During probe choose how many and which regulators will be supported > according to device ID. Then copy the 'regulator_desc' array to > allocated memory so the regulator core can use it. Applied, thanks. signature.asc Description: Digital signature
Re: [PATCH 1/3] regulator: s2mps11: Don't store registered regulators in state container
On Fri, Feb 28, 2014 at 11:01:48AM +0100, Krzysztof Kozlowski wrote: > Regulators registered by devm_regulator_register() do not have to be > stored in state container because they are never dereferenced later. > The array of regulator_dev can be safely removed from state container. Applied, thanks. signature.asc Description: Digital signature
Re: [PATCH 2/3] regulator: s2mps11: Constify regulator_desc array
On Fri, Feb 28, 2014 at 11:01:49AM +0100, Krzysztof Kozlowski wrote: > Constify the regulator_desc 'regulators' array. Applied, thanks. signature.asc Description: Digital signature
