Re: [PATCH v4 0/3] Generic Device Tree based power domain look-up

2014-05-16 Thread Tomasz Figa
Hi, On 08.05.2014 14:49, Tomasz Figa wrote: > Up till now there was no single generic method to bind devices to their > power domains using Device Tree. Each platform has been doing this using > its own way, example of which are Exynos power domain bindings [1] and > look-up code [2]. > > This se

Re: [PATCH v4 0/4] Adds PMU and S2R support for exynos5420

2014-05-16 Thread Tomasz Figa
On 16.05.2014 07:07, Abhilash Kesavan wrote: > Hi Tomasz, > > On Fri, May 16, 2014 at 2:52 AM, Tomasz Figa wrote: >> Hi Abhilash, >> >> On 13.05.2014 14:01, Abhilash Kesavan wrote: >>> Rebased on >>> 1] Kukjin Kim's tree for-next branch (which has Sachin Kamat's SYSRAM >>> patches merged) with To

Re: [PATCHv2] mmc: dw_mmc: change to use recommended reset procedure

2014-05-16 Thread Sonny Rao
On Tue, May 13, 2014 at 4:09 AM, Seungwon Jeon wrote: > On Tuesday, May 13, Sonny Rao wrote: >> On Mon, May 12, 2014 at 10:02 PM, Seungwon Jeon wrote: >> > As I mentioned in previous version, you put all reset stuff in existing >> > fifo_reset function. >> > Although databook mentions ciu_reset

Re: [PATCH v5 1/5] ARM: EXYNOS: Add generic cpu power control functions for all exynos based SoCs

2014-05-16 Thread Tomasz Figa
On 16.05.2014 07:07, Abhilash Kesavan wrote: > Hi Tomasz, > > On Fri, May 16, 2014 at 2:41 AM, Tomasz Figa wrote: >> Hi Abhilash, >> >> On 13.05.2014 12:12, Abhilash Kesavan wrote: >>> On Tue, May 13, 2014 at 7:54 AM, Kukjin Kim wrote: >> >> [snip] >> > diff --git a/arch/arm/mach-exynos/re

Re: [PATCH v4 0/8] cpufreq: use cpufreq-cpu0 driver for exynos based platforms

2014-05-16 Thread Tomasz Figa
Hi Thomas, In general the design already looks good, but I commented on several implementation issues I found in particular patches (and some minor nitpicks while at it). Please let me know whether you have time to work on addressing them. Otherwise we can just let me, Lukasz or someone else addr

Re: [PATCH 1/2] ARM: dts: Add pwmX_out pinctrl nodes to Exynos5250

2014-05-16 Thread Kukjin Kim
On 05/16/14 21:28, Kukjin Kim wrote: Ajay Kumar wrote: Adds the PWM nodes to 5250 pinctrl dtsi file. Signed-off-by: Ajay Kumar --- arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 28 1 file changed, 28 insertions(+) diff --git a/arch/arm/boot/dts/exynos5250-pinct

Re: [PATCH v4 7/8] ARM: Exynos: switch to using generic cpufreq-cpu0 driver

2014-05-16 Thread Tomasz Figa
On 14.05.2014 03:11, Thomas Abraham wrote: > From: Thomas Abraham > > Remove the platform device instantiation for Exynos specific cpufreq > driver and add the platform device for cpufreq-cpu0 driver. > > Signed-off-by: Thomas Abraham > --- > arch/arm/mach-exynos/exynos.c |4 +++- > 1 fi

Re: [PATCH] arm: dts: exynos5: Remove multi core timer

2014-05-16 Thread Kukjin Kim
On 05/17/14 07:56, Chirantan Ekbote wrote: Anyway, I'm by no means opposed to switching to arch timers. They provide a well designed, generic interface and drivers shared by multiple platforms, which means more code sharing and possibly more eyes looking at the code, which is always good. However

Re: [PATCH v4 4/8] Documentation: devicetree: add cpu clock configuration data binding for Exynos4/5

2014-05-16 Thread Tomasz Figa
On 17.05.2014 01:24, Tomasz Figa wrote: > Also, shouldn't you also extend exynos5420-clock.txt in the same way? Please ignore this comment. Somehow I thought other patches of this series also had support for Exynos5420. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubsc

Re: [GIT PULL 1/4] Samsung clock Exynos5260 support for v3.16

2014-05-16 Thread Kukjin Kim
On 05/16/14 06:11, Kukjin Kim wrote: [...] OK, I think I misread the original email. I thought you were asking for future pull requests to go through the samsung tree, but you only mean the ones in this thread. No problem there. Acked-by: Mike Turquette Mike, thanks for your ack on this who

Re: [PATCH v4 5/8] clk: exynos: use cpu-clock provider type to represent arm clock.

2014-05-16 Thread Tomasz Figa
Hi Thomas, On 14.05.2014 03:11, Thomas Abraham wrote: > From: Thomas Abraham > > With the addition of the new Samsung specific cpu-clock type, the > arm clock can be represented as a cpu-clock type and the independent > clock blocks that made up the arm clock can be removed. > > Cc: Tomasz Figa

Re: [PATCH v6 0/5] MCPM backend for Exynos5420

2014-05-16 Thread Kukjin Kim
On 05/16/14 01:52, Nicolas Pitre wrote: On Thu, 15 May 2014, Abhilash Kesavan wrote: Hi Nicolas, Hi all, [...] Good, that looks pretty good. Thanks for you guys effort and time. Applied this whole series. Once you implement full cluster shutdown I can provide you with another script s

Re: [PATCH v3] cpufreq: exynos: Fix the compile error

2014-05-16 Thread Kukjin Kim
On 05/17/14 08:37, Tomasz Figa wrote: On 17.05.2014 01:26, Kukjin Kim wrote: On 05/16/14 20:07, Viresh Kumar wrote: On 16 May 2014 15:48, Jonghwan Choi wrote: Commit 7da83a80 ("ARM: EXYNOS: Migrate Exynos specific macros from plat to mach") which lands in samsung tree causes build breakage f

Re: [PATCH v3] cpufreq: exynos: Fix the compile error

2014-05-16 Thread Tomasz Figa
On 17.05.2014 01:26, Kukjin Kim wrote: > On 05/16/14 20:07, Viresh Kumar wrote: >> On 16 May 2014 15:48, Jonghwan Choi wrote: >>> Commit 7da83a80 ("ARM: EXYNOS: Migrate Exynos specific macros from >>> plat to mach") which lands in samsung tree causes build breakage >>> for cpufreq-exynos like foll

Re: [PATCH v3] cpufreq: exynos: Fix the compile error

2014-05-16 Thread Tomasz Figa
Hi Kukjin, On 17.05.2014 01:24, Kukjin Kim wrote: > On 05/17/14 08:04, Rafael J. Wysocki wrote: >> On Friday, May 16, 2014 07:54:01 PM Kukjin Kim wrote: >>> Jonghwan Choi wrote: Commit 7da83a80 ("ARM: EXYNOS: Migrate Exynos specific macros from plat to mach") which lands in sam

Re: [PATCH v3] cpufreq: exynos: Fix the compile error

2014-05-16 Thread Kukjin Kim
On 05/16/14 20:07, Viresh Kumar wrote: On 16 May 2014 15:48, Jonghwan Choi wrote: Commit 7da83a80 ("ARM: EXYNOS: Migrate Exynos specific macros from plat to mach") which lands in samsung tree causes build breakage for cpufreq-exynos like following: drivers/cpufreq/exynos-cpufreq.c: In functio

Re: [PATCH v4 4/8] Documentation: devicetree: add cpu clock configuration data binding for Exynos4/5

2014-05-16 Thread Tomasz Figa
Hi Thomas, Please see my comments inline. On 14.05.2014 03:11, Thomas Abraham wrote: > From; Thomas Abraham > > The clock blocks within the CMU_CPU clock domain are put together into a > new composite clock type called the cpu clock. This clock type requires > configuration data that will be at

Re: [PATCH v3] cpufreq: exynos: Fix the compile error

2014-05-16 Thread Kukjin Kim
On 05/17/14 08:04, Rafael J. Wysocki wrote: On Friday, May 16, 2014 07:54:01 PM Kukjin Kim wrote: Jonghwan Choi wrote: Commit 7da83a80 ("ARM: EXYNOS: Migrate Exynos specific macros from plat to mach") which lands in samsung tree causes build breakage for cpufreq-exynos like following: drivers

Re: [PATCH v4 6/8] ARM: dts: Exynos: add cpu nodes, opp and cpu clock configuration data

2014-05-16 Thread Tomasz Figa
Hi Thomas, Please see my comments inline. On 14.05.2014 03:11, Thomas Abraham wrote: > From: Thomas Abraham > > For all Exynos based platforms, add CPU nodes, operating points and cpu > clock data for migrating from Exynos specific cpufreq driver to using > generic cpufreq-cpu0 driver. > > Cc:

Re: [PATCH RFC 3/4] clk: samsung: Add driver to control CLKOUT line on Exynos SoCs

2014-05-16 Thread Mike Turquette
Quoting Tomasz Figa (2014-05-15 10:32:30) > This patch introduces a driver that handles configuration of CLKOUT pin > of Exynos SoCs that can be used to output certain clocks from inside of > the SoC to a dedicated output pin. > > Signed-off-by: Tomasz Figa Overall implementation looks good to m

Re: [PATCH 1/1] ARM: dts: Add PD entry to MFC codec on 5420

2014-05-16 Thread Kukjin Kim
On 05/16/14 14:12, Arun Kumar K wrote: Looks good. Reviewed-by : Arun Kumar K On Tue, Apr 29, 2014 at 12:19 PM, Sachin Kamat wrote: PD entry was missing in MFC codec node. Signed-off-by: Sachin Kamat --- arch/arm/boot/dts/exynos5420.dtsi |1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH] arm: dts: exynos5: Remove multi core timer

2014-05-16 Thread Chirantan Ekbote
>>> Anyway, I'm by no means opposed to switching to arch timers. They >>> provide a well designed, generic interface and drivers shared by >>> multiple platforms, which means more code sharing and possibly more eyes >>> looking at the code, which is always good. However if they don't support >>> lo

Re: [PATCH v3] cpufreq: exynos: Fix the compile error

2014-05-16 Thread Rafael J. Wysocki
On Friday, May 16, 2014 07:54:01 PM Kukjin Kim wrote: > Jonghwan Choi wrote: > > > > Commit 7da83a80 ("ARM: EXYNOS: Migrate Exynos specific macros from plat to > > mach") which lands in samsung tree causes build breakage > > for cpufreq-exynos like following: > > > > drivers/cpufreq/exynos-cpufre

Re: [PATCH v4 3/8] clk: samsung: add infrastructure to register cpu clocks

2014-05-16 Thread Tomasz Figa
Hi Thomas, On 14.05.2014 03:11, Thomas Abraham wrote: > From: Thomas Abraham > > The CPU clock provider supplies the clock to the CPU clock domain. The > composition and organization of the CPU clock provider could vary among > Exynos SoCs. A CPU clock provider can be composed of clock mux, divi

Re: [PATCH] mmc: dw_mmc: Make sure we don't get stuck when we get an error

2014-05-16 Thread Doug Anderson
Seungwon, On Thu, May 15, 2014 at 6:46 PM, Seungwon Jeon wrote: > On Wed, May 14, 2014, Doug Anderson wrote: >> Seungwon, >> >> On Mon, May 12, 2014 at 9:52 PM, Seungwon Jeon wrote: >> > Hi Doug, >> > >> > On Tue, May 13, 2014, Doug Anderson wrote: >> >> Seungwon, >> >> >> >> On Sat, May 10, 201

Re: [PATCH RFC 3/4] clk: samsung: Add driver to control CLKOUT line on Exynos SoCs

2014-05-16 Thread Tomasz Figa
On 16.05.2014 16:35, Rahul Sharma wrote: > On 16 May 2014 16:22, Tomasz Figa wrote: >> Hi Rahul, >> >> On 16.05.2014 12:39, Rahul Sharma wrote: >>> [snip] + gate->lock = &clkout_lock; + + mux->reg = reg + EXYNOS_PMU_DEBUG_REG; + mux->mask = EXYNOS_CLKOUT_MUX_M

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-16 Thread Tomasz Figa
On 16.05.2014 16:30, Rahul Sharma wrote: > On 16 May 2014 16:20, Tomasz Figa wrote: >> On 16.05.2014 12:35, Rahul Sharma wrote: >>> On 16 May 2014 15:12, Rahul Sharma wrote: On 16 May 2014 03:14, Tomasz Figa wrote: > On 15.05.2014 06:01, Rahul Sharma wrote: >>> [snip] >>> the PHY pr

Re: [PATCH RFC 3/4] clk: samsung: Add driver to control CLKOUT line on Exynos SoCs

2014-05-16 Thread Rahul Sharma
On 16 May 2014 16:22, Tomasz Figa wrote: > Hi Rahul, > > On 16.05.2014 12:39, Rahul Sharma wrote: >> [snip] >>> + gate->lock = &clkout_lock; >>> + >>> + mux->reg = reg + EXYNOS_PMU_DEBUG_REG; >>> + mux->mask = EXYNOS_CLKOUT_MUX_MASK; >>> + mux->shift = EXYNOS_CLKOUT_MUX_SHI

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-16 Thread Rahul Sharma
On 16 May 2014 16:20, Tomasz Figa wrote: > On 16.05.2014 12:35, Rahul Sharma wrote: >> On 16 May 2014 15:12, Rahul Sharma wrote: >>> On 16 May 2014 03:14, Tomasz Figa wrote: On 15.05.2014 06:01, Rahul Sharma wrote: >> [snip] >> the PHY provider. >> > > Please correct me if I

RE: [PATCH V2 0/2] Add sound card node Snow/Peach-pit board

2014-05-16 Thread Kukjin Kim
Tushar Behera wrote: > > > Patch 2 is dependent on Arun's following patch. > 1. [PATCH v4 0/2] Add peach-pit board support > http://www.mail-archive.com/linux-samsung- > s...@vger.kernel.org/msg29948.html > > Tushar Behera (2): > ARM: dts: Add sound node for Snow board > ARM: dts: Add sound

Re: [PATCH v4 2/8] clk: samsung: change scope of samsung clock lock to global

2014-05-16 Thread Tomasz Figa
Hi Thomas, On 14.05.2014 03:11, Thomas Abraham wrote: > From: Thomas Abraham > > Access to samsung clock lock is required to support newer samsung specific > clock types. So change the scope of the samsung clock lock to global. And > prefix 'samsung_clk_' to the existing name of the lock to prev

[PATCH] ARM: S3C24XX: check for 'CONFIG_SND_SOC_SAMSUNG_SMDK2443_WM9710'

2014-05-16 Thread Paul Bolle
Since v2.6.34 there are two checks for CONFIG_SND_SOC_SMDK2443_WM9710. But a Kconfig symbol SND_SOC_SMDK2443_WM9710 has never been part of the tree. However, in v2.6.38 a symbol SND_SOC_SAMSUNG_SMDK2443_WM9710 was added, so it seems these checks should be for its macro. But the second check is a g

RE: [PATCH 1/2] ARM: dts: Add pwmX_out pinctrl nodes to Exynos5250

2014-05-16 Thread Kukjin Kim
Ajay Kumar wrote: > > Adds the PWM nodes to 5250 pinctrl dtsi file. > > Signed-off-by: Ajay Kumar > --- > arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 28 > > 1 file changed, 28 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi > b/arch/arm/

[PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-16 Thread Thierry Reding
From: Thierry Reding This commit introduces a generic device tree binding for IOMMU devices. Only a very minimal subset is described here, but it is enough to cover the requirements of both the Exynos System MMU and Tegra SMMU as discussed here: https://lkml.org/lkml/2014/4/27/346 More adva

[PATCH] ARM: S3C24XX: remove checks for CONFIG_CPU_S3C2413

2014-05-16 Thread Paul Bolle
There are a number of checks for CONFIG_CPU_S3C2413. But there's no Kconfig symbol CPU_S3C2413. That symbol is not needed, as CPU_S3C2412 is documented to support both the S3C2412 and the S3C2413 SoCs. Luckily, all these checks for CONFIG_CPU_S3C2413 are in places were we also checks for CONFIG_CP

[PATCH] ARM: dts: Add audio subsystem nodes to exynos4.dtsi

2014-05-16 Thread Sylwester Nawrocki
This patch adds the audio subsystem clock controller and the I2S IP block nodes for Exynos4 SoC series. Signed-off-by: Sylwester Nawrocki --- arch/arm/boot/dts/exynos4.dtsi | 38 ++ 1 file changed, 38 insertions(+) diff --git a/arch/arm/boot/dts/exynos4.dts

Re: [PATCH v3] cpufreq: exynos: Fix the compile error

2014-05-16 Thread Viresh Kumar
On 16 May 2014 15:48, Jonghwan Choi wrote: > Commit 7da83a80 ("ARM: EXYNOS: Migrate Exynos specific macros from plat to > mach") which lands in samsung tree causes build breakage > for cpufreq-exynos like following: > > drivers/cpufreq/exynos-cpufreq.c: In function 'exynos_cpufreq_probe': > drive

RE: [PATCH v3] cpufreq: exynos: Fix the compile error

2014-05-16 Thread Kukjin Kim
Jonghwan Choi wrote: > > Commit 7da83a80 ("ARM: EXYNOS: Migrate Exynos specific macros from plat to > mach") which lands in samsung tree causes build breakage > for cpufreq-exynos like following: > > drivers/cpufreq/exynos-cpufreq.c: In function 'exynos_cpufreq_probe': > drivers/cpufreq/exynos-cp

Re: [PATCH RFC 3/4] clk: samsung: Add driver to control CLKOUT line on Exynos SoCs

2014-05-16 Thread Tomasz Figa
Hi Rahul, On 16.05.2014 12:39, Rahul Sharma wrote: > [snip] >> + gate->lock = &clkout_lock; >> + >> + mux->reg = reg + EXYNOS_PMU_DEBUG_REG; >> + mux->mask = EXYNOS_CLKOUT_MUX_MASK; >> + mux->shift = EXYNOS_CLKOUT_MUX_SHIFT; >> + mux->lock = &clkout_lock; >> + >> +

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-16 Thread Tomasz Figa
On 16.05.2014 12:35, Rahul Sharma wrote: > On 16 May 2014 15:12, Rahul Sharma wrote: >> On 16 May 2014 03:14, Tomasz Figa wrote: >>> On 15.05.2014 06:01, Rahul Sharma wrote: > [snip] > the PHY provider. > Please correct me if I got you wrong. You want somthing like this: >>

Re: [PATCH 2/2] ARM: dts: enable fimd for exynos5800 based peach-pi board

2014-05-16 Thread Rahul Sharma
On 13 May 2014 08:53, Rahul Sharma wrote: > Thanks Jingoo Han. > > Hi Kukjin, > > Please consider both of these series for your tree. > > 1) http://www.spinics.net/lists/arm-kernel/msg329697.html > 2) http://www.spinics.net/lists/arm-kernel/msg330291.html > > Regards, > Rahul Sharma > > On 13 Ma

Re: [PATCH RFC 3/4] clk: samsung: Add driver to control CLKOUT line on Exynos SoCs

2014-05-16 Thread Rahul Sharma
[snip] > + gate->lock = &clkout_lock; > + > + mux->reg = reg + EXYNOS_PMU_DEBUG_REG; > + mux->mask = EXYNOS_CLKOUT_MUX_MASK; > + mux->shift = EXYNOS_CLKOUT_MUX_SHIFT; > + mux->lock = &clkout_lock; > + > + clk = clk_register_composite(NULL, "clkout", parent_names,

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-16 Thread Rahul Sharma
On 16 May 2014 15:12, Rahul Sharma wrote: > On 16 May 2014 03:14, Tomasz Figa wrote: >> On 15.05.2014 06:01, Rahul Sharma wrote: [snip] the PHY provider. >>> >>> Please correct me if I got you wrong. You want somthing like this: >>> >>> pmu_system_controller: system-controller@1004

Re: [PATCH 1/2] s5p-mfc: Update mfc-v6 firmware

2014-05-16 Thread Tomasz Figa
Hi Kamil, Arun, On 16.05.2014 12:09, Kamil Debski wrote: > Hi, > > Original Message- >> From: arunkk.sams...@gmail.com [mailto:arunkk.sams...@gmail.com] On >> Behalf Of Arun Kumar K >> Sent: Friday, May 16, 2014 12:00 PM >> >> Hi Kamil, >> >> On Fri, May 16, 2014 at 3:24 PM, Kamil Debski

[PATCH v3] cpufreq: exynos: Fix the compile error

2014-05-16 Thread Jonghwan Choi
Commit 7da83a80 ("ARM: EXYNOS: Migrate Exynos specific macros from plat to mach") which lands in samsung tree causes build breakage for cpufreq-exynos like following: drivers/cpufreq/exynos-cpufreq.c: In function 'exynos_cpufreq_probe': drivers/cpufreq/exynos-cpufreq.c:166:2: error: implicit decl

RE: [PATCH 1/2] s5p-mfc: Update mfc-v6 firmware

2014-05-16 Thread Kamil Debski
Hi, Original Message- > From: arunkk.sams...@gmail.com [mailto:arunkk.sams...@gmail.com] On > Behalf Of Arun Kumar K > Sent: Friday, May 16, 2014 12:00 PM > > Hi Kamil, > > On Fri, May 16, 2014 at 3:24 PM, Kamil Debski > wrote: > > Hi Arun, > > > > I asked you to put old and new v6 firm

Re: [PATCH 1/2] s5p-mfc: Update mfc-v6 firmware

2014-05-16 Thread Arun Kumar K
Hi Kamil, On Fri, May 16, 2014 at 3:24 PM, Kamil Debski wrote: > Hi Arun, > > I asked you to put old and new v6 firmware in separate files. But wont that require a different filename other than s5p-mfc-v6.fw? But the driver still expects the same file name. Can I put the new filename as s5p-mfc-

RE: [PATCH v2] cpufreq: exynos: Fix the compile error

2014-05-16 Thread Jonghwan Choi
On 16.05.2014 5:50 PM, Tomasz Figa wrote: > We have been discussing Exynos cpufreq framework rework, including DT support > since quite a long time. > so if you want to know details, please look at respective discussion threads. > I don't have time to > find them for you right now, but if you lo

RE: [PATCH 1/2] s5p-mfc: Update mfc-v6 firmware

2014-05-16 Thread Kamil Debski
Hi Arun, I asked you to put old and new v6 firmware in separate files. You should also mention in the commit message that this new firmware will not work with the s5p-mfc driver without the patch you recently submitted to linux-media mailing list. Please also add a link to the thread with the nece

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-16 Thread Rahul Sharma
On 16 May 2014 03:14, Tomasz Figa wrote: > On 15.05.2014 06:01, Rahul Sharma wrote: >> Thanks Tomasz, >> >> On 15 May 2014 01:31, Tomasz Figa wrote: >>> Hi Rahul, Tomasz, >> [snip] + simplephys: simple-phys@1004 { + compatible = "samsung,exynos5250-simple-phy"; >>> >

Re: [PATCH 6/7] ARM: EXYNOS: PM: fix register setup on EXYNOS4x12 for AFTR mode code

2014-05-16 Thread Daniel Lezcano
On 05/05/2014 12:57 PM, Bartlomiej Zolnierkiewicz wrote: Add S5P_CENTRAL_SEQ_OPTION register setup for EXYNOS4x12 to AFTR mode code. Without this setup AFTR mode doesn't show any benefit over WFI one. When this setup is applied AFTR mode reduces power consumption by ~12% (as measured on Trats2

Re: [PATCH 4/7] ARM: EXYNOS: PM: replace EXYNOS_BOOT_VECTOR_* macros by static inlines

2014-05-16 Thread Daniel Lezcano
On 05/05/2014 12:57 PM, Bartlomiej Zolnierkiewicz wrote: Replace EXYNOS_BOOT_VECTOR_ADDR and EXYNOS_BOOT_VECTOR_FLAG macros by exynos_boot_vector_addr() and exynos_boot_vector_flag() static inlines. This patch shouldn't cause any functionality changes. Signed-off-by: Bartlomiej Zolnierkiewicz

Re: [PATCH v2] cpufreq: exynos: Fix the compile error

2014-05-16 Thread Tomasz Figa
Hi Jonghwan, On 16.05.2014 09:58, Jonghwan Choi wrote: > Commit 7da83a80 ("ARM: EXYNOS: Migrate Exynos specific macros from plat to > mach") > which lands in samsung tree causes build breakage for cpufreq-exynos like > following: > drivers/cpufreq/exynos-cpufreq.c: In function 'exynos_cpufreq_pr

[PATCH v6 1/6] driver: cpuidle-big-little: add of_device_id structure

2014-05-16 Thread Chander Kashyap
This driver will be used by many big.Little Soc's. As of now it does string matching of hardcoded compatible string to init the driver. This comparison list will keep on growing with addition of new SoC's. Hence add of_device_id structure to collect the compatible strings of SoC's using this driver

[PATCH v6 3/6] cpuidle: config: Add ARCH_EXYNOS entry to select cpuidle-big-little driver

2014-05-16 Thread Chander Kashyap
Add support to select generic big-little cpuidle driver for Samsung Exynos series SoC's. This is required for Exynos big-llittle SoC's eg, Exynos5420. Signed-off-by: Chander Kashyap Signed-off-by: Chander Kashyap --- Changes in v4: 1. Typo fixed from SOC_EXYNOS5420 to ARCH_EXYNOS

RE: [PATCH] cpufreq: exynos: Fix the compile error

2014-05-16 Thread Kukjin Kim
Kukjin Kim wrote: > > Viresh Kumar wrote: > > > > And please use Rafael's email id from Maintainers.. > > > > On 16 May 2014 13:25, Viresh Kumar wrote: > > > On 16 May 2014 13:20, Jonghwan Choi wrote: > > >> Commit 7da83a80 ("ARM: EXYNOS: Migrate Exynos specific macros from > > >> plat to > > >>

[PATCH v6 4/6] driver: cpuidle: cpuidle-big-little: init driver for Exynos5420

2014-05-16 Thread Chander Kashyap
Add "samsung,exynos5420" compatible string to initialize generic big-little cpuidle driver for Exynos5420. Signed-off-by: Chander Kashyap Signed-off-by: Chander Kashyap Acked-by: Daniel Lezcano --- Changes in v5: None Changes in v4: None Changes in v3: 1. Add compatible string to of_dev

[PATCH v6 6/6] mcpm: exynos: populate suspend and powered_up callbacks

2014-05-16 Thread Chander Kashyap
In order to support cpuidle through mcpm, suspend and powered-up callbacks are required in mcpm platform code. Hence populate the same callbacks. Signed-off-by: Chander Kashyap Signed-off-by: Chander Kashyap --- Changes in v6: None Changes in v5: 1. Add comment to address cache access wh

[PATCH v6 5/6] exynos: cpuidle: do not allow cpuidle registration for Exynos5420

2014-05-16 Thread Chander Kashyap
Exynos5420 is big.Little Soc. It uses cpuidle-big-litle generic cpuidle driver. Hence do not allow exynos cpuidle driver registration for Exynos5420. Signed-off-by: Chander Kashyap Signed-off-by: Chander Kashyap Acked-by: Daniel Lezcano --- Changes in v6: 1. Move cpuidle registration ch

RE: [PATCH] cpufreq: exynos: Fix the compile error

2014-05-16 Thread Kukjin Kim
Viresh Kumar wrote: > > And please use Rafael's email id from Maintainers.. > > On 16 May 2014 13:25, Viresh Kumar wrote: > > On 16 May 2014 13:20, Jonghwan Choi wrote: > >> Commit 7da83a80 ("ARM: EXYNOS: Migrate Exynos specific macros from > >> plat to > >> mach") > > > > Why do you have a lin

[PATCH v6 0/6] add cpuidle support for Exynos5420

2014-05-16 Thread Chander Kashyap
Exynos5420 is a big-little Soc from Samsung. It has 4 A15 and 4 A7 cores. This patchset adds cpuidle support for Exynos5420 SoC based on generic big.little cpuidle driver. Tested on SMDK5420. This patch set depends on: 1. [PATCH 0/5] MCPM backend for Exynos5420 http://www.spin

[PATCH v6 2/6] arm: exynos: add generic function to calculate cpu number

2014-05-16 Thread Chander Kashyap
The address of cpu power registers in pmu is based on cpu number offsets. This function calculate the same. This is essentially required in case of multi-cluster SoC's e.g Exynos5420. Signed-off-by: Chander Kashyap Signed-off-by: Chander Kashyap --- arch/arm/mach-exynos/regs-pmu.h |9 ++

[PATCH v2] cpufreq: exynos: Fix the compile error

2014-05-16 Thread Jonghwan Choi
Commit 7da83a80 ("ARM: EXYNOS: Migrate Exynos specific macros from plat to mach") which lands in samsung tree causes build breakage for cpufreq-exynos like following: drivers/cpufreq/exynos-cpufreq.c: In function 'exynos_cpufreq_probe': drivers/cpufreq/exynos-cpufreq.c:166:2: error: implicit decl

Re: [PATCH] cpufreq: exynos: Fix the compile error

2014-05-16 Thread Viresh Kumar
And please use Rafael's email id from Maintainers.. On 16 May 2014 13:25, Viresh Kumar wrote: > On 16 May 2014 13:20, Jonghwan Choi wrote: >> Commit 7da83a80 ("ARM: EXYNOS: Migrate Exynos specific macros from plat to >> mach") > > Why do you have a line break here ? > >> which lands in samsung t

Re: [PATCH] cpufreq: exynos: Fix the compile error

2014-05-16 Thread Viresh Kumar
On 16 May 2014 13:20, Jonghwan Choi wrote: > Commit 7da83a80 ("ARM: EXYNOS: Migrate Exynos specific macros from plat to > mach") Why do you have a line break here ? > which lands in samsung tree causes build breakage for cpufreq-exynos like > following: Enter a blank line here.. > drivers/cpuf

[PATCH] cpufreq: exynos: Fix the compile error

2014-05-16 Thread Jonghwan Choi
Commit 7da83a80 ("ARM: EXYNOS: Migrate Exynos specific macros from plat to mach") which lands in samsung tree causes build breakage for cpufreq-exynos like following: drivers/cpufreq/exynos-cpufreq.c: In function 'exynos_cpufreq_probe': drivers/cpufreq/exynos-cpufreq.c:166:2: error: implicit declar