Re: [PATCH 1/3] clk: exynos5410: Add the definitions of new clock registers

2014-07-31 Thread Thomas Abraham
Hi Humberto, On Wed, Jul 30, 2014 at 8:06 PM, Humberto Silva Naves hsna...@gmail.com wrote: Added clock register definitions for the majority of the relevant clocks inside the SoC, including the definitions of all PLL's clocks. The definitions are now ordered by name, in order to make the It

Re: [PATCH 2/3] clk: exynos5410: Add suspend/resume handling

2014-07-31 Thread Thomas Abraham
Hi Humberto, On Wed, Jul 30, 2014 at 8:06 PM, Humberto Silva Naves hsna...@gmail.com wrote: This patch implements all the necessary code that handles register saving and restoring during a suspend/resume cycle. To make this possible, the local variable reg_base from the function

Re: [PATCH] ARM: exynos_defconfig: Enable PL330 DMA

2014-07-31 Thread Andreas Färber
Hi Tushar, Am 31.07.2014 07:42, schrieb Tushar Behera: We are getting a system hang on Arndale-Octa board if PL330_DMA is not enabled. The issue is related to [1]. AUDSS block provides the clock for audio DMA controller. Any operation on this clock requires that the clock to AUDSS block be

Re: [PATCH 3/3] clk: exynos5410: Added clocks BPLL, DPLL, EPLL, IPLL, MPLL, and VPLL

2014-07-31 Thread Thomas Abraham
Hi Humberto, On Wed, Jul 30, 2014 at 8:06 PM, Humberto Silva Naves hsna...@gmail.com wrote: Added the remaining PLL clocks, and also registered the configuration tables with the PLL coefficients for the supported frequencies. These frequency tables are valid when a 24MHz clock is supplied as

Re: [PATCH v9 0/6] cpufreq: use generic cpufreq drivers for exynos platforms

2014-07-31 Thread Chander M. Kashyap
On Wed, Jul 30, 2014 at 1:37 PM, Thomas Abraham thomas...@samsung.com wrote: Changes since v8: - Fixes suggested by Tomasz Figa. This patch series removes the use of Exynos4210 and Exynos5250 specific cpufreq drivers and enables the use of cpufreq-cpu0 driver for these platforms. This

Re: [PATCH V6 0/8] drm/exynos: few patches to enhance bridge chip support

2014-07-31 Thread Ajay kumar
Andreas, On Thu, Jul 31, 2014 at 1:02 AM, Andreas Färber afaer...@suse.de wrote: Hi Ajay, Am 30.07.2014 08:21, schrieb Ajay kumar: On Tue, Jul 29, 2014 at 4:51 PM, Andreas Färber afaer...@suse.de wrote: Am 28.07.2014 08:13, schrieb Ajay kumar: On 7/27/14, Andreas Färber afaer...@suse.de

Re: [PATCH V6 0/8] drm/exynos: few patches to enhance bridge chip support

2014-07-31 Thread Andreas Färber
Ajay, Am 31.07.2014 10:38, schrieb Ajay kumar: On Thu, Jul 31, 2014 at 1:02 AM, Andreas Färber afaer...@suse.de wrote: Am 30.07.2014 08:21, schrieb Ajay kumar: On Tue, Jul 29, 2014 at 4:51 PM, Andreas Färber afaer...@suse.de wrote: Am 28.07.2014 08:13, schrieb Ajay kumar: On 7/27/14, Andreas

Fwd: Role of PLL_ENABLE_BIT

2014-07-31 Thread Humberto Naves
-- Forwarded message -- From: Humberto Naves hsna...@gmail.com Date: Thu, Jul 31, 2014 at 11:01 AM Subject: Re: Role of PLL_ENABLE_BIT To: Yadwinder Singh Brar yadi.bra...@gmail.com Cc: linux-samsung-soc linux-samsung-soc@vger.kernel.org, Mike Turquette mturque...@linaro.org,

Re: [PATCH v3 4/4] ARM: dts: Add exynos5250-spring device tree

2014-07-31 Thread Andreas Färber
Hi, Am 31.07.2014 11:49, schrieb Ajay kumar: On Thu, Jul 31, 2014 at 2:56 PM, Andreas Färber afaer...@suse.de wrote: Am 30.07.2014 15:50, schrieb Andreas Färber: diff --git a/arch/arm/boot/dts/exynos5250-spring.dts b/arch/arm/boot/dts/exynos5250-spring.dts new file mode 100644 index

Re: [PATCH v3 4/4] ARM: dts: Add exynos5250-spring device tree

2014-07-31 Thread Ajay kumar
On Thu, Jul 31, 2014 at 3:23 PM, Andreas Färber afaer...@suse.de wrote: Hi, Am 31.07.2014 11:49, schrieb Ajay kumar: On Thu, Jul 31, 2014 at 2:56 PM, Andreas Färber afaer...@suse.de wrote: Am 30.07.2014 15:50, schrieb Andreas Färber: diff --git a/arch/arm/boot/dts/exynos5250-spring.dts

Re: Role of PLL_ENABLE_BIT

2014-07-31 Thread Andreas Färber
Hi Humberto, Somehow the original message didn't arrive on linux-samsung-soc... Am 31.07.2014 06:51, schrieb Yadwinder Singh Brar: --- Original Message --- Sender : Humberto Naveshsna...@gmail.com Date : Jul 31, 2014 00:16 (GMT+09:00) Title : Role of PLL_ENABLE_BIT Hi, I am

Re: [PATCH V6 0/8] drm/exynos: few patches to enhance bridge chip support

2014-07-31 Thread Ajay kumar
On Thu, Jul 31, 2014 at 2:27 PM, Andreas Färber afaer...@suse.de wrote: Ajay, Am 31.07.2014 10:38, schrieb Ajay kumar: On Thu, Jul 31, 2014 at 1:02 AM, Andreas Färber afaer...@suse.de wrote: Am 30.07.2014 08:21, schrieb Ajay kumar: On Tue, Jul 29, 2014 at 4:51 PM, Andreas Färber

Re: [PATCH V6 0/8] drm/exynos: few patches to enhance bridge chip support

2014-07-31 Thread Thierry Reding
On Thu, Jul 31, 2014 at 10:57:55AM +0200, Andreas Färber wrote: Am 31.07.2014 10:38, schrieb Ajay kumar: [...] With just the spring-bridge.v6 branch of your own tree, I am able to see bootup logo on Skate(a variant of spring which also contains ps8622). I have tried both exynos_defconfig

Re: [PATCH V6 0/8] drm/exynos: few patches to enhance bridge chip support

2014-07-31 Thread Andreas Färber
Am 31.07.2014 12:23, schrieb Thierry Reding: On Thu, Jul 31, 2014 at 10:57:55AM +0200, Andreas Färber wrote: Am 31.07.2014 10:38, schrieb Ajay kumar: [...] With just the spring-bridge.v6 branch of your own tree, I am able to see bootup logo on Skate(a variant of spring which also contains

Re: Role of PLL_ENABLE_BIT

2014-07-31 Thread Humberto Naves
Hi Andreas, I guess the original message was not plain text, and majordomo refused to deliver it :-( The signedness is not an issue, if I just use what I sent in the patch, the set_rate function works like a charm. But otherwise, the whole system freezes and I have to reboot the machine. Best,

Re: [PATCH v9 0/6] cpufreq: use generic cpufreq drivers for exynos platforms

2014-07-31 Thread Thomas Abraham
On Thu, Jul 31, 2014 at 11:50 AM, Chander M. Kashyap chander.kash...@gmail.com wrote: On Wed, Jul 30, 2014 at 1:37 PM, Thomas Abraham thomas...@samsung.com wrote: Changes since v8: - Fixes suggested by Tomasz Figa. This patch series removes the use of Exynos4210 and Exynos5250 specific

Re: [PATCH V6 6/8] drm/bridge: Modify drm_bridge core to support driver model

2014-07-31 Thread Thierry Reding
On Wed, Jul 30, 2014 at 09:33:28PM +0530, Ajay kumar wrote: On Wed, Jul 30, 2014 at 8:38 PM, Thierry Reding thierry.red...@gmail.com wrote: [...] I think it should even be possible to do this in more separate steps. For example you could add the new bridge infrastructure without touching

Re: [PATCH V2 7/8] drm/bridge: Add i2c based driver for ptn3460 bridge

2014-07-31 Thread Thierry Reding
On Wed, Jul 30, 2014 at 09:44:32PM +0530, Ajay kumar wrote: On Wed, Jul 30, 2014 at 9:10 PM, Thierry Reding thierry.red...@gmail.com wrote: On Wed, Jul 30, 2014 at 08:46:44PM +0530, Ajay kumar wrote: On Wed, Jul 30, 2014 at 5:35 PM, Thierry Reding thierry.red...@gmail.com wrote: On

[PATCHv2 3/5] clk: samsung: exynos5410: Add suspend/resume handling

2014-07-31 Thread Humberto Silva Naves
This patch implements all the necessary code that handles register saving and restoring during a suspend/resume cycle. To make this possible, the local variable reg_base from the function exynos5410_clk_init was changed to global. In addition, new clock register definitions were added for the

[PATCHv2 5/5] clk: samsung: exynos5410: Added clocks DPLL, EPLL, IPLL, and VPLL

2014-07-31 Thread Humberto Silva Naves
Added the remaining PLL clocks, and also added the configuration tables with the PLL coefficients for the supported frequencies. These frequency tables are only installed when a 24MHz clock is supplied as the input clock source. To reflect these changes, new constants were added to the dt-bindings

[PATCHv2 4/5] clk: samsung: exynos5410: Add fixed rate clocks

2014-07-31 Thread Humberto Silva Naves
This implements the fixed rate clocks generated either inside or outside the SoC. It also adds a dt-binding constant for the sclk_hdmiphy clock, which shall be later used by other drivers, such as the DRM. Since the external fixed rate clock fin_pll is now registered by the clk-exynos5410 file,

[PATCHv2 0/5] clk: samsung: exynos5410: Implementation of the PLL clocks

2014-07-31 Thread Humberto Silva Naves
Hi, This patch series slightly improves the exynos5410 clock driver. Below is a list of changes introduced by the patch: - Basic validation in the clock initialization routine - Added resume/suspend handler - Implemented some fixed rate clocks and changed the way fin_pll is defined - Added

[PATCHv2 1/5] clk: samsung: exynos5410: Add NULL pointer checks in clock init

2014-07-31 Thread Humberto Silva Naves
Added NULL pointer checks for device_node input parameter and for the samsung_clk_provider context returned by samsung_clk_init. Even though the *current* samsung_clk_init function never returns a NULL pointer, it is good to keep this check in place to avoid possible problems in the future due to

[PATCHv2 2/5] clk: samsung: exynos5410: Organize register offset constants

2014-07-31 Thread Humberto Silva Naves
The different register groups (SRC, DIV, PLL, GATE, etc) are now separated by a blank line, and within the same group, the definitions are ordered by address. This is done to reduce the chances of potential conflicts when adding new entries, and to improve the readability of code. While at it,

Re: [PATCHv2 4/5] clk: samsung: exynos5410: Add fixed rate clocks

2014-07-31 Thread Sylwester Nawrocki
(dropping linux-doc ML and Randy from Cc) On 31/07/14 13:22, Humberto Silva Naves wrote: This implements the fixed rate clocks generated either inside or outside the SoC. It also adds a dt-binding constant for the sclk_hdmiphy clock, which shall be later used by other drivers, such as the

[PATCH 0/2] Better model Peach Pit and PI power scheme

2014-07-31 Thread Javier Martinez Canillas
Hello, This is a small series that improve the modeling of the power scheme on the Peach Pit and Pi boards. Besides making the DTS to better describe the hardware these changes allows the core regulator to know what's the real supply for a child to fetch the parent output voltage if the child

[PATCH 1/2] ARM: dts: Improve Peach Pit and Pi power scheme

2014-07-31 Thread Javier Martinez Canillas
The DeviceTree files for the Peach Pit and Pi machines have a simplistic model of the connections between the different regulators since not all the tps65090 regulators get their input supply voltage from the VDC. DCDC1-3, LD0-1 and fet7 parent supply is indded VDC but the fet1-6 get their input

[PATCH 2/2] ARM: dts: Add tps65090 FET constraints on Peach Pit and Pi

2014-07-31 Thread Javier Martinez Canillas
Both Exynos5420 Peach Pit and Exynos5800 Peach Pi boards have a tps65090 PMU that has a number of switches (FETs) that are just on/off devices but they do have a current limit and the output voltage of the switch is ramped up within a controlled slope. After the switch is turned on, a safety

Re: [PATCH v9 0/6] cpufreq: use generic cpufreq drivers for exynos platforms

2014-07-31 Thread Chander M. Kashyap
On Thu, Jul 31, 2014 at 4:29 PM, Thomas Abraham ta.oma...@gmail.com wrote: On Thu, Jul 31, 2014 at 11:50 AM, Chander M. Kashyap chander.kash...@gmail.com wrote: On Wed, Jul 30, 2014 at 1:37 PM, Thomas Abraham thomas...@samsung.com wrote: Changes since v8: - Fixes suggested by Tomasz Figa.

[PATCH] regulator: tps65090: Set voltage for fixed regulators

2014-07-31 Thread Javier Martinez Canillas
According to the tps65090 data manual [0], the DCDC1 and DCDC2 step-down converters and the LDO's have a fixed output voltage. Add this information to the driver since these fixed regulators can be used as parent input supply for switches that don't have an output voltage defined. So the

Re: [PATCHv2 1/5] clk: samsung: exynos5410: Add NULL pointer checks in clock init

2014-07-31 Thread Tomasz Figa
Hi Humberto, Please see my comments inline. On 31.07.2014 13:22, Humberto Silva Naves wrote: Added NULL pointer checks for device_node input parameter and for the samsung_clk_provider context returned by samsung_clk_init. Even though the *current* samsung_clk_init function never returns a

Re: [PATCHv2 2/5] clk: samsung: exynos5410: Organize register offset constants

2014-07-31 Thread Tomasz Figa
Hi Humberto, Please see my comments inline. On 31.07.2014 13:22, Humberto Silva Naves wrote: The different register groups (SRC, DIV, PLL, GATE, etc) are now separated by a blank line, and within the same group, the definitions are ordered by address. This is done to reduce the chances of

Re: [PATCHv2 4/5] clk: samsung: exynos5410: Add fixed rate clocks

2014-07-31 Thread Tomasz Figa
Hi Humberto, You can find my comments inline. On 31.07.2014 13:22, Humberto Silva Naves wrote: This implements the fixed rate clocks generated either inside or outside the SoC. It also adds a dt-binding constant for the sclk_hdmiphy clock, which shall be later used by other drivers, such as

Re: [PATCHv2 5/5] clk: samsung: exynos5410: Added clocks DPLL, EPLL, IPLL, and VPLL

2014-07-31 Thread Tomasz Figa
Hi Humberto, You can find my comments inline. On 31.07.2014 13:22, Humberto Silva Naves wrote: Added the remaining PLL clocks, and also added the configuration tables with the PLL coefficients for the supported frequencies. These frequency tables are only installed when a 24MHz clock is

Re: [PATCHv2 3/5] clk: samsung: exynos5410: Add suspend/resume handling

2014-07-31 Thread Tomasz Figa
Hi Humberto, On 31.07.2014 13:22, Humberto Silva Naves wrote: This patch implements all the necessary code that handles register saving and restoring during a suspend/resume cycle. To make this possible, the local variable reg_base from the function exynos5410_clk_init was changed to global.

Re: [PATCHv2 1/5] clk: samsung: exynos5410: Add NULL pointer checks in clock init

2014-07-31 Thread Tomasz Figa
On 31.07.2014 15:13, Humberto Naves wrote: Hi, I am bit confused by your response: first you mentioned that I should remove the NULL check for variable np, but later on you suggested that I should rearrange the conditional statement to avoid adding more indentation. That was just a side

Re: [PATCHv2 1/5] clk: samsung: exynos5410: Add NULL pointer checks in clock init

2014-07-31 Thread Humberto Naves
Hi, I am bit confused by your response: first you mentioned that I should remove the NULL check for variable np, but later on you suggested that I should rearrange the conditional statement to avoid adding more indentation. My guess is that I should remove that if statement altogether? Regarding

Re: [PATCHv2 4/5] clk: samsung: exynos5410: Add fixed rate clocks

2014-07-31 Thread Humberto Naves
Hi Tomasz, I perfectly see your point. However my question was why you did you decide to postpone Sylwester's? Was there any specific reason? I suppose it would break all the dtb compatibility, but besides that, was there any other reason? Best, Humberto On Thu, Jul 31, 2014 at 2:53 PM, Tomasz

Re: Role of PLL_ENABLE_BIT

2014-07-31 Thread Tomasz Figa
On 31.07.2014 12:46, Humberto Naves wrote: Hi Andreas, I guess the original message was not plain text, and majordomo refused to deliver it :-( The signedness is not an issue, if I just use what I sent in the patch, the set_rate function works like a charm. But otherwise, the whole system

Re: [PATCHv2 5/5] clk: samsung: exynos5410: Added clocks DPLL, EPLL, IPLL, and VPLL

2014-07-31 Thread Humberto Naves
Hi Tomasz, I remember checking these rates on my calculator. You might notice the odd frequency of 45158401Hz (no pun intended) in the EPLL clock. This particular clock frequency was giving me a big headache in a previous project, since it was wrongly listed as 45158400. At first it seems

Re: [PATCHv2 4/5] clk: samsung: exynos5410: Add fixed rate clocks

2014-07-31 Thread Tomasz Figa
On 31.07.2014 15:23, Humberto Naves wrote: Hi Tomasz, I perfectly see your point. However my question was why you did you decide to postpone Sylwester's? Was there any specific reason? I suppose it would break all the dtb compatibility, but besides that, was there any other reason? We

Re: [PATCH v9 6/6] clk: samsung: remove unused clock aliases and update clock flags

2014-07-31 Thread Tomasz Figa
On 30.07.2014 10:07, Thomas Abraham wrote: With some of the Exynos SoCs switched over to use the generic CPUfreq drivers, the unused clock aliases can be removed. In addition to this, the individual clock blocks which are now encapsulated with the consolidate CPU clock type can now be marked

Re: [PATCH v9 0/6] cpufreq: use generic cpufreq drivers for exynos platforms

2014-07-31 Thread Tomasz Figa
Hi Thomas, On 30.07.2014 10:07, Thomas Abraham wrote: Changes since v8: - Fixes suggested by Tomasz Figa. This patch series removes the use of Exynos4210 and Exynos5250 specific cpufreq drivers and enables the use of cpufreq-cpu0 driver for these platforms. This series also enables

Re: [PATCH V6 0/8] drm/exynos: few patches to enhance bridge chip support

2014-07-31 Thread Andreas Färber
Am 31.07.2014 12:23, schrieb Thierry Reding: On Thu, Jul 31, 2014 at 10:57:55AM +0200, Andreas Färber wrote: Am 31.07.2014 10:38, schrieb Ajay kumar: With just the spring-bridge.v6 branch of your own tree, I am able to see bootup logo on Skate(a variant of spring which also contains ps8622).

Re: [PATCH] ARM: exynos_defconfig: Enable PL330 DMA

2014-07-31 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday, July 31, 2014 08:09:49 AM Andreas Färber wrote: Hi Tushar, Am 31.07.2014 07:42, schrieb Tushar Behera: We are getting a system hang on Arndale-Octa board if PL330_DMA is not enabled. The issue is related to [1]. AUDSS block provides the clock for audio DMA

Re: [PATCHv2 5/5] clk: samsung: exynos5410: Added clocks DPLL, EPLL, IPLL, and VPLL

2014-07-31 Thread Tomasz Figa
On 31.07.2014 15:37, Humberto Naves wrote: Hi Tomasz, I remember checking these rates on my calculator. You might notice the odd frequency of 45158401Hz (no pun intended) in the EPLL clock. This particular clock frequency was giving me a big headache in a previous project, since it was

[GIT PULL] Samsung clock changes for v3.17

2014-07-31 Thread Tomasz Figa
From: Tomasz Figa tomasz.f...@gmail.com Hi Mike, The following changes since commit bdfcdf18c380a3c376b42709a89eb2cc52e95ae0: Merge branch 'v3.16-samsung-clk-fixes-1' into samsung-clk-next (2014-06-30 15:06:43 +0200) are available in the git repository at:

Re: [PATCHv9 1/5] mmc: dw_mmc: Slot quirk disable-wp is deprecated.

2014-07-31 Thread Doug Anderson
Jaehoon On Wed, Jul 30, 2014 at 10:35 PM, Jaehoon Chung jh80.ch...@samsung.com wrote: Slot quirks disable-wp is deprecated. Instead, use the host quirk disable-wp. (Because the slot-node is removed in dt-file.) Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com Tested-by: Sachin Kamat

[PATCH v4 0/4] ARM: dts: exynos: Prepare Spring

2014-07-31 Thread Andreas Färber
Hello, Based on the preinstalled 3.8 based ChromeOS kernel and previous 3.15 based attempts by Stephan and me that broke for 3.16, I've prepared a device tree for the HP Chromebook 11 aka Google Spring. v4 fixes a pinctrl bug. Not yet enabled are trackpad, Wifi and sound. My rebasing branch

[PATCH v4 4/4] ARM: dts: Add exynos5250-spring device tree

2014-07-31 Thread Andreas Färber
Adds initial support for the HP Chromebook 11. Cc: Vincent Palatin vpala...@chromium.org Cc: Doug Anderson diand...@chromium.org Cc: Stephan van Schaik step...@synkhronix.com Signed-off-by: Andreas Färber afaer...@suse.de --- v3 - v4: * Fixed samsung,pin-function 1 - 0 for dp-hpd-gpio *

[PATCH v4 3/4] ARM: dts: Clean up exynos5250-snow

2014-07-31 Thread Andreas Färber
Use the new style of referencing inherited nodes and use symbolic names. Suggested-by: Doug Anderson diand...@chromium.org Signed-off-by: Andreas Färber afaer...@suse.de --- v3 - v4: Unchanged v3: New (Doug Anderson) arch/arm/boot/dts/exynos5250-snow.dts | 182

[PATCH v4 1/4] ARM: dts: Fix MMC pinctrl for exynos5250-snow

2014-07-31 Thread Andreas Färber
The pinctrl properties should be on the device directly and not on the slot sub-node. Reported-by: Doug Anderson diand...@chromium.org Cc: Jaehoon Chung jh80.ch...@samsung.com Signed-off-by: Andreas Färber afaer...@suse.de --- v3 - v4: Unchanged v3: New (Doug Anderson) Redundant with Jaehoon

[PATCH v4 2/4] ARM: dts: Fold exynos5250-cros-common into exynos5250-snow

2014-07-31 Thread Andreas Färber
The remaining common ChromeOS pieces are fairly minor. Suggested-by: Doug Anderson diand...@chromium.org Signed-off-by: Andreas Färber afaer...@suse.de --- v3 - v4: Unchanged v2 - v3: * Renamed subject to match Kukjin's style * Rebased onto MMC pinctrl bug fix (Doug Anderson) v2: New

Re: [PATCH v4 0/4] ARM: dts: exynos: Prepare Spring

2014-07-31 Thread Andreas Färber
Am 31.07.2014 18:08, schrieb Andreas Färber: Hello, Based on the preinstalled 3.8 based ChromeOS kernel and previous 3.15 based attempts by Stephan and me that broke for 3.16, I've prepared a device tree for the HP Chromebook 11 aka Google Spring. v4 fixes a pinctrl bug. Once again,

Re: [PATCH v4 4/4] ARM: dts: Add exynos5250-spring device tree

2014-07-31 Thread Vincent Palatin
Always a bit late to the game. One small comment inline. Reviewed-by: Vincent Palatin vpala...@chromium.org On Thu, Jul 31, 2014 at 9:08 AM, Andreas Färber afaer...@suse.de wrote: Adds initial support for the HP Chromebook 11. Cc: Vincent Palatin vpala...@chromium.org Cc: Doug Anderson

[PATCH v3 3/8] thermal: exynos: remove redundant pdata checks from exynos_tmu_initialize()

2014-07-31 Thread Bartlomiej Zolnierkiewicz
Remove runtime checks for pdata sanity from exynos_tmu_initialize(). The current values hardcoded in pdata will never trigger the checks and checking itself is not proper. The checks in question are done at runtime in a production code for data that is hardcoded inside driver during development

[PATCH v3 8/8] thermal: exynos: remove identical values from exynos*_tmu_registers structures

2014-07-31 Thread Bartlomiej Zolnierkiewicz
There is no need for abstracting configuration for registers that are identical on all SoC types. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com ---

[PATCH v3 7/8] thermal: exynos: remove redundant pdata checks from exynos_tmu_control()

2014-07-31 Thread Bartlomiej Zolnierkiewicz
pdata-reference_voltage and pdata-gain are always defined to non-zero values so remove the redundant checks from exynos_tmu_control(). There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Acked-by: Kyungmin Park

[PATCH v3 5/8] thermal: exynos: simplify temp_to_code() and code_to_temp()

2014-07-31 Thread Bartlomiej Zolnierkiewicz
* Remove dead temp check from temp_to_code() (this function users in exynos_tmu_initialize() always pass correct temperatures and exynos_tmu_set_emulation() returns early for EXYNOS4210 because TMU_SUPPORT_EMULATION flag is not set on this SoC). * Move temp_code check from code_to_temp() to

[PATCH v3 4/8] thermal: exynos: remove redundant threshold_code checks from exynos_tmu_initialize()

2014-07-31 Thread Bartlomiej Zolnierkiewicz
Remove runtime checks for negative return values of temp_to_code() from exynos_tmu_initialize(). The current level temperature data hardcoded in pdata will never cause a negative temp_to_code() return values and checking itself is not proper. The checks in question are done at runtime in a

[PATCH v3 1/8] thermal: exynos: remove unused struct exynos_tmu_registers entries

2014-07-31 Thread Bartlomiej Zolnierkiewicz
Remove unused / write-only entries from struct exynos_tmu_registers. Then remove unused defines while at it. We don't keep the unused/untested features in the kernel just in case that some future hardware might need it. Such code has a real maintainance cost (all other code changes have to take

[PATCH v3 0/8] thermal: exynos: various cleanups

2014-07-31 Thread Bartlomiej Zolnierkiewicz
Hi, This patch series contains various cleanups for EXYNOS thermal driver. Overall it decreases driver's LOC by 9%. It is based on next-20140731 kernel. It should not cause any functionality changes. Changes since v2 (https://lkml.org/lkml/2014/6/17/436): - synced patches against next

[PATCH v3 6/8] thermal: exynos: cache non_hw_trigger_levels in pdata

2014-07-31 Thread Bartlomiej Zolnierkiewicz
Cache number of non-hardware trigger levels in a new pdata field (non_hw_trigger_levels) and convert code in exynos_tmu_initialize() accordingly. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Acked-by: Kyungmin Park

[PATCH v3 2/8] thermal: exynos: remove dead code for HW_MODE calibration

2014-07-31 Thread Bartlomiej Zolnierkiewicz
The commit 1928457 (thermal: exynos: Add hardware mode thermal calibration support) has added HW_MODE feature but it has never been enabled. As such it has been a dead code for over a year now and should be removed from the kernel. We don't keep the unused/untested features in the kernel just in

Re: [PATCH v4 4/4] ARM: dts: Add exynos5250-spring device tree

2014-07-31 Thread Andreas Färber
Hi, Am 31.07.2014 19:00, schrieb Vincent Palatin: Always a bit late to the game. One small comment inline. Reviewed-by: Vincent Palatin vpala...@chromium.org Thanks, On Thu, Jul 31, 2014 at 9:08 AM, Andreas Färber afaer...@suse.de wrote: + usb3_vbus_reg: regulator-usb3 { +

Re: [PATCH v2 0/9] thermal: exynos: various cleanups

2014-07-31 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday, July 29, 2014 08:58:48 AM Eduardo Valentin wrote: On Mon, Jul 28, 2014 at 08:30:53PM +0530, amit daniel kachhap wrote: Hi Eduardo, Hello Amit, Please reject this entire series as this is not re-based recently. Actually two point trimming which this series seeks to

[PATCH 06/15] drm/exynos: dpi: Add support for panel prepare and unprepare routines

2014-07-31 Thread Ajay Kumar
Modify exynos_dpi driver to support the new panel calls: prepare and unprepare. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_dpi.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c

[PATCH 03/15] drm/panel: ld9040: Add dummy prepare and unprepare routines

2014-07-31 Thread Ajay Kumar
This patch adds dummy definition for prepare and unprepare routines to ld9040 panel driver. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com --- drivers/gpu/drm/panel/panel-ld9040.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-ld9040.c

[PATCH 04/15] drm/panel: s6e8aa0: Add dummy prepare and unprepare routines

2014-07-31 Thread Ajay Kumar
This patch adds dummy definition for prepare and unprepare routines to s6e8aa0 panel driver. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com --- drivers/gpu/drm/panel/panel-s6e8aa0.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-s6e8aa0.c

[PATCH 08/15] drm/tegra: Add support for panel prepare and unprepare routines

2014-07-31 Thread Ajay Kumar
Modify tegra output driver to support the new panel calls: prepare and unprepare. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com --- drivers/gpu/drm/tegra/output.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/tegra/output.c b/drivers/gpu/drm/tegra/output.c index

[PATCH 01/15] drm/panel: add prepare and unprepare routines

2014-07-31 Thread Ajay Kumar
Most of the panels need an init sequence as mentioned below: -- poweron LCD unit/LCD_EN -- start video data -- poweron LED unit/BACKLIGHT_EN And, a de-init sequence as mentioned below: -- poweroff LED unit/BACKLIGHT_EN -- stop video data -- poweroff

[PATCH 12/15] drm/panel: simple: Support usage of delays in panel functions

2014-07-31 Thread Ajay Kumar
For most of the panels, we need to provide delays during various stages of panel powerup/powerdown. So, Add a structure to hold those delay values and use them in corresponding functions. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com --- drivers/gpu/drm/panel/panel-simple.c | 30

[PATCH 02/15] drm/panel: Add get_modes helper

2014-07-31 Thread Ajay Kumar
Add a helper function drm_panel_get_modes to get modes from the panel. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com --- include/drm/drm_panel.h |8 1 file changed, 8 insertions(+) diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h index 9addc69..efc63cc 100644 ---

[PATCH 00/15] drm/panel: Add prepare and unprepare routines

2014-07-31 Thread Ajay Kumar
This series is based on exynos-drm-next branch of Inki Dae's tree at: git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git This is originally a part of the bridge chip series: http://www.spinics.net/lists/linux-samsung-soc/msg34826.html But, since we can handle panel and bridge

[PATCH 09/15] drm/panel: ld9040: Add proper definition for prepare and unprepare

2014-07-31 Thread Ajay Kumar
Move out code from enable and disable routines to prepare and unprepare routines, so that functionality is properly distributed across all the panel functions. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com --- drivers/gpu/drm/panel/panel-ld9040.c | 22 +++--- 1 file

[PATCH 10/15] drm/panel: s6e8aa0: Add proper definition for prepare and unprepare

2014-07-31 Thread Ajay Kumar
Move out code from enable and disable routines to prepare and unprepare routines, so that functionality is properly distributed across all the panel functions. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com --- drivers/gpu/drm/panel/panel-s6e8aa0.c | 22 +++--- 1 file

[PATCH 07/15] drm/exynos: dsi: Add support for panel prepare and unprepare routines

2014-07-31 Thread Ajay Kumar
Modify exynos_dsi driver to support the new panel calls: prepare and unprepare. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git

[PATCH 11/15] drm/panel: simple: Add proper definition for prepare and unprepare

2014-07-31 Thread Ajay Kumar
Move out code from enable and disable routines to prepare and unprepare routines, so that functionality is properly distributed across all the panel functions. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com --- drivers/gpu/drm/panel/panel-simple.c | 37 +- 1

[PATCH 15/15] drm/exynos: dp: Modify driver to support drm_panel

2014-07-31 Thread Ajay Kumar
Add drm_panel controls to support powerup/down of the eDP panel, if one is present at the sink side. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com --- drivers/gpu/drm/exynos/Kconfig |1 + drivers/gpu/drm/exynos/exynos_dp_core.c | 88 ---

[PATCH 14/15] drm/exynos: Move DP setup into commit()

2014-07-31 Thread Ajay Kumar
Add commit callback for exynos_dp, and move the DP link training, video configuration code from the hotplug handler into commit(). Signed-off-by: Sean Paul seanp...@chromium.org Signed-off-by: Ajay Kumar ajaykumar...@samsung.com --- drivers/gpu/drm/exynos/exynos_dp_core.c | 24

[PATCH 13/15] drm/panel: simple: Add support for auo_b133htn01 panel

2014-07-31 Thread Ajay Kumar
Add panel_desc structure for auo_b133htn01 eDP panel. Signed-off-by: Ajay Kumar ajaykumar...@samsung.com --- .../devicetree/bindings/panel/auo,b133htn01.txt|7 + drivers/gpu/drm/panel/panel-simple.c | 31 2 files changed, 38 insertions(+) create

[GIT PULL] Samsung 2nd DT updates for v3.17

2014-07-31 Thread Kukjin Kim
The following changes since commit 6da287ad0266cca1fa8f88fb8b1c466e8164671f: Merge branch 'v3.17-next/power-exynos' into v3.17-next/dt-samsung-2 (2014-07-29 06:09:42 +0900) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git

Re: [PATCH v9 6/6] clk: samsung: remove unused clock aliases and update clock flags

2014-07-31 Thread Thomas Abraham
Hi Tomasz, On Thu, Jul 31, 2014 at 7:43 PM, Tomasz Figa tomasz.f...@gmail.com wrote: On 30.07.2014 10:07, Thomas Abraham wrote: With some of the Exynos SoCs switched over to use the generic CPUfreq drivers, the unused clock aliases can be removed. In addition to this, the individual clock

Re: [PATCH v9 0/6] cpufreq: use generic cpufreq drivers for exynos platforms

2014-07-31 Thread Thomas Abraham
On Thu, Jul 31, 2014 at 7:45 PM, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Thomas, On 30.07.2014 10:07, Thomas Abraham wrote: Changes since v8: - Fixes suggested by Tomasz Figa. This patch series removes the use of Exynos4210 and Exynos5250 specific cpufreq drivers and enables the use

Re: [GIT PULL] Samsung 2nd DT updates for v3.17

2014-07-31 Thread Kukjin Kim
On 08/01/14 03:20, Kukjin Kim wrote: Hi Arnd and Olof, Probably you may see merge conflict when you merge this branch into arm-soc because of cros-ec-keyboard related patches from Stephen. Here is my preferred resolution. diff --cc arch/arm/boot/dts/exynos5250-snow.dts index

Re: [PATCH v9 4/6] ARM: Exynos: switch to using generic cpufreq driver for Exynos4210/5250/5420

2014-07-31 Thread Kukjin Kim
On 07/30/14 17:07, Thomas Abraham wrote: The new CPU clock type allows the use of generic CPUfreq drivers. So for Exynos4210/5250, switch to using generic cpufreq driver. For Exynos5420, which did not have CPUfreq driver support, enable the use of generic CPUfreq driver. Suggested-by: Tomasz

Re: [PATCH v9 0/6] cpufreq: use generic cpufreq drivers for exynos platforms

2014-07-31 Thread Thomas Abraham
Hi Viresh, On Thu, Jul 31, 2014 at 11:55 PM, Thomas Abraham ta.oma...@gmail.com wrote: On Thu, Jul 31, 2014 at 7:45 PM, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Thomas, On 30.07.2014 10:07, Thomas Abraham wrote: Changes since v8: - Fixes suggested by Tomasz Figa. This patch series

Re: [PATCHv9 1/5] mmc: dw_mmc: Slot quirk disable-wp is deprecated.

2014-07-31 Thread Kukjin Kim
On 08/01/14 01:02, Doug Anderson wrote: Jaehoon On Wed, Jul 30, 2014 at 10:35 PM, Jaehoon Chungjh80.ch...@samsung.com wrote: Slot quirks disable-wp is deprecated. Instead, use the host quirk disable-wp. (Because the slot-node is removed in dt-file.) Signed-off-by: Jaehoon

Re: [PATCH v9 6/6] clk: samsung: remove unused clock aliases and update clock flags

2014-07-31 Thread Tomasz Figa
On 31.07.2014 20:24, Thomas Abraham wrote: Hi Tomasz, On Thu, Jul 31, 2014 at 7:43 PM, Tomasz Figa tomasz.f...@gmail.com wrote: On 30.07.2014 10:07, Thomas Abraham wrote: With some of the Exynos SoCs switched over to use the generic CPUfreq drivers, the unused clock aliases can be

Re: [PATCHv9 1/5] mmc: dw_mmc: Slot quirk disable-wp is deprecated.

2014-07-31 Thread Kukjin Kim
On 08/01/14 01:02, Doug Anderson wrote: Jaehoon On Wed, Jul 30, 2014 at 10:35 PM, Jaehoon Chungjh80.ch...@samsung.com wrote: Slot quirks disable-wp is deprecated. Instead, use the host quirk disable-wp. (Because the slot-node is removed in dt-file.) Signed-off-by: Jaehoon

Re: [PATCH v9 4/6] ARM: Exynos: switch to using generic cpufreq driver for Exynos4210/5250/5420

2014-07-31 Thread Tomasz Figa
Kukjin, On 31.07.2014 20:32, Kukjin Kim wrote: On 07/30/14 17:07, Thomas Abraham wrote: The new CPU clock type allows the use of generic CPUfreq drivers. So for Exynos4210/5250, switch to using generic cpufreq driver. For Exynos5420, which did not have CPUfreq driver support, enable the use

Re: [PATCH v4 1/4] ARM: dts: Fix MMC pinctrl for exynos5250-snow

2014-07-31 Thread Kukjin Kim
On 08/01/14 01:08, Andreas Färber wrote: The pinctrl properties should be on the device directly and not on the slot sub-node. Reported-by: Doug Andersondiand...@chromium.org Cc: Jaehoon Chungjh80.ch...@samsung.com Signed-off-by: Andreas Färberafaer...@suse.de --- v3 - v4: Unchanged v3:

Re: [PATCH v9 6/6] clk: samsung: remove unused clock aliases and update clock flags

2014-07-31 Thread Tomasz Figa
On 31.07.2014 20:41, Thomas Abraham wrote: On Fri, Aug 1, 2014 at 12:05 AM, Tomasz Figa tomasz.f...@gmail.com wrote: On 31.07.2014 20:24, Thomas Abraham wrote: Hi Tomasz, On Thu, Jul 31, 2014 at 7:43 PM, Tomasz Figa tomasz.f...@gmail.com wrote: On 30.07.2014 10:07, Thomas Abraham wrote:

Re: [PATCH v9 6/6] clk: samsung: remove unused clock aliases and update clock flags

2014-07-31 Thread Thomas Abraham
On Fri, Aug 1, 2014 at 12:16 AM, Tomasz Figa tomasz.f...@gmail.com wrote: On 31.07.2014 20:41, Thomas Abraham wrote: On Fri, Aug 1, 2014 at 12:05 AM, Tomasz Figa tomasz.f...@gmail.com wrote: On 31.07.2014 20:24, Thomas Abraham wrote: Hi Tomasz, On Thu, Jul 31, 2014 at 7:43 PM, Tomasz Figa

Re: [PATCH v9 4/6] ARM: Exynos: switch to using generic cpufreq driver for Exynos4210/5250/5420

2014-07-31 Thread Tomasz Figa
On 31.07.2014 20:40, Tomasz Figa wrote: Kukjin, On 31.07.2014 20:32, Kukjin Kim wrote: On 07/30/14 17:07, Thomas Abraham wrote: The new CPU clock type allows the use of generic CPUfreq drivers. So for Exynos4210/5250, switch to using generic cpufreq driver. For Exynos5420, which did not

[GIT PULL] Samsung 2nd cleanup for v3.17

2014-07-31 Thread Kukjin Kim
Hi Arnd, Olof One more pull-request. Sorry. Thanks, Kukjin The following changes since commit f1ff47454bb2fe0d5644f981679d1bea532816fd: clk: samsung: s5pv210: Remove legacy board support (2014-07-19 04:32:19 +0900) are available in the git repository at:

Re: [PATCH v4 4/4] ARM: dts: Add exynos5250-spring device tree

2014-07-31 Thread Tomasz Figa
Hi Andreas, Sorry for joining the party a bit late, but there were patches with less people involved so I preferred to review them first. You can find my comments inline. On 31.07.2014 18:08, Andreas Färber wrote: Adds initial support for the HP Chromebook 11. [snip] + gpio-keys { +

Re: [PATCH v2 0/2] Firmware-assisted suspend/resume of Exynos SoCs

2014-07-31 Thread Tomasz Figa
Hi Kukjin, On 17.07.2014 17:56, Tomasz Figa wrote: On Exynos-based boards running secure firmware the sequence of low level operations to enter and leave system-wide sleep mode is different than on those without the firmware. Namely: - CP15 power control and diagnostic registers cannot be

Re: [PATCH v3 0/7] Enable L2 cache support on Exynos4210/4x12 SoCs

2014-07-31 Thread Tomasz Figa
On 17.07.2014 18:38, Tomasz Figa wrote: This series intends to add support for L2 cache on Exynos4 SoCs on boards running under secure firmware, which requires certain initialization steps to be done with help of firmware, as selected registers are writable only from secure mode. First four

Re: [PATCH v4 1/4] ARM: dts: Fix MMC pinctrl for exynos5250-snow

2014-07-31 Thread Tomasz Figa
On 31.07.2014 18:08, Andreas Färber wrote: The pinctrl properties should be on the device directly and not on the slot sub-node. Reported-by: Doug Anderson diand...@chromium.org Cc: Jaehoon Chung jh80.ch...@samsung.com Signed-off-by: Andreas Färber afaer...@suse.de --- v3 - v4: Unchanged

  1   2   >