Re: [PATCH v4 4/4] ARM: dts: Add exynos5250-spring device tree
Am 02.08.2014 07:15, schrieb Doug Anderson:
On Thu, Jul 31, 2014 at 12:40 PM, Tomasz Figa tomasz.f...@gmail.com wrote:
On 31.07.2014 21:20, Andreas Färber wrote:
Am 31.07.2014 21:05, schrieb Tomasz Figa:
On 31.07.2014 18:08, Andreas Färber wrote:
+sd1_clk {
+ samsung,pin-drv = 0;
+};
+
+sd1_cmd {
+ samsung,pin-pud = 3;
+ samsung,pin-drv = 0;
+};
+
+sd1_cd {
+ samsung,pin-drv = 0;
+};
+
+sd1_bus4 {
+ samsung,pin-drv = 0;
+};
Here generic settings are being overridden, so it might be a good idea
to explain why, like with i2c pull-up above.
Snow does not have an explanation either, so please suggest what comment
you'd like to see. Consider me just a user with no specs. :)
Doug, Vincent, someone else?
The comment is just in a different place--it's in the dw_mmc node.
Probably belongs here, though:
/*
* Wifi is a SiP, so can keep drive strengths low
* to reduce EMI.
*/
I did copy such a comment for the MMC node in v5, still present in v6.
Andreas
I guess the cmd line isn't documented. There is no external pull on
the command line and on most boards there is one. Our hardware guys
thought we didn't need it and apparently we don't...
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 00/10] ARM: dts: exynos: Prepare Spring
Hi, Am 02.08.2014 06:57, schrieb Doug Anderson: On Fri, Aug 1, 2014 at 7:34 PM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: On 08/02/2014 02:52 AM, Andreas Färber wrote: Based on the preinstalled 3.8 based ChromeOS kernel and previous 3.15 based attempts by Stephan and me that broke for 3.16, I've prepared a device tree for the HP Chromebook 11 aka Google Spring. v6 renames a node and reverts dp_hpd. Not yet enabled are trackpad, Wifi and sound. I made a comment on patch 05/10 but the rest of the series looks good to me. So for the remaining patches: Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk NOTE: I thought that Tomasz Figa gave you his Reviewed-by on v5 for the whole series as well but I didn't see his tag on the v6 patches. Yes, I thought that too. I assume he's OK with the small changes you made between v5 and v6. In the very least his Reviewed-by could be present on the patches that didn't change between the last two revs. I did add it to the bootargs, GPIO, USB3503 patches. All other patches were either split off or slightly changed due to dp_hpd[_gpio], so I didn't carry it over. Given Javier's review and Tomasz's review and Vincent's comments, I'll probably skip all the work of reviewing the rest of the series unless someone really wants me to. ;) Could you maybe give an Rb or Ab for the actual Spring patch to have the Cc: updated? :) Note that if there's some problem that can't be resolved by selectively dropping patches, I won't be available next week, so you'll either have to provide fixups for Kukjin to squash or wait till I've returned. One thing I've wondered is whether we should put status = disabled on the dp node with some comment, since it's known not to work as is (but better having the data here than leaving it out, I believe). Of course if either of you has input on the discussions on the drm bridge/panel series V6 [1] for how to enable non-simplefb display and iommus, that would be valuable. [1] http://www.spinics.net/lists/linux-samsung-soc/msg35274.html And when one thing is accomplished, I am always quick to look forward: I've taken a quick look at sound nodes: According to 3.8 DT, Spring uses max98089 whereas Snow has 98091, so different codec driver and still lacking DT binding support. I might look into trivially enabling sound/soc/codecs/max98089.c through a maxim,max98089 OF match table once this series lands in linux-next. As for the driver, can we reuse http://git.kernel.org/cgit/linux/kernel/git/broonie/sound.git/tree/sound/soc/samsung/snow.c?h=for-next with a google,spring-audio-max98089, or are code changes needed? Both of you mentioned limitations of cros_ec i2c passthrough leading to a forked tps65090 driver downstream - I don't think I can be of help there, as I guess simply copying a driver will not be an option. ;) https://code.google.com/p/chromium/issues/detail?id=391797 For the touchpad it seems DT support has landed in the input tree as atmel,maxtouch. Backporting just that patch does not make it work though. (Tried the rejected pinctrl approach to be on the safe side.) https://code.google.com/p/chromium/issues/detail?id=371114 https://patchwork.kernel.org/patch/3976801/ I thought the internal xhci would have the webcam on it, but I don't see it in lsusb. Does that need some pinctrl or tps65090 regulator? Once appearing on a bus, which driver config option will it need? Many thanks for your support, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] ARM: EXYNOS: Fix build with PM_SLEEP=n part #2
On Mon, Jul 14, 2014 at 04:43:59PM +0200, Bartlomiej Zolnierkiewicz wrote: Fix building of exynos_defconfig with disabled CONFIG_PM_SLEEP by adding checking whether Exynos cpuidle support is enabled before accessing exynos_enter_aftr. The build error message: arch/arm/mach-exynos/built-in.o:(.data+0x74): undefined reference to `exynos_enter_aftr' make: *** [vmlinux] Error 1 Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com What's happening with this patch? I'm still seeing failures in my builds due to the above error from Tuesday's arm-soc. -- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 03/10] ARM: dts: Prepare node labels for exynos5250
Andreas,
Ehh, one more thing. It looks like my memory is playing tricks on me.
Please see inline.
On 02.08.2014 02:52, Andreas Färber wrote:
Allows them to be extended by reference.
Signed-off-by: Andreas Färber afaer...@suse.de
---
v6: Split off from Snow/SMDK cleanups (Doug Anderson)
[snip]
- serial@12C0 {
+ uart0: serial@12C0 {
clocks = clock CLK_UART0, clock CLK_SCLK_UART0;
clock-names = uart, clk_uart_baud0;
};
- serial@12C1 {
+ uart1: serial@12C1 {
clocks = clock CLK_UART1, clock CLK_SCLK_UART1;
clock-names = uart, clk_uart_baud0;
};
- serial@12C2 {
+ uart2: serial@12C2 {
clocks = clock CLK_UART2, clock CLK_SCLK_UART2;
clock-names = uart, clk_uart_baud0;
};
- serial@12C3 {
+ uart3: serial@12C3 {
clocks = clock CLK_UART3, clock CLK_SCLK_UART3;
clock-names = uart, clk_uart_baud0;
};
I forgot about a series [1] that went through tty tree, which is going
to conflict with this patch. It already adds labels to uart nodes in
serial_X format. I don't really remember why I went with this format for
Exynos SoCs and with uartX for older ones...
[1]
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/arch/arm/boot/dts?id=1e64f48ea7c59fb94acd7551dd9fa68b8a752efc
Best regards,
Tomasz
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 04/10] ARM: dts: Clean up exynos5250-snow
On 02.08.2014 02:52, Andreas Färber wrote: Use the new style of referencing inherited nodes and use symbolic names. Reorder one pinctrl node in GPIO order. Goal is the alignment of all exynos5250 based device trees for comparison. Suggested-by: Doug Anderson diand...@chromium.org Reviewed-by: Doug Anderson diand...@chromium.org Signed-off-by: Andreas Färber afaer...@suse.de --- v5 - v6: * Split off label additions (Doug Anderson) * Fixed alphabetical order of sd3_* nodes (Doug Anderson) v4 - v5: * Introduced labels to consistently use new referencing style (Tomasz Figa) * Use IRQ_TYPE_* constants * Use some more GPIO_ACTIVE_* v3 - v4: Unchanged v3: New (Doug Anderson) arch/arm/boot/dts/exynos5250-snow.dts | 291 +- 1 file changed, 145 insertions(+), 146 deletions(-) Reviewed-by: Tomasz Figa t.f...@samsung.com Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 4/4] ARM: dts: Add exynos5250-spring device tree
On 01.08.2014 05:17, Andreas Färber wrote:
Am 31.07.2014 21:05, schrieb Tomasz Figa:
+
+i2c_2 {
+ status = okay;
+ samsung,i2c-sda-delay = 100;
+ samsung,i2c-max-bus-freq = 66000;
+
+ hdmiddc@50 {
+ compatible = samsung,exynos4210-hdmiddc;
+ reg = 0x50;
+ };
I don't think this matches current Exynos HDMI bindings, which I believe
have been changed to just take a phandle to i2c bus instead.
Looks correct to me:
http://git.kernel.org/cgit/linux/kernel/git/kgene/linux-samsung.git/tree/Documentation/devicetree/bindings/video/exynos_hdmiddc.txt?h=for-next
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/video/exynos_hdmiddc.txt
Looks correct according to the documentation, but unfortunately this is
not the first time (and most likely not the last time) when our Exynos
DRM people carelessly change the binding without taking care of updating
relevant documentation correctly...
Please see following code:
https://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/tree/drivers/gpu/drm/exynos/exynos_hdmi.c?h=exynos-drm-next#n2415
To get the DDC I2C adapter it first tries to look by a hardcoded
compatible string for backwards compatibility, but when there is no such
node, it uses the ddc property which is a phandle to the I2C adapter
node on which the DDC channel will be present.
Long story short, the binding of fake DDC device is obsolete and should
be marked so in documentation, while new device trees should only use
the new way with phandle.
However what this patch adds is for now technically correct and should
work even if support for old bindings is dropped in future, so I won't
consider this an issue.
Best regards,
Tomasz
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 04/10] ARM: dts: Clean up exynos5250-snow
On 02.08.2014 14:21, Tomasz Figa wrote:
On 02.08.2014 02:52, Andreas Färber wrote:
Use the new style of referencing inherited nodes and use symbolic names.
Reorder one pinctrl node in GPIO order.
Goal is the alignment of all exynos5250 based device trees for comparison.
Suggested-by: Doug Anderson diand...@chromium.org
Reviewed-by: Doug Anderson diand...@chromium.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
v5 - v6:
* Split off label additions (Doug Anderson)
* Fixed alphabetical order of sd3_* nodes (Doug Anderson)
v4 - v5:
* Introduced labels to consistently use new referencing style (Tomasz Figa)
* Use IRQ_TYPE_* constants
* Use some more GPIO_ACTIVE_*
v3 - v4: Unchanged
v3: New (Doug Anderson)
arch/arm/boot/dts/exynos5250-snow.dts | 291
+-
1 file changed, 145 insertions(+), 146 deletions(-)
Reviewed-by: Tomasz Figa t.f...@samsung.com
Just for convenience of other reviewers, here are actual changes done do
the device tree after compiling into dtb and then back into dts:
--- exynos5250-snow.dtb.dts 2014-08-02 14:54:15.145905921 +0200
+++ ../dtbs.post/exynos5250-snow.dtb.dts 2014-08-02 14:54:15.146905921
+0200
@@ -8,6 +8,7 @@
model = Google Snow;
chosen {
+ bootargs = console=tty1;
};
aliases {
@@ -829,15 +830,6 @@
phandle = 0x44;
};
- hdmi-hpd-irq {
- samsung,pins = gpx3-7;
- samsung,pin-function = 0x0;
- samsung,pin-pud = 0x1;
- samsung,pin-drv = 0x0;
- linux,phandle = 0x33;
- phandle = 0x33;
- };
-
max77686-irq {
samsung,pins = gpx3-2;
samsung,pin-function = 0x0;
@@ -846,6 +838,15 @@
linux,phandle = 0xe;
phandle = 0xe;
};
+
+ hdmi-hpd-irq {
+ samsung,pins = gpx3-7;
+ samsung,pin-function = 0x0;
+ samsung,pin-pud = 0x1;
+ samsung,pin-drv = 0x0;
+ linux,phandle = 0x33;
+ phandle = 0x33;
+ };
};
pinctrl@1340 {
@@ -1703,12 +1704,12 @@
samsung,dw-mshc-ciu-div = 0x3;
samsung,dw-mshc-sdr-timing = 0x2 0x3;
samsung,dw-mshc-ddr-timing = 0x1 0x2;
+ pinctrl-names = default;
+ pinctrl-0 = 0x27 0x28 0x29;
slot@0 {
reg = 0x0;
bus-width = 0x4;
- pinctrl-names = default;
- pinctrl-0 = 0x27 0x28 0x29;
};
};
Best regards,
Tomasz
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 06/10] ARM: dts: Clean up exynos5250-smdk5250
On 02.08.2014 02:52, Andreas Färber wrote: Use the new style for referencing inherited nodes and use symbolic names. Goal is the alignment of all exynos5250 based device trees for comparison. Signed-off-by: Andreas Färber afaer...@suse.de --- v5 - v6: * Renamed node label codec - mfc for alignment with add System MMU nodes * Rebased for leaving dp_hpd in .dtsi v5: New Follow-up after adding dp_hpd pinctrl node new-style. arch/arm/boot/dts/exynos5250-smdk5250.dts | 632 +++--- 1 file changed, 318 insertions(+), 314 deletions(-) This in fact ends up with empty diff after compiling and decompiling the dts, so obviously will not break anything. :) Reviewed-by: Tomasz Figa t.f...@samsung.com Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 03/10] ARM: dts: Prepare node labels for exynos5250
Am 02.08.2014 14:19, schrieb Tomasz Figa:
Andreas,
Ehh, one more thing. It looks like my memory is playing tricks on me.
Please see inline.
On 02.08.2014 02:52, Andreas Färber wrote:
Allows them to be extended by reference.
Signed-off-by: Andreas Färber afaer...@suse.de
---
v6: Split off from Snow/SMDK cleanups (Doug Anderson)
[snip]
-serial@12C0 {
+uart0: serial@12C0 {
clocks = clock CLK_UART0, clock CLK_SCLK_UART0;
clock-names = uart, clk_uart_baud0;
};
-serial@12C1 {
+uart1: serial@12C1 {
clocks = clock CLK_UART1, clock CLK_SCLK_UART1;
clock-names = uart, clk_uart_baud0;
};
-serial@12C2 {
+uart2: serial@12C2 {
clocks = clock CLK_UART2, clock CLK_SCLK_UART2;
clock-names = uart, clk_uart_baud0;
};
-serial@12C3 {
+uart3: serial@12C3 {
clocks = clock CLK_UART3, clock CLK_SCLK_UART3;
clock-names = uart, clk_uart_baud0;
};
I forgot about a series [1] that went through tty tree, which is going
to conflict with this patch. It already adds labels to uart nodes in
serial_X format. I don't really remember why I went with this format for
Exynos SoCs and with uartX for older ones...
[1]
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/arch/arm/boot/dts?id=1e64f48ea7c59fb94acd7551dd9fa68b8a752efc
I doubt that I'll manage to resend another time today, so please just
drop those hunks from my patch before applying - I ended up not using
them here.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 07/10] ARM: dts: Clean up exynos5250-arndale
On 02.08.2014 02:52, Andreas Färber wrote:
Use the new style of referencing inherited nodes, use symbolic names,
tidy indentation and reorder includes.
Goal is the alignment of all exynos5250 based device trees for comparison.
Signed-off-by: Andreas Färber afaer...@suse.de
---
v5 - v6:
* Updated for mfc node label
v5: New
Aligns with SMDK.
arch/arm/boot/dts/exynos5250-arndale.dts | 929
---
1 file changed, 466 insertions(+), 463 deletions(-)
Diff in resulting dtb:
--- exynos5250-arndale.dtb.dts2014-08-02 14:54:15.102905920 +0200
+++ ../dtbs.post/exynos5250-arndale.dtb.dts 2014-08-02 14:54:15.104905920
+0200
@@ -1977,7 +1977,7 @@
clocks = 0x2 0x158 0x2 0x88 0x2 0x89 0x2 0x9f 0x2 0x400;
clock-names = hdmi, sclk_hdmi, sclk_pixel,
sclk_hdmiphy, mout_hdmi;
samsung,syscon-phandle = 0x7;
- hpd-gpio = 0xc 0x7 0x2;
+ hpd-gpio = 0xc 0x7 0x1;
vdd_osc-supply = 0x31;
vdd_pll-supply = 0x32;
vdd-supply = 0x32;
@@ -2104,15 +2104,9 @@
};
};
- usb_hub_bus {
- compatible = simple-bus;
- #address-cells = 0x1;
- #size-cells = 0x0;
-
- usb_hub {
- compatible = smsc,usb3503a;
- reset-gpios = 0xc 0x5 0x1;
- connect-gpios = 0x10 0x7 0x1;
- };
+ usb-hub {
+ compatible = smsc,usb3503a;
+ reset-gpios = 0xc 0x5 0x1;
+ connect-gpios = 0x10 0x7 0x1;
};
};
Reviewed-by: Tomasz Figa t.f...@samsung.com
Best regards,
Tomasz
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 04/10] ARM: dts: Clean up exynos5250-snow
Am 02.08.2014 14:56, schrieb Tomasz Figa:
On 02.08.2014 14:21, Tomasz Figa wrote:
On 02.08.2014 02:52, Andreas Färber wrote:
Use the new style of referencing inherited nodes and use symbolic names.
Reorder one pinctrl node in GPIO order.
Goal is the alignment of all exynos5250 based device trees for comparison.
Suggested-by: Doug Anderson diand...@chromium.org
Reviewed-by: Doug Anderson diand...@chromium.org
Signed-off-by: Andreas Färber afaer...@suse.de
---
v5 - v6:
* Split off label additions (Doug Anderson)
* Fixed alphabetical order of sd3_* nodes (Doug Anderson)
v4 - v5:
* Introduced labels to consistently use new referencing style (Tomasz Figa)
* Use IRQ_TYPE_* constants
* Use some more GPIO_ACTIVE_*
v3 - v4: Unchanged
v3: New (Doug Anderson)
arch/arm/boot/dts/exynos5250-snow.dts | 291
+-
1 file changed, 145 insertions(+), 146 deletions(-)
Reviewed-by: Tomasz Figa t.f...@samsung.com
Just for convenience of other reviewers, here are actual changes done do
the device tree after compiling into dtb and then back into dts:
Erm, to not confuse reviewers, this must be over the whole series:
--- exynos5250-snow.dtb.dts 2014-08-02 14:54:15.145905921 +0200
+++ ../dtbs.post/exynos5250-snow.dtb.dts 2014-08-02 14:54:15.146905921
+0200
@@ -8,6 +8,7 @@
model = Google Snow;
chosen {
+bootargs = console=tty1;
};
aliases {
This is optional follow-on patch 05/10.
@@ -829,15 +830,6 @@
phandle = 0x44;
};
-hdmi-hpd-irq {
-samsung,pins = gpx3-7;
-samsung,pin-function = 0x0;
-samsung,pin-pud = 0x1;
-samsung,pin-drv = 0x0;
-linux,phandle = 0x33;
-phandle = 0x33;
-};
-
max77686-irq {
samsung,pins = gpx3-2;
samsung,pin-function = 0x0;
@@ -846,6 +838,15 @@
linux,phandle = 0xe;
phandle = 0xe;
};
+
+hdmi-hpd-irq {
+samsung,pins = gpx3-7;
+samsung,pin-function = 0x0;
+samsung,pin-pud = 0x1;
+samsung,pin-drv = 0x0;
+linux,phandle = 0x33;
+phandle = 0x33;
+};
};
pinctrl@1340 {
This is this patch 04/10. Just a movement.
@@ -1703,12 +1704,12 @@
samsung,dw-mshc-ciu-div = 0x3;
samsung,dw-mshc-sdr-timing = 0x2 0x3;
samsung,dw-mshc-ddr-timing = 0x1 0x2;
+pinctrl-names = default;
+pinctrl-0 = 0x27 0x28 0x29;
slot@0 {
reg = 0x0;
bus-width = 0x4;
-pinctrl-names = default;
-pinctrl-0 = 0x27 0x28 0x29;
};
};
This is preceding patch 01/10.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 04/10] ARM: dts: Clean up exynos5250-snow
On 02.08.2014 15:08, Andreas Färber wrote: Am 02.08.2014 14:56, schrieb Tomasz Figa: On 02.08.2014 14:21, Tomasz Figa wrote: On 02.08.2014 02:52, Andreas Färber wrote: Use the new style of referencing inherited nodes and use symbolic names. Reorder one pinctrl node in GPIO order. Goal is the alignment of all exynos5250 based device trees for comparison. Suggested-by: Doug Anderson diand...@chromium.org Reviewed-by: Doug Anderson diand...@chromium.org Signed-off-by: Andreas Färber afaer...@suse.de --- v5 - v6: * Split off label additions (Doug Anderson) * Fixed alphabetical order of sd3_* nodes (Doug Anderson) v4 - v5: * Introduced labels to consistently use new referencing style (Tomasz Figa) * Use IRQ_TYPE_* constants * Use some more GPIO_ACTIVE_* v3 - v4: Unchanged v3: New (Doug Anderson) arch/arm/boot/dts/exynos5250-snow.dts | 291 +- 1 file changed, 145 insertions(+), 146 deletions(-) Reviewed-by: Tomasz Figa t.f...@samsung.com Just for convenience of other reviewers, here are actual changes done do the device tree after compiling into dtb and then back into dts: Erm, to not confuse reviewers, this must be over the whole series: Erm, right, I have forgot to state this, sorry. Similarly for other dtb diffs. Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 07/10] ARM: dts: Clean up exynos5250-arndale
Am 02.08.2014 15:02, schrieb Tomasz Figa:
On 02.08.2014 02:52, Andreas Färber wrote:
Use the new style of referencing inherited nodes, use symbolic names,
tidy indentation and reorder includes.
Goal is the alignment of all exynos5250 based device trees for comparison.
Signed-off-by: Andreas Färber afaer...@suse.de
---
v5 - v6:
* Updated for mfc node label
v5: New
Aligns with SMDK.
arch/arm/boot/dts/exynos5250-arndale.dts | 929
---
1 file changed, 466 insertions(+), 463 deletions(-)
Diff in resulting dtb:
Same here, appears to be over whole series:
--- exynos5250-arndale.dtb.dts 2014-08-02 14:54:15.102905920 +0200
+++ ../dtbs.post/exynos5250-arndale.dtb.dts 2014-08-02 14:54:15.104905920
+0200
@@ -1977,7 +1977,7 @@
clocks = 0x2 0x158 0x2 0x88 0x2 0x89 0x2 0x9f 0x2 0x400;
clock-names = hdmi, sclk_hdmi, sclk_pixel,
sclk_hdmiphy, mout_hdmi;
samsung,syscon-phandle = 0x7;
-hpd-gpio = 0xc 0x7 0x2;
+hpd-gpio = 0xc 0x7 0x1;
vdd_osc-supply = 0x31;
vdd_pll-supply = 0x32;
vdd-supply = 0x32;
Optional follow-up patch 08/10.
@@ -2104,15 +2104,9 @@
};
};
-usb_hub_bus {
-compatible = simple-bus;
-#address-cells = 0x1;
-#size-cells = 0x0;
-
-usb_hub {
-compatible = smsc,usb3503a;
-reset-gpios = 0xc 0x5 0x1;
-connect-gpios = 0x10 0x7 0x1;
-};
+usb-hub {
+compatible = smsc,usb3503a;
+reset-gpios = 0xc 0x5 0x1;
+connect-gpios = 0x10 0x7 0x1;
};
};
Optional follow-up patch 09/10.
Reviewed-by: Tomasz Figa t.f...@samsung.com
Thanks,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 00/10] ARM: dts: exynos: Prepare Spring
On 02.08.2014 12:25, Andreas Färber wrote: [snip] One thing I've wondered is whether we should put status = disabled on the dp node with some comment, since it's known not to work as is (but better having the data here than leaving it out, I believe). Does the DP node itself need more data to work or just some external things are missing? If the former then probably status = disabled should be set, otherwise okay is fine if provided data are enough to probe the Exynos DP driver. Of course if either of you has input on the discussions on the drm bridge/panel series V6 [1] for how to enable non-simplefb display and iommus, that would be valuable. Support for Exynos IOMMU is being worked on right now and patches adding DT support from Marek Szyprowski should show up on the lists in very near future. However I think you don't strictly need IOMMU to get non-simplefb display, as CMA can be used to allocate contiguous memory. [1] http://www.spinics.net/lists/linux-samsung-soc/msg35274.html [snip] For the touchpad it seems DT support has landed in the input tree as atmel,maxtouch. Backporting just that patch does not make it work though. (Tried the rejected pinctrl approach to be on the safe side.) https://code.google.com/p/chromium/issues/detail?id=371114 https://patchwork.kernel.org/patch/3976801/ Looking at what we already have in mainline and the discussion in Chromium issue tracker, current driver should be already in shape to handle the Chromebooks. Apparently it even supports recovery from bootloader mode without the need to parse bootloader address from DT (it somehow calculates possible addresses from main address). Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v6 10/10] ARM: dts: Add exynos5250-spring device tree
On 02.08.2014 02:52, Andreas Färber wrote: Adds initial support for the HP Chromebook 11. Cc: Vincent Palatin vpala...@chromium.org Cc: Doug Anderson diand...@chromium.org Cc: Stephan van Schaik step...@synkhronix.com Signed-off-by: Andreas Färber afaer...@suse.de --- v5 - v6: * Updated for mfc node label * Reverted to dp-hpd-gpio node in pinctrl_0 (Doug Anderson) * Fixed alphabetical order of sd1_* nodes (Doug Anderson) Reviewed-by: Tomasz Figa t.f...@samsung.com Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 1/7] ARM: l2c: Refactor the driver to use commit-like interface
On Thu, Jul 17, 2014 at 06:38:56PM +0200, Tomasz Figa wrote:
Certain implementations of secure hypervisors (namely the one found on
Samsung Exynos-based boards) do not provide access to individual L2C
registers. This makes the .write_sec()-based interface insufficient and
provoking ugly hacks.
This patch is first step to make the driver not rely on availability of
writes to individual registers. This is achieved by refactoring the
driver to use a commit-like operation scheme: all register values are
prepared first and stored in an instance of l2x0_regs struct and then a
single callback is responsible to flush those values to the hardware.
This isn't going to work very well...
+static const struct l2c_init_data *l2x0_data;
So you keep a pointer to the init data...
+static void l2c_resume(void)
+{
+ l2x0_data-enable(l2x0_base, l2x0_saved_regs.aux_ctrl,
+ l2x0_data-num_lock);
which you dereference at resume time...
static const struct l2c_init_data l2c210_data __initconst = {
but the structures which get assigned to the pointer are marked __initconst.
That's not going to work very well.
--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 1/7] ARM: l2c: Refactor the driver to use commit-like interface
On 03.08.2014 00:09, Russell King - ARM Linux wrote:
On Thu, Jul 17, 2014 at 06:38:56PM +0200, Tomasz Figa wrote:
Certain implementations of secure hypervisors (namely the one found on
Samsung Exynos-based boards) do not provide access to individual L2C
registers. This makes the .write_sec()-based interface insufficient and
provoking ugly hacks.
This patch is first step to make the driver not rely on availability of
writes to individual registers. This is achieved by refactoring the
driver to use a commit-like operation scheme: all register values are
prepared first and stored in an instance of l2x0_regs struct and then a
single callback is responsible to flush those values to the hardware.
This isn't going to work very well...
+static const struct l2c_init_data *l2x0_data;
So you keep a pointer to the init data...
+static void l2c_resume(void)
+{
+l2x0_data-enable(l2x0_base, l2x0_saved_regs.aux_ctrl,
+l2x0_data-num_lock);
which you dereference at resume time...
static const struct l2c_init_data l2c210_data __initconst = {
but the structures which get assigned to the pointer are marked __initconst.
Good catch. The code was tested on Exynos which requires the cache to be
resumed from early assembly code and so I did not hit issues caused by this.
Proposed solution: kmemdup() in init, so that only used data remain in
memory and the structures can be kept __initconst.
Best regards,
Tomasz
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
