Re: [PATCH v5 RESEND 1/3] ARM: EXYNOS: Move code from hotplug.c to platsmp.c
W dniu 26.09.2014 o 23:13, Arnd Bergmann pisze: On Friday 05 September 2014, Krzysztof Kozlowski wrote: The commit only moves code around with one additional observable change: the hotplug.c was compiled with custom CFLAGS (-march=armv7-a). These CFLAGS are not necessary any more. This turns out to be wrong, and your change broke 'allmodconfig' builds in linux-next. Please apply this patch on top. My patch definitely needed more testing. I posted a fix here: https://lkml.org/lkml/2014/9/24/163 However it seems that it wasn't picked up by anyone yet. Russell, could you pick up the patch (with acks from Nicolas and Kukjin)? Best regards, Krzysztof Arnd 8-- From 4ba6bf8806caec386e35930314dbad071284c837 Mon Sep 17 00:00:00 2001 From: Arnd Bergmann a...@arndb.de Date: Fri, 26 Sep 2014 23:09:38 +0200 Subject: [PATCH] ARM: EXYNOS: fix build error in platsmp.c /tmp/ccYeWL3V.s: Assembler messages: /tmp/ccYeWL3V.s:659: Error: selected processor does not support ARM mode `isb ' /tmp/ccYeWL3V.s:664: Error: selected processor does not support ARM mode `isb ' /tmp/ccYeWL3V.s:665: Error: selected processor does not support ARM mode `dsb ' make[3]: *** [arch/arm/mach-exynos/platsmp.o] Error 1 Signed-off-by: Arnd Bergmann a...@arndb.de Fixes: 17342534e1d932 (ARM: EXYNOS: Move code from hotplug.c to platsmp.c) diff --git a/arch/arm/mach-exynos/Makefile b/arch/arm/mach-exynos/Makefile index 4e49d4efb264..64324bf5edb4 100644 --- a/arch/arm/mach-exynos/Makefile +++ b/arch/arm/mach-exynos/Makefile @@ -21,6 +21,7 @@ obj-$(CONFIG_PM_SLEEP)+= suspend.o obj-$(CONFIG_PM_GENERIC_DOMAINS) += pm_domains.o obj-$(CONFIG_SMP) += platsmp.o headsmp.o +CFLAGS_platsmp.o := -march=armv7-a plus_sec := $(call as-instr,.arch_extension sec,+sec) AFLAGS_exynos-smc.o :=-Wa,-march=armv7-a$(plus_sec) -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] pinctrl: samsung: Data structure clean-up
Hi Linus, On 25.09.2014 09:49, Tomasz Figa wrote: On 25.09.2014 09:47, Linus Walleij wrote: On Tue, Sep 23, 2014 at 9:05 PM, Tomasz Figa tomasz.f...@gmail.com wrote: This series intends to clean up data structures used by pinctrl-samsung driver. More specifically, it separates initial compile time constants from data used at runtime, allowing unused variant data to be dropped and selected structures constified to improve safety. I like the patch set, tried to apply it but patch 3/5 failed to apply to the devel branch for pinctrl. Can you rebase this on my devel branch, include Marek's Tested-by tag and resend, and I'll take it for v3.18. Sure. Will do that today evening. Probably clashed with some other changes queued in the meantime. Uhm. I went back home and forgot about this series until now. Sorry. I have rebased it on your devel branch, although it seems like this branch is missing [1], which in turn seems to be already present in your for-next branch and is going to cause a merge conflict with this series. Should I still proceed with posting the series based on devel? [1] f6a8249f9e55d pinctrl: exynos: Lock GPIOs as interrupts when used as EINTs Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/3] clk: samsung: Spelling s/bwtween/between/
Hi Pankaj, On 27.09.2014 07:41, Pankaj Dubey wrote: Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com Even though the patch is obvious, it should have at least one line of description. Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/3] clk: samsung: remove unnecessary CONFIG_OF from clk.c
Hi Pankaj, On 27.09.2014 07:41, Pankaj Dubey wrote: Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com Missing patch description. --- drivers/clk/samsung/clk.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/clk/samsung/clk.c b/drivers/clk/samsung/clk.c index deab84d..31bf391 100644 --- a/drivers/clk/samsung/clk.c +++ b/drivers/clk/samsung/clk.c @@ -281,7 +281,6 @@ void __init samsung_clk_register_gate(struct samsung_clk_provider *ctx, * obtain the clock speed of all external fixed clock sources from device * tree and register it */ -#ifdef CONFIG_OF We still have non-DT platforms which use this code, i.e. s3c24xx and s3c64xx. Have you checked if this compiles fine on them with CONFIG_OF disabled? Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 RESEND 1/3] ARM: EXYNOS: Move code from hotplug.c to platsmp.c
On 09/27/14 17:39, Krzysztof Kozlowski wrote: W dniu 26.09.2014 o 23:13, Arnd Bergmann pisze: On Friday 05 September 2014, Krzysztof Kozlowski wrote: The commit only moves code around with one additional observable change: the hotplug.c was compiled with custom CFLAGS (-march=armv7-a). These CFLAGS are not necessary any more. This turns out to be wrong, and your change broke 'allmodconfig' builds in linux-next. Please apply this patch on top. Arnd, Krzysztof commented its fix has been submitted and landed in my -test tree not -next because it should be handled in rmk's tree I think. I sent the patch to RMK patch tracking system just now and it should be fine in there. BTW, I just applied the fix in my -next until its ladning in RMK tree but as you know it will be not be sent to arm-soc via samsung tree... One more, Arnd please pull my pull-request 2nd round and 3rd round for samsung stuff for 3.18. My patch definitely needed more testing. I posted a fix here: https://lkml.org/lkml/2014/9/24/163 However it seems that it wasn't picked up by anyone yet. Russell, could you pick up the patch (with acks from Nicolas and Kukjin)? I believe Russell will take the patch in his tree. Thanks, Kukjin 8-- From 4ba6bf8806caec386e35930314dbad071284c837 Mon Sep 17 00:00:00 2001 From: Arnd Bergmann a...@arndb.de Date: Fri, 26 Sep 2014 23:09:38 +0200 Subject: [PATCH] ARM: EXYNOS: fix build error in platsmp.c /tmp/ccYeWL3V.s: Assembler messages: /tmp/ccYeWL3V.s:659: Error: selected processor does not support ARM mode `isb ' /tmp/ccYeWL3V.s:664: Error: selected processor does not support ARM mode `isb ' /tmp/ccYeWL3V.s:665: Error: selected processor does not support ARM mode `dsb ' make[3]: *** [arch/arm/mach-exynos/platsmp.o] Error 1 Signed-off-by: Arnd Bergmann a...@arndb.de Fixes: 17342534e1d932 (ARM: EXYNOS: Move code from hotplug.c to platsmp.c) diff --git a/arch/arm/mach-exynos/Makefile b/arch/arm/mach-exynos/Makefile index 4e49d4efb264..64324bf5edb4 100644 --- a/arch/arm/mach-exynos/Makefile +++ b/arch/arm/mach-exynos/Makefile @@ -21,6 +21,7 @@ obj-$(CONFIG_PM_SLEEP) += suspend.o obj-$(CONFIG_PM_GENERIC_DOMAINS) += pm_domains.o obj-$(CONFIG_SMP) += platsmp.o headsmp.o +CFLAGS_platsmp.o := -march=armv7-a plus_sec := $(call as-instr,.arch_extension sec,+sec) AFLAGS_exynos-smc.o :=-Wa,-march=armv7-a$(plus_sec) -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
