Please reply
Dear Sir/Madam, Here is a pdf attachment of my proposal to you. Please read and reply I would be grateful. Jose Calvache -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 0/6] Add initial support for pinctrl on Exynos7
Abhilash, Linus, On 09.10.2014 15:54, Abhilash Kesavan wrote: > Changes since v4: > - Rebased over Tomasz Figa's pinctrl clean-up patches[1] > > Changes since v3: > - Changed variable name from exynos_wkup_irq_chip to irq_chip > - Added acked-by tag from Tomasz Figa > > Changes since v2: > - Added a .irq_chip field to the samsung_pin_bank struct > - Consolidated the wakeup and gpio irqd_ops > > Changes since v1: > - Marked the newly created irq_chip instances as __initdata > - Used kmemdup to keep a copy of the irq_chip > - Change the pinctrl name from sd0_rdqs to sd0_ds as per UM > - Moved the pinctrl enablement for exynos7 into a separate patch > - Added tested-by and reviewed-by tags from Thomas Abraham > > This series has been tested on linux-next (20141008) > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/ with > the following dependencies and [1]. > > a) Samsung Serial symbol clean-up for exynos7 serial driver enablement (v2) >http://www.spinics.net/lists/arm-kernel/msg366947.html >http://www.spinics.net/lists/arm-kernel/msg366948.html > b) "dts, kbuild: Implement support for dtb vendor subdirs" patchset - rebased >http://comments.gmane.org/gmane.linux.kbuild.devel/12131 > c) "arch: arm64: enable support for Samsung Exynos7 SoC" patchset (v5) - > rebased >http://www.spinics.net/lists/arm-kernel/msg364014.html > > [1] https://lkml.org/lkml/2014/10/2/476 > > Abhilash Kesavan (3): > pinctrl: exynos: Generalize the eint16_31 demux code > pinctrl: exynos: Consolidate irq domain callbacks > pinctrl: exynos: Add irq_chip instance for Exynos7 wakeup interrupts > > Naveen Krishna Ch (3): > pinctrl: exynos: Add initial driver data for Exynos7 > arm64: dts: Add initial pinctrl support to EXYNOS7 > arm64: exynos: Enable pinctrl support for Exynos7 > > .../bindings/pinctrl/samsung-pinctrl.txt |3 + > arch/arm64/Kconfig |2 + > arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi| 560 > > arch/arm64/boot/dts/exynos/exynos7.dtsi| 66 +++ > drivers/pinctrl/samsung/pinctrl-exynos.c | 188 +-- > drivers/pinctrl/samsung/pinctrl-exynos.h |3 + > drivers/pinctrl/samsung/pinctrl-samsung.c |2 + > drivers/pinctrl/samsung/pinctrl-samsung.h |3 + > 8 files changed, 791 insertions(+), 36 deletions(-) > create mode 100644 arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi > No further comments from me. Thanks Abhilash for addressing all of them. Linus, feel free to apply this series with my ACK (which seems to be already present in all patches). Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/5] pinctrl: samsung: Data structure clean-up
On 08.10.2014 12:23, Linus Walleij wrote: > On Thu, Oct 2, 2014 at 8:52 PM, Tomasz Figa wrote: > >> This series intends to clean up data structures used by pinctrl-samsung >> driver. >> More specifically, it separates initial compile time constants from data used >> at runtime, allowing unused variant data to be dropped and selected >> structures >> constified to improve safety. > > Thanks! > > The patches missed the v3.18 merge window, but I have queued them up as > the first thing to go into v3.19. OK, thanks. > > Now I need you to help me check the patch set from Abhilash so I know > what to do about that, whenever you have some time... I've already acked previous version of that series, only with some minor nitpicks pointed, but let me take a look at last version. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/4] drm/exynos: enable vblank after DPMS on
On Fri, Oct 10, 2014 at 02:31:55PM +0200, Andrzej Hajda wrote: > Before DPMS off driver disables vblank. > It should be balanced by vblank enable after DPMS on. > The patch fixes issue with page_flip ioctl not being able > to acquire vblank counter introduced by patch: > drm: Always reject drm_vblank_get() after drm_vblank_off() > > Signed-off-by: Andrzej Hajda Yeah, you should always call vblank_on again when you (re)enable a crtc, whether this is through a set_config call or through dpms. This is Reviewed-by: Daniel Vetter Sorry that we didn't catch the impact of this additional check on existing drivers, I've thought I've reviewed them and checked that they all call vblank_on. But I didn't take into account that the codepaths might differ for dpms and set_config paths. Otoh most drivers really should implement one in terms of the other. Cheers, Daniel > --- > drivers/gpu/drm/exynos/exynos_drm_crtc.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c > b/drivers/gpu/drm/exynos/exynos_drm_crtc.c > index 8e38e9f..45026e6 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_crtc.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_crtc.c > @@ -71,13 +71,16 @@ static void exynos_drm_crtc_dpms(struct drm_crtc *crtc, > int mode) > !atomic_read(&exynos_crtc->pending_flip), > HZ/20)) > atomic_set(&exynos_crtc->pending_flip, 0); > - drm_vblank_off(crtc->dev, exynos_crtc->pipe); > + drm_crtc_vblank_off(crtc); > } > > if (manager->ops->dpms) > manager->ops->dpms(manager, mode); > > exynos_crtc->dpms = mode; > + > + if (mode == DRM_MODE_DPMS_ON) > + drm_crtc_vblank_on(crtc); > } > > static void exynos_drm_crtc_prepare(struct drm_crtc *crtc) > -- > 1.9.1 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
