Re: [PATCH v3 18/19] iommu: exynos: init from dt-specific callback instead of initcall
Hi Marek,
Thank you for the patch.
On Wednesday 19 November 2014 12:15:47 Marek Szyprowski wrote:
This patch introduces IOMMU_OF_DECLARE-based initialization to the
driver, which replaces subsys_initcall-based procedure.
exynos_iommu_of_setup ensures that each sysmmu controller is probed
before its master device.
Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com
---
drivers/iommu/exynos-iommu.c | 28 +++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
index cd28dc09db39..88f9afe641a0 100644
--- a/drivers/iommu/exynos-iommu.c
+++ b/drivers/iommu/exynos-iommu.c
[snip]
@@ -1125,4 +1134,21 @@ err_reg_driver:
kmem_cache_destroy(lv2table_kmem_cache);
return ret;
}
-subsys_initcall(exynos_iommu_init);
+
+static int __init exynos_iommu_of_setup(struct device_node *np)
+{
+ struct platform_device *pdev;
+
+ if (!init_done)
+ exynos_iommu_init();
+
+ pdev = of_platform_device_create(np, NULL, platform_bus_type.dev_root);
+ if (IS_ERR(pdev))
+ return PTR_ERR(pdev);
If we end up having to create the IOMMU platform devices from within the
drivers, the introduction of IOMMU_OF_DECLARE starts to feel like a workaround
to me. I wonder whether it wouldn't then be better to let the driver core
instantiate the IOMMU platform device from DT as for all other devices, and
use device notifiers to defer probe of the bus masters until the required
IOMMU(s) are registered.
Will, what's your opinion on that ?
+
+ of_iommu_set_ops(np, exynos_iommu_ops);
+ return 0;
+}
+
+IOMMU_OF_DECLARE(exynos_iommu_of, samsung,exynos-sysmmu,
+ exynos_iommu_of_setup);
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v3 0/2] serial: samsung: add support for early console
Hi, I found this patchset was not merget even 3.19 merge window. As you know, there is no support of legacy early_printk on arm64. I need this patchset to support exynos arm64 board properly. Dear Kukjin, Could you pick up this patchset in your tree? Best Regards, Chanho Park -Original Message- From: linux-arm-kernel [mailto:linux-arm-kernel- boun...@lists.infradead.org] On Behalf Of Marek Szyprowski Sent: Monday, October 20, 2014 8:28 PM To: linux-samsung-soc@vger.kernel.org; linux-arm- ker...@lists.infradead.org Cc: Tomasz Figa; Kyungmin Park; thomas...@samsung.com; Alim Akhtar; Marek Szyprowski Subject: [PATCH v3 0/2] serial: samsung: add support for early console This patchset adds support for early console defined in device tree. As an example, DTS files for all Exynos4 based machines are updated with the correct value for common chosen/sdtout property. To get it fully functional on ARM architecture, additional improvements (support for early_ioremap) are needed in early console code. Best regards Marek Szyprowski Samsung RD Institute Poland Change log: v3: - rebased onto v3.18-rc1 - removed options from documentation (they are not yet supported) v2: http://www.spinics.net/lists/linux-samsung-soc/msg37278.html - added support for command line based initialization v1: http://www.spinics.net/lists/linux-samsung-soc/msg37094.html - initial version Tomasz Figa (2): serial: samsung: Add support for early console ARM: dts: exynos4: Add stdout-path properties Documentation/kernel-parameters.txt | 12 +++ arch/arm/boot/dts/exynos4210-origen.dts | 1 + arch/arm/boot/dts/exynos4210-smdkv310.dts | 1 + arch/arm/boot/dts/exynos4210-trats.dts | 1 + arch/arm/boot/dts/exynos4210-universal_c210.dts | 1 + arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 4 + arch/arm/boot/dts/exynos4412-origen.dts | 1 + arch/arm/boot/dts/exynos4412-smdk4412.dts | 1 + arch/arm/boot/dts/exynos4412-tiny4412.dts | 4 + arch/arm/boot/dts/exynos4412-trats2.dts | 1 + drivers/tty/serial/Kconfig | 1 + drivers/tty/serial/samsung.c| 103 12 files changed, 131 insertions(+) -- 1.9.2 ___ linux-arm-kernel mailing list linux-arm-ker...@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
