Re: [PATCH 1/3] thermal: exynos: Fix NULL pointer exception during kernel booting

2015-02-16 Thread Chanwoo Choi
Hi Lukasz, On Tue, Feb 17, 2015 at 12:06 AM, Lukasz Majewski l.majew...@samsung.com wrote: Hi Chanwoo, This patch fixes the NULL pointer exception during kernel booting. The thermal_zone _of_sensor_register() registers a sensor to DT thermal zone and then read the current temperature by

Re: [PATCH 1/3] thermal: exynos: Fix NULL pointer exception during kernel booting

2015-02-16 Thread Chanwoo Choi
Hi Lukasz, On Tue, Feb 17, 2015 at 1:28 AM, Lukasz Majewski l.majew...@samsung.com wrote: Hi Chanwoo, Hi Lukasz, On Tue, Feb 17, 2015 at 12:06 AM, Lukasz Majewski l.majew...@samsung.com wrote: Hi Chanwoo, This patch fixes the NULL pointer exception during kernel booting. The

Re: [PATCH 1/3] thermal: exynos: Fix NULL pointer exception during kernel booting

2015-02-16 Thread Lukasz Majewski
Hi Chanwoo, Hi Lukasz, On Tue, Feb 17, 2015 at 12:06 AM, Lukasz Majewski l.majew...@samsung.com wrote: Hi Chanwoo, This patch fixes the NULL pointer exception during kernel booting. The thermal_zone _of_sensor_register() registers a sensor to DT thermal zone and then read the

[PATCH 07/45] exynos_drm.h: include stdint.h in userspace

2015-02-16 Thread Mikko Rapeli
Fixes compilation errors like: drm/exynos_drm.h:30:2: error: unknown type name ‘uint64_t’ Signed-off-by: Mikko Rapeli mikko.rap...@iki.fi --- include/uapi/drm/exynos_drm.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/uapi/drm/exynos_drm.h b/include/uapi/drm/exynos_drm.h

[PATCH 0/3] thermal: exynos: Fix NULL pointer error and bug of PD_DET_EN of Exynos7

2015-02-16 Thread Chanwoo Choi
This patch-set fix NULL pointer error during kernel booting and the bug of PD_DET_EN bit field of Exynos7 TMU. And the clean-up the exynos compatible table by making oneline entry. Chanwoo Choi (3): thermal: exynos: Fix NULL pointer exception during kernel booting thermal: exynos: Fix wrong

[PATCH 1/3] thermal: exynos: Fix NULL pointer exception during kernel booting

2015-02-16 Thread Chanwoo Choi
This patch fixes the NULL pointer exception during kernel booting. The thermal_zone _of_sensor_register() registers a sensor to DT thermal zone and then read the current temperature by '.get_temp' callback. The callback function of exynos thermal driver is exynos_get_temp() which must need the

[PATCH 2/3] thermal: exynos: Fix wrong control of power down detection mode for Exynos7

2015-02-16 Thread Chanwoo Choi
This patch fixes the wrong control of PD_DET_EN (power down detection mode) for Exynos7 because exynos7_tmu_control() always enables the power down detection mode regardless 'on' parameter. Cc: Zhang Rui rui.zh...@intel.com Cc: Eduardo Valentin edubez...@gmail.com Signed-off-by: Chanwoo Choi

[PATCH 3/3] thermal: exynos: Clean-up code to use oneline entry for exynos compatible table

2015-02-16 Thread Chanwoo Choi
This patch cleanup the code to use oneline for entry of exynos compatible table. Cc: Zhang Rui rui.zh...@intel.com Cc: Eduardo Valentin edubez...@gmail.com Signed-off-by: Chanwoo Choi cw00.c...@samsung.com --- drivers/thermal/samsung/exynos_tmu.c | 38 ++-- 1 file

[PATCH v2 14/15] exynos: fimg2d: unify register style

2015-02-16 Thread Tobias Jakobi
Register defines all use uppercase hex codes. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/fimg2d_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exynos/fimg2d_reg.h b/exynos/fimg2d_reg.h index 5782488..07dd634 100644 --- a/exynos/fimg2d_reg.h

[PATCH v2 15/15] exynos: fimg2d: introduce G2D_OP_INTERPOLATE

2015-02-16 Thread Tobias Jakobi
This sets up the blending equation in the following way: out = src * src_alpha + dst * (1 - src_alpha) Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.c | 4 exynos/exynos_fimg2d.h | 1 + 2 files changed, 5 insertions(+) diff --git

[PATCH] ARM: EXYNOS: Don't use LDREX and STREX after disabling cache coherency

2015-02-16 Thread Krzysztof Kozlowski
During CPU shutdown the exynos_cpu_power_down() is called after disabling cache coherency and it uses LDREX and STREX instructions (by calling of_machine_is_compatible() - kobject_get() - kref_get()). The LDREX and STREX should not be used after disabling the cache coherency so just use

[PATCH v2 05/15] exynos: add g2d_scale_and_blend

2015-02-16 Thread Tobias Jakobi
This is a combination of g2d_copy_with_scale and g2d_scale. It is a pretty common operation to scale one buffer and then blend it on top of another, so provide a direct way to that operation. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.c | 129

[PATCH v2 06/15] tests/exynos: introduce wait_for_user_input

2015-02-16 Thread Tobias Jakobi
Currently getchar() is used to pause execution after each test. The user isn't informed if one is supposed to do anything for the tests to continue, so print a simple message to make this more clear. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- tests/exynos/exynos_fimg2d_test.c

[PATCH v2 11/15] exynos: add exynos prefix to fimg2d header

2015-02-16 Thread Tobias Jakobi
Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/Makefile.am| 2 +- exynos/exynos_fimg2d.c| 2 +- exynos/exynos_fimg2d.h| 328 ++ exynos/fimg2d.h | 328

[PATCH v2 10/15] tests/exynos: improve error handling

2015-02-16 Thread Tobias Jakobi
Check for a useable connector and also if the resolution is sane (width and height are both non-zero). Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- tests/exynos/exynos_fimg2d_test.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git

[PATCH v2 01/15] tests/exynos: fimg2d: add a checkerboard test

2015-02-16 Thread Tobias Jakobi
This makes it easier to spot memory corruptions which don't become visible when using a plain buffer filled with a solid color (so corruptions that are just a permutation of the bytes in the buffer). Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- tests/exynos/exynos_fimg2d_test.c

[PATCH v2 08/15] exynos: introduce g2d_add_base_addr helper function

2015-02-16 Thread Tobias Jakobi
In almost all functions the base address register is written, so it makes sense to have a helper function for this. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.c | 87 +++--- 1 file changed, 33 insertions(+), 54

[PATCH v2 04/15] tests/exynos: disable the G2D userptr/blend test

2015-02-16 Thread Tobias Jakobi
v2: Move the commit description into the patch itself. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- tests/exynos/exynos_fimg2d_test.c | 8 1 file changed, 8 insertions(+) diff --git a/tests/exynos/exynos_fimg2d_test.c b/tests/exynos/exynos_fimg2d_test.c index

[PATCH v2 03/15] tests/exynos: fix typos and change wording

2015-02-16 Thread Tobias Jakobi
No functional changes. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.c| 8 tests/exynos/exynos_fimg2d_test.c | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/exynos/exynos_fimg2d.c b/exynos/exynos_fimg2d.c index

[PATCH v2 07/15] exynos: honor the repeat mode in g2d_copy_with_scale

2015-02-16 Thread Tobias Jakobi
This is useful when the default repeat mode, which is 'repeat' produces artifacts at the borders of the copied image. Choose the 'pad' mode to make use of the color of the destination image. In my usage case the destination is the framebuffer, which is solid filled with a background color.

[v2] libdrm: improvements to userspace exynos component

2015-02-16 Thread Tobias Jakobi
Hello, here are some miscellaneous improvements (small features, bugfixes, spelling fixes, etc.) for the exynos component of libdrm. The general idea is to let userspace use the G2D engine functionality more efficiently. If someone is interested in an application that actually makes use of

[PATCH v2 13/15] exynos: fimg2d: fix comment for G2D_COEFF_MODE_GB_COLOR

2015-02-16 Thread Tobias Jakobi
The coefficient mode enables use of global color, not alpha. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exynos/exynos_fimg2d.h b/exynos/exynos_fimg2d.h index bd116cf..78cff47 100644 ---

[PATCH v2 02/15] exynos: replace G2D_DOUBLE_TO_FIXED macro with function

2015-02-16 Thread Tobias Jakobi
This also avoids the floating point conversion steps and just uses pure integer arithmetic. Since the G2D hardware scaling approach is a bit unintuitive, document it in the function as well. v2: Explicitly mention the normalization constant. Signed-off-by: Tobias Jakobi

[PATCH v2 09/15] exynos: use structure initialization instead of memset

2015-02-16 Thread Tobias Jakobi
Keeps the code cleaner, since the structs have to be initialized once anyway. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.c| 4 +--- tests/exynos/exynos_fimg2d_test.c | 15 --- 2 files changed, 5 insertions(+), 14 deletions(-)

[PATCH v2 12/15] exynos: add fimg2d header to common includes

2015-02-16 Thread Tobias Jakobi
The reason for this change is to let userspace use the header. Currently 'make install' does not install it. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/Makefile.am | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/exynos/Makefile.am

Re: [PATCH 1/3] thermal: exynos: Fix NULL pointer exception during kernel booting

2015-02-16 Thread Lukasz Majewski
Hi Chanwoo, This patch fixes the NULL pointer exception during kernel booting. The thermal_zone _of_sensor_register() registers a sensor to DT thermal zone and then read the current temperature by '.get_temp' callback. The callback function of exynos thermal driver is exynos_get_temp() which

Re: [PATCH 3/3] thermal: exynos: Clean-up code to use oneline entry for exynos compatible table

2015-02-16 Thread Lukasz Majewski
Hi Chanwoo, This patch cleanup the code to use oneline for entry of exynos compatible table. Cc: Zhang Rui rui.zh...@intel.com Cc: Eduardo Valentin edubez...@gmail.com Signed-off-by: Chanwoo Choi cw00.c...@samsung.com --- drivers/thermal/samsung/exynos_tmu.c | 38

Re: [PATCH v5 0/7] platform/chrome: Add user-space dev inferface support

2015-02-16 Thread Javier Martinez Canillas
Hello Olof, On 02/02/2015 12:26 PM, Javier Martinez Canillas wrote: Hello, The mainline ChromeOS Embedded Controller (EC) driver is still missing some features that are present in the downstream ChromiumOS tree. These are: - Low Pin Count (LPC) interface - User-space device interface

Re: [PATCH v12 0/6] cpufreq: use generic cpufreq drivers for exynos platforms

2015-02-16 Thread Lukasz Majewski
Hi Krzysztof, Thomas, 2015-01-08 22:17 GMT+01:00 Kevin Hilman khil...@kernel.org: On Fri, Nov 21, 2014 at 5:31 AM, Thomas Abraham thomas...@samsung.com wrote: Changes since v11: - Rebased on top of git://linuxtv.org/snawrocki/samsung.git for-v3.19-exynos-clk This patch series

Re: [PATCH] thermal: exynos: fix: Check if data-tmu_read callback is present before read

2015-02-16 Thread Lukasz Majewski
Hi Eduardo, The exynos_tmu_data() function should on entrance test not only for valid data pointer, but also for data-tmu_read one. It is important, since afterwards it is dereferenced to get temperature code. Signed-off-by: Lukasz Majewski l.majew...@samsung.com ---

Re: [PATCH 2/3] exynos: config: Enable thermal emulation for Exynos TMU (exynos_defconfig)

2015-02-16 Thread Lukasz Majewski
Hi Kukjin, On Wed, Jan 28, 2015 at 04:28:39PM +0100, Lukasz Majewski wrote: Enabling thermal emulation on Exynos SoCs. New sysfs attribute - emul_temp is created. Signed-off-by: Lukasz Majewski l.majew...@samsung.com I dont see problems with this patch: Acked-by: Eduardo Valentin

Re: [PATCH 1/3] exynos: config: Remove CONFIG_EXYNOS_THERMAL_CORE define (exynos_defconfig)

2015-02-16 Thread Lukasz Majewski
Hi Kukjin, On Wed, Jan 28, 2015 at 04:28:38PM +0100, Lukasz Majewski wrote: After Exynos TMU rework to use device tree for configuration this flag can be removed. It is not used anymore. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Acked-by: Eduardo Valentin

Re: [PATCH 3/3] exynos: config: Enable support for cpufreq on Exynos SoCs (exynos_defconfig)

2015-02-16 Thread Lukasz Majewski
Hi Kukjin, On Wed, Jan 28, 2015 at 04:28:40PM +0100, Lukasz Majewski wrote: This commit enables the cpufreq subsystem. Moreover, support for using CPU as a cooling device is provided. Signed-off-by: Lukasz Majewski l.majew...@samsung.com I dont see problems with this patch: