Re: [PATCH 3/8] clk: Constify pointers to parent names in init data

2015-04-08 Thread Stephen Boyd
On 04/08/15 06:22, Krzysztof Kozlowski wrote: > The 'parent_names' member of 'clk_init_data' is not modified so it can > be made as an array of const pointers to constant strings. > > Some drivers (e.g. arch/mips/alchemy/common/clock.c) already pass such > data. > > Signed-off-by: Krzysztof Kozlows

Re: [PATCH 6/6] hwmon: pwm-fan: Update the duty cycle inorder to control the pwm-fan

2015-04-08 Thread Anand Moon
Hi Guenter, Sorry my blunder mistake. Sorry for the noise. I just tested with spiking this patch and my observation and testing were wrong we can skip this patch. I will send an v2 patch series removing the patch 5 and patch 6. With correct dts changes. Thanks for pointing my mistake. -Anand

Re: [PATCH 6/6] hwmon: pwm-fan: Update the duty cycle inorder to control the pwm-fan

2015-04-08 Thread Guenter Roeck
On Wed, Apr 08, 2015 at 09:32:05PM +0530, Anand Moon wrote: > Hi Guenter, > > Initially the board bootup the cooling level state is 0. > So update the duty cycle and this power off the fan. > As their is no state change the fan will not spin. > > Once the temperature sensor is reached to alert te

Re: [PATCH 6/6] hwmon: pwm-fan: Update the duty cycle inorder to control the pwm-fan

2015-04-08 Thread Anand Moon
Hi Guenter, Initially the board bootup the cooling level state is 0. So update the duty cycle and this power off the fan. As their is no state change the fan will not spin. Once the temperature sensor is reached to alert temperature it changes state. With the state change the fan cools the CPU an

Re: [PATCH 6/6] hwmon: pwm-fan: Update the duty cycle inorder to control the pwm-fan

2015-04-08 Thread Guenter Roeck
On Wed, Apr 08, 2015 at 10:44:15AM +0200, Lukasz Majewski wrote: > Hi Anand, > > > Below changes depend on following patch. > > https://patchwork.kernel.org/patch/5944061/ > > > > Update the pwm_config with duty then update the pwm_disable > > to poweroff the cpu fan. > > Unfortunately, the pat

Re: [PATCH -v3 00/11] drm/exynos: Add atomic modesetting support

2015-04-08 Thread Inki Dae
On 2015년 04월 08일 03:39, Gustavo Padovan wrote: > Hi Inki, > > 2015-04-07 Inki Dae : > >> On 2015년 04월 07일 00:44, Inki Dae wrote: >>> 2015-04-06 19:46 GMT+09:00 Inki Dae : On 2015년 04월 04일 03:09, Gustavo Padovan wrote: > From: Gustavo Padovan > > Hi, > > Here goes the ful

[PATCH 2/8] clk: exynos: Staticize file-scope declarations

2015-04-08 Thread Krzysztof Kozlowski
Add missing static to local (file-scope only) symbols. Signed-off-by: Krzysztof Kozlowski --- drivers/clk/samsung/clk-exynos5260.c | 74 ++-- drivers/clk/samsung/clk-exynos5420.c | 10 ++--- 2 files changed, 42 insertions(+), 42 deletions(-) diff --git a/drivers/

[PATCH 1/8] clk: rockchip: Staticize file-scope declarations

2015-04-08 Thread Krzysztof Kozlowski
Add missing static to local (file-scope only) symbols. Signed-off-by: Krzysztof Kozlowski --- drivers/clk/rockchip/clk-rk3188.c | 2 +- drivers/clk/rockchip/clk-rk3288.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/rockchip/clk-rk3188.c b/drivers/clk/rockch

[PATCH 6/8] clk: sirf: Constify parent names in clock init data

2015-04-08 Thread Krzysztof Kozlowski
The array of parent names can be made as array of const pointers to const strings. Signed-off-by: Krzysztof Kozlowski --- drivers/clk/sirf/clk-common.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/clk/sirf/clk-common.c b/drivers/clk/sirf/clk-common.c i

[PATCH 4/8] clk: tegra: Fix duplicate const for parent names

2015-04-08 Thread Krzysztof Kozlowski
Replace duplicated const keyword for 'emc_parent_clk_names' with proper array of const pointers to const strings. Signed-off-by: Krzysztof Kozlowski --- drivers/clk/tegra/clk-emc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/tegra/clk-emc.c b/drivers/clk/tegra

[PATCH 5/8] clk: cdce706: Constify parent names in clock init data

2015-04-08 Thread Krzysztof Kozlowski
The array of parent names can be made as array of const pointers to const strings. Signed-off-by: Krzysztof Kozlowski --- drivers/clk/clk-cdce706.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-cdce706.c b/drivers/clk/clk-cdce706.c index b8e4f8a822e9..8a

[PATCH 7/8] clk: ls1x: Fix duplicate const for parent names

2015-04-08 Thread Krzysztof Kozlowski
Replace duplicated const keyword with proper array of const pointers to const strings. Signed-off-by: Krzysztof Kozlowski --- drivers/clk/clk-ls1x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/clk-ls1x.c b/drivers/clk/clk-ls1x.c index ca80103ac188..d4c61

[PATCH 8/8] MIPS: Alchemy: Remove unneeded cast removing const

2015-04-08 Thread Krzysztof Kozlowski
Parent names in clock init data is now array of const pointers to const strings so the cast is not needed. Signed-off-by: Krzysztof Kozlowski --- arch/mips/alchemy/common/clock.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/mips/alchemy/common/clock.c b/arch/mip

[PATCH 0/8] clk: Minor cleanups

2015-04-08 Thread Krzysztof Kozlowski
Hi, Small cleanups for different clock drivers. The first two patches are independent. Rest of the patches (these related to constifying parent names) depend on the third patch: "clk: Constify pointers to parent names in init data". Tested on Arndale Octa (Exynos5420) and Trats2 (Exynos4412).

[PATCH 3/8] clk: Constify pointers to parent names in init data

2015-04-08 Thread Krzysztof Kozlowski
The 'parent_names' member of 'clk_init_data' is not modified so it can be made as an array of const pointers to constant strings. Some drivers (e.g. arch/mips/alchemy/common/clock.c) already pass such data. Signed-off-by: Krzysztof Kozlowski --- drivers/clk/clk-composite.c | 2 +- drivers/clk

Re: [PATCH 6/6] hwmon: pwm-fan: Update the duty cycle inorder to control the pwm-fan

2015-04-08 Thread Guenter Roeck
On 04/08/2015 01:44 AM, Lukasz Majewski wrote: Hi Anand, Below changes depend on following patch. https://patchwork.kernel.org/patch/5944061/ Update the pwm_config with duty then update the pwm_disable to poweroff the cpu fan. Tested on OdroidXU3 board. Signed-off-by: Anand Moon --- drive

Re: [PATCH 3/6] ARM:dts exynos5422 Update the thermal sensor for tmu_cpu0

2015-04-08 Thread Anand Moon
Hi Lukasz, I have Odroidxu3 board with fan. Odroid xu3 board and run on high temperature. As per my understating as the sensors temperature cross the first alert it triggers fan to run. I was doing some stress testing to trigger this overheating with my changes. -Anand Moon On 8 April 2015 at 1

Re: [PATCH 3/6] ARM:dts exynos5422 Update the thermal sensor for tmu_cpu0

2015-04-08 Thread Lukasz Majewski
Hi Anand, > Hi Lukasz, > > On Odroidxu3 board critical temp is 85.0 C. Below is the sensors > output. Do you have XU3 with a fan? > > therm_zone0-virtual-0 > Adapter: Virtual device > temp1: +39.0▒ၰC (crit = +85.0▒°C) > temp2: +38.0▒°C (crit = +85.0▒°C) > temp3: +40.0▒°C (crit = +85.0▒°C) > te

Re: [PATCH 1/1] clk: exynos5420: Restore GATE_BUS_TOP on suspend

2015-04-08 Thread Javier Martinez Canillas
Hello Sylwester, On 04/08/2015 11:06 AM, Sylwester Nawrocki wrote: >> >> diff --git a/drivers/clk/samsung/clk-exynos5420.c >> b/drivers/clk/samsung/clk-exynos5420.c >> index 07d666cc6a29..bea4a173eef5 100644 >> --- a/drivers/clk/samsung/clk-exynos5420.c >> +++ b/drivers/clk/samsung/clk-exynos542

Re: [PATCH 3/6] ARM:dts exynos5422 Update the thermal sensor for tmu_cpu0

2015-04-08 Thread Anand Moon
Hi Lukasz, On Odroidxu3 board critical temp is 85.0 C. Below is the sensors output. therm_zone0-virtual-0 Adapter: Virtual device temp1: +39.0▒ၰC (crit = +85.0▒°C) temp2: +38.0▒°C (crit = +85.0▒°C) temp3: +40.0▒°C (crit = +85.0▒°C) temp4: +49.0▒°C (crit = +85.0▒°C) temp5: +29.0▒°C (crit = +85.0▒°

Re: [PATCH 1/1] clk: exynos5420: Restore GATE_BUS_TOP on suspend

2015-04-08 Thread Sylwester Nawrocki
Hello, On 08/04/15 07:34, Javier Martinez Canillas wrote: > Commit ae43b3289186 ("ARM: 8202/1: dmaengine: pl330: Add runtime Power > Management support v12") added pm support for the pl330 dma driver but > it makes the clock for the Exynos5420 MDMA0 DMA controller to be gated > during suspend and

Re: [PATCH 5/6] pwm: samsung: Fix output race on disabling

2015-04-08 Thread Anand Moon
Hi Sjoerd, Correct. Will do so. I just included in this series. As it relevant to my changes and testing. -Anand Moon On 8 April 2015 at 14:12, Sjoerd Simons wrote: > > > On Wed, 2015-04-08 at 10:28 +0200, Lukasz Majewski wrote: >> Hi Anand, >> >> > From: Sjoerd Simons >> > When disabling the

Re: [PATCH 6/6] hwmon: pwm-fan: Update the duty cycle inorder to control the pwm-fan

2015-04-08 Thread Lukasz Majewski
Hi Anand, > Below changes depend on following patch. > https://patchwork.kernel.org/patch/5944061/ > > Update the pwm_config with duty then update the pwm_disable > to poweroff the cpu fan. > > Tested on OdroidXU3 board. > > Signed-off-by: Anand Moon > --- > drivers/hwmon/pwm-fan.c | 10 -

Re: [PATCH 5/6] pwm: samsung: Fix output race on disabling

2015-04-08 Thread Sjoerd Simons
On Wed, 2015-04-08 at 10:28 +0200, Lukasz Majewski wrote: > Hi Anand, > > > From: Sjoerd Simons > > When disabling the samsung PWM the output state remains at the level > > it was in the end of a pwm cycle. In other words, calling pwm_disable > > when at 100% duty will keep the output active, w

Re: [PATCH 5/6] pwm: samsung: Fix output race on disabling

2015-04-08 Thread Lukasz Majewski
Hi Anand, > From: Sjoerd Simons > > When disabling the samsung PWM the output state remains at the level > it was in the end of a pwm cycle. In other words, calling pwm_disable > when at 100% duty will keep the output active, while at all other > setting the output will go/stay inactive. On top

Re: [PATCH 4/6] ARM: dts: OdroidXU3: Enable TMU at Exynos5422 base.

2015-04-08 Thread Lukasz Majewski
Hi Anand, > This commit enables TMU IP block on the Exynos5422 OdroidXU3 > device. > > Tested on OdroidXU3 board. > > Signed-off-by: Anand Moon > --- > arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25 > + 1 file changed, 25 insertions(+) > > diff --git a/arch/arm/boot/d

Re: [PATCH 3/6] ARM:dts exynos5422 Update the thermal sensor for tmu_cpu0

2015-04-08 Thread Lukasz Majewski
Hi Anand, > Move the registration of thermal sensors for tmu_cpu0 from > exynos5420.dtsi to exynos5-cpu-thermal.dtsi, to avoid duplicate > registration of the sensors. > > Tested on OdroidXU3 board. > > Signed-off-by: Anand Moon > --- > arch/arm/boot/dts/exynos5-cpu-thermal.dtsi | 58 > +++

Re: [PATCH 2/6] ARM: dts exynos5420 update the cooling cells for core cpu0

2015-04-08 Thread Lukasz Majewski
Hi Anand, > update the cooling level for cpu0 to avoid following message. > > root@odroidxu3:~# dmesg | grep ther > [0.241511] /thermal-zones/cpu-thermal/cooling-maps/map0: >could not get #cooling-cells for /cpus/cpu@0 > > Signed-off-by: Anand Moon > --- > arch/arm/

Re: [PATCH 1/6] ARM: dts :exynos5422-odroidxu3 Add pwm-fan node to the Odroid-XU3 board.

2015-04-08 Thread Lukasz Majewski
Hi Anand, > Add pwm-fan node to the OdroidXU3 board. > > Tested on OdroidXU3 board. > > Signed-off-by: Anand Moon > --- > arch/arm/boot/dts/exynos5422-odroidxu3.dts | 16 > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts > b/arch/a