Re: [PATCH] libgencec: Add userspace library for the generic CEC kernel interface
Hi Kamil, It seems that you've only incorporated the libgencec.pc suggestion. Did you change your mind about the others, found out something funny with them (if so can you let me know what) or simply forgot about them ? On 30 April 2015 at 11:25, Kamil Debski k.deb...@samsung.com wrote: Hi Emil, From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of Emil Velikov Sent: Wednesday, April 29, 2015 5:00 PM Hi Kamil, Allow me to put a few suggestions: On 29 April 2015 at 11:02, Kamil Debski k.deb...@samsung.com wrote: diff --git a/m4/.gitkeep b/m4/.gitkeep new file mode 100644 index 000..e69de29 Haven't seen any projects doing this. Curious what the benefits of keeping and empty folder might be ? When I run autoreconf -i it complained about missing m4 folder, hence I added this filler file such that the folder is created. Any suggestion on how to do this better? Ahh yes - that lovely message. It turns out that older versions of automake will even error out [1], rather than just printing out a warning. A handy workaround would be to add a .gitignore (and a second one in the top folder) list. Plus it will slim down the untracked files list and let you clearly see when git add was missed :-) Cheers Emil [1] https://bugzilla.redhat.com/show_bug.cgi?id=901333 -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RESEND PATCH 1/8] mfd: cros ec: Remove parent field
Hello Lee, On 04/29/2015 12:37 PM, Lee Jones wrote: On Thu, 23 Apr 2015, Gwendal Grignou wrote: Be consistent, use cros_ec instead of cros ec or cros-ec. What is this in reference to? I think Gwendal meant that I should be consistent in general and was not referring to this patch particular. Otherwise: Reviewed-by: Gwendal Grignou gwen...@chromium.org Tested-by: Gwendal Grignou gwen...@chromium.org On Mon, Apr 6, 2015 at 9:14 AM, Javier Martinez Canillas javier.marti...@collabora.co.uk wrote: From: Gwendal Grignou gwen...@chromium.org parent and dev were pointing to the same device structure. parent is unused, removed. Signed-off-by: Gwendal Grignou gwen...@chromium.org Reviewed-by: Stephen Barber smbar...@chromium.org Tested-by: Stephen Barber smbar...@chromium.org Reviewed-by: Puthikorn Voravootivat put...@chromium.org Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- drivers/mfd/cros_ec_i2c.c | 1 - drivers/mfd/cros_ec_spi.c | 1 - drivers/platform/chrome/cros_ec_lpc.c | 1 - include/linux/mfd/cros_ec.h | 2 -- 4 files changed, 5 deletions(-) For when you re-submit: Acked-by: Lee Jones lee.jo...@linaro.org Thanks a lot for your ack. Best regards, Javier -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] i2c: s3c2410: fix oops in suspend callback for non-dt platforms
On 05/06/15 06:28, Kukjin Kim wrote: On 05/04/15 08:50, Krzysztof Kozlowski wrote: 2015-05-04 3:13 GMT+09:00 Vasily Khoruzhick anars...@gmail.com: Initialize sysreg by default, otherwise driver will crash in suspend callback. Signed-off-by: Vasily Khoruzhick anars...@gmail.com I think the crash is possible if device node is missing in DT or pdata is supplied. If you agree, could you add this information to commit message, along with Cc-stable and Fixes tag? Anyway, the patch itself looks good: Reviewed-by: Krzysztof Kozlowski k.kozlow...@samsung.com Can you please add me in Cc in your next posting? I can't see the patch in my mail box... Oops, sorry for the noise. My email client had a problem and I can see the patch now. Please kindly ignore the request :) Thanks, Kukjin -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RESEND-v2-PATCH] ARM: dts: Add missing irq pinctrl for max77686 on smdk5250
On 05/05/15 13:39, Pankaj Dubey wrote:
From: Yadwinder Singh Brar yadi.b...@samsung.com
This patch adds pinctrl configuration for using configuring gpx3-2 as an
external interrupt from max77686. Though max77686 RTC is enabled and gets
probed by default, it doesnt work as its unable to get interrupt.
This patch makes max77686 RTC work and also configures it as wakeup source.
Signed-off-by: Yadwinder Singh Brar yadi.b...@samsung.com
[pankaj.dubey: resubmitted after rebasing to latest kgene tree]
Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com
Reviewed-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
Tested-by: Pankaj Dubey pankaj.du...@samsung.com
Acked-by: Krzysztof Kozlowski k.kozlow...@samsung.com
---
Initial version of this patch was part of following series, though
they are not dependent on each other, resubmitting after rebasing
and detaching second one from first patch in the series [1]
[1]:
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-November/303652.html
v2:
-Included my Signed-off-by for touching this patch.
-Included Acked-by from Krzysztof Kozlowski.
arch/arm/boot/dts/exynos5250-smdk5250.dts | 12
1 file changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
b/arch/arm/boot/dts/exynos5250-smdk5250.dts
index bc27cc2..4fe186d 100644
--- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
+++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
@@ -131,6 +131,9 @@
reg = 0x09;
interrupt-parent = gpx3;
interrupts = 2 IRQ_TYPE_NONE;
+ pinctrl-names = default;
+ pinctrl-0 = max77686_irq;
+ wakeup-source;
voltage-regulators {
ldo1_reg: LDO1 {
@@ -410,3 +413,12 @@
};
};
};
+
+pinctrl_0 {
+ max77686_irq: max77686-irq {
+ samsung,pins = gpx3-2;
+ samsung,pin-function = 0xf;
+ samsung,pin-pud = 0;
+ samsung,pin-drv = 0;
+ };
+};
Applied, thanks.
- Kukjin
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
