Re: [PATCH v3 1/9] drm/exynos: pass the correct pipe number

2015-07-29 Thread Inki Dae
Hi Gustavo, On 2015년 07월 30일 05:11, Gustavo Padovan wrote: > Hi Inki, > > Any comments about this series? Will review all of them. Now we are reviewing fix-up and clean-up patches. Thanks, Inki Dae > > Thanks, > > Gustavo > > 2015-07-16 Gustavo Padovan : > >> From: Gustavo Pad

Re: [PATCH] ARM: EXYNOS: pd: fix resource deallocation on error path

2015-07-29 Thread Krzysztof Kozlowski
On 30.07.2015 09:35, Vladimir Zapolskiy wrote: > On 30.07.2015 03:15, Krzysztof Kozlowski wrote: >> On 30.07.2015 09:06, Vladimir Zapolskiy wrote: >>> On 30.07.2015 02:37, Krzysztof Kozlowski wrote: 2015-07-30 5:15 GMT+09:00 Vladimir Zapolskiy : > The change fixes a bug introduced by 2be2a

Re: [PATCH] ARM: EXYNOS: pd: fix resource deallocation on error path

2015-07-29 Thread Vladimir Zapolskiy
On 30.07.2015 03:15, Krzysztof Kozlowski wrote: > On 30.07.2015 09:06, Vladimir Zapolskiy wrote: >> On 30.07.2015 02:37, Krzysztof Kozlowski wrote: >>> 2015-07-30 5:15 GMT+09:00 Vladimir Zapolskiy : The change fixes a bug introduced by 2be2a3ff42a5, memory allocated by kstrdup_const() mus

Re: [PATCH] ARM: EXYNOS: pd: fix resource deallocation on error path

2015-07-29 Thread Krzysztof Kozlowski
On 30.07.2015 09:06, Vladimir Zapolskiy wrote: > On 30.07.2015 02:37, Krzysztof Kozlowski wrote: >> 2015-07-30 5:15 GMT+09:00 Vladimir Zapolskiy : >>> The change fixes a bug introduced by 2be2a3ff42a5, memory allocated >>> by kstrdup_const() must be always deallocated with kfree_const(), >>> otherw

Re: [PATCH] ARM: EXYNOS: pd: fix resource deallocation on error path

2015-07-29 Thread Vladimir Zapolskiy
On 30.07.2015 02:37, Krzysztof Kozlowski wrote: > 2015-07-30 5:15 GMT+09:00 Vladimir Zapolskiy : >> The change fixes a bug introduced by 2be2a3ff42a5, memory allocated >> by kstrdup_const() must be always deallocated with kfree_const(), >> otherwise there is a risk of kfree'ing ro memory. > > This

Re: [PATCH] ARM: EXYNOS: pd: fix resource deallocation on error path

2015-07-29 Thread Krzysztof Kozlowski
2015-07-30 5:15 GMT+09:00 Vladimir Zapolskiy : > The change fixes a bug introduced by 2be2a3ff42a5, memory allocated > by kstrdup_const() must be always deallocated with kfree_const(), > otherwise there is a risk of kfree'ing ro memory. This looks good. Can you provide also Cc-stable and fixes tag

[PATCH] ARM: EXYNOS: pd: fix resource deallocation on error path

2015-07-29 Thread Vladimir Zapolskiy
The change fixes a bug introduced by 2be2a3ff42a5, memory allocated by kstrdup_const() must be always deallocated with kfree_const(), otherwise there is a risk of kfree'ing ro memory. Also remove unneeded of_node_put(), if for_each_compatible_node() body execution is not terminated, this prevents

Re: [PATCH v3 1/9] drm/exynos: pass the correct pipe number

2015-07-29 Thread Gustavo Padovan
Hi Inki, Any comments about this series? Thanks, Gustavo 2015-07-16 Gustavo Padovan : > From: Gustavo Padovan > > Instead of giving -1 to as arg to drm_send_vblank_event() pass the > correct pipe number to it. > > Signed-off-by: Gustavo Padovan > Reviewed-by: Joonyoung Shi

Re: [RFC PATCH 2/2] dt: spi: s3c64xx: add compatible to controller-data

2015-07-29 Thread Mark Brown
On Wed, Jul 29, 2015 at 08:21:34PM +0200, Michal Suchanek wrote: > On 29 July 2015 at 19:16, Mark Brown wrote: > >> It will not break anything. It will just spam dmesg. > > I'm confused - if all this change does is to spam dmesg then what's the > > point? > Presumably when your SPI NOR flash fa

Re: [RFC PATCH 2/2] dt: spi: s3c64xx: add compatible to controller-data

2015-07-29 Thread Michal Suchanek
On 29 July 2015 at 19:16, Mark Brown wrote: > On Wed, Jul 29, 2015 at 06:19:24PM +0200, Michal Suchanek wrote: >> On 29 July 2015 at 16:00, Mark Brown wrote: > >> > I can't tell from this commit message what the issue you're trying to >> > fix is, sorry. Nodes without compatible strings are enti

Re: [RFC PATCH 2/2] dt: spi: s3c64xx: add compatible to controller-data

2015-07-29 Thread Mark Brown
On Wed, Jul 29, 2015 at 06:19:24PM +0200, Michal Suchanek wrote: > On 29 July 2015 at 16:00, Mark Brown wrote: > > I can't tell from this commit message what the issue you're trying to > > fix is, sorry. Nodes without compatible strings are entirely normal and > > don't need compatible strings.

Re: [RFC PATCH 2/2] dt: spi: s3c64xx: add compatible to controller-data

2015-07-29 Thread Brian Norris
On Wed, Jul 29, 2015 at 06:19:24PM +0200, Michal Suchanek wrote: > On 29 July 2015 at 16:00, Mark Brown wrote: > > On Wed, Jul 29, 2015 at 12:19:57PM +0200, Michal Suchanek wrote: > > > > Please use subject lines matching the style for the subsytsem so people > > can spot that the patch is in some

Re: [RFC PATCH 2/2] dt: spi: s3c64xx: add compatible to controller-data

2015-07-29 Thread Michal Suchanek
On 29 July 2015 at 16:00, Mark Brown wrote: > On Wed, Jul 29, 2015 at 12:19:57PM +0200, Michal Suchanek wrote: > > Please use subject lines matching the style for the subsytsem so people > can spot that the patch is in some way relevant. > >> The controller-data subnode has no compatible. This can

Re: [RFC PATCH 2/2] dt: spi: s3c64xx: add compatible to controller-data

2015-07-29 Thread Mark Brown
On Wed, Jul 29, 2015 at 12:19:57PM +0200, Michal Suchanek wrote: Please use subject lines matching the style for the subsytsem so people can spot that the patch is in some way relevant. > The controller-data subnode has no compatible. This can lead to other > drivers getting confused by it. Add a