Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support

Hello Krzysztof, On 09/30/2015 02:30 AM, Krzysztof Kozlowski wrote: [snip] >> >> The DTS in the vendor ChromeOS tree are called exynos5250-snow-rev{4,5}.dtb >> but I decided to leave Rev4 as exynos5250-snow.dtb to avoid breaking u-boot >> that has CONFIG_DEFAULT_DEVICE_TREE="exynos5250-snow" in

Re: [GIT PULL] Samsung fixes for v4.3

On 09/30/15 08:59, Krzysztof Kozlowski wrote: > Dear Kukjin, > > Below you will find fixes for current release cycle which are not > present yet in your tree. > > Best regards, > Krzysztof > > > The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f: > > Linux 4.3-rc1

Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support

Hello Doug, On 09/29/2015 07:28 PM, Doug Anderson wrote: [snip] > > >> arch/arm/boot/dts/Makefile| 1 + >> arch/arm/boot/dts/exynos5250-snow-common.dtsi | 684 >> ++ >> arch/arm/boot/dts/exynos5250-snow-rev5.dts| 47 ++ >>

Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support

On 30.09.2015 16:06, Javier Martinez Canillas wrote: > Hello, > > On 09/30/2015 09:02 AM, Krzysztof Kozlowski wrote: >> On 30.09.2015 15:58, Kukjin Kim wrote: > > [snip] > Could you add the new compatible and fix patch issues pointed by Doug? >>> Documenting for the compatibles

Re: [PATCH] ARM: exynos_defconfig: Enable WiFi-Ex as a module instead built-in

Hello Krzysztof, On 09/30/2015 02:36 AM, Krzysztof Kozlowski wrote: > On 29.09.2015 21:42, Javier Martinez Canillas wrote: >> The Marvell WiFi-Ex driver tries to load a firmware on probe. So if the >> driver is built-in and probed before a firmware is available, this is >> not loaded and the chip

Re: [PATCH v5 02/17] drm: bridge: analogix/dp: split exynos dp driver to bridge directory

Hi Krzysztof, On 09/30/2015 01:17 PM, Krzysztof Kozlowski wrote: On 22.09.2015 16:29, Yakir Yang wrote: Split the dp core driver from exynos directory to bridge directory, and rename the core driver to analogix_dp_*, rename the platform code to exynos_dp. Beside the new analogix_dp driver

Re: [PATCH v5 03/17] drm: bridge: analogix/dp: fix some obvious code style

Hi Krzysztof, On 09/30/2015 01:22 PM, Krzysztof Kozlowski wrote: On 22.09.2015 16:34, Yakir Yang wrote: Fix some obvious alignment problems, like alignment and line over 80 characters problems, make this easy to be maintained later. Signed-off-by: Yakir Yang --- Changes

Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support

On 30.09.2015 15:58, Kukjin Kim wrote: > On 09/30/15 09:30, Krzysztof Kozlowski wrote: >> On 29.09.2015 20:57, Javier Martinez Canillas wrote: >>> There are 2 revisions of the Exynos5250 Snow Chromebook that were shipped: >>> Rev4 and Rev5. The only difference between these 2 revisions is the

Re: [PATCH] ARM: exynos_defconfig: Enable WiFi-Ex as a module instead built-in

On 30.09.2015 16:22, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 09/30/2015 02:36 AM, Krzysztof Kozlowski wrote: >> On 29.09.2015 21:42, Javier Martinez Canillas wrote: >>> The Marvell WiFi-Ex driver tries to load a firmware on probe. So if the >>> driver is built-in and probed

Re: [PATCH 4/4] ARM64: dts: exynos5433: add jpeg node

On 09/28/15 21:02, Krzysztof Kozlowski wrote: > W dniu 28.09.2015 o 20:54, Bartlomiej Zolnierkiewicz pisze: >> >> Hi, >> >> On Monday, September 28, 2015 05:52:13 PM Krzysztof Kozlowski wrote: >>> W dniu 21.09.2015 o 18:59, Andrzej Pietrasiewicz pisze: Hi Hans, W dniu 21.09.2015 o

[PATCH v2] ARM: dts: Add Exynos5250 Snow Rev5+ support

There are 2 revisions of the Exynos5250 Snow Chromebook that were shipped: Rev4 and Rev5. The only difference between these 2 revisions is the codec, Rev4 has a max98095 codec while Rev5 has a max98090. Mainline only supports Rev4 so this patch moves the common device nodes to a DTSI file and

Re: [PATCH 4/4] ARM64: dts: exynos5433: add jpeg node

Dear Kukjin, On 2015년 09월 30일 15:35, Kukjin Kim wrote: > On 09/28/15 21:02, Krzysztof Kozlowski wrote: >> W dniu 28.09.2015 o 20:54, Bartlomiej Zolnierkiewicz pisze: >>> >>> Hi, >>> >>> On Monday, September 28, 2015 05:52:13 PM Krzysztof Kozlowski wrote: W dniu 21.09.2015 o 18:59, Andrzej

Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support

Hello, On 09/30/2015 09:02 AM, Krzysztof Kozlowski wrote: > On 30.09.2015 15:58, Kukjin Kim wrote: [snip] >>> >>> Could you add the new compatible and fix patch issues pointed by Doug? >>> >> Documenting for the compatibles would be required even I already applied >> its updated patch... >

Re: [PATCH v5 05/17] drm: bridge: analogix/dp: dynamic parse sync_pol & interlace & dynamic_range

On 30.09.2015 16:19, Yakir Yang wrote: > Hi Krzysztof, > > On 09/30/2015 01:32 PM, Krzysztof Kozlowski wrote: >> On 22.09.2015 16:37, Yakir Yang wrote: >>> Both hsync/vsync polarity and interlace mode can be parsed from >>> drm display mode, and dynamic_range and ycbcr_coeff can be judge >>> by

Re: [PATCH v5 07/17] ARM: dts: exynos/dp: remove some properties that deprecated by analogix_dp driver

Hi Krzysztof, On 09/30/2015 01:39 PM, Krzysztof Kozlowski wrote: On 22.09.2015 16:43, Yakir Yang wrote: After exynos_dp have been split the common IP code into analogix_dp driver, the analogix_dp driver have deprecated some Samsung platform properties which could be dynamically parsed from

Re: [PATCH] ARM: exynos_defconfig: Enable WiFi-Ex as a module instead built-in

Hello Krzysztof, On 09/30/2015 09:37 AM, Krzysztof Kozlowski wrote: > On 30.09.2015 16:22, Javier Martinez Canillas wrote: >> Hello Krzysztof, >> >> On 09/30/2015 02:36 AM, Krzysztof Kozlowski wrote: >>> On 29.09.2015 21:42, Javier Martinez Canillas wrote: The Marvell WiFi-Ex driver tries to

Re: [PATCH v5 05/17] drm: bridge: analogix/dp: dynamic parse sync_pol & interlace & dynamic_range

On 30.09.2015 17:20, Yakir Yang wrote: > Hi Krzysztof, > > On 09/30/2015 03:34 PM, Krzysztof Kozlowski wrote: >> On 30.09.2015 16:19, Yakir Yang wrote: >>> Hi Krzysztof, >>> >>> On 09/30/2015 01:32 PM, Krzysztof Kozlowski wrote: On 22.09.2015 16:37, Yakir Yang wrote: > Both hsync/vsync

Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support

Hello Krzysztof, On 09/30/2015 09:08 AM, Krzysztof Kozlowski wrote: > On 30.09.2015 16:06, Javier Martinez Canillas wrote: >> Hello, >> >> On 09/30/2015 09:02 AM, Krzysztof Kozlowski wrote: >>> On 30.09.2015 15:58, Kukjin Kim wrote: >> >> [snip] >> > > Could you add the new compatible and

Re: [PATCH v5 05/17] drm: bridge: analogix/dp: dynamic parse sync_pol & interlace & dynamic_range

Hi Krzysztof, On 09/30/2015 04:26 PM, Krzysztof Kozlowski wrote: On 30.09.2015 17:20, Yakir Yang wrote: Hi Krzysztof, On 09/30/2015 03:34 PM, Krzysztof Kozlowski wrote: On 30.09.2015 16:19, Yakir Yang wrote: Hi Krzysztof, On 09/30/2015 01:32 PM, Krzysztof Kozlowski wrote: On 22.09.2015

Re: [PATCH] drm/exynos: Avoid NULL pointer dereference in resume if bind failed

Hi, On 2015년 09월 28일 01:11, Charles Keepax wrote: > If binding failed calling exynos_dp_enable in exynos_dp_resume will > result in several NULL pointer dereferences. It is much better to > simply skip suspend/resume handling if bind has failed, do so by > checking if a drm_dev exists. Thanks

[PATCH] drm/exynos: dp: remove suspend/resume functions

This patch removes unnecessary pm suspend/resume functions. All kms sub drivers will be controlled by top of Exynos drm driver and connector dpms so these sub drivers shouldn't have their own pm interfaces. Signed-off-by: Inki Dae ---

Re: [PATCH] drm/exynos: dp: remove suspend/resume functions

Hi Inki, On 30 September 2015 at 12:21, Inki Dae wrote: > This patch removes unnecessary pm suspend/resume functions. > > All kms sub drivers will be controlled by top of Exynos drm driver > and connector dpms so these sub drivers shouldn't have their own > pm interfaces. >

Re: [PATCH RESENDv2] mach:-s3c64xx:Output trace information with WARN_ON if calls for setting up gpio board configuration fail in s3c64xx_i2s_cfg_gpio

On 30.09.2015 11:07, Nicholas Krause wrote: > This fixes the function s3c64xx_i2c_cfg_gpio to log output to the > kernel log buff with WARN_ON if any of the calls to either > s3c_gpio_cfgpin_range or s3c_gpio_cfgpin fail as we cannot exit > from s3c64xx_i2s_cfg_gpio if any of these calls fail

Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support

Hi, On Wed, Sep 30, 2015 at 4:44 PM, Krzysztof Kozlowski wrote: >> Switching the default meaning of "google,snow" to Rev5 is probably not >> something we'd ever want to do, since it could confuse "rev3" boards >> (which should be serviced by the rev4 dts). From comments

Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support

On 01.10.2015 01:17, Doug Anderson wrote: > Hi, > > On Tue, Sep 29, 2015 at 5:30 PM, Krzysztof Kozlowski > wrote: >> Now the exynos5250-snow.dts means in fact Rev4... but there is no >> information in DTS about it. I think adding compatible >> "google,snow-rev4" makes

[PATCH] drm/exynos: fimd: actually disable dp clock

From: Gustavo Padovan fimd_dp_clock_enable() was setting the always to enabled, this patch fix this to actually use the value that is set to 'val'. Reported-by: Emilio López Signed-off-by: Gustavo Padovan

[RESEND] drm/exynos: Staticize local function in exynos_drm_gem.c

The exynos_drm_gem_mmap_buffer() is not used outside so make it static. Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/exynos/exynos_drm_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c

Re: [PATCH] drm/exynos: dp: remove suspend/resume functions

Hi Inki, 2015-09-30 Inki Dae : > This patch removes unnecessary pm suspend/resume functions. > > All kms sub drivers will be controlled by top of Exynos drm driver > and connector dpms so these sub drivers shouldn't have their own > pm interfaces. > > Signed-off-by: Inki

Re: [PATCH 04/16] drm/exynos/hdmi: move PLL stabilization check code to separate function

Hi Andrzej, 2015-09-25 Andrzej Hajda : > The patch moves PLL stabilization check to separate function, adjust timeout > parameters and de-duplicates code common for both HW variants. > > Signed-off-by: Andrzej Hajda > --- >

Re: [PATCH 01/16] drm/exynos/hdmi: remove support for deprecated compatible

Hi Andrzej, 2015-09-25 Andrzej Hajda : > This compatible was marked as deprecated in Jun 2013 and it is not used since > then. Additionally its driver data points to wrong pll settings, so it > cannot work anyway. > > Signed-off-by: Andrzej Hajda > ---

Re: [PATCH 02/16] dt-bindings: remove deprecated compatible string from exynos-hdmi

Hi Andrzej, 2015-09-25 Andrzej Hajda : > samsung,exynos5-hdmi compatible was marked as deprecated in Jun 2013. > It was never used since then. > > Signed-off-by: Andrzej Hajda > --- > Documentation/devicetree/bindings/video/exynos_hdmi.txt | 7 +++

Re: [PATCH 03/16] drm/exynos/hdmi: use mappings for registers with IP dependent address

Hi Andrzej, 2015-09-25 Andrzej Hajda : > Some registers resides at different offsets depending on device version. > This patch adds infrastructure for mapping such registers to proper address > based on hdmi_type. It adds also mappings to some registers. > > Signed-off-by:

Re: [PATCH 05/16] drm/exynos/hdmi: simplify HDMI-PHY power sequence

Hi Andrzej, 2015-09-25 Andrzej Hajda : > Currently driver tries to set specific HDMI-PHY registers in three situations: > - before reset, > - before power off, > - after applying HDMI-PHY configuration. > > First two cases seems to be unnecessary - register contents will be

Re: [PATCH] drm/exynos: dp: remove suspend/resume functions

On 30 September 2015 at 14:46, Inki Dae wrote: > Hi Emil, > > On 2015년 09월 30일 21:19, Emil Velikov wrote: >> Hi Inki, >> >> On 30 September 2015 at 12:21, Inki Dae wrote: >>> This patch removes unnecessary pm suspend/resume functions. >>> >>> All kms

Re: [PATCH 06/16] drm/exynos/hdmi: replace all writeb with writel

Hi Andrzej, 2015-09-25 Andrzej Hajda : > Registers are 32-bit, even if only lower 8-bits are used. > > Signed-off-by: Andrzej Hajda > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-)

Re: [PATCH] ARM: dts: Add Exynos5250 Snow Rev5+ support

Hi, On Tue, Sep 29, 2015 at 5:30 PM, Krzysztof Kozlowski wrote: > Now the exynos5250-snow.dts means in fact Rev4... but there is no > information in DTS about it. I think adding compatible > "google,snow-rev4" makes sense: > 1. For informational purposes (this could be

Re: [PATCH 15/16] drm/exynos/hdmi: remove unused field

Hi Andrzej, 2015-09-25 Andrzej Hajda : > The patch removes unused hdmi_context field. > > Signed-off-by: Andrzej Hajda > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Gustavo Padovan

Re: [PATCH 09/16] drm/exynos/hdmi: use constant size array for regulators

Hi Andrzej, 2015-09-25 Andrzej Hajda : > Driver always uses the same number of regulators, so there is no point in > dynamic allocation. > > Signed-off-by: Andrzej Hajda > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 25 + > 1

Re: [PATCH 13/16] drm/exynos/hdmi: convert container_of macro to inline function

Hi Andrzej, 2015-09-25 Andrzej Hajda : > Inline function is safer than macro, also the name has been changed to > be consistent with other inline function encoder_to_hdmi. > > Signed-off-by: Andrzej Hajda > --- > drivers/gpu/drm/exynos/exynos_hdmi.c |