Re: [PATCH v2 0/6] ARM: dts: Use correct CD properties for SDIO and eMMC in Snow and Peach
On 10/16/15 22:48, Javier Martinez Canillas wrote: > Hello Alim, > > On 10/16/2015 01:37 PM, Alim Akhtar wrote: >> Hi Javier, >> >> On 10/15/2015 10:21 PM, Javier Martinez Canillas wrote: >>> Hello, >>> >>> The Exynos Chromebooks DTS don't use the correct card detection properties >>> since these were carried from the vendor tree that had a reason to do so. >>> >>> There are two things that I noticed: >>> >>> 1) The Marvell WiFi SDIO is marked as broken-cd instead of non-removable: >>> >>> This causes the device to be removed when the system enters into a suspend >>> state which leads to the following warning when the system is resumed: >>> >>> [ 181.944636] mmc2: error -2 during resume (card was removed?) >>> >>> The rationale for using broken-cd is explained in downstream commit [0] and >>> was that using the non-removable property caused issues with the mwifiex >>> driver since the reset logic called the mmc_{remove,add}_host() functions. >>> >>> But the reset logic in the mwifiex mainline driver has changed and this is >>> no longer the case so it's safe to use the non-removable property AFAICT. >>> >> Good to know it is fixed now. This is fixed in firmware or in the driver? >> > > The fix is only in the driver. In fact, I'm using the same firmware from > the ChromeOS rootfs for both the v3.8 vendor tree and mainline. > > So IIUC, the problem with the vendor tree was that the mwifiex SDIO driver > mwifiex_sdio_reset_work() function did a card reset by calling the functions > mmc_remove_host() and then mmc_add_host(). > > But this didn't play nice with MMC_CAP_NONREMOVABLE since mmc_rescan() just > returns if the flag is set so the card wouldn't be tried to be detected again. > > After commit ("b4336a282db8 mwifiex: sdio: reset adapter using mmc_hw_reset"), > the card is reset by doing a power cycle so that's why "non-removable" can be > used now instead of "broken-cd". > >>> 2) The eMMC node has both broken-cd and non-removable but the MMC DT binding >>> doc (Documentation/devicetree/bindings/mmc/mmc.txt) mentions that only one >>> of these card detection properties should be used. >>> >> This change looks ok, will take a closer look once I am back to my work >> station. >> Actually, looks good to me +1. Let me take this series once get the feedback from Alim. Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 1/2] clk: samsung: exynos5250: Add DISP1 clocks
On 10/17/15 03:56, Tomeu Vizoso wrote: > On 16 October 2015 at 19:26, Stephen Boyd wrote: >> On 10/16, Michael Turquette wrote: >>> Quoting Krzysztof Kozlowski (2015-10-15 16:46:27) On 15.10.2015 19:31, Tomeu Vizoso wrote: > When the DISP1 power domain is powered off, there's two clocks that need > to be temporarily reparented to OSC, and back to their original parents > when the domain is powered on again. > > We expose these two clocks in the DT bindings so that the DT node of the > power domain can reference them. > > Signed-off-by: Tomeu Vizoso > Acked-by: Stephen Boyd > --- > > Changes in v2: > - Reuse mout_aclk200_p > - Rename div_aclk300 as div_aclk300_disp > > drivers/clk/samsung/clk-exynos5250.c | 14 +- > include/dt-bindings/clock/exynos5250.h | 4 +++- > 2 files changed, 16 insertions(+), 2 deletions(-) > Reviewed-by: Krzysztof Kozlowski >>> >>> Applied to clk-next. >>> >> >> I think Tomeu wanted to take this through arm-soc? Otherwise >> we'll need to provide a stable branch for the dt header. > > Hi, Stephen is right, the second patch depends on this one. > So...how can I take 2nd patch of this series in samsung(arm-soc) tree? And this series shouldn't be for fixes for 4.3?...Mike how do you think? Thanks, Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[GIT PULL] Samsung 2nd fixes for v4.3
Hello Arnd, Olof, Kevin Here is 2nd Samsung fixes for v4.3 and it is including fix of exynos thermal driver with exynos thermal driver maintainer(Lukasz)'s ack. Please pull. Thanks, Kukjin The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f: Linux 4.3-rc1 (2015-09-12 16:35:56 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git tags/samsung-fixes-2 for you to fetch changes up to b28fec1324bf8f5010d2c3c5d57db4115bda66d4: thermal: exynos: Fix register read in TMU (2015-10-17 08:08:56 +0900) Samsung 2nd fixes for v4.3 - fix SOC detection of exynos thermal on exynos5260 - fix audio card detection on Peach boards - fix double of_node_put() when parsing child power domains Alim Akhtar (1): ARM: dts: Fix audio card detection on Peach boards Krzysztof Kozlowski (1): ARM: EXYNOS: Fix double of_node_put() when parsing child power domains Sudip Mukherjee (1): thermal: exynos: Fix register read in TMU arch/arm/boot/dts/exynos5420-peach-pit.dts | 5 + arch/arm/boot/dts/exynos5800-peach-pi.dts | 5 + arch/arm/mach-exynos/pm_domains.c | 8 +++- drivers/thermal/samsung/exynos_tmu.c | 2 +- 4 files changed, 14 insertions(+), 6 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] thermal: exynos: Fix register read in TMU
On 10/13/15 08:51, Krzysztof Kozlowski wrote: > From: Sudip Mukherjee > > The value of emul_con was getting overwritten if the selected soc is > SOC_ARCH_EXYNOS5260. And so as a result we were reading from the wrong > register in the case of SOC_ARCH_EXYNOS5260. > > Signed-off-by: Sudip Mukherjee > Reviewed-by: Krzysztof Kozlowski > Reviewed-by: Chanwoo Choi > Acked-by: Lukasz Majewski > Fixes: 488c7455d74c ("thermal: exynos: Add the support for Exynos5433 TMU") > Signed-off-by: Krzysztof Kozlowski > --- > drivers/thermal/samsung/exynos_tmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/samsung/exynos_tmu.c > b/drivers/thermal/samsung/exynos_tmu.c > index 0bae8cc6c23a..ca920b0ecf8f 100644 > --- a/drivers/thermal/samsung/exynos_tmu.c > +++ b/drivers/thermal/samsung/exynos_tmu.c > @@ -932,7 +932,7 @@ static void exynos4412_tmu_set_emulation(struct > exynos_tmu_data *data, > > if (data->soc == SOC_ARCH_EXYNOS5260) > emul_con = EXYNOS5260_EMUL_CON; > - if (data->soc == SOC_ARCH_EXYNOS5433) > + else if (data->soc == SOC_ARCH_EXYNOS5433) > emul_con = EXYNOS5433_TMU_EMUL_CON; > else if (data->soc == SOC_ARCH_EXYNOS7) > emul_con = EXYNOS7_TMU_REG_EMUL_CON; Applied, thanks. - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 1/2] clk: samsung: exynos5250: Add DISP1 clocks
On 16 October 2015 at 19:26, Stephen Boyd wrote: > On 10/16, Michael Turquette wrote: >> Quoting Krzysztof Kozlowski (2015-10-15 16:46:27) >> > On 15.10.2015 19:31, Tomeu Vizoso wrote: >> > > When the DISP1 power domain is powered off, there's two clocks that need >> > > to be temporarily reparented to OSC, and back to their original parents >> > > when the domain is powered on again. >> > > >> > > We expose these two clocks in the DT bindings so that the DT node of the >> > > power domain can reference them. >> > > >> > > Signed-off-by: Tomeu Vizoso >> > > Acked-by: Stephen Boyd >> > > --- >> > > >> > > Changes in v2: >> > > - Reuse mout_aclk200_p >> > > - Rename div_aclk300 as div_aclk300_disp >> > > >> > > drivers/clk/samsung/clk-exynos5250.c | 14 +- >> > > include/dt-bindings/clock/exynos5250.h | 4 +++- >> > > 2 files changed, 16 insertions(+), 2 deletions(-) >> > > >> > >> > Reviewed-by: Krzysztof Kozlowski >> >> Applied to clk-next. >> > > I think Tomeu wanted to take this through arm-soc? Otherwise > we'll need to provide a stable branch for the dt header. Hi, Stephen is right, the second patch depends on this one. Thanks, Tomeu > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 1/2] clk: samsung: exynos5250: Add DISP1 clocks
On 10/16, Michael Turquette wrote: > Quoting Krzysztof Kozlowski (2015-10-15 16:46:27) > > On 15.10.2015 19:31, Tomeu Vizoso wrote: > > > When the DISP1 power domain is powered off, there's two clocks that need > > > to be temporarily reparented to OSC, and back to their original parents > > > when the domain is powered on again. > > > > > > We expose these two clocks in the DT bindings so that the DT node of the > > > power domain can reference them. > > > > > > Signed-off-by: Tomeu Vizoso > > > Acked-by: Stephen Boyd > > > --- > > > > > > Changes in v2: > > > - Reuse mout_aclk200_p > > > - Rename div_aclk300 as div_aclk300_disp > > > > > > drivers/clk/samsung/clk-exynos5250.c | 14 +- > > > include/dt-bindings/clock/exynos5250.h | 4 +++- > > > 2 files changed, 16 insertions(+), 2 deletions(-) > > > > > > > Reviewed-by: Krzysztof Kozlowski > > Applied to clk-next. > I think Tomeu wanted to take this through arm-soc? Otherwise we'll need to provide a stable branch for the dt header. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] hwrng: exynos - Fix unbalanced PM runtime get/puts
Currently this driver calls pm_runtime_get_sync() rampantly but never puts anything back. This makes it impossible for the device to autosuspend properly; it will remain fully active after the first use. Fix in the obvious way. Signed-off-by: Daniel Thompson Cc: Kukjin Kim Cc: Krzysztof Kozlowski --- Notes: Compile tested only (CONFIG_PM=y, CONFIG_HW_RANDOM_EXYNOS=m); I spotted this whilst reviewing the code and don't have an exynos platform to test on. drivers/char/hw_random/exynos-rng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/hw_random/exynos-rng.c b/drivers/char/hw_random/exynos-rng.c index dc4701fd814f..73318e2a34dd 100644 --- a/drivers/char/hw_random/exynos-rng.c +++ b/drivers/char/hw_random/exynos-rng.c @@ -95,7 +95,7 @@ static int exynos_read(struct hwrng *rng, void *buf, *data = exynos_rng_readl(exynos_rng, EXYNOS_PRNG_OUT1_OFFSET); pm_runtime_mark_last_busy(exynos_rng->dev); - pm_runtime_autosuspend(exynos_rng->dev); + pm_runtime_put_sync_autosuspend(exynos_rng->dev); return 4; } -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/6] ARM: dts: Use correct CD properties for SDIO and eMMC in Snow and Peach
Hello Alim, On 10/16/2015 01:37 PM, Alim Akhtar wrote: > Hi Javier, > > On 10/15/2015 10:21 PM, Javier Martinez Canillas wrote: >> Hello, >> >> The Exynos Chromebooks DTS don't use the correct card detection properties >> since these were carried from the vendor tree that had a reason to do so. >> >> There are two things that I noticed: >> >> 1) The Marvell WiFi SDIO is marked as broken-cd instead of non-removable: >> >> This causes the device to be removed when the system enters into a suspend >> state which leads to the following warning when the system is resumed: >> >> [ 181.944636] mmc2: error -2 during resume (card was removed?) >> >> The rationale for using broken-cd is explained in downstream commit [0] and >> was that using the non-removable property caused issues with the mwifiex >> driver since the reset logic called the mmc_{remove,add}_host() functions. >> >> But the reset logic in the mwifiex mainline driver has changed and this is >> no longer the case so it's safe to use the non-removable property AFAICT. >> > Good to know it is fixed now. This is fixed in firmware or in the driver? > The fix is only in the driver. In fact, I'm using the same firmware from the ChromeOS rootfs for both the v3.8 vendor tree and mainline. So IIUC, the problem with the vendor tree was that the mwifiex SDIO driver mwifiex_sdio_reset_work() function did a card reset by calling the functions mmc_remove_host() and then mmc_add_host(). But this didn't play nice with MMC_CAP_NONREMOVABLE since mmc_rescan() just returns if the flag is set so the card wouldn't be tried to be detected again. After commit ("b4336a282db8 mwifiex: sdio: reset adapter using mmc_hw_reset"), the card is reset by doing a power cycle so that's why "non-removable" can be used now instead of "broken-cd". >> 2) The eMMC node has both broken-cd and non-removable but the MMC DT binding >> doc (Documentation/devicetree/bindings/mmc/mmc.txt) mentions that only one >> of these card detection properties should be used. >> > This change looks ok, will take a closer look once I am back to my work > station. > Thanks a lot for taking a look. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 1/2] clk: samsung: exynos5250: Add DISP1 clocks
Quoting Krzysztof Kozlowski (2015-10-15 16:46:27) > On 15.10.2015 19:31, Tomeu Vizoso wrote: > > When the DISP1 power domain is powered off, there's two clocks that need > > to be temporarily reparented to OSC, and back to their original parents > > when the domain is powered on again. > > > > We expose these two clocks in the DT bindings so that the DT node of the > > power domain can reference them. > > > > Signed-off-by: Tomeu Vizoso > > Acked-by: Stephen Boyd > > --- > > > > Changes in v2: > > - Reuse mout_aclk200_p > > - Rename div_aclk300 as div_aclk300_disp > > > > drivers/clk/samsung/clk-exynos5250.c | 14 +- > > include/dt-bindings/clock/exynos5250.h | 4 +++- > > 2 files changed, 16 insertions(+), 2 deletions(-) > > > > Reviewed-by: Krzysztof Kozlowski Applied to clk-next. Regards, Mike > > Best regards, > Krzysztof > > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFT PATCH v2 3/6] ARM: dts: Mark SDIO as non-removable in exynos5250-snow-common
On 15 October 2015 at 18:51, Javier Martinez Canillas wrote: > The Exynos5250 Snow Chromebooks have a Marvell WiFi SDIO chip which > can't neither be removed nor be detected. But the node isn't marked > as non-removable and instead has the broken-cd DT property. > > This causes the device to be removed when the system enters into a > suspend state and the following warnings is shown after a resume: > > [ 181.944636] mmc2: error -2 during resume (card was removed?) > > Also remove the card-detect-delay property that is not needed with > non-removable. > > Signed-off-by: Javier Martinez Canillas Reviewed-by: Tomeu Vizoso Tested-by: Tomeu Vizoso Thanks, Tomeu > > Changes since v1: > - Remove card-detect-delay property as well. > - Use the correct mmc node. Suggested by Tomeu. > > arch/arm/boot/dts/exynos5250-snow-common.dtsi | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5250-snow-common.dtsi > b/arch/arm/boot/dts/exynos5250-snow-common.dtsi > index 0a7f408824d8..1822c502a25a 100644 > --- a/arch/arm/boot/dts/exynos5250-snow-common.dtsi > +++ b/arch/arm/boot/dts/exynos5250-snow-common.dtsi > @@ -552,10 +552,9 @@ > &mmc_3 { > status = "okay"; > num-slots = <1>; > - broken-cd; > + non-removable; > cap-sdio-irq; > keep-power-in-suspend; > - card-detect-delay = <200>; > samsung,dw-mshc-ciu-div = <3>; > samsung,dw-mshc-sdr-timing = <2 3>; > samsung,dw-mshc-ddr-timing = <1 2>; > -- > 2.4.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFT PATCH v2 6/6] ARM: dts: Mark eMMC as non-removable in exynos5250-snow-common
On 15 October 2015 at 18:51, Javier Martinez Canillas wrote: > The eMMC is non-removable so mark it using the non-removable DT > property to avoid having to redetect it after a suspend/resume. > > Also remove the card-detect-delay property that is not needed with > non-removable. > > Signed-off-by: Javier Martinez Canillas Reviewed-by: Tomeu Vizoso Tested-by: Tomeu Vizoso Thanks, Tomeu > --- > > Changes since v1: > - None, new patch. > > arch/arm/boot/dts/exynos5250-snow-common.dtsi | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5250-snow-common.dtsi > b/arch/arm/boot/dts/exynos5250-snow-common.dtsi > index 1822c502a25a..5cb33ba5e296 100644 > --- a/arch/arm/boot/dts/exynos5250-snow-common.dtsi > +++ b/arch/arm/boot/dts/exynos5250-snow-common.dtsi > @@ -520,8 +520,7 @@ > &mmc_0 { > status = "okay"; > num-slots = <1>; > - broken-cd; > - card-detect-delay = <200>; > + non-removable; > samsung,dw-mshc-ciu-div = <3>; > samsung,dw-mshc-sdr-timing = <2 3>; > samsung,dw-mshc-ddr-timing = <1 2>; > -- > 2.4.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 0/6] ARM: dts: Use correct CD properties for SDIO and eMMC in Snow and Peach
Hi Javier, On 10/15/2015 10:21 PM, Javier Martinez Canillas wrote: Hello, The Exynos Chromebooks DTS don't use the correct card detection properties since these were carried from the vendor tree that had a reason to do so. There are two things that I noticed: 1) The Marvell WiFi SDIO is marked as broken-cd instead of non-removable: This causes the device to be removed when the system enters into a suspend state which leads to the following warning when the system is resumed: [ 181.944636] mmc2: error -2 during resume (card was removed?) The rationale for using broken-cd is explained in downstream commit [0] and was that using the non-removable property caused issues with the mwifiex driver since the reset logic called the mmc_{remove,add}_host() functions. But the reset logic in the mwifiex mainline driver has changed and this is no longer the case so it's safe to use the non-removable property AFAICT. Good to know it is fixed now. This is fixed in firmware or in the driver? 2) The eMMC node has both broken-cd and non-removable but the MMC DT binding doc (Documentation/devicetree/bindings/mmc/mmc.txt) mentions that only one of these card detection properties should be used. This change looks ok, will take a closer look once I am back to my work station. So this series change both the SDIO WiFi and eMMC device nodes in the Snow, Peach Pi and Peach Pit boards DTS to use the non-removable property. To test, I've cherry picked commit [1] from the vendor tree that adds a debugfs entry to force a card reset and after the reset, the WiFi card still works correctly: $ echo 1 > /sys/kernel/debug/mwifiex/mlan0/reset And also tested that both eMMC and WiFi are working correctly after a S2R. The test were made on an Exynos5800 Peach Pi but I don't have access to a Snow anymore so testing patch 3/6 and 6/6 on that board will be appreciated. v1 of the series was [2] and this version fixes issues pointed out by Tomeu. Changes since v1: - Replace broken-cd for non-removable in the correct mmc node for Snow. - Correct the card detetion properties for eMMC in Snow, Pit and Pi. - Also remove the card-detect-delay property when using non-removable. [0]: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/ad348e1e2381 [1]: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/5995363523de [2]: https://lkml.org/lkml/2015/10/15/294 Best regards, Javier Javier Martinez Canillas (6): ARM: dts: Mark SDIO as non-removable in exynos5800-peach-pi ARM: dts: Mark SDIO as non-removable in exynos5420-peach-pit ARM: dts: Mark SDIO as non-removable in exynos5250-snow-common ARM: dts: Remove broken-cd from eMMC node in exynos5800-peach-pi ARM: dts: Remove broken-cd from eMMC node in exynos5420-peach-pi ARM: dts: Mark eMMC as non-removable in exynos5250-snow-common arch/arm/boot/dts/exynos5250-snow-common.dtsi | 6 ++ arch/arm/boot/dts/exynos5420-peach-pit.dts| 5 + arch/arm/boot/dts/exynos5800-peach-pi.dts | 5 + 3 files changed, 4 insertions(+), 12 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 2/2] ARM: dts: exynos5250: Add clocks to DISP1 domain
On 10/16/2015 01:44 AM, Krzysztof Kozlowski wrote: > On 15.10.2015 19:31, Tomeu Vizoso wrote: >> Adds to the node of the DISP1 power domain the two clocks that need to >> be reparented while the domain is powered off: >> CLK_MOUT_ACLK200_DISP1_SUB and CLK_MOUT_ACLK300_DISP1_SUB. >> >> Otherwise the state is unknown at power up and the mixer's clocks are >> all messed up. >> >> Signed-off-by: Tomeu Vizoso >> Link: http://lkml.kernel.org/g/561cdc33.7050...@collabora.com >> --- >> >> >> arch/arm/boot/dts/exynos5250.dtsi | 4 >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5250.dtsi >> b/arch/arm/boot/dts/exynos5250.dtsi >> index b24610ea8c2a..88b9cf5f226f 100644 >> --- a/arch/arm/boot/dts/exynos5250.dtsi >> +++ b/arch/arm/boot/dts/exynos5250.dtsi >> @@ -130,6 +130,10 @@ >> compatible = "samsung,exynos4210-pd"; >> reg = <0x100440A0 0x20>; >> #power-domain-cells = <0>; >> +clocks = <&clock CLK_FIN_PLL>, >> + <&clock CLK_MOUT_ACLK200_DISP1_SUB>, >> + <&clock CLK_MOUT_ACLK300_DISP1_SUB>; >> +clock-names = "oscclk", "clk0", "clk1"; >> }; >> >> clock: clock-controller@1001 { >> > > I reviewed it already. Any changes here since v1? No, I just forgot to add your r-b tag, sorry about that. Thanks, Tomeu -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html