ically allocated IDs.
- This change was only compile-tested (corgi_defconfig), since I don't
have access to a board that uses this driver.
Doug Anderson (2):
i2c-core: dt: Pick i2c bus number from i2c alias if present
i2c: pxa: Use i2c-core to get bus number now
drivers/i2
Sylwester,
Thanks for the review...
On Fri, Jan 11, 2013 at 2:12 PM, Sylwester Nawrocki
wrote:
>> - ret = of_alias_get_id(np, "i2c");
>> - if (ret< 0) {
>> - dev_err(&pdev->dev, "failed to get alias id, errno %d\n",
>> ret);
>> - return ret;
>> - }
Will,
On Mon, Jan 14, 2013 at 2:47 AM, Will Newton wrote:
> These changes look ok to me. I don't know if patch 4 made it to the
> list, I only got a copy via the cc and the only archive I can find of
> linux-mmc (gmane) seems to be missing a lot of messages besides this
> one.
It seems to have m
Vivek,
On Fri, Jan 11, 2013 at 4:40 AM, Vivek Gautam wrote:
>>> +#define HOST_CTRL0_REFCLKSEL_MASK (0x3)
>>> +#define HOST_CTRL0_REFCLKSEL_XTAL (0x0 << 19)
>>> +#define HOST_CTRL0_REFCLKSEL_EXTL (0x1 << 19)
>>> +#define HOST_CTRL0_REFCLKSEL_CLKCORE
{
i2c0 = &i2c_0;
i2c1 = &i2c_1;
};
Signed-off-by: Doug Anderson
Acked-by: Haojian Zhuang
---
drivers/i2c/i2c-core.c | 105 +++-
1 files changed, 77 insertions(+), 28 deletions(-)
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core
The commit: "i2c-core: dt: Pick i2c bus number from i2c alias if
present" adds support for automatically picking the bus number based
on the alias ID. Remove the now unnecessary code from i2c-pxa that
did the same thing.
Signed-off-by: Doug Anderson
Acked-by: Haojian Zhuang
---
d
tested.
Reposting (with Haojian Zhuang's ack) in the hopes that a maintainer
will pick it up. :)
Doug Anderson (2):
i2c-core: dt: Pick i2c bus number from i2c alias if present
i2c: pxa: Use i2c-core to get bus number now
drivers/i2c/busses/i2c-pxa.c |8 +---
drivers/i2c/i2c-c
-off-by: Doug Anderson
Acked-by: Seungwon Jeon
---
Changes in v4: None
Changes in v3:
- Totally removed wp-gpios handling from exynos code.
Changes in v2: None
drivers/mmc/host/dw_mmc-exynos.c | 10 --
1 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/drivers/mmc/host
The next change will remove the code from the dw_mmc-exynos that added
the DW_MCI_QUIRK_NO_WRITE_PROTECT. Keep existing functionality of
having no write protect pin on smdk5250 by adding the disable-wp
property.
Signed-off-by: Doug Anderson
Acked-by: Seungwon Jeon
---
Changes in v4: None
-off-by: Doug Anderson
Acked-by: Seungwon Jeon
---
Changes in v4: None
Changes in v3: None
Changes in v2:
- Fixed return type from u32 to int
- Return -EINVAL instead of -1
drivers/mmc/host/dw_mmc.c | 34 ++
1 files changed, 34 insertions(+), 0 deletions(-)
diff
quot;disable-wp" device tree property) added a slot-level quirk and
support for the quirk directly to dw_mmc.
Signed-off-by: Doug Anderson
---
Changes in v4:
- New for this version; addresses comments from Olof Johansson about
the fact that we shouldn't have both a slot and control
l in needing to specify "disable-wp"
because the lack of a "wp-gpios" property means to use the special
purpose write protect line. On some other mmc devices the lack of
"wp-gpios" means that write protect should be disabled.
Signed-off-by: Doug Anderson
Acked-by: Seungw
Hi,
A followup as I did more investigation here...
On Thu, Jan 10, 2013 at 3:23 PM, Doug Anderson wrote:
> Olof,
>
> Thanks for your comments.
>
> On Thu, Jan 10, 2013 at 3:01 PM, Olof Johansson wrote:
>>
>> The previous code used the controller-common quirk field
Olof,
Thanks for your comments.
On Thu, Jan 10, 2013 at 3:01 PM, Olof Johansson wrote:
>
> The previous code used the controller-common quirk field to set a
> per-controller DW_MCI_QUIRK_NO_WRITE_PROTECT. Is there really need to
> do this per-slot? And if so, please explain in the commit message
-off-by: Doug Anderson
Acked-by: Seungwon Jeon
---
Changes in v3: None
Changes in v2:
- Fixed return type from u32 to int
- Return -EINVAL instead of -1
drivers/mmc/host/dw_mmc.c | 34 ++
1 files changed, 34 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc
The next change will remove the code from the dw_mmc-exynos that added
the DW_MCI_QUIRK_NO_WRITE_PROTECT. Keep existing functionality of
having no write protect pin on smdk5250 by adding the disable-wp
property.
Signed-off-by: Doug Anderson
Acked-by: Seungwon Jeon
---
Changes in v3:
- New for
-off-by: Doug Anderson
Acked-by: Seungwon Jeon
---
Changes in v3:
- Totally removed wp-gpios handling from exynos code.
Changes in v2: None
drivers/mmc/host/dw_mmc-exynos.c | 10 --
1 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers
l in needing to specify "disable-wp"
because the lack of a "wp-gpios" property means to use the special
purpose write protect line. On some other mmc devices the lack of
"wp-gpios" means that write protect should be disabled.
Signed-off-by: Doug Anderson
Acked-by: Seu
e current Chrome OS
tree. The third number (that you removed) is already correctly
specified in the dts as "samsung,dw-mshc-ciu-div". :)
> Signed-off-by: Alim Akhtar
Tested-by: Doug Anderson
Acked-by: Doug Anderson
--
To unsubscribe from this list: send the line "unsubscrib
Vivek,
On Fri, Dec 21, 2012 at 12:16 AM, Vivek Gautam
wrote:
> Hi all,
>
>
> On Wed, Dec 19, 2012 at 7:20 PM, Vivek Gautam
> wrote:
>> CC: Doug Anderson
>>
>>
>> On Sat, Dec 15, 2012 at 12:53 PM, Grant Likely
>> wrote:
>>> On Thu
mpatible strings for the device
>>>> usb: dwc3-exynos: Fix compatible strings for the device
>>>
>>> for both patches:
>>> Acked-by: Grant Likely
>>>
>
> Any more thought about this patch-set?
> Or does this change seems fine?
Thes
Vivek,
Nothing really serious below and things look good to me, but figured
I'd put a few nits in (sorry!).
On Fri, Dec 21, 2012 at 12:16 AM, Vivek Gautam wrote:
> diff --git a/Documentation/devicetree/bindings/usb/samsung-usbphy.txt
> b/Documentation/devicetree/bindings/usb/samsung-usbphy.txt
On Wed, Dec 19, 2012 at 10:37 PM, Vivek Gautam
wrote:
>
> On Thu, Dec 20, 2012 at 5:00 AM, Doug Anderson wrote:
>>
>> On Tue, Dec 18, 2012 at 6:43 AM, Vivek Gautam
>> wrote:
>>> +static void s5p_ehci_phy_enable(struct s5p_ehci_hcd *s5p_ehci)
>>> +
Vivek,
On Wed, Dec 19, 2012 at 9:51 PM, Vivek Gautam wrote:
> Hi Doug,
>
>
> On Thu, Dec 20, 2012 at 3:18 AM, Doug Anderson wrote:
>> Vivek,
>>
>> Since you're changing the name, I would have expected to see a removal
>> of the old enum type in thi
Chris,
On Fri, Nov 30, 2012 at 3:57 AM, Seungwon Jeon wrote:
> Doug, Thanks to work.
> Looks good to me with other patches.
>
> Acked-by: Seungwon Jeon
Does this series look reasonable to you? I can check back later when
things are less hectic, but I wanted to make sure this wasn't
forgotten.
Vivek,
Again, not a high-level review, but...
On Tue, Dec 18, 2012 at 6:43 AM, Vivek Gautam wrote:
> Adding the phy driver to ehci-s5p. Keeping the platform data
> for continuing the smooth operation for boards which still uses it
>
> Signed-off-by: Vivek Gautam
> Acked-by: Jingoo Han
> ---
>
Vivek,
I don't really have a good 1 foot view about how all of the USB
bits fit together, but a few detail-oriented comments below.
On Tue, Dec 18, 2012 at 6:43 AM, Vivek Gautam wrote:
> This patch adds host phy support to samsung-usbphy.c and
> further adds support for samsung's exynos5250
Vivek,
On Tue, Dec 18, 2012 at 6:43 AM, Vivek Gautam wrote:
> Updating the names of usb-phy types to more generic names:
> USB_PHY_TYPE_DEIVCE & USB_PHY_TYPE_HOST; and further update
> its dependencies.
Since you're changing the name, I would have expected to see a removal
of the old enum type i
>;
> + regulator-always-on;
> + };
> +
> + buck7_reg: BUCK7 {
> + regulator-name = "P2.0V_BUCK_OUT7";
> +
The next change will remove the code from the dw_mmc-exynos that added
the DW_MCI_QUIRK_NO_WRITE_PROTECT. Keep existing functionality of
having no write protect pin on smdk5250 by adding the disable-wp
property.
Signed-off-by: Doug Anderson
---
Changes in v3:
- New for this version of the patch
l in needing to specify "disable-wp"
because the lack of a "wp-gpios" property means to use the special
purpose write protect line. On some other mmc devices the lack of
"wp-gpios" means that write protect should be disabled.
Signed-off-by: Doug Anderson
---
Changes in v
Seungwon,
On Wed, Nov 28, 2012 at 11:46 PM, Seungwon Jeon wrote:
> Hi Doug,
>
> On Thursday, November 29, 2012, Doug Anderson wrote:
>> Seungwon,
>>
>> Thanks for the review. See below for comments. If you'd like me to
>> respin then please let me know.
-off-by: Doug Anderson
---
Changes in v3: None
Changes in v2:
- Fixed return type from u32 to int
- Return -EINVAL instead of -1
drivers/mmc/host/dw_mmc.c | 34 ++
1 files changed, 34 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers
-off-by: Doug Anderson
---
Changes in v3:
- Totally removed wp-gpios handling from exynos code.
Changes in v2: None
drivers/mmc/host/dw_mmc-exynos.c | 10 --
1 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c
I have some suggestion below.
> Could you check it?
>
> On Friday, November 23, 2012, Doug Anderson wrote:
>> The exynos code claimed wp-gpio with devm_gpio_request() but never did
>> anything with it. That meant that anyone using a write protect GPIO
>> would effectively be
sson wrote:
>> > >>
>> > >> On Tue, Nov 27, 2012 at 11:53 AM, Doug Anderson
>> > >> wrote:
>> > >>>
>> > >>> The recent commit "ARM: EXYNOS: add support for EXYNOS5440 SoC" broke
>> > >>> su
m [<8060a754>]
(start_kernel+0x1e0/0x3c8)
[<8060a754>] (start_kernel+0x1e0/0x3c8) from [<40008078>] (0x40008078)
Signed-off-by: Doug Anderson
---
arch/arm/mach-exynos/common.c |5 -
arch/arm/mach-exynos/mach-exynos5-dt.c |4 +++-
2 files changed, 7 insertions
won't claim the GPIO but will
just set the DW_MCI_QUIRK_NO_WRITE_PROTECT quirk if write protect
won't be used.
Signed-off-by: Doug Anderson
---
drivers/mmc/host/dw_mmc-exynos.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc-
-off-by: Doug Anderson
---
Changes in v2:
- Fixed return type from u32 to int
- Return -EINVAL instead of -1
drivers/mmc/host/dw_mmc.c | 35 +++
1 files changed, 35 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
won't claim the GPIO but will
just set the DW_MCI_QUIRK_NO_WRITE_PROTECT quirk if write protect
won't be used.
Signed-off-by: Doug Anderson
---
Changes in v2:
- Nothing new in this patch
drivers/mmc/host/dw_mmc-exynos.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletion
Jaehoon,
Thanks for the review. See below for comments. I'll plan on a new
patch either Monday or Tuesday when I have a chance to spin and
re-test.
On Wed, Nov 21, 2012 at 5:55 PM, Jaehoon Chung wrote:
> On 11/22/2012 07:03 AM, Doug Anderson wrote:
>> On some SoCs (like exynos
On Wed, Nov 21, 2012 at 5:42 PM, Seungwon Jeon wrote:
> Hi,
>
> wp-gpios has been implemented in dw_mmc-exynos.c
> It can be reused for EXYNOS platform? We need to modify some though.
Yup, I've seen that. Patch 1/2 ("mmc: dw_mmc: exynos: Stop claiming
wp-gpio") addressed that. For some reason I
-off-by: Doug Anderson
---
drivers/mmc/host/dw_mmc.c | 35 +++
1 files changed, 35 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 5b41348..9c79870 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host
On Tue, Nov 20, 2012 at 8:09 PM, Mark Brown
wrote:
> On Tue, Nov 20, 2012 at 02:27:04PM -0800, Doug Anderson wrote:
>> From: Padmavathi Venna
>>
>> Get the i2c bus number that the device is connected to using the alias
>> id. This makes debugging / grokking of
The commit: "i2c-core: dt: Pick i2c bus number from i2c alias if
present" adds support for automatically picking the bus number based
on the alias ID. Remove the now unnecessary code from i2c-pxa that
did the same thing.
Signed-off-by: Doug Anderson
---
drivers/i2c/busses/i2c-px
{
i2c0 = &i2c_0;
i2c1 = &i2c_1;
};
Signed-off-by: Doug Anderson
CC: Mark Brown
---
drivers/i2c/i2c-core.c | 105 +++-
1 files changed, 77 insertions(+), 28 deletions(-)
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index
and ack. The patch adding the generic functionality could go in
even if the i2c-pxa patch needs changes.
Doug Anderson (2):
i2c-core: dt: Pick i2c bus number from i2c alias if present
i2c: pxa: Use i2c-core to get bus number now
drivers/i2c/busses/i2c-pxa.c |8 +---
drivers/i2c/i2c-core.c
On Tue, Nov 20, 2012 at 11:29 PM, Olof Johansson wrote:
>
> On Tue, Nov 20, 2012 at 02:48:58PM -0800, Doug Anderson wrote:
> > From: Olof Johansson
> >
> > UART3 is used for debugging on exynos5250-snow.
> >
> > [dianders: cleaned commit message.]
&
From: Olof Johansson
Add support for using UART3 for DEBUG_LL on exynos.
[dianders: added depend on ARCH_EXYNOS.]
Signed-off-by: Olof Johansson
Signed-off-by: Doug Anderson
---
Changes in v2:
- Matched Olof's commit message.
- Added ARCH_EXYNOS to depend list.
arch/arm/Kconfig.
From: Olof Johansson
UART3 is used for debugging on exynos5250-snow.
[dianders: cleaned commit message.]
Signed-off-by: Olof Johansson
Signed-off-by: Doug Anderson
---
arch/arm/Kconfig.debug| 11 +++
arch/arm/plat-samsung/Kconfig |1 +
2 files changed, 12 insertions
From: Padmavathi Venna
Get the i2c bus number that the device is connected to using the alias
id. This makes debugging / grokking of kernel messages much easier.
[dianders: slight patch cleanup from Padmavathi's original.]
Signed-off-by: Padmavathi Venna
Signed-off-by: Doug And
This is similar to a recent commit for exynos5250 titled:
ARM: EXYNOS: Add aliases for i2c controller
Adding aliases will be useful to prevent warnings in a future
change. See:
i2c: s3c2410: Get the i2c bus number from alias id
Signed-off-by: Doug Anderson
---
arch/arm/boot/dts/exynos4
From: Olof Johansson
Needed to match device ids for clocks, etc.
Signed-off-by: Olof Johansson
Signed-off-by: Doug Anderson
---
arch/arm/mach-exynos/mach-exynos5-dt.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c
b
r boards
has not yet been send upstream.
With this file and a change to use UART3 for serial output I can:
* Boot to a command line using either SD or EMMC as a root filesystem
* See the power button and lid switch using evtest.
Signed-off-by: Doug Anderson
---
arch/arm/boot/dts/Makefile
The aliases for dwmmc were placed in the SMDK5250 dts file but really
should be common for all exynos5250 boards. Move it to the common CPU
file.
Signed-off-by: Doug Anderson
---
arch/arm/boot/dts/exynos5250-smdk5250.dts | 12
arch/arm/boot/dts/exynos5250.dtsi | 12
From: Julien Pichon
The following patch allows users to use KGDB over serial console on
board based on Samsung SOC. It has been tested on a board using
exynos5.
Signed-off-by: Julien Pichon
Signed-off-by: Doug Anderson
(dianders changed poll to return NO_POLL_CHAR, which appears to
fix '
k(&desc->irq_data);
> -
> generic_handle_irq(*irq_data);
> -
> - chip->irq_unmask(&desc->irq_data);
> chained_irq_exit(chip, desc);
> }
>
> --
> 1.7.7.3
>
Acked-by: Doug Anderson
--
To unsubscribe from this list: send the line &q
701 - 757 of 757 matches
Mail list logo
