Re: [PATCH v2 00/13] drm/exynos: async G2D and g2d_move()

On 27 November 2015 at 02:11, Hyungwon Hwang <human.hw...@samsung.com> wrote: > Dear All, > > On Thu, 26 Nov 2015 16:35:29 + > Emil Velikov <emil.l.veli...@gmail.com> wrote: > >> Hi Tobias, >> >> On 22 November 2015 at 18:48, Tobias Jakobi >>

Re: [PATCH v2 08/13] exynos: fimg2d: add g2d_set_direction

On 22 November 2015 at 18:48, Tobias Jakobi wrote: > This allows setting the two direction registers, which specify how > the engine blits pixels. This can be used for overlapping blits, > which happen e.g. when 'moving' a rectangular region inside a > fixed buffer.

Re: [PATCH v2 00/13] drm/exynos: async G2D and g2d_move()

Hi Tobias, On 22 November 2015 at 18:48, Tobias Jakobi wrote: > Hello, > > this series mostly touches G2D code. It introduces the following: > > (1) drmHandleEvent2() is added to enable processing of vendor-specific > events. This will be used to expose

Re: [PATCH v2 08/13] exynos: fimg2d: add g2d_set_direction

On 26 November 2015 at 16:41, Tobias Jakobi wrote: > Hello Emil, > > my main system which I also used for development was stolen on Tuesday, > so I won't be working on this series anytime soon. If anyone wants to > pick it up, please go ahead. > Sad to hear that x2. You've

Re: [PATCH 00/25] Exynos DRM: new life of IPP (Image Post Processing) subsystem

Hello Marek, On 10 November 2015 at 13:23, Marek Szyprowski wrote: > Dear All, > > This patch series introduces a new life into Exynos IPP (Image Post > Processing) subsystem by integrating it (transparently for userspace > applications) with Exynos DRM core plane

Re: [PATCH 10/13] tests/exynos: add test for g2d_move

On 9 November 2015 at 09:47, Tobias Jakobi wrote: > Hello Hyungwon, > > Hyungwon Hwang wrote: >> Hello, >> >> I think this patch should update .gitignore, not for adding the built >> binary to untracked file list. > good point. I should do this for the event test as

Re: [PATCH 06/13] tests/exynos: add fimg2d event test

On 30 October 2015 at 11:16, Tobias Jakobi wrote: > Hello Hyungwon, > > first of all thanks for reviewing the series! > > > > Hyungwon Hwang wrote: >> On Tue, 22 Sep 2015 17:54:55 +0200 >> Tobias Jakobi wrote: >> >>> +

Re: [PATCH 06/13] tests/exynos: add fimg2d event test

On 30 October 2015 at 11:28, Tobias Jakobi <tjak...@math.uni-bielefeld.de> wrote: > Hello Emil, > > > Emil Velikov wrote: >> On 30 October 2015 at 11:16, Tobias Jakobi >> <tjak...@math.uni-bielefeld.de> wrote: >>> Hello Hyungwon, >>

Re: [PATCH 06/13] tests/exynos: add fimg2d event test

On 30 October 2015 at 14:28, Tobias Jakobi wrote: > OK, I see what you mean. However this shouldn't happen as long as the > user properly zero initializes the event context structures, right? > It pains me to say it but in this day and age, not everyone zero

Re: [PATCH] drm/exynos: dp: remove suspend/resume functions

Hi Inki, On 30 September 2015 at 12:21, Inki Dae wrote: > This patch removes unnecessary pm suspend/resume functions. > > All kms sub drivers will be controlled by top of Exynos drm driver > and connector dpms so these sub drivers shouldn't have their own > pm interfaces. >

Re: [PATCH] drm/exynos: dp: remove suspend/resume functions

On 30 September 2015 at 14:46, Inki Dae <inki@samsung.com> wrote: > Hi Emil, > > On 2015년 09월 30일 21:19, Emil Velikov wrote: >> Hi Inki, >> >> On 30 September 2015 at 12:21, Inki Dae <inki@samsung.com> wrote: >>> This patch removes unnecess

Re: [PATCH v2 0/9] drm/exynos: rewrite fimg2d error handling

Hi Tobias, On 8 September 2015 at 16:22, Tobias Jakobi wrote: > Hello, > > during the discussion about the last patchset touching the > fimg2d code, it became apparent that the error handling for > the command submission is currently unsatisfactory. > > This series

Re: [PATCH v4 03/16] drm: bridge: analogix/dp: split exynos dp driver to bridge dir

[Dropping the CC list] Hi Yakir Yang, On 1 September 2015 at 06:49, Yakir Yang wrote: > Split the dp core driver from exynos directory to bridge > directory, and rename the core driver to analogix_dp_*, > leave the platform code to analogix_dp-exynos. > > Signed-off-by:

Re: [PATCH 07/14] exynos/fimg2d: add g2d_validate_xyz() functions

On 31 August 2015 at 14:18, Inki Dae wrote: > On 2015년 08월 24일 23:14, Tobias Jakobi wrote: >> The G2D headers define a number of modes through enums >> (like e.g. color, select, repeat, etc.). >> >> This introduces g2d_validate_select_mode() and >> g2d_validate_blending_op()

Re: [PATCH 04/14] exynos/fimg2d: check buffer space in g2d_solid_fill()

On 31 August 2015 at 20:27, Tobias Jakobi wrote: > Hello! > > Inki Dae wrote: >> On 2015년 08월 24일 23:13, Tobias Jakobi wrote: >>> +if (g2d_check_space(ctx, 7, 1)) >>> +return -ENOSPC; >> >> You can make 3 and 4 patches to one. These should be same

Re: [PATCH 00/14] drm/exynos: rewrite fimg2d error handling

and printf, and the G2D context struct was moved out of the public header. Thanks for going with my earlier suggestion and untangling all this. I've went through the lot and it looks great afaict. Fwiw for the series Reviewed-by: Emil Velikov emil.l.veli...@gmail.com As pretty much none

Re: [PATCH v2 0/9] drm/exynos: cleanups and small fixes for libdrm

On 12 June 2015 at 18:15, Tobias Jakobi tjak...@math.uni-bielefeld.de wrote: Hello, I've split off the Exynos specific bits, so this is just some cleanups and small fixes. Everything can be reviewed without knowledge about the Exynos platform. My hope is that I can get at least some of the

Re: [PATCH 4/9] tests/exynos: clean struct connector

On 10 June 2015 at 14:42, Tobias Jakobi tjak...@math.uni-bielefeld.de wrote: Remove all unused struct members. Mentioning if they were used at some point in the past will be great. Thanks Emil Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- tests/exynos/exynos_fimg2d_test.c

Re: [PATCH 8/9] tests/exynos: remove connector_find_plane

On 10 June 2015 at 14:42, Tobias Jakobi tjak...@math.uni-bielefeld.de wrote: No test uses DRM planes at the moment so this function is never called. Similar to the other patch - mention if this been used previously. I'm assuming that the exynos guys might have some work stashed which depends on

Re: [PATCH 1/9] exynos: fimg2d: fix return codes

On 10 June 2015 at 14:42, Tobias Jakobi tjak...@math.uni-bielefeld.de wrote: Even if flushing the command buffer doesn't succeed, the G2D calls would still return zero. Fix this by just passing the flush return code. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de ---

Re: [PATCH] libgencec: Add userspace library for the generic CEC kernel interface

, From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of Emil Velikov Sent: Wednesday, April 29, 2015 5:00 PM Hi Kamil, Allow me to put a few suggestions: On 29 April 2015 at 11:02, Kamil Debski k.deb...@samsung.com wrote: diff --git a/m4

Re: [PATCH 2/5] exynos: add EXYNOS_G2D_EVENT to drmHandleEvent

Hi Tobias, On 30/03/15 13:04, Tobias Jakobi wrote: Hello, On 2015-03-30 02:02, Rob Clark wrote: so, iirc, vmwgfx also has some custom events.. not really sure if they have their own hand-rolled drmHandleEvent() or if they have another way of catching those. Maybe we need some more

Re: [PATCH 3/3] drm/exynos: mixer: add 2x scaling to mixer_graph_buffer

Hi Tobias, On 1 April 2015 at 14:29, Tobias Jakobi tjak...@math.uni-bielefeld.de wrote: diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c index 5ab0e32..6822b36 100644 --- a/drivers/gpu/drm/exynos/exynos_mixer.c +++

Re: [PATCH 1/5] tests/exynos: add fimg2d performance analysis

On 25/03/15 18:27, Tobias Jakobi wrote: Hello, the new version should fix most of the mentioned issues. Tobias Jakobi wrote: As a general note I would recommend keeping statements on separate lines (none of if (foo) far()) as it makes debugging easier. OK, changing this. Except for

Re: [PATCH v2 1/5] tests/exynos: add fimg2d performance analysis

On 25/03/15 16:48, Tobias Jakobi wrote: Currently only fast solid color clear performance is measured. A large buffer is allocated and solid color clear operations are executed on it with randomly chosen properties (position and size of the region, clear color). Execution time is measured and

Re: [PATCH 2/5] exynos: add EXYNOS_G2D_EVENT to drmHandleEvent

Hi Tobias, On 22/03/15 16:29, Tobias Jakobi wrote: Hello Emil, Emil Velikov wrote: I fear we are not (yet) allowed to do either of these changes. The exynos/exynos_drm.h header is (supposed to) be in sync/come from the kernel. And changes here are to be reflected only when the corresponding

Re: [PATCH 2/5] exynos: add EXYNOS_G2D_EVENT to drmHandleEvent

On 20/03/15 22:25, Tobias Jakobi wrote: This event is specific to Exynos G2D DRM driver. Only process it when Exynos support is enabled. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_drm.h | 12 xf86drm.h | 7 ++- xf86drmMode.c

Re: [PATCH 1/5] tests/exynos: add fimg2d performance analysis

On 20/03/15 22:25, Tobias Jakobi wrote: Currently only fast solid color clear performance is measured. A large buffer is allocated and solid color clear operations are executed on it with randomly chosen properties (position and size of the region, clear color). Execution time is measured and

Re: [PATCH 1/7] tests/exynos: fimg2d: add a checkerboard test

On 11/03/15 19:38, Tobias Jakobi wrote: This makes it easier to spot memory corruptions which don't become visible when using a plain buffer filled with a solid color (so corruptions that are just a permutation of the bytes in the buffer). Signed-off-by: Tobias Jakobi

Re: [v3] libdrm: improvements to userspace exynos component

improve. v2: - Mention value of G2D scaling normalization factor (02/15). - Moved patch (04/15) description from commit message to source itself, like suggested by Joonyoung Shim. v3: I integrated the suggestions by Emil Velikov and added two additional patches to the series. One doing

Re: [v3] libdrm: improvements to userspace exynos component

On 08/03/15 23:12, Tobias Jakobi wrote: Hello Emil, Emil Velikov wrote: I'm planning to push the above mentioned patches around lunchtime this Tuesday. If anyone has objections please speak up. I doubt you're going to hear anything from Inki Dae. Despite that it might sound a bit rude, I

Re: [v3] libdrm: improvements to userspace exynos component

On 25 February 2015 at 15:54, Emil Velikov emil.l.veli...@gmail.com wrote: On 24 February 2015 at 14:20, Tobias Jakobi tjak...@math.uni-bielefeld.de wrote: Hello, here are some miscellaneous improvements (small features, bugfixes, spelling fixes, etc.) for the exynos component of libdrm

Re: [v3] libdrm: improvements to userspace exynos component

of G2D scaling normalization factor (02/15). - Moved patch (04/15) description from commit message to source itself, like suggested by Joonyoung Shim. v3: I integrated the suggestions by Emil Velikov and added two additional patches to the series. One doing the header cleanup that Emil point out

Re: [PATCH v2 04/15] tests/exynos: disable the G2D userptr/blend test

On 16/02/15 13:46, Tobias Jakobi wrote: v2: Move the commit description into the patch itself. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- tests/exynos/exynos_fimg2d_test.c | 8 1 file changed, 8 insertions(+) diff --git a/tests/exynos/exynos_fimg2d_test.c

Re: [PATCH v2 12/15] exynos: add fimg2d header to common includes

On 16/02/15 13:46, Tobias Jakobi wrote: The reason for this change is to let userspace use the header. Currently 'make install' does not install it. Hi Tobias, Afaict that this was done intentionally. I believe the Samsung guys got this out only to fulfil the no drm(render) driver without

Re: [v2] libdrm: improvements to userspace exynos component

and they are quite ok (baring a trivial comment) Reviewed-by: Emil Velikov emil.l.veli...@gmail.com Thanks Emil P.S. Please don't recent the entire series, unless needed. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v2 08/15] exynos: introduce g2d_add_base_addr helper function

On 16/02/15 13:46, Tobias Jakobi wrote: In almost all functions the base address register is written, so it makes sense to have a helper function for this. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.c | 87

Re: [PATCH v2 06/15] tests/exynos: introduce wait_for_user_input

On 16/02/15 13:46, Tobias Jakobi wrote: Currently getchar() is used to pause execution after each test. The user isn't informed if one is supposed to do anything for the tests to continue, so print a simple message to make this more clear. Signed-off-by: Tobias Jakobi

Re: [PATCH 1/2] exynos: Don't use DRM_EXYNOS_GEM_{MAP_OFFSET/MMAP} ioctls

On 26 January 2015 at 01:42, Hyungwon Hwang human.hw...@samsung.com wrote: Dear Tobias, Thanks for fixing it. Signed-off-by: Hyungwon Hwang human.hw...@samsung.com Hi Hyungwon Hwang I'm a bit confused about the use of s-o-b here. I've assumed that libdrm follows the kernel style [1] for

Re: [PATCH 1/2] exynos: Don't use DRM_EXYNOS_GEM_{MAP_OFFSET/MMAP} ioctls

On 27 January 2015 at 01:05, Hyungwon Hwang human.hw...@samsung.com wrote: Dear Emil, On Mon, 26 Jan 2015 19:05:51 + Emil Velikov emil.l.veli...@gmail.com wrote: On 26 January 2015 at 01:42, Hyungwon Hwang human.hw...@samsung.com wrote: Dear Tobias, Thanks for fixing

Re: [PATCH] drm/exynos: resolve infinite loop issue on non multi-platform

Hi Inki, With all respect, On 06/11/14 14:10, Inki Dae wrote: This patch resovles the infinite loop issue incurred when Exyno drm driver is enabled but all kms drivers are disabled on Exynos board by returning -EPROBE_DEFER only in case that there is kms device registered. I believe it's

Re: [PATCH] drm/exynos: resolve infinite loop issue on non multi-platform

On 06/11/14 15:44, Emil Velikov wrote: Hi Inki, With all respect, On 06/11/14 14:10, Inki Dae wrote: This patch resovles the infinite loop issue incurred when Exyno drm driver is enabled but all kms drivers are disabled on Exynos board by returning -EPROBE_DEFER only in case