functions to use the in-kernel thermal interfaces.
CC: Guenter Roeck guenter.ro...@ericsson.com
Signed-off-by: Amit Daniel Kachhap amit.kach...@linaro.org
Signed-off-by: Donggeun Kim dg77@samsung.com
Acked-by: Guenter Roeck guenter.ro...@ericsson.com
Some suggestions, possibly for later
On Fri, Jul 13, 2012 at 08:28:18PM +0900, Kukjin Kim wrote:
Amit Daniel Kachhap wrote:
These TMU enablement patches are needed for exynos4 and exynos5 TMU
driver patches sent earlier. The link for those are
http://www.spinics.net/lists/lm-sensors/msg35858.html.
How was going on above
Fyi.
Guenter
- Forwarded message from Sachin Kamat sachin.ka...@linaro.org -
Date: Fri, 13 Jul 2012 14:16:27 +0530
From: Sachin Kamat sachin.ka...@linaro.org
To: lm-sens...@lm-sensors.org
Cc: kh...@linux-fr.org, li...@roeck-us.net, sachin.ka...@linaro.org,
patc...@linaro.org
Subject:
On Tue, Jul 24, 2012 at 12:20:33PM +0530, Sachin Kamat wrote:
Hi Amit,
On 14 July 2012 12:55, amit kachhap amit.kach...@gmail.com wrote:
On Fri, Jul 13, 2012 at 8:11 PM, Guenter Roeck li...@roeck-us.net wrote:
On Fri, Jul 13, 2012 at 08:28:18PM +0900, Kukjin Kim wrote:
Amit Daniel
On Tue, Jul 24, 2012 at 09:53:11PM +0200, Rafael J. Wysocki wrote:
[ ... ]
If anything, I should not have applied Rafael's patch to the driver either.
Well, it looks like I sent it at a wrong time. Sorry about that.
My fault, not yours.
Guenter
--
To unsubscribe from this list: send the
On Thu, Aug 16, 2012 at 02:27:49PM +0530, Thomas Abraham wrote:
On 14 August 2012 03:14, Guenter Roeck li...@roeck-us.net wrote:
Hi all,
looking through SPI master drivers, I noticed that the following drivers
call
spi_master_get() in their suspend and resume functions. Yet
Suspend and resume functions call spi_master_get() without matching
spi_master_put(). The extra references are unnecessary and cause subsequent
module unload attempts to fail. Drop the calls.
Signed-off-by: Guenter Roeck li...@roeck-us.net
---
drivers/spi/spi-s3c64xx.c |8
1 file
Sigh.
s/remove/resume/ in headline.
Guenter
On Thu, Aug 16, 2012 at 08:14:25PM -0700, Guenter Roeck wrote:
Suspend and resume functions call spi_master_get() without matching
spi_master_put(). The extra references are unnecessary and cause subsequent
module unload attempts to fail. Drop
On Thu, Aug 23, 2012 at 02:40:45PM +0900, Kukjin Kim wrote:
Guenter Roeck wrote:
Suspend and resume functions call spi_master_get() without matching
spi_master_put(). The extra references are unnecessary and cause
subsequent
module unload attempts to fail. Drop the calls.
Signed
On Thu, May 08, 2014 at 04:46:51PM +0200, Arnd Bergmann wrote:
These are a bunch of fixes I had to do to get all randconfig
configurations on ARM working. Most of these are really old
bugs, but there are also some new ones. I don't think any of
them require a backport to linux-stable.
I
Chatradhi ch.nav...@samsung.com
Acked-by: Mark Rutland mark.rutl...@arm.com
Cc: Guenter Roeck li...@roeck-us.net
Applied.
Thanks,
Guenter
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info
according to the vendor-prefix.txt
Note: Drivers continue to support the previous compatible strings
but further addition of these compatible strings in device tree
is deprecated.
Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
Cc: Guenter Roeck li...@roeck-us.net
Applied.
Guenter
On 06/25/2014 03:57 AM, Kukjin Kim wrote:
Naveen Krishna Chatradhi wrote:
+ Jean Delvare, Guenter Roeck
I'm adding maintainers for drivers/hwmon/ntc* but I'm not sure.
Hi,
This series looks good to me. I will take 3/4 and 4/4 for exynos DT changes once
hwmon/ntc maintainer pick the others
On Wed, 2011-12-21 at 06:59 -0500, Amit Daniel Kachhap wrote:
Export and register information from the hwmon tmu sensor to the samsung
exynos kernel thermal framework where different cooling devices and thermal
zone are binded. The exported information is based according to the data
structure
On Wed, 2012-01-04 at 05:23 -0500, R, Durgadoss wrote:
Hi Amit Daniel,
Hi Guenter,
The main idea of this work is to leave the current userspace based
notification scheme and add the kernel based cooling scheme on top of
it. Anyway, It is a good idea to move the file
On Sat, Mar 03, 2012 at 06:06:05AM -0500, Amit Daniel Kachhap wrote:
This movement is needed because the hwmon entries and corresponding
sysfs interface is a duplicate of utilities already provided by
driver/thermal/thermal_sys.c. The goal is to place it in mfd folder
and add necessary calls
On Sat, Mar 03, 2012 at 06:06:06AM -0500, Amit Daniel Kachhap wrote:
Export and register information from the tmu temperature sensor to the samsung
exynos kernel thermal framework where different cooling devices and thermal
zone are binded. The exported information is based according to the
On Sat, Mar 03, 2012 at 11:44:10AM -0500, Mark Brown wrote:
On Sat, Mar 03, 2012 at 04:36:05PM +0530, Amit Daniel Kachhap wrote:
This movement is needed because the hwmon entries and corresponding
sysfs interface is a duplicate of utilities already provided by
driver/thermal/thermal_sys.c.
On 10/27/2013 11:24 PM, Sachin Kamat wrote:
Update the name as per DT naming convention.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Reviewed-by: Guenter Roeck li...@roeck-us.net
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message
On 10/27/2013 11:24 PM, Sachin Kamat wrote:
Update the name as per DT naming convention.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
.../devicetree/bindings/watchdog/samsung-wdt.txt |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Wed, Oct 30, 2013 at 12:22:09PM +0100, Tomasz Figa wrote:
On Wednesday 30 of October 2013 15:43:19 Sachin Kamat wrote:
On 30 October 2013 15:39, Leela Krishna Amudala l.kris...@samsung.com
wrote:
Hi,
On Wed, Oct 30, 2013 at 3:22 PM, Sachin Kamat sachin.ka...@linaro.org
wrote:
On 10/31/2013 05:29 AM, Tomasz Figa wrote:
Hi Leela,
On Thursday 31 of October 2013 11:30:50 Leela Krishna Amudala wrote:
The syscon regmap interface is used to configure AUTOMATIC_WDT_RESET_DISABLE
and MASK_WDT_RESET_REQUEST registers of PMU to mask/unmask enable/disable of
watchdog in probe
On Mon, Nov 18, 2013 at 03:19:48PM +0530, Leela Krishna Amudala wrote:
Add device tree support for exynos5250 and 5420 SoCs and use syscon regmap
interface
to configure AUTOMATIC_WDT_RESET_DISABLE and MASK_WDT_RESET_REQUEST registers
of PMU
to mask/unmask enable/disable of watchdog in probe
On 11/18/2013 08:36 PM, Leela Krishna Amudala wrote:
Hi Guenter Roeck,
Thanks for reviewing the patch.
On Mon, Nov 18, 2013 at 10:12 PM, Guenter Roeck li...@roeck-us.net wrote:
On Mon, Nov 18, 2013 at 03:19:48PM +0530, Leela Krishna Amudala wrote:
Add device tree support for exynos5250
On 11/18/2013 09:26 PM, Leela Krishna Amudala wrote:
Hi Guenter Roeck,
On Tue, Nov 19, 2013 at 10:30 AM, Guenter Roeck li...@roeck-us.net wrote:
On 11/18/2013 08:36 PM, Leela Krishna Amudala wrote:
Hi Guenter Roeck,
Thanks for reviewing the patch.
On Mon, Nov 18, 2013 at 10:12 PM, Guenter
On 11/25/2013 02:55 PM, Doug Anderson wrote:
On modern SoCs the watchdog timer is parented on a clock that doesn't
change every time we have a cpufreq change. That means we don't need
to constantly adjust the watchdog timer, so avoid registering for and
dealing with cpufreq transitions unless
Anderson diand...@chromium.org
Reviewed-by: Guenter Roeck li...@roeck-us.net
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/26/2013 10:30 AM, Doug Anderson wrote:
The existing watchdog timeout worked OK but didn't deal with
rounding in an ideal way when dividing out all of its clocks.
Specifically if you had a timeout of 32 seconds and an input clock of
, you'd end up setting a timeout of 31.9998
On 11/26/2013 01:34 PM, Doug Anderson wrote:
Guenter,
On Tue, Nov 26, 2013 at 10:48 AM, Guenter Roeck li...@roeck-us.net wrote:
On 11/26/2013 10:30 AM, Doug Anderson wrote:
The existing watchdog timeout worked OK but didn't deal with
rounding in an ideal way when dividing out all of its
-by: Doug Anderson diand...@chromium.org
Reviewed-by: Guenter Roeck li...@roeck-us.net
---
Changes in v2:
- Avoid a for loop as per Guenter.
drivers/watchdog/s3c2410_wdt.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers
On 11/27/2013 03:50 AM, Leela Krishna Amudala wrote:
Add device tree support for exynos5250 and 5420 SoCs and use syscon regmap
interface
to configure AUTOMATIC_WDT_RESET_DISABLE and MASK_WDT_RESET_REQUEST registers
of PMU
to mask/unmask enable/disable of watchdog in probe and s2r scenarios.
On Mon, Dec 02, 2013 at 10:14:41AM -0800, Doug Anderson wrote:
A good watchdog driver is supposed to report when it was responsible
for resetting the system. Implement this for the s3c2410, at least on
exynos5250 and exynos5420 where we already have a pointer to the PMU
registers to read the
On Mon, Dec 02, 2013 at 12:47:53PM -0800, Olof Johansson wrote:
On Mon, Dec 2, 2013 at 12:21 PM, Guenter Roeck li...@roeck-us.net wrote:
On Mon, Dec 02, 2013 at 10:14:41AM -0800, Doug Anderson wrote:
A good watchdog driver is supposed to report when it was responsible
for resetting
On Thu, Dec 05, 2013 at 01:27:13PM +0530, Leela Krishna Amudala wrote:
Hi Guenter Roeck,
On Tue, Dec 3, 2013 at 3:06 AM, Guenter Roeck li...@roeck-us.net wrote:
On Mon, Dec 02, 2013 at 12:47:53PM -0800, Olof Johansson wrote:
On Mon, Dec 2, 2013 at 12:21 PM, Guenter Roeck li...@roeck
-by: Tomasz Figa t.f...@samsung.com
Reviewed-by: Doug Anderson diand...@chromium.org
Tested-by: Doug Anderson diand...@chromium.org
Acked-by: Guenter Roeck li...@roeck-us.net
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
and s2r scenarios.
Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com
Signed-off-by: Doug Anderson diand...@chromium.org
Reviewed-by: Guenter Roeck li...@roeck-us.net
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord
...@samsung.com
Reviewed-by: Tomasz Figa t.f...@samsung.com
Reviewed-by: Doug Anderson diand...@chromium.org
Tested-by: Doug Anderson diand...@chromium.org
Acked-by: Guenter Roeck li...@roeck-us.net
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message
On Thu, Dec 05, 2013 at 10:15:29AM -0800, Doug Anderson wrote:
A good watchdog driver is supposed to report when it was responsible
for resetting the system. Implement this for the s3c2410, at least on
exynos5250 and exynos5420 where we already have a pointer to the PMU
registers to read the
PMU Registers vs. needing PMU Config.
Signed-off-by: Doug Anderson diand...@chromium.org
Reviewed-by: Guenter Roeck li...@roeck-us.net
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
On Fri, Dec 06, 2013 at 03:01:23PM -0800, Doug Anderson wrote:
Guenter,
On Fri, Dec 6, 2013 at 11:47 AM, Guenter Roeck li...@roeck-us.net wrote:
On Fri, Dec 06, 2013 at 11:17:46AM +0530, Leela Krishna Amudala wrote:
This patch adds pmusysreg node to exynos5250 and exynos5420 dtsi files
-by: Guenter Roeck li...@roeck-us.net
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jul 08, 2014 at 04:21:09PM +0200, Tomasz Figa wrote:
Hi Heiko,
On 06.07.2014 20:42, Heiko Stübner wrote:
On a lot of Samsung systems the watchdog is responsible for restarting the
system and until now this code was contained in
plat-samsung/watchdog-reset.c .
With the
From: Heiko Stübner he...@sntech.de
Add infrastructure to write the correct value to the restart register and
register the restart notifier for both rk3188 (including rk3066) and rk3288.
Signed-off-by: Heiko Stuebner he...@sntech.de
Signed-off-by: Guenter Roeck li...@roeck-us.net
---
v7: Added
...@sntech.de
Signed-off-by: Guenter Roeck li...@roeck-us.net
---
v7: Added patch to series.
drivers/clk/samsung/clk-s3c2412.c | 29 +
drivers/clk/samsung/clk-s3c2443.c | 19 +++
2 files changed, 48 insertions(+)
diff --git a/drivers/clk/samsung/clk-s3c2412.c
b
The kernel core now provides an API to trigger a system restart.
Register with it instead of setting arm_pm_restart.
Signed-off-by: Guenter Roeck li...@roeck-us.net
Acked-by: Heiko Stuebner he...@sntech.de
---
v7: Added patch to series. Necessary since the restart handler in the driver
is now
Implementing a restart handler in a module don't make sense
as there would be no guarantee that the module is loaded when
a restart is needed. Unexport arm_pm_restart to ensure that
no one gets the idea to do it anyway.
Signed-off-by: Guenter Roeck li...@roeck-us.net
Acked-by: Catalin Marinas
The kernel core now provides an API to trigger a system restart.
Register with it to restart the system instead of misusing the
reboot notifier.
Signed-off-by: Guenter Roeck li...@roeck-us.net
Acked-by: Catalin Marinas catalin.mari...@arm.com
Acked-by: Heiko Stuebner he...@sntech.de
---
v7
machine_restart is supported on non-ARM platforms, and and ultimately calls
arm_pm_restart, so dont call arm_pm_restart directly but use the more
generic function.
Cc: Russell King li...@arm.linux.org.uk
Signed-off-by: Guenter Roeck li...@roeck-us.net
Acked-by: Catalin Marinas catalin.mari
-off-by: Guenter Roeck li...@roeck-us.net
Acked-by: Catalin Marinas catalin.mari...@arm.com
Acked-by: Heiko Stuebner he...@sntech.de
---
v7: Dropped null_restart and made arm_pm_restart truly optional.
v6: No change.
v5: Renamed restart function to do_kernel_restart
v4: No change.
v3: Use wrapper
The kernel now provides an API to trigger a system restart.
Register with it instead of setting arm_pm_restart.
Signed-off-by: Guenter Roeck li...@roeck-us.net
Acked-by: Catalin Marinas catalin.mari...@arm.com
Acked-by: Heiko Stuebner he...@sntech.de
---
v7: No change.
v6: No change.
v5
capabilities for a given system
is called first.
Signed-off-by: Guenter Roeck li...@roeck-us.net
Acked-by: Catalin Marinas catalin.mari...@arm.com
Acked-by: Heiko Stuebner he...@sntech.de
---
v7: Rebased to v3.17-rc1
v6: Use atomic notifier call chain
v5: Function renames:
register_restart_notifier
The kernel core now supports a restart handler call chain to restart
the system. Call it if arm_pm_restart is not set.
Signed-off-by: Guenter Roeck li...@roeck-us.net
Acked-by: Catalin Marinas catalin.mari...@arm.com
Acked-by: Heiko Stuebner he...@sntech.de
---
v7: No change.
v6: No change.
v5
On Wed, Aug 20, 2014 at 09:10:31PM -0700, Doug Anderson wrote:
Guenter,
On Tue, Aug 19, 2014 at 5:45 PM, Guenter Roeck li...@roeck-us.net wrote:
machine_restart is supported on non-ARM platforms, and and ultimately calls
arm_pm_restart, so dont call arm_pm_restart directly but use the more
On Thu, Aug 21, 2014 at 12:30:44PM -0700, Doug Anderson wrote:
Guenter,
On Wed, Aug 20, 2014 at 9:42 PM, Guenter Roeck li...@roeck-us.net wrote:
On Wed, Aug 20, 2014 at 09:10:31PM -0700, Doug Anderson wrote:
Guenter,
On Tue, Aug 19, 2014 at 5:45 PM, Guenter Roeck li...@roeck-us.net
On Fri, Aug 22, 2014 at 03:32:42AM +0200, Andreas Färber wrote:
Hi,
Am 20.08.2014 02:45, schrieb Guenter Roeck:
The kernel core now supports a restart handler call chain for system
restart functions.
With this change, the arm_pm_restart callback is now optional, so
drop its
On Tue, Aug 19, 2014 at 05:45:27PM -0700, Guenter Roeck wrote:
Various drivers implement architecture and/or device specific means
to restart (reset) the system. Various mechanisms have been implemented
to support those schemes. The best known mechanism is arm_pm_restart,
which is a function
On 08/21/2014 01:39 PM, Sebastian Reichel wrote:
Hi,
On Tue, Aug 19, 2014 at 05:45:29PM -0700, Guenter Roeck wrote:
machine_restart is supported on non-ARM platforms, and and ultimately calls
arm_pm_restart, so dont call arm_pm_restart directly but use the more
generic function.
Cc: Russell
On 08/23/2014 04:00 PM, Heiko Stübner wrote:
Am Samstag, 23. August 2014, 09:35:05 schrieb Guenter Roeck:
On Tue, Aug 19, 2014 at 05:45:27PM -0700, Guenter Roeck wrote:
Various drivers implement architecture and/or device specific means
to restart (reset) the system. Various mechanisms have
On Wed, Aug 27, 2014 at 03:17:11PM +0530, Naveen Krishna Chatradhi wrote:
Exynos7 SoC has a Watchdog for Atlas (A57) cores
This patch adds support for the Atlas watchdog.
Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com
Cc: Wim Van Sebroeck w...@iguana.be
Reviewed-by: Guenter
On Tue, Sep 30, 2014 at 02:20:02PM -0700, Andrew Morton wrote:
On Tue, 19 Aug 2014 17:45:27 -0700 Guenter Roeck li...@roeck-us.net wrote:
Introduce a system restart handler call chain to solve the described
problems.
So someone has merged eight of these patches into linux-next
On 09/30/2014 04:40 PM, Stephen Rothwell wrote:
Hi Guenter,
On Tue, 30 Sep 2014 15:30:00 -0700 Guenter Roeck li...@roeck-us.net wrote:
On Tue, Sep 30, 2014 at 02:20:02PM -0700, Andrew Morton wrote:
On Tue, 19 Aug 2014 17:45:27 -0700 Guenter Roeck li...@roeck-us.net wrote:
Introduce
On 10/01/2014 04:36 AM, Pankaj Dubey wrote:
Let's register reboot_notifier from PMU driver for reboot
functionality. So that we can remove restart hooks from
machine specific file, and thus moving ahead when PMU moved
to driver folder, this functionality can be reused for ARM64
based Exynos
On Tue, Oct 07, 2014 at 01:23:19PM +0530, Pankaj Dubey wrote:
This patch removes restart hook from machine_desc of Exynos, and moves
respective code into reboot_notifiers.
Nitpick:
s/reboot_notifiers/restart_notifiers/
Guenter
Exynos5440 handles reboot via clock register so let's register a
the fallback priority to indicate that the poweroff handler is one
of last resort. If the poweroff handler powers off the system, select the
default priority.
Cc: Russell King li...@arm.linux.org.uk
Signed-off-by: Guenter Roeck li...@roeck-us.net
---
- Use defines to specify poweroff handler priorities
the fallback priority to indicate that the power-off handler is one
of last resort. If the power-off handler powers off the system, select the
default priority.
Cc: Russell King li...@arm.linux.org.uk
Signed-off-by: Guenter Roeck li...@roeck-us.net
---
v3:
- Replace poweroff in all newly introduced
the fallback priority to indicate that the power-off handler is one
of last resort. If the power-off handler powers off the system, select the
default priority.
Cc: Russell King li...@arm.linux.org.uk
Signed-off-by: Guenter Roeck li...@roeck-us.net
---
v5:
- Rebase to v3.18-rc3
v4:
- No change
v3
the fallback priority to indicate that the power-off handler is one
of last resort. If the power-off handler powers off the system, select the
default priority.
Cc: Russell King li...@arm.linux.org.uk
Signed-off-by: Guenter Roeck li...@roeck-us.net
---
v6:
- This patch: No change.
Global: Replaced
register restart handler err=%d\n, ret);
+
dev_warn might be more appropriate, since you ignore the error.
But that is a nitpick, really, as well as the above.
Acked-by: Guenter Roeck li...@roeck-us.net
dev_dbg(dev, Exynos PMU Driver probe done\n);
return 0;
}
--
1.7.9.5
tomasz.f...@gmail.com
Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com
reboot-restart, and consider using pr_warn instead of pr_err.
Since those are nitpicks
Acked-by: Guenter Roeck li...@roeck-us.net
---
arch/arm/mach-exynos/exynos.c| 19 +--
drivers/clk/samsung/clk
On 12/04/2014 05:36 AM, Geert Uytterhoeven wrote:
Hi Günther,
On Wed, Aug 20, 2014 at 2:45 AM, Guenter Roeck li...@roeck-us.net wrote:
Implementing a restart handler in a module don't make sense
as there would be no guarantee that the module is loaded when
a restart is needed. Unexport
On 12/04/2014 06:44 AM, Geert Uytterhoeven wrote:
Hi Günther,
On Thu, Dec 4, 2014 at 3:26 PM, Guenter Roeck li...@roeck-us.net wrote:
On 12/04/2014 05:36 AM, Geert Uytterhoeven wrote:
On Wed, Aug 20, 2014 at 2:45 AM, Guenter Roeck li...@roeck-us.net wrote:
Implementing a restart handler
On Thu, Dec 04, 2014 at 04:06:22PM +0100, Arnd Bergmann wrote:
On Thursday 04 December 2014 06:51:49 Guenter Roeck wrote:
On 12/04/2014 06:44 AM, Geert Uytterhoeven wrote:
On Thu, Dec 4, 2014 at 3:26 PM, Guenter Roeck li...@roeck-us.net wrote:
On 12/04/2014 05:36 AM, Geert Uytterhoeven
On 12/18/2014 02:13 AM, Lukasz Majewski wrote:
Several new properties to allow PWM fan working as a cooling device have been
combined into this single commit.
Signed-off-by: Lukasz Majewski l.majew...@samsung.com
---
.../devicetree/bindings/hwmon/pwm-fan.txt | 28
On Fri, Dec 19, 2014 at 04:32:24PM +0100, Lukasz Majewski wrote:
Hi Sjoerd,
Thanks for your feedback and sorry for a late reply.
On Thu, 2014-12-18 at 11:13 +0100, Lukasz Majewski wrote:
Several new properties to allow PWM fan working as a cooling device
have been combined into this
On Mon, Dec 22, 2014 at 05:27:47PM +0100, Lukasz Majewski wrote:
Code for reading PWM FAN configuration data via device tree.
Signed-off-by: Lukasz Majewski l.majew...@samsung.com
---
The headline is quite misleading. Please provide the affected subsystem (hwmon)
and the affected driver
On Mon, Dec 22, 2014 at 05:27:46PM +0100, Lukasz Majewski wrote:
It was necessary to decouple code handling writing to sysfs from the one
responsible for setting PWM of the fan.
Due to that, new __set_pwm() method was extracted, which is responsible for
only setting new PWM duty cycle.
);
... when != res
- if (res == NULL) { ... \(goto l;\|return ret;\) }
... when != res
+ res = platform_get_resource(pdev, IORESOURCE_MEM, n);
e = devm_ioremap_resource(e1, res);
// /smpl
Signed-off-by: Julia Lawall julia.law...@lip6.fr
Reviewed-by: Guenter Roeck li...@roeck-us.net
On Wed, Aug 21, 2013 at 10:01:05PM +0200, Wim Van Sebroeck wrote:
Hi All,
Leela Krishna Amudala wrote:
This patch removes the global variables in the driver file and
group them into a structure.
Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com
(+ Wim Van
On Fri, Feb 06, 2015 at 05:59:06PM +0100, Lukasz Majewski wrote:
It was necessary to decouple code handling writing to sysfs from the one
responsible for setting PWM of the fan.
Due to that, new __set_pwm() method was extracted, which is responsible for
only setting new PWM duty cycle.
On Fri, Feb 06, 2015 at 05:59:07PM +0100, Lukasz Majewski wrote:
This patch provides code for reading PWM FAN configuration data via
device tree. The pwm-fan can work with full speed when configuration
is not provided. However, errors are propagated when wrong DT bindings
are found.
On Wed, Jan 14, 2015 at 03:57:32PM -0800, Kevin Hilman wrote:
From: Kevin Hilman khil...@linaro.org
Add support for ina231 as compatible string.
Tested with the Exynos5422-based odroid-xu3 board which has on-board
INA231 sensors.
Signed-off-by: Kevin Hilman khil...@linaro.org
Hi Kevin,
On 02/08/2015 01:36 PM, Lukasz Majewski wrote:
On Fri, 6 Feb 2015 10:36:57 -0800
Guenter Roeck li...@roeck-us.net wrote:
On Fri, Feb 06, 2015 at 05:59:07PM +0100, Lukasz Majewski wrote:
This patch provides code for reading PWM FAN configuration data via
device tree. The pwm-fan can work
On Mon, Feb 23, 2015 at 05:51:22PM +0100, Lukasz Majewski wrote:
Hi Guenter,
On Mon, Feb 23, 2015 at 05:13:36PM +0100, Lukasz Majewski wrote:
Hi Guenter,
[ ... ]
If devicetree is not configured, of_property_count_elems_of_size
returns -ENOSYS, which is returned,
On Mon, Feb 23, 2015 at 05:13:36PM +0100, Lukasz Majewski wrote:
Hi Guenter,
[ ... ]
If devicetree is not configured, of_property_count_elems_of_size
returns -ENOSYS, which is returned, causing the driver to fail
loading.
Has of_property_count_elems_of_size() returns -ENOSYS?
:
Acked-by: Guenter Roeck li...@roeck-us.net
Should I take it through hwmon ? Might make sense given the majority
of the changes is in hwmon code.
Thanks,
Guenter
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
On Wed, Feb 25, 2015 at 02:29:18PM -0400, Eduardo Valentin wrote:
Guenter,
On Wed, Feb 25, 2015 at 09:18:20AM -0800, Guenter Roeck wrote:
On Wed, Feb 25, 2015 at 04:34:16PM +0100, Lukasz Majewski wrote:
Presented patches add support for Odroid's U3 optional CPU FAN, which
uses PWM
On 02/26/2015 05:59 AM, Lukasz Majewski wrote:
The PWM FAN device can now be used as a thermal cooling device. Necessary
infrastructure has been added in this commit.
Signed-off-by: Lukasz Majewski l.majew...@samsung.com
Acked-by: Eduardo Valentin edubez...@gmail.com
---
Changes for v2:
-
On 02/18/2015 02:07 AM, Lukasz Majewski wrote:
This patch provides code for reading PWM FAN configuration data via
device tree. The pwm-fan can work with full speed when configuration
is not provided. However, errors are propagated when wrong DT bindings
are found.
Additionally the struct
On 04/12/2015 11:44 AM, Anand Moon wrote:
pwm_config() must be called with a duty cycle of 0 prior to calling
pwm_disable() to ensure that the pwm signal is set to low.
Changes since v1 : None.
Changes since v2 : None
Changes since v3 : Simplify the comment.
Reported-by: Markus Reichl
On 04/12/2015 07:54 AM, Anand Moon wrote:
In order to disable the PWM we need to update using following sequence.
pwm_config(pwm, 0, period);
pwm_disable(pwm);
pwm_config() with a zero duty cycle to make it clear the timer and update the
PWM registers.
pwm_disable will clear
On 04/12/2015 08:29 AM, Anand Moon wrote:
hi Guenter,
I am referring to #linux/drivers/pwm/pwm-samsung.c
Will update the comment.
Sure, but that doesn't help as patch description for the pwm-fan driver.
Guenter
-Anand Moon
On 12 April 2015 at 20:37, Guenter Roeck li...@roeck-us.net wrote
On 04/08/2015 01:44 AM, Lukasz Majewski wrote:
Hi Anand,
Below changes depend on following patch.
https://patchwork.kernel.org/patch/5944061/
Update the pwm_config with duty then update the pwm_disable
to poweroff the cpu fan.
Tested on OdroidXU3 board.
Signed-off-by: Anand Moon
On Wed, Apr 08, 2015 at 10:44:15AM +0200, Lukasz Majewski wrote:
Hi Anand,
Below changes depend on following patch.
https://patchwork.kernel.org/patch/5944061/
Update the pwm_config with duty then update the pwm_disable
to poweroff the cpu fan.
Unfortunately, the patch does not
with the current code, and how does your
patch fix it ?
Guenter
-Anand Moon
On 8 April 2015 at 21:02, Guenter Roeck li...@roeck-us.net wrote:
On Wed, Apr 08, 2015 at 10:44:15AM +0200, Lukasz Majewski wrote:
Hi Anand,
Below changes depend on following patch.
https://patchwork.kernel.org/patch
robot is happy this time.
Acked-by: Guenter Roeck li...@roeck-us.net
Guenter
---
Changes since v2:
Fixed drivers/watchdog/txx9wdt.c:134:20: error: 'pdev' undeclared
Reported-by: kbuild test robot fengguang...@intel.com
Changes since v1:
Squash all commits of V1 into a single patch.
V1
On 07/24/2015 03:11 PM, Pavel Machek wrote:
On Fri 2015-07-24 06:59:26, Guenter Roeck wrote:
On 07/23/2015 11:29 PM, Sascha Hauer wrote:
On Thu, Jul 23, 2015 at 02:07:59PM +0200, Pavel Machek wrote:
On Tue 2015-07-21 09:21:32, Sascha Hauer wrote:
The thermal code uses int, long and unsigned
On 07/23/2015 11:29 PM, Sascha Hauer wrote:
On Thu, Jul 23, 2015 at 02:07:59PM +0200, Pavel Machek wrote:
On Tue 2015-07-21 09:21:32, Sascha Hauer wrote:
The thermal code uses int, long and unsigned long for temperatures
in different places.
Using an unsigned type limits the thermal framework
On Tue, Sep 08, 2015 at 12:10:02PM -0700, Greg KH wrote:
> On Tue, Sep 08, 2015 at 08:30:13AM -0700, Guenter Roeck wrote:
> > Emilio,
> >
> > On Tue, Sep 08, 2015 at 09:07:44AM -0300, Emilio López wrote:
> > > According to the sysfs header file:
> > >
>
Emilio,
On Tue, Sep 08, 2015 at 09:07:44AM -0300, Emilio López wrote:
> According to the sysfs header file:
>
> "The returned value will replace static permissions defined in
> struct attribute or struct bin_attribute."
>
> but this isn't the case, as is_visible is only called on
>
Hi Emilio,
On 09/08/2015 05:51 PM, Emilio López wrote:
Hi Greg & Guenter,
[ ... ]
Unless I am missing something, this is not explained anywhere, but it is
not entirely trivial to understand. I think it should be documented.
I agree. I couldn't find any mention of what this int was
1 - 100 of 103 matches
Mail list logo
